the zx_handle_t type

[George Kulakowski]

Very shortly the zx_handle_t type is being changed from signed to unsigned. Rust publishes its own definition of this type in https://fuchsia.googlesource.com/garnet/+/master/public/rust/crates/fuchsia-zircon/fuchsia-zircon-sys/src/lib.rs#12

This is at least in theory an ABI breaking change. Do I have to do anything re crates publication etc.?

[George Kulakowski]

Relatedly, I'm noticing that the definition of zx_futex_t is wrong. It should be 32 bits, not isize-sized.

[Taylor Cramer]

Since nothing is depending on the crates.io version at the moment (I think?), I believe you should just be able to make the change in place. When you do, can you bump the version numbers of fuchsia-zircon-sys and fuchsia-zircon to 0.3?

--
You received this message because you are subscribed to the Google Groups "rust-fuchsia" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rust-fuchsia+unsubscribe@fuchsia.com.
To post to this group, send email to rust-f...@fuchsia.com.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.com/d/msgid/rust-fuchsia/CAKP51mb4CfMcSN17sNN4SekFM3c5n5qNxM2wu3JU6y-RyUtbaQ%40mail.gmail.com.

[George Kulakowski]

Thanks!

https://fuchsia-review.googlesource.com/c/garnet/+/71066

https://fuchsia-review.googlesource.com/c/garnet/+/70983

https://fuchsia-review.googlesource.com/c/garnet/+/70984

[James Tucker]

We also have to update rust libstd, I am preparing a patch for that right now.

To view this discussion on the web visit https://groups.google.com/a/fuchsia.com/d/msgid/rust-fuchsia/CAKP51mZ6ZOk9%3Dm7cUkEpcTe5aXkgpag_p6NAsO6NM-eNJwC9HQ%40mail.gmail.com.

[George Kulakowski]

I already did.

[George Kulakowski]

Oh, I misread. Carry on!

[James Tucker]

https://github.com/rust-lang/rust/pull/45030