Groups keyboard shortcuts have been updated
Dismiss
See shortcuts

Request for unstable feature: -Zsanitizer

16 views
Skip to first unread message

Aaron Green

unread,
Jan 14, 2020, 2:41:44 PM1/14/20
to rust-f...@fuchsia.com, TQ Toolchain Discuss
As per the in-tree docs, I've created a short doc seeking approval to enable -Zsanitizer when creating Rust fuzzers. Please note this feature is for testing purposes only, and would not be used for any shipping code.

Let me know if there is other information I can provide.

-Aaron

Aaron Green

unread,
Jan 14, 2020, 2:59:28 PM1/14/20
to rust-f...@fuchsia.com, TQ Toolchain Discuss
Hmm, on second look I'm concerned I'm conflating "unstable features" with "unstable options". Feel free to disregard and/or correct me if this is the case.

-Aaron

Benjamin Brittain

unread,
Jan 14, 2020, 3:08:57 PM1/14/20
to Aaron Green, rust-f...@fuchsia.com, TQ Toolchain Discuss
Yeah, I don't see any problems with using this. It's an unstable option so it could go away, but I think the more likely path is that it will improve. The commit adding this is pretty straightforward too, so easy to extend if something isn't quite right.
https://github.com/rust-lang/rust/pull/38699/files

We might want to get involved in the process of stabilizing it?

We use 3 other unstable flags:
-Zallow-features - allows us to constrain rust features
-Zpanic_abort_tests - enables panic=abort tests 
-Zdep-info-omit-d-target - removes the dep file from tracking itself

Only one of those (panic-abort-tests) is on a path to stabilizing. The other two aren't loadbearing in any way except making our lives easier.

--
You received this message because you are subscribed to the Google Groups "rust-fuchsia" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rust-fuchsia...@fuchsia.com.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.com/d/msgid/rust-fuchsia/CABx4ieVcx40ixPvd9Vcbnu-M5th_%2BvmezUFmTH85BwJqNP3ZpA%40mail.gmail.com.

Erick Tryzelaar

unread,
Jan 14, 2020, 7:21:31 PM1/14/20
to Benjamin Brittain, Aaron Green, rust-f...@fuchsia.com, TQ Toolchain Discuss
I agree, this isn't an option that production code would use, and I think we'd get a lot of value out of using sanitizers with rust code.

Tyler Mandry

unread,
Jan 14, 2020, 9:12:52 PM1/14/20
to Erick Tryzelaar, Benjamin Brittain, Aaron Green, rust-f...@fuchsia.com, TQ Toolchain Discuss
Just registering my agreement with the above. We use `-Z` options in a number of places already. Of course each use should be carefully considered, but for the reasons already stated I'm fine with this.

You received this message because you are subscribed to the Google Groups "TQ Toolchain Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email to tq-toolchain-dis...@google.com.
To view this discussion on the web visit https://groups.google.com/a/google.com/d/msgid/tq-toolchain-discuss/CAP%2BUz2bjOL9g-Q30haQwt8e_S%2BHbANb_gDT3Rj9sWcO%2BbwExkQ%40mail.gmail.com.
Reply all
Reply to author
Forward
0 new messages