[L] Change in fuchsia/fuchsia[main]: [fidl][rust] Get default transport from protocol

2 views
Skip to first unread message

'David Koloski (Gerrit)' via owners-override

unread,
Oct 16, 2025, 1:20:11 PM10/16/25
to Owners Override
Attention needed from Owners Override

David Koloski has uploaded the change for review

David Koloski would like Owners Override to review this change.

Commit message

[fidl][rust] Get default transport from protocol

This change allows developers to omit the transport type more often,
including in drivers and on host. As a tradeoff, libraries that deal
with protocols generically will always have to specify the transport
type.
Fixed: 448696666
Change-Id: I849b5cb658683cc79a56646ae6c08a539a8f5970

Change diff


Change information

Files:
  • M examples/drivers/transport/driver/rust_next/child/src/lib.rs
  • M examples/drivers/transport/driver/rust_next/parent/src/lib.rs
  • M examples/fidl/calculator/rust_next/server/src/main.rs
  • M examples/fidl/new/canvas/baseline/rust_next/client/BUILD.gn
  • M examples/fidl/new/canvas/baseline/rust_next/client/src/main.rs
  • M sdk/lib/driver/component/rust/src/server.rs
  • M sdk/lib/driver/runtime/rust/fidl/src/lib.rs
  • M src/lib/fdomain/example_next/src/lib.rs
  • M src/lib/fidl/rust_next/fidl_next_bind/src/client.rs
  • M src/lib/fidl/rust_next/fidl_next_bind/src/decoded.rs
  • M src/lib/fidl/rust_next/fidl_next_bind/src/endpoint.rs
  • M src/lib/fidl/rust_next/fidl_next_bind/src/future/send.rs
  • M src/lib/fidl/rust_next/fidl_next_bind/src/future/two_way.rs
  • M src/lib/fidl/rust_next/fidl_next_bind/src/protocol.rs
  • M src/lib/fidl/rust_next/fidl_next_bind/src/server.rs
  • M src/lib/fidl/rust_next/fidl_next_bind/src/service.rs
  • M src/lib/fuchsia-component/client/src/fidl_next.rs
  • M tools/fidl/fidlgen_rust_next/goldens/anonymous.rs.golden
  • M tools/fidl/fidlgen_rust_next/goldens/bindings_denylist.rs.golden
  • M tools/fidl/fidlgen_rust_next/goldens/doc_comments.rs.golden
  • M tools/fidl/fidlgen_rust_next/goldens/driver_handle.rs.golden
  • M tools/fidl/fidlgen_rust_next/goldens/driver_one_way.rs.golden
  • M tools/fidl/fidlgen_rust_next/goldens/driver_service.rs.golden
  • M tools/fidl/fidlgen_rust_next/goldens/driver_two_way.rs.golden
  • M tools/fidl/fidlgen_rust_next/goldens/empty_struct.rs.golden
  • M tools/fidl/fidlgen_rust_next/goldens/error.rs.golden
  • M tools/fidl/fidlgen_rust_next/goldens/error_syntax.rs.golden
  • M tools/fidl/fidlgen_rust_next/goldens/experimental_maybe_from_alias.rs.golden
  • M tools/fidl/fidlgen_rust_next/goldens/foreign_type_in_response_used_through_compose.rs.golden
  • M tools/fidl/fidlgen_rust_next/goldens/handles.rs.golden
  • M tools/fidl/fidlgen_rust_next/goldens/inheritance.rs.golden
  • M tools/fidl/fidlgen_rust_next/goldens/inheritance_with_recursive_decl.rs.golden
  • M tools/fidl/fidlgen_rust_next/goldens/nullable.rs.golden
  • M tools/fidl/fidlgen_rust_next/goldens/placement_of_attributes.rs.golden
  • M tools/fidl/fidlgen_rust_next/goldens/protocol_layouts.rs.golden
  • M tools/fidl/fidlgen_rust_next/goldens/protocol_layouts_same_library.rs.golden
  • M tools/fidl/fidlgen_rust_next/goldens/protocol_payloads.rs.golden
  • M tools/fidl/fidlgen_rust_next/goldens/protocol_request.rs.golden
  • M tools/fidl/fidlgen_rust_next/goldens/protocols.rs.golden
  • M tools/fidl/fidlgen_rust_next/goldens/request_flexible_envelope.rs.golden
  • M tools/fidl/fidlgen_rust_next/goldens/service.rs.golden
  • M tools/fidl/fidlgen_rust_next/goldens/transitive_dependencies_compose.rs.golden
  • M tools/fidl/fidlgen_rust_next/goldens/types_in_protocols.rs.golden
  • M tools/fidl/fidlgen_rust_next/goldens/union.rs.golden
  • M tools/fidl/fidlgen_rust_next/goldens/unknown_interactions.rs.golden
  • M tools/fidl/fidlgen_rust_next/goldens/versions.rs.golden
  • M tools/fidl/fidlgen_rust_next/src/templates/protocol.rs
  • M tools/fidl/fidlgen_rust_next/templates/protocol.askama
Change size: L
Delta: 48 files changed, 609 insertions(+), 335 deletions(-)
Open in Gerrit

Related details

Attention is currently required from:
  • Owners Override
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I849b5cb658683cc79a56646ae6c08a539a8f5970
Gerrit-Change-Number: 1384823
Gerrit-PatchSet: 4
Gerrit-Owner: David Koloski <dkol...@google.com>
Gerrit-Reviewer: David Koloski <dkol...@google.com>
Gerrit-Reviewer: Ian McKellar <ian...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/101ab5841dd331e0fd0c278dce7739ad823ec61f-HTML%40fuchsia-review.googlesource.com.
unsatisfied_requirement
satisfied_requirement
open
diffy

'David Koloski (Gerrit)' via owners-override

unread,
Oct 16, 2025, 1:20:13 PM10/16/25
to Owners Override, Ian McKellar
Attention needed from Owners Override

David Koloski voted Fuchsia-Auto-Submit+1

Fuchsia-Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Owners Override
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I849b5cb658683cc79a56646ae6c08a539a8f5970
Gerrit-Change-Number: 1384823
Gerrit-PatchSet: 4
Gerrit-Owner: David Koloski <dkol...@google.com>
Gerrit-Reviewer: David Koloski <dkol...@google.com>
Gerrit-Reviewer: Ian McKellar <ian...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Comment-Date: Thu, 16 Oct 2025 17:20:08 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/101ab5841dd331e0fd0c278dce7739ad823ec61f-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
unsatisfied_requirement
satisfied_requirement
open
diffy

'James Robinson (Gerrit)' via owners-override

unread,
Oct 16, 2025, 1:22:54 PM10/16/25
to David Koloski, Owners Override, Ian McKellar
Attention needed from David Koloski and Owners Override

James Robinson voted Owners-Override+1

Owners-Override+1
Open in Gerrit

Related details

Attention is currently required from:
  • David Koloski
  • Owners Override
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I849b5cb658683cc79a56646ae6c08a539a8f5970
Gerrit-Change-Number: 1384823
Gerrit-PatchSet: 4
Gerrit-Owner: David Koloski <dkol...@google.com>
Gerrit-Reviewer: David Koloski <dkol...@google.com>
Gerrit-Reviewer: Ian McKellar <ian...@google.com>
Gerrit-Reviewer: James Robinson <jam...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: David Koloski <dkol...@google.com>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Comment-Date: Thu, 16 Oct 2025 17:22:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/354e2decd392f6f9d6e1c746a64fb0558d51d8f1-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy

'David Koloski (Gerrit)' via owners-override

unread,
Oct 16, 2025, 2:12:25 PM10/16/25
to GI Try Builder, CQ Bot, James Robinson, Owners Override, Ian McKellar
Attention needed from Owners Override

David Koloski voted Fuchsia-Auto-Submit+0

Fuchsia-Auto-Submit+0
Open in Gerrit

Related details

Attention is currently required from:
  • Owners Override
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I849b5cb658683cc79a56646ae6c08a539a8f5970
Gerrit-Change-Number: 1384823
Gerrit-PatchSet: 4
Gerrit-Owner: David Koloski <dkol...@google.com>
Gerrit-Reviewer: David Koloski <dkol...@google.com>
Gerrit-Reviewer: Ian McKellar <ian...@google.com>
Gerrit-Reviewer: James Robinson <jam...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Comment-Date: Thu, 16 Oct 2025 18:12:21 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/e620b4b5c5f3de87e4a89f4277784942daa60e60-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy

'James Robinson (Gerrit)' via owners-override

unread,
Oct 20, 2025, 4:05:35 PM10/20/25
to David Koloski, GI Try Builder, CQ Bot, Owners Override, Ian McKellar
Attention needed from David Koloski and Owners Override

James Robinson voted Owners-Override+1

Owners-Override+1
Open in Gerrit

Related details

Attention is currently required from:
  • David Koloski
  • Owners Override
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I849b5cb658683cc79a56646ae6c08a539a8f5970
Gerrit-Change-Number: 1384823
Gerrit-PatchSet: 6
Gerrit-Owner: David Koloski <dkol...@google.com>
Gerrit-Reviewer: David Koloski <dkol...@google.com>
Gerrit-Reviewer: Ian McKellar <ian...@google.com>
Gerrit-Reviewer: James Robinson <jam...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: David Koloski <dkol...@google.com>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Comment-Date: Mon, 20 Oct 2025 20:05:26 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/dfa12600037d2e9c86159a92d9a2eb008ef7dd44-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy

'David Koloski (Gerrit)' via owners-override

unread,
Oct 20, 2025, 4:06:11 PM10/20/25
to James Robinson, GI Try Builder, CQ Bot, Owners Override, Ian McKellar
Attention needed from Owners Override

David Koloski voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Owners Override
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I849b5cb658683cc79a56646ae6c08a539a8f5970
Gerrit-Change-Number: 1384823
Gerrit-PatchSet: 6
Gerrit-Owner: David Koloski <dkol...@google.com>
Gerrit-Reviewer: David Koloski <dkol...@google.com>
Gerrit-Reviewer: Ian McKellar <ian...@google.com>
Gerrit-Reviewer: James Robinson <jam...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Comment-Date: Mon, 20 Oct 2025 20:06:05 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/f2c1f2fb61a6bfb8bb03daeab3fd380f79fc6350-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy

'CQ Bot (Gerrit)' via owners-override

unread,
Oct 20, 2025, 5:48:08 PM10/20/25
to David Koloski, James Robinson, GI Try Builder, Owners Override, Ian McKellar

CQ Bot submitted the change

Unreviewed changes

4 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:
[fidl][rust] Get default transport from protocol

This change allows developers to omit the transport type more often,
including in drivers and on host. As a tradeoff, libraries that deal
with protocols generically will always have to specify the transport
type.
Fixed: 448696666
Change-Id: I849b5cb658683cc79a56646ae6c08a539a8f5970
Reviewed-by: Ian McKellar <ian...@google.com>
Owners-Override: James Robinson <jam...@google.com>
Commit-Queue: David Koloski <dkol...@google.com>
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +2 by Ian McKellar
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I849b5cb658683cc79a56646ae6c08a539a8f5970
Gerrit-Change-Number: 1384823
Gerrit-PatchSet: 7
Gerrit-Owner: David Koloski <dkol...@google.com>
Gerrit-Reviewer: David Koloski <dkol...@google.com>
Gerrit-Reviewer: Ian McKellar <ian...@google.com>
Gerrit-Reviewer: James Robinson <jam...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/b3f89bf795ba6eab1e7ced862d5f0d2d44304b3b-HTML%40fuchsia-review.googlesource.com.
open
diffy
satisfied_requirement

'GI Roller (Gerrit)' via owners-override

unread,
Oct 20, 2025, 6:00:28 PM10/20/25
to David Koloski, CQ Bot, James Robinson, GI Try Builder, Owners Override, Ian McKellar

Message from GI Roller

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I849b5cb658683cc79a56646ae6c08a539a8f5970
Gerrit-Change-Number: 1384823
Gerrit-PatchSet: 7
Gerrit-Owner: David Koloski <dkol...@google.com>
Gerrit-Reviewer: David Koloski <dkol...@google.com>
Gerrit-Reviewer: Ian McKellar <ian...@google.com>
Gerrit-Reviewer: James Robinson <jam...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Comment-Date: Mon, 20 Oct 2025 22:00:24 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/7b30f7761522e33e78e61d797d12f7079e56a866-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages