[M] Change in fuchsia/fuchsia[main]: [zx][rs] Remove HandleBased::is_invalid_handle.

0 views
Skip to first unread message

'Adam Perry (Gerrit)' via owners-override

unread,
Feb 11, 2026, 11:02:25 PM (8 days ago) Feb 11
to Owners Override, Adam Barth
Attention needed from Adam Barth and Owners Override

Adam Perry has uploaded the change for review

Adam Perry would like Owners Override and Adam Barth to review this change.

Commit message

[zx][rs] Remove HandleBased::is_invalid_handle.

Replaced with is_invalid() inherent methods on typed
handle wrappers.

NO_IFTTT=superficial api change
Bug: 434763877
Depends-on: turquoise-internal:Ie6ee0b8b07f7d1293b9f26df45b9c0aee5921d42
Change-Id: I704c6e66631b3dd1846c1d419b6b6632b279737f

Change diff


Change information

Files:
  • M sdk/lib/driver_test_realm/realm_builder/rust/src/builder.rs
  • M sdk/rust/zx/src/handle.rs
  • M sdk/rust/zx/src/macros.rs
  • M src/bringup/bin/ptysvc/src/integration_tests.rs
  • M src/bringup/bin/ptysvc/src/ptysvc.rs
  • M src/devices/bin/devfs/src/lib.rs
  • M src/lib/fidl_codec/rust/src/handle/classic.rs
  • M src/lib/fuchsia-async/src/handle/emulated/mod.rs
  • M src/lib/fuchsia-fs/src/file.rs
  • M src/lib/process_builder/src/process_builder.rs
  • M src/power/system-activity-governor/integration/tests/src/main.rs
  • M src/security/bin/tee_manager/src/main.rs
  • M src/starnix/kernel/core/mm/memory_manager.rs
  • M src/starnix/kernel/core/task/memory_attribution.rs
  • M src/starnix/lib/syncio/src/lib.rs
  • M src/storage/lib/sync_io_client/src/lib.rs
  • M src/storage/lib/vfs/rust/src/object_request.rs
  • M src/storage/lib/vfs/rust/src/temp_clone.rs
  • M src/sys/service-broker/src/lib.rs
Change size: M
Delta: 19 files changed, 72 insertions(+), 65 deletions(-)
Open in Gerrit

Related details

Attention is currently required from:
  • Adam Barth
  • Owners Override
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedDependencies-Satisfied
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I704c6e66631b3dd1846c1d419b6b6632b279737f
Gerrit-Change-Number: 1456310
Gerrit-PatchSet: 19
Gerrit-Owner: Adam Perry <adam...@google.com>
Gerrit-Reviewer: Adam Barth <aba...@google.com>
Gerrit-Reviewer: Adam Perry <adam...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Adam Barth <aba...@google.com>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/4ebe242eda7d8813d8ff6eb5c687db6d7e715b0f-HTML%40fuchsia-review.googlesource.com.
unsatisfied_requirement
open
diffy

'Adam Perry (Gerrit)' via owners-override

unread,
Feb 11, 2026, 11:02:28 PM (8 days ago) Feb 11
to Adam Barth, Owners Override, GI Try Builder, CQ Bot
Attention needed from Adam Barth and Owners Override

Adam Perry voted

Commit-Queue+1
Fuchsia-Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Adam Barth
  • Owners Override
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedDependencies-Satisfied
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I704c6e66631b3dd1846c1d419b6b6632b279737f
Gerrit-Change-Number: 1456310
Gerrit-PatchSet: 19
Gerrit-Owner: Adam Perry <adam...@google.com>
Gerrit-Reviewer: Adam Barth <aba...@google.com>
Gerrit-Reviewer: Adam Perry <adam...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Adam Barth <aba...@google.com>
Gerrit-Comment-Date: Thu, 12 Feb 2026 04:02:21 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/4ebe242eda7d8813d8ff6eb5c687db6d7e715b0f-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
unsatisfied_requirement
open
diffy

'Adam Barth (Gerrit)' via owners-override

unread,
Feb 12, 2026, 10:44:37 AM (8 days ago) Feb 12
to Adam Perry, Owners Override, GI Try Builder, CQ Bot
Attention needed from Adam Perry and Owners Override

Adam Barth voted

Code-Review+2
Owners-Override+1
Open in Gerrit

Related details

Attention is currently required from:
  • Adam Perry
  • Owners Override
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedDependencies-Satisfied
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I704c6e66631b3dd1846c1d419b6b6632b279737f
Gerrit-Change-Number: 1456310
Gerrit-PatchSet: 19
Gerrit-Owner: Adam Perry <adam...@google.com>
Gerrit-Reviewer: Adam Barth <aba...@google.com>
Gerrit-Reviewer: Adam Perry <adam...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Adam Perry <adam...@google.com>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Comment-Date: Thu, 12 Feb 2026 15:44:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/8064fc0a184e8e053a83da7d62500cf9f3f141f8-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
unsatisfied_requirement
open
diffy

'CQ Bot (Gerrit)' via owners-override

unread,
Feb 12, 2026, 10:46:34 AM (8 days ago) Feb 12
to Adam Perry, CL Deps Checker, Adam Barth, Owners Override, GI Try Builder

CQ Bot submitted the change

Change information

Commit message:
[zx][rs] Remove HandleBased::is_invalid_handle.

Replaced with is_invalid() inherent methods on typed
handle wrappers.

NO_IFTTT=superficial api change
Bug: 434763877
Depends-on: turquoise-internal:Ie6ee0b8b07f7d1293b9f26df45b9c0aee5921d42
Change-Id: I704c6e66631b3dd1846c1d419b6b6632b279737f
Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1456310
Owners-Override: Adam Barth <aba...@google.com>
Fuchsia-Auto-Submit: Adam Perry <adam...@google.com>
Reviewed-by: Adam Barth <aba...@google.com>
Commit-Queue: Adam Perry <adam...@google.com>
Dependencies-Satisfied: CL Deps Checker <cl-deps...@fuchsia-internal-service-accts.iam.gserviceaccount.com>
Files:
  • M sdk/lib/driver_test_realm/realm_builder/rust/src/builder.rs
  • M sdk/rust/zx/src/handle.rs
  • M sdk/rust/zx/src/macros.rs
  • M src/bringup/bin/ptysvc/src/integration_tests.rs
  • M src/bringup/bin/ptysvc/src/ptysvc.rs
  • M src/devices/bin/devfs/src/lib.rs
  • M src/lib/fidl_codec/rust/src/handle/classic.rs
  • M src/lib/fuchsia-async/src/handle/emulated/mod.rs
  • M src/lib/fuchsia-fs/src/file.rs
  • M src/lib/process_builder/src/process_builder.rs
  • M src/power/system-activity-governor/integration/tests/src/main.rs
  • M src/security/bin/tee_manager/src/main.rs
  • M src/starnix/kernel/core/mm/memory_manager.rs
  • M src/starnix/kernel/core/task/memory_attribution.rs
  • M src/starnix/lib/syncio/src/lib.rs
  • M src/storage/lib/sync_io_client/src/lib.rs
  • M src/storage/lib/vfs/rust/src/object_request.rs
  • M src/storage/lib/vfs/rust/src/temp_clone.rs
  • M src/sys/service-broker/src/lib.rs
Change size: M
Delta: 19 files changed, 72 insertions(+), 65 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +2 by Adam Barth
  • requirement satisfiedDependencies-Satisfied: +1 by CL Deps Checker
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I704c6e66631b3dd1846c1d419b6b6632b279737f
Gerrit-Change-Number: 1456310
Gerrit-PatchSet: 20
Gerrit-Owner: Adam Perry <adam...@google.com>
Gerrit-Reviewer: Adam Barth <aba...@google.com>
Gerrit-Reviewer: Adam Perry <adam...@google.com>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/db94ad3c78fd6c33925712d6d4f8a0075ee7443e-HTML%40fuchsia-review.googlesource.com.
open
diffy
satisfied_requirement

'GI Roller (Gerrit)' via owners-override

unread,
Feb 12, 2026, 10:49:02 AM (8 days ago) Feb 12
to Adam Perry, CQ Bot, CL Deps Checker, Adam Barth, Owners Override, GI Try Builder

Message from GI Roller

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedDependencies-Satisfied
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: fuchsia
    Gerrit-Branch: main
    Gerrit-Change-Id: I704c6e66631b3dd1846c1d419b6b6632b279737f
    Gerrit-Change-Number: 1456310
    Gerrit-PatchSet: 20
    Gerrit-Owner: Adam Perry <adam...@google.com>
    Gerrit-Reviewer: Adam Barth <aba...@google.com>
    Gerrit-Reviewer: Adam Perry <adam...@google.com>
    Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
    Gerrit-Comment-Date: Thu, 12 Feb 2026 15:48:59 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: No

    --
    You received this message because you are subscribed to the Google Groups "owners-override" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
    To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/97e573387c983c832de9afb62428388f398a1e07-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
    satisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages