'John Wittrock (Gerrit)' via owners-override

unread,

Nov 25, 2025, 1:55:51 PMNov 25

to Owners Override

Attention needed from Adam Perry, Eric Rahm and Owners Override

Eric Rahm has uploaded the change for review

John Wittrock would like Owners Override to review this change authored by Eric Rahm.

Commit message

[tools] Add a gemini ignore file

This adds a `.geminiignore` file that un-ignores several `.gitignore`d
directories:
  - `local`
  - `vendor`
  - `third_party`

This is similar to what we do with our `.ignore` file that's used by
tools like `fdfind` and `ripgrep`. This allows `gemini-cli` to access
those directories out-of-the-box. Ideally `gemini-cli` would support a
more generic `.ignore`, but for now an explicit `.geminiignore` works
well enough.

This allows us to remove previous work-arounds where the `.gitignore`d
directories were explicitly included as if they were external
directories.

Test: Manually verified `@` completion works in `gemini-cli`.

Change-Id: I4419365be621532c180958c830d7ceff8d930ace

Change diff

diff --git a/.gemini/settings.json b/.gemini/settings.json
index fd69755..bb90681 100644
--- a/.gemini/settings.json
+++ b/.gemini/settings.json
@@ -10,11 +10,6 @@
     "fileFiltering": {
       "respectGitIgnore": true,
       "enableRecursiveFileSearch": false
-    },
-    "includeDirectories": [
-      "local",
-      "vendor/google"
-    ],
-    "loadFromIncludeDirectories": true
+    }
   }
-}
\ No newline at end of file
+}
diff --git a/.geminiignore b/.geminiignore
new file mode 100644
index 0000000..e393454
--- /dev/null
+++ b/.geminiignore
@@ -0,0 +1,8 @@
+# This file contains globs which should not be tracked by git but which should be searched by
+# gemini-based tools, for example when finding usages of APIs.
+
+# TODO(https://fxbug.dev/28607) delete when we stop gitignore'ing version-controlled sources
+
+!/local/
+!/third_party/*
+!/vendor/

Change information

Files:

M .gemini/settings.json
A .geminiignore

Change size: S

Delta: 2 files changed, 10 insertions(+), 7 deletions(-)

Open in Gerrit

Related details

Attention is currently required from:

Adam Perry
Eric Rahm
Owners Override

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/c63455da178cf67ec6f8cec2d2484e394d3f20e8-HTML%40fuchsia-review.googlesource.com.

unsatisfied_requirement

satisfied_requirement

open

diffy

'John Wittrock (Gerrit)' via owners-override

unread,

Nov 25, 2025, 1:56:20 PMNov 25

to Eric Rahm, Owners Override, Nick Van der Auwermeulen, Adam Perry

Attention needed from Adam Perry, Eric Rahm and Owners Override

John Wittrock voted Code-Review+2

Code-Review

+2

Open in Gerrit

Related details

Attention is currently required from:

Adam Perry
Eric Rahm
Owners Override

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/05ea112f5331ddabdef92fbbdf598b10ef472f79-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

unsatisfied_requirement

satisfied_requirement

open

diffy

'James Robinson (Gerrit)' via owners-override

unread,

Nov 25, 2025, 2:03:07 PMNov 25

to Eric Rahm, John Wittrock, Owners Override, Nick Van der Auwermeulen, Adam Perry

Attention needed from Adam Perry, Eric Rahm and Owners Override

James Robinson added 1 comment

File .geminiignore

Line 4, Patchset 1 (Latest):# TODO(https://fxbug.dev/28607) delete when we stop gitignore'ing version-controlled sources

James Robinson . unresolved

This bug refers to submodules which we aren't going to do. Is there actually a plan to stop .gitignoring these directories? Is there a more appropriate bug to link this to?

Open in Gerrit

Related details

Attention is currently required from:

Adam Perry
Eric Rahm
Owners Override

Submit Requirements:

Code-Owners
Code-Review

No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/ef17e35e6c59401dd86aef3e0320411d6264361f-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

unsatisfied_requirement

satisfied_requirement

open

diffy

'Eric Rahm (Gerrit)' via owners-override

unread,

Nov 25, 2025, 2:08:17 PMNov 25

to James Robinson, John Wittrock, Owners Override, Nick Van der Auwermeulen, Adam Perry

Attention needed from Adam Perry, James Robinson and Owners Override

Eric Rahm added 1 comment

File .geminiignore

Line 4, Patchset 1 (Latest):# TODO(https://fxbug.dev/28607) delete when we stop gitignore'ing version-controlled sources

James Robinson . unresolved

This bug refers to submodules which we aren't going to do. Is there actually a plan to stop .gitignoring these directories? Is there a more appropriate bug to link this to?

Eric Rahm

This was lifted from the existing `.ignore` file, I can remove the reference if you think that makes more sense. I'm not sure if there's still a plan in place to stop gitignore'ing version-controlled sources, but perhaps that's going to fall out of the superproject work?

Open in Gerrit

Related details

Attention is currently required from:

Adam Perry
James Robinson
Owners Override

Submit Requirements:

Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/b28137842e96b9ff2b219ffce631f36e8f2606ed-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

unsatisfied_requirement

satisfied_requirement

open

diffy

'James Robinson (Gerrit)' via owners-override

unread,

Nov 25, 2025, 2:11:36 PMNov 25

to Eric Rahm, John Wittrock, Owners Override, Nick Van der Auwermeulen, Adam Perry

Attention needed from Adam Perry, Eric Rahm and Owners Override

James Robinson added 1 comment

File .geminiignore

Line 4, Patchset 1 (Latest):# TODO(https://fxbug.dev/28607) delete when we stop gitignore'ing version-controlled sources

James Robinson . unresolved

This bug refers to submodules which we aren't going to do. Is there actually a plan to stop .gitignoring these directories? Is there a more appropriate bug to link this to?

Eric Rahm

This was lifted from the existing `.ignore` file, I can remove the reference if you think that makes more sense. I'm not sure if there's still a plan in place to stop gitignore'ing version-controlled sources, but perhaps that's going to fall out of the superproject work?

James Robinson

I'm not aware of any. No reason to have a TODO here if we do not have a plan to take action. If you want to remove these in the future, please file a new bug describing the steps and link it here - otherwise remove the TODO.

Open in Gerrit

Related details

Attention is currently required from:

Adam Perry
Eric Rahm
Owners Override

Submit Requirements:

Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/e69e3a0406893b45af4d9a34e8cb25962af44cb0-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

unsatisfied_requirement

satisfied_requirement

open

diffy

'Eric Rahm (Gerrit)' via owners-override

unread,

Nov 25, 2025, 2:15:19 PMNov 25

to James Robinson, John Wittrock, Owners Override, Nick Van der Auwermeulen, Adam Perry

Attention needed from Adam Perry, James Robinson and Owners Override

Eric Rahm added 1 comment

File .geminiignore

Line 4, Patchset 1:# TODO(https://fxbug.dev/28607) delete when we stop gitignore'ing version-controlled sources

James Robinson . resolved

This bug refers to submodules which we aren't going to do. Is there actually a plan to stop .gitignoring these directories? Is there a more appropriate bug to link this to?

Eric Rahm

This was lifted from the existing `.ignore` file, I can remove the reference if you think that makes more sense. I'm not sure if there's still a plan in place to stop gitignore'ing version-controlled sources, but perhaps that's going to fall out of the superproject work?

James Robinson

I'm not aware of any. No reason to have a TODO here if we do not have a plan to take action. If you want to remove these in the future, please file a new bug describing the steps and link it here - otherwise remove the TODO.

Eric Rahm

Makes sense, thanks James!

Open in Gerrit

Related details

Attention is currently required from:

Adam Perry
James Robinson
Owners Override

Submit Requirements:

Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/9f8e7e4a21787d59943aab93bc80c6fe44387399-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

unsatisfied_requirement

satisfied_requirement

open

diffy

'James Robinson (Gerrit)' via owners-override

unread,

Nov 25, 2025, 3:02:38 PMNov 25

to Eric Rahm, John Wittrock, Owners Override, Nick Van der Auwermeulen, Adam Perry

Attention needed from Adam Perry, Eric Rahm and Owners Override

James Robinson voted Owners-Override+1

Owners-Override

+1

Open in Gerrit

Related details

Attention is currently required from:

Adam Perry
Eric Rahm
Owners Override

Submit Requirements:

Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--

You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/0833ee8b7828411d47f69611bd79e1ff74ee3e96-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

satisfied_requirement

open

diffy

'Eric Rahm (Gerrit)' via owners-override

unread,

Nov 25, 2025, 3:03:59 PMNov 25

to James Robinson, John Wittrock, Owners Override, Nick Van der Auwermeulen, Adam Perry

Attention needed from Adam Perry and Owners Override

Eric Rahm voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention is currently required from:

Adam Perry
Owners Override

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/5c1cfce5d5ccb7bd2d2de0b8bc170b77d7fcd15c-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

satisfied_requirement

open

diffy

'CQ Bot (Gerrit)' via owners-override

unread,

Nov 25, 2025, 3:51:32 PMNov 25

to Eric Rahm, GI Try Builder, James Robinson, John Wittrock, Owners Override, Nick Van der Auwermeulen, Adam Perry

CQ Bot submitted the change with unreviewed changes

Unreviewed changes

1 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: .geminiignore
Insertions: 0, Deletions: 2.

@@ -1,8 +1,6 @@


 # This file contains globs which should not be tracked by git but which should be searched by

 # gemini-based tools, for example when finding usages of APIs.

-# TODO(https://fxbug.dev/28607) delete when we stop gitignore'ing version-controlled sources
-
 !/local/
 !/third_party/*
 !/vendor/
```

Change information

Commit message:

[tools] Add a gemini ignore file

This adds a `.geminiignore` file that un-ignores several `.gitignore`d
directories:
  - `local`
  - `vendor`
  - `third_party`

This is similar to what we do with our `.ignore` file that's used by
tools like `fdfind` and `ripgrep`. This allows `gemini-cli` to access
those directories out-of-the-box. Ideally `gemini-cli` would support a
more generic `.ignore`, but for now an explicit `.geminiignore` works
well enough.

This allows us to remove previous work-arounds where the `.gitignore`d
directories were explicitly included as if they were external
directories.

Test: Manually verified `@` completion works in `gemini-cli`.

Change-Id: I4419365be621532c180958c830d7ceff8d930ace

Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1433978

Owners-Override: James Robinson <jam...@google.com>

Reviewed-by: Nick Van der Auwermeulen <nickv...@google.com>

Reviewed-by: John Wittrock <witt...@google.com>

Commit-Queue: Eric Rahm <er...@google.com>

Files:

M .gemini/settings.json
A .geminiignore

Change size: S

Delta: 2 files changed, 8 insertions(+), 7 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +2 by John Wittrock, +2 by Nick Van der Auwermeulen

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/a57d0ad12c0bac2a79d190b73018602bb56f7748-HTML%40fuchsia-review.googlesource.com.

open

diffy

satisfied_requirement

'GI Roller (Gerrit)' via owners-override

unread,

Nov 25, 2025, 4:02:10 PMNov 25

to Eric Rahm, CQ Bot, GI Try Builder, James Robinson, John Wittrock, Owners Override, Nick Van der Auwermeulen, Adam Perry

Message from GI Roller

Change has been successfully rolled: https://turquoise-internal-review.googlesource.com/1098232

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/d19ceb1859712024e6068c1c6f0135a3b6786743-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

satisfied_requirement

open

diffy

Reply all

Reply to author

Forward

[S] Change in fuchsia/fuchsia[main]: [tools] Add a gemini ignore file

'John Wittrock (Gerrit)' via owners-override

Eric Rahm has uploaded the change for review

Commit message

Change diff

Change information

Related details

'John Wittrock (Gerrit)' via owners-override

John Wittrock voted Code-Review+2

Related details

'James Robinson (Gerrit)' via owners-override

James Robinson added 1 comment

Related details

'Eric Rahm (Gerrit)' via owners-override

Eric Rahm added 1 comment

Related details

'James Robinson (Gerrit)' via owners-override

James Robinson added 1 comment

Related details

'Eric Rahm (Gerrit)' via owners-override

Eric Rahm added 1 comment

Related details

'James Robinson (Gerrit)' via owners-override

James Robinson voted Owners-Override+1

Related details

'Eric Rahm (Gerrit)' via owners-override

Eric Rahm voted Commit-Queue+2

Related details

'CQ Bot (Gerrit)' via owners-override

CQ Bot submitted the change with unreviewed changes

Unreviewed changes

Change information

'GI Roller (Gerrit)' via owners-override

Message from GI Roller

Related details