[XS] Change in fuchsia/fuchsia[main]: [generate_cargo] Strip suffix from proc-macro deps
2 views
Skip to first unread message
'David Koloski (Gerrit)' via owners-override
Jun 3, 2025, 1:52:00 PM6/3/25
to Owners Override
Attention needed from Owners Override
David Koloski has uploaded the change for review![]( "Open in Gerrit")
David Koloski would like Owners Override to review this change.
Commit message
[generate_cargo] Strip suffix from proc-macro deps
Proc macro crates get third-party target names which include a trailing
'_proc_macro'. These need to be removed when generating manifest
dependencies for cargo-based workflows.
Change-Id: Id0c342eb0cf11d75830b5488cabbf291abfc34c4
Change diff
diff --git a/scripts/generate_cargo.py b/scripts/generate_cargo.py
index 115c3a0..a6d0d2d 100755
--- a/scripts/generate_cargo.py
+++ b/scripts/generate_cargo.py
@@ -426,6 +426,8 @@
# versions of the same crate declared with different
# features.
continue
+ # Remove the trailing suffix from proc-macro crates
+ version = version.removesuffix("_proc_macro")
dep_crate_names.add(crate_name)
version = version.replace("_", ".")
fout.write('[%s."%s"]\n' % (dep_type, crate_name))
Change information
Files:
- M scripts/generate_cargo.py
Change size: XS
Delta: 1 file changed, 2 insertions(+), 0 deletions(-)
Related details
Attention is currently required from:
- Owners Override
Submit Requirements:
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/49b13dbeea71b6e18d6c711a9287a05d855b9ede-HTML%40fuchsia-review.googlesource.com.
'David Koloski (Gerrit)' via owners-override
Jun 3, 2025, 1:52:02 PM6/3/25
to Owners Override, Adam Perry
Attention needed from Owners Override
David Koloski voted Fuchsia-Auto-Submit+1![]( "Open in Gerrit")
| Fuchsia-Auto-Submit | +1 |
Related details
Attention is currently required from:
- Owners Override
Submit Requirements:
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/49b13dbeea71b6e18d6c711a9287a05d855b9ede-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'David Koloski (Gerrit)' via owners-override
Jun 3, 2025, 1:56:10 PM6/3/25
to Owners Override, Adam Perry
Attention needed from Owners Override
David Koloski added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 2 (Latest):
David Koloski . resolved
Per @adam...@google.com it seems like this may also fix docs generation for some crates (which broke recently).
Related details
Attention is currently required from:
- Owners Override
Submit Requirements:
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/16e44962155f63e81ef67e44ff39505c660d39c1-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'Adam Barth (Gerrit)' via owners-override
Jun 3, 2025, 1:56:26 PM6/3/25
to David Koloski, Owners Override, Adam Perry
Attention needed from David Koloski and Owners Override
Adam Barth voted Owners-Override+1![]( "Open in Gerrit")
Attention is currently required from:
- David Koloski
- Owners Override
Submit Requirements:
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/9f23ba36a1f6f476174a83523d262c5996ad6e9e-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'CQ Bot (Gerrit)' via owners-override
Jun 3, 2025, 3:14:13 PM6/3/25
to David Koloski, GI Try Builder, Adam Barth, Owners Override, Adam Perry
CQ Bot submitted the change![]( "Open in Gerrit")
Unreviewed changes
1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
[generate_cargo] Strip suffix from proc-macro deps
Proc macro crates get third-party target names which include a trailing
'_proc_macro'. These need to be removed when generating manifest
dependencies for cargo-based workflows.
Change-Id: Id0c342eb0cf11d75830b5488cabbf291abfc34c4
Commit-Queue: David Koloski <dkol...@google.com>
Owners-Override: Adam Barth <aba...@google.com>
Reviewed-by: Adam Perry <adam...@google.com>
Fuchsia-Auto-Submit: David Koloski <dkol...@google.com>
Files:
- M scripts/generate_cargo.py
Change size: XS
Delta: 1 file changed, 2 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +2 by Adam Perry
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/b3d0559705c6721450e09f6d19397eaec7471ab2-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'GI Roller (Gerrit)' via owners-override
Jun 3, 2025, 3:17:22 PM6/3/25
to David Koloski, CQ Bot, GI Try Builder, Adam Barth, Owners Override, Adam Perry
Message from GI Roller![]( "Open in Gerrit")
Change has been successfully rolled: http://go/roll-cl/634a6761074500d59775b7fee20e13ce4f60be41
Related details
Attention set is empty
Submit Requirements:
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/6b3370941b002e9e4ea0d343f255f9c83c27c503-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
Reply all
Reply to author
Forward
0 new messages