'Brandon Castellano (Gerrit)' via owners-override

unread,

Dec 10, 2025, 10:50:21 AM12/10/25

to Owners Override

Attention needed from Hunter Freyer and Owners Override

Brandon Castellano has uploaded the change for review

Brandon Castellano would like Owners Override to review this change.

Commit message

[version_history] Retire API level 26

Fixed: 449772374

Change-Id: Iffe85780eb923a31e4c0fc1f0d4f89c24e719310

Change diff

Change information

Files:

M docs/development/graphics/magma/concepts/porting.md
M sdk/fidl/fuchsia.diagnostics.types/fuchsia.diagnostics.types.api
M sdk/fidl/fuchsia.diagnostics/fuchsia.diagnostics.api
M sdk/fidl/fuchsia.gpu.magma/fuchsia.gpu.magma.api
M sdk/fidl/fuchsia.hardware.power.statecontrol/fuchsia.hardware.power.statecontrol.api
M sdk/fidl/fuchsia.hardware.rtc/fuchsia.hardware.rtc.api
M sdk/fidl/fuchsia.logger/fuchsia.logger.api
M sdk/lib/driver/component/cpp/driver_base.cc
M sdk/lib/driver/component/cpp/driver_base.h
M sdk/lib/driver/component/cpp/driver_component_cpp.api
M sdk/lib/sys/component/cpp/testing/internal/convert.cc
M sdk/lib/sys/component/cpp/testing/realm_builder.cc
M sdk/lib/sys/component/cpp/testing/realm_builder.h
M sdk/lib/sys/component/cpp/testing/sys_component_cpp_testing.api
M sdk/lib/syslog/duplicate_header_test/BUILD.gn
M sdk/lib/syslog/duplicate_header_test/duplicate_header_unittest.cc
M sdk/version_history.json
M src/bringup/bin/critical-services/oom_watcher-test.cc
M src/bringup/bin/netsvc/test/integration/src/lib.rs
M src/developer/ffx/plugins/log/src/testing_utils.rs
M src/devices/clock/bin/clock/clock.cc
M src/devices/rtc/drivers/aml-rtc/aml-rtc.cc
M src/devices/rtc/drivers/aml-rtc/aml-rtc.h
M src/devices/rtc/drivers/intel-rtc/intel-rtc.cc
M src/devices/rtc/drivers/intel-rtc/intel-rtc.h
M src/devices/rtc/drivers/pl031-rtc/pl031-rtc.cc
M src/devices/rtc/drivers/pl031-rtc/pl031-rtc.h
M src/diagnostics/archivist/src/accessor.rs
M src/diagnostics/archivist/src/logs/listener.rs
M src/diagnostics/archivist/src/logs/mod.rs
M src/diagnostics/archivist/src/logs/servers/log.rs
M src/diagnostics/archivist/src/logs/servers/log_settings.rs
M src/diagnostics/archivist/src/logs/testing.rs
M src/diagnostics/lib/log-command/src/lib.rs
M src/diagnostics/lib/validating-log-listener/src/lib.rs
M src/diagnostics/sampler/testing/realm-factory/src/mocks.rs
M src/diagnostics/tests/inspect-system/src/main.rs
M src/graphics/magma/lib/magma_service/sys_driver/magma_system_context.h
M src/graphics/magma/lib/magma_service/sys_driver/primary_fidl_server.cc
M src/graphics/magma/lib/magma_service/sys_driver/primary_fidl_server.h
M src/lib/diagnostics/data/rust/BUILD.gn
M src/lib/diagnostics/data/rust/src/logs_legacy.rs
M src/lib/diagnostics/log/message/rust/BUILD.gn
M src/lib/diagnostics/log/message/rust/src/test.rs
M src/lib/diagnostics/reader/rust/src/lib.rs
M src/lib/fuchsia-component-test/realm_builder_server/src/main.rs
M src/lib/fuchsia-component-test/src/lib.rs
M src/power/shutdown-shim/BUILD.gn
M src/power/shutdown-shim/src/lib.rs
M src/power/shutdown-shim/src/reboot_reasons.rs
M src/power/shutdown-shim/src/shutdown_watcher.rs
M src/power/shutdown-shim/tests/src/main.rs
M src/power/shutdown-shim/tests/src/reboot_watcher_client.rs
M src/starnix/lib/magma/src/magma.rs
M src/sys/fuzzing/manager/src/diagnostics.rs
M src/sys/fuzzing/manager/src/test_support.rs
M src/sys/test_manager/src/running_suite.rs
M src/sys/time/testing/lib/lib.rs
M src/sys/time/timekeeper/src/rtc.rs
M src/testing/end_to_end/honeydew/BUILD.gn
M src/testing/end_to_end/honeydew/honeydew/fuchsia_device/fuchsia_device_impl.py

Change size: L

Delta: 61 files changed, 196 insertions(+), 743 deletions(-)

Open in Gerrit

Related details

Attention is currently required from:

Hunter Freyer
Owners Override

Submit Requirements:

API-Review
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/9219ca07e52049976b73dd635bc67d19b4ecc508-HTML%40fuchsia-review.googlesource.com.

unsatisfied_requirement

open

diffy

'Clayton Mccray (Gerrit)' via owners-override

unread,

Dec 15, 2025, 12:08:44 PM12/15/25

to Brandon Castellano, David Dorwin, fuchsia-c...@fuchsia-infra.iam.gserviceaccount.com, Owners Override, Hunter Freyer, GI Try Builder, CQ Bot

Attention needed from Brandon Castellano, David Dorwin, Hunter Freyer and Owners Override

Clayton Mccray voted and added 3 comments

Votes added by Clayton Mccray

Code-Review

+2

3 comments

Patchset-level comments

File-level comment, Patchset 14 (Latest):

Clayton Mccray . resolved

LGTM for diagnostics. Thanks!

File src/diagnostics/archivist/src/accessor.rs

Line 269, Patchset 14 (Latest): _ => panic!("unhandled log format"),

Clayton Mccray . unresolved

I think I prefer to undo and leave the previous exhaustive match:
```
// TODO(https://fxbug.dev/401548725): Remove this from the FIDL definition.
                    Format::Text => Err(AccessorError::UnsupportedFormat),
                    Format::Cbor => unreachable!("CBOR is not supported for logs"),
```

They aren't perfect error messages by any means, but I prefer that we get compiler errors if we adjust this enum.

File src/diagnostics/lib/log-command/src/lib.rs

Line 581, Patchset 14 (Latest): persist: Some(true),

Clayton Mccray . unresolved

I think `persist` could now be false on this path, right? So we should do `persist: Some(persist),`

Open in Gerrit

Related details

Attention is currently required from:

Brandon Castellano
David Dorwin
Hunter Freyer
Owners Override

Submit Requirements:

API-Review
Code-Owners

Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/f98b581bf610712106ef967e0c1458951c5c95e7-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

unsatisfied_requirement

satisfied_requirement

open

diffy

'Brandon Castellano (Gerrit)' via owners-override

unread,

Dec 15, 2025, 5:52:34 PM12/15/25

to Clayton Mccray, David Dorwin, fuchsia-c...@fuchsia-infra.iam.gserviceaccount.com, Owners Override, Hunter Freyer, GI Try Builder, CQ Bot

Attention needed from David Dorwin, Hunter Freyer and Owners Override

Brandon Castellano added 2 comments

File src/diagnostics/archivist/src/accessor.rs

Line 269, Patchset 14: _ => panic!("unhandled log format"),

Clayton Mccray . resolved

I think I prefer to undo and leave the previous exhaustive match:
```
// TODO(https://fxbug.dev/401548725): Remove this from the FIDL definition.
                    Format::Text => Err(AccessorError::UnsupportedFormat),
                    Format::Cbor => unreachable!("CBOR is not supported for logs"),
```

They aren't perfect error messages by any means, but I prefer that we get compiler errors if we adjust this enum.

Brandon Castellano

Restored.

File src/diagnostics/lib/log-command/src/lib.rs

Line 581, Patchset 14: persist: Some(true),

Clayton Mccray . resolved

I think `persist` could now be false on this path, right? So we should do `persist: Some(persist),`

Brandon Castellano

Good catch, done.

Open in Gerrit

Related details

Attention is currently required from:

David Dorwin
Hunter Freyer
Owners Override

Submit Requirements:

API-Review
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/79fcb41f9fdc471438f3f20d87388a77819e608b-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

unsatisfied_requirement

satisfied_requirement

open

diffy

'Adam Barth (Gerrit)' via owners-override

unread,

Dec 15, 2025, 6:13:16 PM12/15/25

to Brandon Castellano, Clayton Mccray, David Dorwin, fuchsia-c...@fuchsia-infra.iam.gserviceaccount.com, Owners Override, Hunter Freyer, GI Try Builder, CQ Bot

Attention needed from Brandon Castellano, David Dorwin, Hunter Freyer and Owners Override

Adam Barth added 1 comment

Patchset-level comments

File-level comment, Patchset 16 (Latest):

Adam Barth . resolved

Looks like there are a bunch of files with non-mechanical changes that haven't been reviewed, which means it seems too early for owners-override.

Open in Gerrit

Related details

Attention is currently required from:

Brandon Castellano

David Dorwin
Hunter Freyer
Owners Override

Submit Requirements:

API-Review
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--

You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/e289cf73cd8489983fe641c9c013aaa12758dbf7-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

unsatisfied_requirement

satisfied_requirement

open

diffy

'Hunter Freyer (Gerrit)' via owners-override

unread,

Dec 16, 2025, 11:41:00 AM12/16/25

to Brandon Castellano, Michael Brunson, Adam Barth, Clayton Mccray, David Dorwin, fuchsia-c...@fuchsia-infra.iam.gserviceaccount.com, Owners Override, GI Try Builder, CQ Bot

Attention needed from Brandon Castellano, David Dorwin, Michael Brunson and Owners Override

Hunter Freyer added 2 comments

Patchset-level comments

File-level comment, Patchset 16 (Latest):

Hunter Freyer . resolved

The main thing

File-level comment, Patchset 16 (Latest):

Adam Barth . unresolved

Looks like there are a bunch of files with non-mechanical changes that haven't been reviewed, which means it seems too early for owners-override.

Hunter Freyer

I think I can speak to the RTC changes, they look good to me. The power changes could maybe use another set of eyes. @mbru...@google.com, can you take a look? After that I can provide OO+1.

Open in Gerrit

Related details

Attention is currently required from:

Brandon Castellano
David Dorwin
Michael Brunson
Owners Override

Submit Requirements:

API-Review
Code-Owners
Code-Review

No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/2dffd36823056e61073103a6f0699a2e07c95947-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

unsatisfied_requirement

satisfied_requirement

open

diffy

'Michael Brunson (Gerrit)' via owners-override

unread,

Dec 17, 2025, 6:11:37 PM12/17/25

to Brandon Castellano, Jeff Martin, Francois Rousseau, Adam Barth, Clayton Mccray, David Dorwin, fuchsia-c...@fuchsia-infra.iam.gserviceaccount.com, Owners Override, Hunter Freyer, GI Try Builder, CQ Bot

Attention needed from Brandon Castellano, David Dorwin, Francois Rousseau, Jeff Martin and Owners Override

Michael Brunson added 1 comment

Patchset-level comments

File-level comment, Patchset 16 (Latest):

Adam Barth . unresolved

Looks like there are a bunch of files with non-mechanical changes that haven't been reviewed, which means it seems too early for owners-override.

Hunter Freyer

I think I can speak to the RTC changes, they look good to me. The power changes could maybe use another set of eyes. @mbru...@google.com, can you take a look? After that I can provide OO+1.

Michael Brunson

fxbug.dev/385742868 is still open. Looks like a number of changes have been landed but it still remains open. Maybe @martin...@google.com or @frou...@google.com know the state of things there?

Open in Gerrit

Related details

Attention is currently required from:

Brandon Castellano
David Dorwin
Francois Rousseau
Jeff Martin
Owners Override

Submit Requirements:

API-Review
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/5d8189a625603bb3fb1cb90dbbea4f73d46520d8-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

unsatisfied_requirement

satisfied_requirement

open

diffy

'Francois Rousseau (Gerrit)' via owners-override

unread,

Dec 17, 2025, 6:33:24 PM12/17/25

to Brandon Castellano, Jeff Martin, Michael Brunson, Adam Barth, Clayton Mccray, David Dorwin, fuchsia-c...@fuchsia-infra.iam.gserviceaccount.com, Owners Override, Hunter Freyer, GI Try Builder, CQ Bot

Attention needed from Brandon Castellano, David Dorwin, Jeff Martin and Owners Override

Francois Rousseau added 1 comment

Patchset-level comments

File-level comment, Patchset 16 (Latest):

Adam Barth . unresolved

Looks like there are a bunch of files with non-mechanical changes that haven't been reviewed, which means it seems too early for owners-override.

Hunter Freyer

I think I can speak to the RTC changes, they look good to me. The power changes could maybe use another set of eyes. @mbru...@google.com, can you take a look? After that I can provide OO+1.

Michael Brunson

fxbug.dev/385742868 is still open. Looks like a number of changes have been landed but it still remains open. Maybe @martin...@google.com or @frou...@google.com know the state of things there?

Francois Rousseau

I guess I would have expected the CL to also remove the definitions in the //sdk/fidl/fuchsia.hardware.power.statecontrol/*.fidl files. That's what that cleanup issue is tracking, deleting the server implementation and the FIDL definitions.

Open in Gerrit

Related details

Attention is currently required from:

Brandon Castellano
David Dorwin
Jeff Martin
Owners Override

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/54595d5d97c99991de3f87138710218c462b6aa4-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

unsatisfied_requirement

satisfied_requirement

open

diffy

'Jeff Martin (Gerrit)' via owners-override

unread,

Dec 18, 2025, 9:08:47 AM12/18/25

to Brandon Castellano, Francois Rousseau, Michael Brunson, Adam Barth, Clayton Mccray, David Dorwin, fuchsia-c...@fuchsia-infra.iam.gserviceaccount.com, Owners Override, Hunter Freyer, GI Try Builder, CQ Bot

Attention needed from Brandon Castellano, David Dorwin and Owners Override

Jeff Martin voted and added 2 comments

Votes added by Jeff Martin

Code-Review

+1

2 comments

Patchset-level comments

File-level comment, Patchset 16 (Latest):

Adam Barth . unresolved

Looks like there are a bunch of files with non-mechanical changes that haven't been reviewed, which means it seems too early for owners-override.

Hunter Freyer

I think I can speak to the RTC changes, they look good to me. The power changes could maybe use another set of eyes. @mbru...@google.com, can you take a look? After that I can provide OO+1.

Michael Brunson

fxbug.dev/385742868 is still open. Looks like a number of changes have been landed but it still remains open. Maybe @martin...@google.com or @frou...@google.com know the state of things there?

Francois Rousseau

I guess I would have expected the CL to also remove the definitions in the //sdk/fidl/fuchsia.hardware.power.statecontrol/*.fidl files. That's what that cleanup issue is tracking, deleting the server implementation and the FIDL definitions.

Jeff Martin

I've been holding on to fxbug.dev/385742868 waiting for F26 to be retired so that we could delete the logic backing the old FIDL definitions. So from that perspective, the deletions in `src/power/shutdown-shim` LGTM. But +1 to what Francois said, I'm a little confused that the FIDL definitions aren't being deleted as part of this CL.

Commit Message

Line 10, Patchset 16 (Latest):Change-Id: Iffe85780eb923a31e4c0fc1f0d4f89c24e719310

Jeff Martin . unresolved

nit: would you mind adding `Bug: 385742868` to this CL description? You're performing a lot of the cleanup in scope of that bug (thanks by the way!)

Open in Gerrit

Related details

Attention is currently required from:

Brandon Castellano
David Dorwin
Owners Override

Submit Requirements:

API-Review
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/358f64b7907089a1a7fe7ed3343acedac48bbe4a-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

unsatisfied_requirement

satisfied_requirement

open

diffy

'Brandon Castellano (Gerrit)' via owners-override

unread,

Dec 18, 2025, 5:52:41 PM12/18/25

to Jeff Martin, Francois Rousseau, Michael Brunson, Adam Barth, Clayton Mccray, David Dorwin, fuchsia-c...@fuchsia-infra.iam.gserviceaccount.com, Owners Override, Hunter Freyer, GI Try Builder, CQ Bot

Attention needed from Adam Barth, David Dorwin, Francois Rousseau, Hunter Freyer, Jeff Martin, Michael Brunson and Owners Override

Brandon Castellano added 2 comments

Patchset-level comments

File-level comment, Patchset 16:

Adam Barth . unresolved

Looks like there are a bunch of files with non-mechanical changes that haven't been reviewed, which means it seems too early for owners-override.

Hunter Freyer

I think I can speak to the RTC changes, they look good to me. The power changes could maybe use another set of eyes. @mbru...@google.com, can you take a look? After that I can provide OO+1.

Michael Brunson

fxbug.dev/385742868 is still open. Looks like a number of changes have been landed but it still remains open. Maybe @martin...@google.com or @frou...@google.com know the state of things there?

Francois Rousseau

I guess I would have expected the CL to also remove the definitions in the //sdk/fidl/fuchsia.hardware.power.statecontrol/*.fidl files. That's what that cleanup issue is tracking, deleting the server implementation and the FIDL definitions.

Jeff Martin

I've been holding on to fxbug.dev/385742868 waiting for F26 to be retired so that we could delete the logic backing the old FIDL definitions. So from that perspective, the deletions in `src/power/shutdown-shim` LGTM. But +1 to what Francois said, I'm a little confused that the FIDL definitions aren't being deleted as part of this CL.

Brandon Castellano

I don't think we usually remove FIDL definitions in the same CL that we retire a given API level. Could this be done in a follow-up?

Commit Message

Line 10, Patchset 16:Change-Id: Iffe85780eb923a31e4c0fc1f0d4f89c24e719310

Jeff Martin . resolved

nit: would you mind adding `Bug: 385742868` to this CL description? You're performing a lot of the cleanup in scope of that bug (thanks by the way!)

Brandon Castellano

Done

Open in Gerrit

Related details

Attention is currently required from:

Adam Barth
David Dorwin
Francois Rousseau
Hunter Freyer
Jeff Martin
Michael Brunson
Owners Override

Submit Requirements:

API-Review
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/80d9dc6df0d53606c801b26a7e7abe82fed1e403-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

unsatisfied_requirement

satisfied_requirement

open

diffy

'Hunter Freyer (Gerrit)' via owners-override

unread,

Dec 19, 2025, 11:55:16 AM12/19/25

to Brandon Castellano, Jeff Martin, Francois Rousseau, Michael Brunson, Adam Barth, Clayton Mccray, David Dorwin, fuchsia-c...@fuchsia-infra.iam.gserviceaccount.com, Owners Override, GI Try Builder, CQ Bot

Attention needed from Adam Barth, Brandon Castellano, David Dorwin, Francois Rousseau, Jeff Martin, Michael Brunson and Owners Override

Hunter Freyer added 2 comments

Patchset-level comments

File-level comment, Patchset 16:

Hunter Freyer . resolved

The main thing

Hunter Freyer

What an insightful comment this was.

File-level comment, Patchset 16:

Adam Barth . unresolved

Looks like there are a bunch of files with non-mechanical changes that haven't been reviewed, which means it seems too early for owners-override.

Hunter Freyer

I think I can speak to the RTC changes, they look good to me. The power changes could maybe use another set of eyes. @mbru...@google.com, can you take a look? After that I can provide OO+1.

Michael Brunson

fxbug.dev/385742868 is still open. Looks like a number of changes have been landed but it still remains open. Maybe @martin...@google.com or @frou...@google.com know the state of things there?

Francois Rousseau

I guess I would have expected the CL to also remove the definitions in the //sdk/fidl/fuchsia.hardware.power.statecontrol/*.fidl files. That's what that cleanup issue is tracking, deleting the server implementation and the FIDL definitions.

Jeff Martin

I've been holding on to fxbug.dev/385742868 waiting for F26 to be retired so that we could delete the logic backing the old FIDL definitions. So from that perspective, the deletions in `src/power/shutdown-shim` LGTM. But +1 to what Francois said, I'm a little confused that the FIDL definitions aren't being deleted as part of this CL.

Brandon Castellano

I don't think we usually remove FIDL definitions in the same CL that we retire a given API level. Could this be done in a follow-up?

Hunter Freyer

In general, we leave removed definitions in the FIDL files to act as historical documentation. We've bikeshedded on this several times before - I should probably just write a tiny RFC to make it official policy.

Still waiting on a +2 from @mbru...@google.com (or another owner on the `shutdown-shim` code), and then I think we're good to go.

Open in Gerrit

Related details

Attention is currently required from:

Adam Barth

Brandon Castellano
David Dorwin
Francois Rousseau

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/8adef51c55971280f314112241eca024428ec085-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

unsatisfied_requirement

satisfied_requirement

open

diffy

'Michael Brunson (Gerrit)' via owners-override

unread,

Dec 19, 2025, 2:06:47 PM12/19/25

to Brandon Castellano, Jeff Martin, Francois Rousseau, Adam Barth, Clayton Mccray, David Dorwin, fuchsia-c...@fuchsia-infra.iam.gserviceaccount.com, Owners Override, Hunter Freyer, GI Try Builder, CQ Bot

Attention needed from Adam Barth, Brandon Castellano, David Dorwin, Francois Rousseau, Jeff Martin and Owners Override

Michael Brunson voted Code-Review+2

Code-Review

+2

Open in Gerrit

Related details

Attention is currently required from:

Adam Barth
Brandon Castellano
David Dorwin
Francois Rousseau
Jeff Martin

Owners Override

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/b65e0ac616f0533d283a84887c3efe1e75a1adb1-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

unsatisfied_requirement

satisfied_requirement

open

diffy

'Hunter Freyer (Gerrit)' via owners-override

unread,

Dec 19, 2025, 3:07:55 PM12/19/25

to Brandon Castellano, Michael Brunson, Jeff Martin, Francois Rousseau, Adam Barth, Clayton Mccray, David Dorwin, fuchsia-c...@fuchsia-infra.iam.gserviceaccount.com, Owners Override, GI Try Builder, CQ Bot

Attention needed from Adam Barth, Brandon Castellano, David Dorwin, Francois Rousseau, Jeff Martin and Owners Override

Hunter Freyer voted and added 2 comments

Votes added by Hunter Freyer

API-Review	+1
Code-Review	+2
Owners-Override	+1

2 comments

Patchset-level comments

File-level comment, Patchset 16:

Adam Barth . resolved

Looks like there are a bunch of files with non-mechanical changes that haven't been reviewed, which means it seems too early for owners-override.

Hunter Freyer

I think I can speak to the RTC changes, they look good to me. The power changes could maybe use another set of eyes. @mbru...@google.com, can you take a look? After that I can provide OO+1.

Michael Brunson

fxbug.dev/385742868 is still open. Looks like a number of changes have been landed but it still remains open. Maybe @martin...@google.com or @frou...@google.com know the state of things there?

Francois Rousseau

I guess I would have expected the CL to also remove the definitions in the //sdk/fidl/fuchsia.hardware.power.statecontrol/*.fidl files. That's what that cleanup issue is tracking, deleting the server implementation and the FIDL definitions.

Jeff Martin

I've been holding on to fxbug.dev/385742868 waiting for F26 to be retired so that we could delete the logic backing the old FIDL definitions. So from that perspective, the deletions in `src/power/shutdown-shim` LGTM. But +1 to what Francois said, I'm a little confused that the FIDL definitions aren't being deleted as part of this CL.

Brandon Castellano

I don't think we usually remove FIDL definitions in the same CL that we retire a given API level. Could this be done in a follow-up?

Hunter Freyer

In general, we leave removed definitions in the FIDL files to act as historical documentation. We've bikeshedded on this several times before - I should probably just write a tiny RFC to make it official policy.
Still waiting on a +2 from @mbru...@google.com (or another owner on the `shutdown-shim` code), and then I think we're good to go.

Hunter Freyer

Boom. Let's do this!

File-level comment, Patchset 17 (Latest):

Hunter Freyer . resolved

Thanks so much Brandon! Incredible dedication as always 😊

Open in Gerrit

Related details

Attention is currently required from:

Adam Barth
Brandon Castellano
David Dorwin
Francois Rousseau
Jeff Martin
Owners Override

Submit Requirements:

API-Review
Code-Owners
Code-Review
Review-Enforcement

--

You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/b3124ac66c5ee56b429ccfdeb853743428bbc8ee-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

satisfied_requirement

open

diffy

'Brandon Castellano (Gerrit)' via owners-override

unread,

Dec 19, 2025, 4:16:24 PM12/19/25

to Hunter Freyer, Michael Brunson, Jeff Martin, Francois Rousseau, Adam Barth, Clayton Mccray, David Dorwin, fuchsia-c...@fuchsia-infra.iam.gserviceaccount.com, Owners Override, GI Try Builder, CQ Bot

Attention needed from Adam Barth, David Dorwin, Francois Rousseau, Jeff Martin and Owners Override

Brandon Castellano voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention is currently required from:

Adam Barth

--

You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/a13db63e072b68e7df6075a449335690ee3bd663-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

satisfied_requirement

open

diffy

'Brandon Castellano (Gerrit)' via owners-override

unread,

Dec 19, 2025, 5:09:08 PM12/19/25

to Hunter Freyer, Michael Brunson, Jeff Martin, Francois Rousseau, Adam Barth, Clayton Mccray, David Dorwin, fuchsia-c...@fuchsia-infra.iam.gserviceaccount.com, Owners Override, GI Try Builder, CQ Bot

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/f0fe28a0947609426ba836e55a3748982df9bae6-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

satisfied_requirement

open

diffy

'CQ Bot (Gerrit)' via owners-override

unread,

Dec 19, 2025, 6:18:47 PM12/19/25

to Brandon Castellano, Hunter Freyer, Michael Brunson, Jeff Martin, Francois Rousseau, Adam Barth, Clayton Mccray, David Dorwin, fuchsia-c...@fuchsia-infra.iam.gserviceaccount.com, Owners Override, GI Try Builder

CQ Bot submitted the change

Change information

Commit message:

[version_history] Retire API level 26

Fixed: 449772374

Bug: 385742868

Change-Id: Iffe85780eb923a31e4c0fc1f0d4f89c24e719310

Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1384801

API-Review: Hunter Freyer <hjfr...@google.com>

Owners-Override: Hunter Freyer <hjfr...@google.com>

Commit-Queue: Brandon Castellano <bcas...@google.com>

Reviewed-by: Jeff Martin <martin...@google.com>

Reviewed-by: Michael Brunson <mbru...@google.com>

Reviewed-by: Hunter Freyer <hjfr...@google.com>

Reviewed-by: Clayton Mccray <clayto...@google.com>

Files:

M docs/development/graphics/magma/concepts/porting.md
M sdk/fidl/fuchsia.diagnostics.types/fuchsia.diagnostics.types.api
M sdk/fidl/fuchsia.diagnostics/fuchsia.diagnostics.api
M sdk/fidl/fuchsia.gpu.magma/fuchsia.gpu.magma.api
M sdk/fidl/fuchsia.hardware.power.statecontrol/fuchsia.hardware.power.statecontrol.api
M sdk/fidl/fuchsia.hardware.rtc/fuchsia.hardware.rtc.api
M sdk/fidl/fuchsia.logger/fuchsia.logger.api

Change size: L

Delta: 58 files changed, 193 insertions(+), 702 deletions(-)

Branch: refs/heads/main

Submit Requirements:

API-Review: +1 by Hunter Freyer
Code-Review: +1 by Jeff Martin, +2 by Clayton Mccray, +2 by Hunter Freyer, +2 by Michael Brunson

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--

You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/f1a855a51f5602da5f83561d615b8f62ecc35689-HTML%40fuchsia-review.googlesource.com.

open

diffy

satisfied_requirement

'GI Roller (Gerrit)' via owners-override

unread,

Dec 19, 2025, 6:31:09 PM12/19/25

to Brandon Castellano, CQ Bot, Hunter Freyer, Michael Brunson, Jeff Martin, Francois Rousseau, Adam Barth, Clayton Mccray, David Dorwin, fuchsia-c...@fuchsia-infra.iam.gserviceaccount.com, Owners Override, GI Try Builder

Message from GI Roller

Change has been successfully rolled: https://turquoise-internal-review.googlesource.com/1120703

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

API-Review

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/6f74e7152c0adbfbfcafeaab26946ab957aa5cf0-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

satisfied_requirement

open

diffy

Reply all

Reply to author

Forward

[L] Change in fuchsia/fuchsia[main]: [version_history] Retire API level 26

'Brandon Castellano (Gerrit)' via owners-override

Brandon Castellano has uploaded the change for review

Commit message

Change diff

Change information

Related details

'Clayton Mccray (Gerrit)' via owners-override

Clayton Mccray voted and added 3 comments

Votes added by Clayton Mccray

3 comments

Related details

'Brandon Castellano (Gerrit)' via owners-override

Brandon Castellano added 2 comments

Related details

'Adam Barth (Gerrit)' via owners-override

Adam Barth added 1 comment

Related details

'Hunter Freyer (Gerrit)' via owners-override

Hunter Freyer added 2 comments

Related details

'Michael Brunson (Gerrit)' via owners-override

Michael Brunson added 1 comment

Related details

'Francois Rousseau (Gerrit)' via owners-override

Francois Rousseau added 1 comment

Related details

'Jeff Martin (Gerrit)' via owners-override

Jeff Martin voted and added 2 comments

Votes added by Jeff Martin

2 comments

Related details

'Brandon Castellano (Gerrit)' via owners-override

Brandon Castellano added 2 comments

Related details

'Hunter Freyer (Gerrit)' via owners-override

Hunter Freyer added 2 comments

Related details

'Michael Brunson (Gerrit)' via owners-override

Michael Brunson voted Code-Review+2

Related details

'Hunter Freyer (Gerrit)' via owners-override

Hunter Freyer voted and added 2 comments

Votes added by Hunter Freyer

2 comments

Related details

'Brandon Castellano (Gerrit)' via owners-override

Brandon Castellano voted Commit-Queue+2

Related details

'Brandon Castellano (Gerrit)' via owners-override

'CQ Bot (Gerrit)' via owners-override

CQ Bot submitted the change

Change information

'GI Roller (Gerrit)' via owners-override

Message from GI Roller

Related details