[M] Change in fuchsia/fuchsia[main]: [scheduler] Separate ProfileProvider into a deprecated library

0 views
Skip to first unread message

'Anirudh Mathukumilli (Gerrit)' via owners-override

unread,
Mar 27, 2024, 8:24:35 PMMar 27
to Owners Override
Attention needed from Owners Override

Anirudh Mathukumilli has uploaded the change for review

Anirudh Mathukumilli would like Owners Override to review this change.

Commit message

[scheduler] Separate ProfileProvider into a deprecated library

Moves `fuchsia.scheduler.ProfileProvider` into its own deprecated
library called `fuchsia.scheduler.deprecated.ProfileProvider`. This
change also modifies all routes and code that use the ProfileProvider to
use the new location for the FIDL bindings.

This change will allow us to mark the role.fidl API as partner
accessible without exposing the deprecated profile.fidl API.
Bug: 42083865, 323262398
Change-Id: Iefdea98b3d2760d246c663d4639fdbb8766d5245

Change diff


Change information

Files:
  • A sdk/fidl/fuchsia.scheduler.deprecated/BUILD.gn
  • R sdk/fidl/fuchsia.scheduler.deprecated/profile.fidl
  • M sdk/fidl/fuchsia.scheduler/BUILD.gn
  • M src/bringup/bin/console-launcher/meta/console-launcher.cml
  • M src/bringup/bin/console/meta/console.shard.cml
  • M src/bringup/bin/svchost/meta/svchost.cml
  • M src/connectivity/network/meta/common.shard.cml
  • M src/connectivity/network/netstack/BUILD.gn
  • M src/connectivity/network/netstack/main.go
  • M src/connectivity/network/netstack/meta/netstack2-prod.shard.cml
  • M src/connectivity/network/tests/integration/sys/BUILD.gn
  • M src/connectivity/network/tests/integration/sys/src/lib.rs
  • M src/media/audio/audio_core/tools/output_pipeline_benchmark/main.cc
  • M src/media/audio/audio_core/tools/output_pipeline_benchmark/meta/pipeline_benchmark.cml
  • M src/media/audio/audio_core/tools/output_pipeline_benchmark/pipeline_benchmark_v2.gni
  • M src/security/tests/pkg_test/tests/access_ota_blob_as_executable/meta/access_ota_blob_as_executable.cml
  • M src/security/tests/pkg_test/tests/bad_signature_update/meta/bad_signature_update.cml
  • M src/sys/bootstrap/meta/bootstrap.cml
  • M src/sys/core/meta/core.cml
  • M src/sys/root/root.cml
  • M src/sys/test_manager/meta/common.shard.cml
  • M src/sys/test_manager/meta/test_manager.core_shard.cml
  • M src/sys/testing/meta/system-tests.shard.cml
  • M src/sys/testing/meta/test_realm.core_shard.cml
  • M src/zircon/tests/profile/BUILD.gn
  • M src/zircon/tests/profile/meta/profile-test.cml
  • M src/zircon/tests/profile/profile.cc
  • M zircon/system/ulib/profile/BUILD.gn
  • M zircon/system/ulib/profile/profile.cc
  • M zircon/system/utest/svchost/BUILD.gn
  • M zircon/system/utest/svchost/main.cc
Change size: M
Delta: 31 files changed, 86 insertions(+), 59 deletions(-)
Open in Gerrit

Related details

Attention is currently required from:
  • Owners Override
Submit Requirements:
  • requirement is not satisfiedAPI-Review
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: Iefdea98b3d2760d246c663d4639fdbb8766d5245
Gerrit-Change-Number: 1015816
Gerrit-PatchSet: 8
Gerrit-Owner: Anirudh Mathukumilli <rudy...@google.com>
Gerrit-Reviewer: Anirudh Mathukumilli <rudy...@google.com>
Gerrit-Reviewer: Corey Tabaka <ei...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/21bde59c4f555735d216a9c951d391488a6ae77c-HTML%40fuchsia-review.googlesource.com.
unsatisfied_requirement
satisfied_requirement
open
diffy

'Anirudh Mathukumilli (Gerrit)' via owners-override

unread,
Mar 27, 2024, 8:24:37 PMMar 27
to Owners Override, Corey Tabaka, fuchsia-c...@fuchsia-infra.iam.gserviceaccount.com, CQ Bot
Attention needed from Owners Override

Anirudh Mathukumilli added 1 comment

Patchset-level comments
File-level comment, Patchset 8 (Latest):
Anirudh Mathukumilli . resolved

Adding the owners-override once again because this migration spans a lot of owners domains but ultimately is purely mechanical. This should be the last change in the ProfileProvider migration changes in-tree.

Open in Gerrit

Related details

Attention is currently required from:
  • Owners Override
Submit Requirements:
  • requirement is not satisfiedAPI-Review
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: Iefdea98b3d2760d246c663d4639fdbb8766d5245
Gerrit-Change-Number: 1015816
Gerrit-PatchSet: 8
Gerrit-Owner: Anirudh Mathukumilli <rudy...@google.com>
Gerrit-Reviewer: Anirudh Mathukumilli <rudy...@google.com>
Gerrit-Reviewer: Corey Tabaka <ei...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Comment-Date: Thu, 28 Mar 2024 00:24:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/21bde59c4f555735d216a9c951d391488a6ae77c-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
unsatisfied_requirement
satisfied_requirement
open
diffy

'Adam Barth (Gerrit)' via owners-override

unread,
Mar 28, 2024, 2:40:41 AMMar 28
to Anirudh Mathukumilli, Owners Override, Corey Tabaka, fuchsia-c...@fuchsia-infra.iam.gserviceaccount.com, CQ Bot
Attention needed from Anirudh Mathukumilli and Owners Override

Adam Barth voted

API-Review+1
Owners-Override+1
Open in Gerrit

Related details

Attention is currently required from:
  • Anirudh Mathukumilli
  • Owners Override
Submit Requirements:
  • requirement satisfiedAPI-Review
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: Iefdea98b3d2760d246c663d4639fdbb8766d5245
Gerrit-Change-Number: 1015816
Gerrit-PatchSet: 8
Gerrit-Owner: Anirudh Mathukumilli <rudy...@google.com>
Gerrit-Reviewer: Adam Barth <aba...@google.com>
Gerrit-Reviewer: Anirudh Mathukumilli <rudy...@google.com>
Gerrit-Reviewer: Corey Tabaka <ei...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Anirudh Mathukumilli <rudy...@google.com>
Gerrit-Comment-Date: Thu, 28 Mar 2024 06:40:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/5ac06f4ef388e0e1c3eab3600a7ad9dbb7123137-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy

'Anirudh Mathukumilli (Gerrit)' via owners-override

unread,
Mar 28, 2024, 12:39:13 PMMar 28
to Adam Barth, Owners Override, Corey Tabaka, fuchsia-c...@fuchsia-infra.iam.gserviceaccount.com, CQ Bot
Attention needed from Owners Override

Anirudh Mathukumilli voted

Commit-Queue+2
Fuchsia-Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Owners Override
Submit Requirements:
  • requirement satisfiedAPI-Review
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: Iefdea98b3d2760d246c663d4639fdbb8766d5245
Gerrit-Change-Number: 1015816
Gerrit-PatchSet: 8
Gerrit-Owner: Anirudh Mathukumilli <rudy...@google.com>
Gerrit-Reviewer: Adam Barth <aba...@google.com>
Gerrit-Reviewer: Anirudh Mathukumilli <rudy...@google.com>
Gerrit-Reviewer: Corey Tabaka <ei...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Comment-Date: Thu, 28 Mar 2024 16:39:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/63d4756699a66748f1f3ab3dfbb20722a37da791-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy

'CQ Bot (Gerrit)' via owners-override

unread,
Mar 28, 2024, 1:00:29 PMMar 28
to Anirudh Mathukumilli, Adam Barth, Owners Override, Corey Tabaka, fuchsia-c...@fuchsia-infra.iam.gserviceaccount.com

CQ Bot submitted the change with unreviewed changes

Unreviewed changes

6 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: src/bringup/bin/console/meta/console.shard.cml
Insertions: 262, Deletions: 0.

The diff is too large to show. Please review the diff.
```
```
The name of the file: src/sys/bootstrap/meta/bootstrap.cml
Insertions: 0, Deletions: 59.

The diff is too large to show. Please review the diff.
```

Change information

Commit message:
[scheduler] Separate ProfileProvider into a deprecated library

Moves `fuchsia.scheduler.ProfileProvider` into its own deprecated
library called `fuchsia.scheduler.deprecated.ProfileProvider`. This
change also modifies all routes and code that use the ProfileProvider to
use the new location for the FIDL bindings.

This change will allow us to mark the role.fidl API as partner
accessible without exposing the deprecated profile.fidl API.
Bug: 42083865, 323262398
Change-Id: Iefdea98b3d2760d246c663d4639fdbb8766d5245
API-Review: Adam Barth <aba...@google.com>
Reviewed-by: Corey Tabaka <ei...@google.com>
Commit-Queue: Anirudh Mathukumilli <rudy...@google.com>
Fuchsia-Auto-Submit: Anirudh Mathukumilli <rudy...@google.com>
Owners-Override: Adam Barth <aba...@google.com>
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedAPI-Review: +1 by Adam Barth
  • requirement satisfiedCode-Review: +2 by Corey Tabaka
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: Iefdea98b3d2760d246c663d4639fdbb8766d5245
Gerrit-Change-Number: 1015816
Gerrit-PatchSet: 9
Gerrit-Owner: Anirudh Mathukumilli <rudy...@google.com>
Gerrit-Reviewer: Adam Barth <aba...@google.com>
Gerrit-Reviewer: Anirudh Mathukumilli <rudy...@google.com>
Gerrit-Reviewer: Corey Tabaka <ei...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/87b4bea8efe17b215f7763f95224b05af5723c46-HTML%40fuchsia-review.googlesource.com.
open
diffy
satisfied_requirement

'GI Roller (Gerrit)' via owners-override

unread,
Mar 28, 2024, 1:02:36 PMMar 28
to Anirudh Mathukumilli, CQ Bot, Adam Barth, Owners Override, Corey Tabaka, fuchsia-c...@fuchsia-infra.iam.gserviceaccount.com

Message from GI Roller

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedAPI-Review
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: Iefdea98b3d2760d246c663d4639fdbb8766d5245
Gerrit-Change-Number: 1015816
Gerrit-PatchSet: 9
Gerrit-Owner: Anirudh Mathukumilli <rudy...@google.com>
Gerrit-Reviewer: Adam Barth <aba...@google.com>
Gerrit-Reviewer: Anirudh Mathukumilli <rudy...@google.com>
Gerrit-Reviewer: Corey Tabaka <ei...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Comment-Date: Thu, 28 Mar 2024 17:02:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/b54af3763226b6f86a574687d8196cff4b5e173c-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages