[XS] Change in fuchsia/fuchsia[main]: [kmutex] Create src/lib/kmutex

0 views
Skip to first unread message

'Adam Barth (Gerrit)' via owners-override

unread,
May 22, 2026, 1:09:25 PM (2 days ago) May 22
to James Robinson, Adrian Danis, Owners Override
Attention needed from Adrian Danis and James Robinson

Adam Barth has uploaded the change for review

Adam Barth would like James Robinson and Adrian Danis to review this change.

Commit message

[kmutex] Create src/lib/kmutex

This directory will contain a crate for working with Rust Mutex objects
in the Zircon kernel.
Bug: b/507423574
Change-Id: Ib5fc37a371a54da90a4f0900adccbc2ecebe2b73

Change diff

diff --git a/src/lib/kmutex/OWNERS b/src/lib/kmutex/OWNERS
new file mode 100644
index 0000000..496abb7
--- /dev/null
+++ b/src/lib/kmutex/OWNERS
@@ -0,0 +1,2 @@
+aba...@google.com
+include /zircon/kernel/OWNERS

Change information

Files:
  • A src/lib/kmutex/OWNERS
Change size: XS
Delta: 1 file changed, 2 insertions(+), 0 deletions(-)
Open in Gerrit

Related details

Attention is currently required from:
  • Adrian Danis
  • James Robinson
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: Ib5fc37a371a54da90a4f0900adccbc2ecebe2b73
Gerrit-Change-Number: 1623779
Gerrit-PatchSet: 1
Gerrit-Owner: Adam Barth <aba...@google.com>
Gerrit-Reviewer: Adam Barth <aba...@google.com>
Gerrit-Reviewer: Adrian Danis <ada...@google.com>
Gerrit-Reviewer: James Robinson <jam...@google.com>
Gerrit-CC: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: James Robinson <jam...@google.com>
Gerrit-Attention: Adrian Danis <ada...@google.com>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/ec6951db1445841710b3a367c6569ced9f6631a7-HTML%40fuchsia-review.googlesource.com.
unsatisfied_requirement
open
diffy

'Adam Barth (Gerrit)' via owners-override

unread,
May 22, 2026, 1:09:27 PM (2 days ago) May 22
to James Robinson, Adrian Danis, Owners Override
Attention needed from Adrian Danis and James Robinson

Adam Barth voted

Commit-Queue+1
Fuchsia-Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Adrian Danis
  • James Robinson
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: Ib5fc37a371a54da90a4f0900adccbc2ecebe2b73
Gerrit-Change-Number: 1623779
Gerrit-PatchSet: 1
Gerrit-Owner: Adam Barth <aba...@google.com>
Gerrit-Reviewer: Adam Barth <aba...@google.com>
Gerrit-Reviewer: Adrian Danis <ada...@google.com>
Gerrit-Reviewer: James Robinson <jam...@google.com>
Gerrit-CC: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: James Robinson <jam...@google.com>
Gerrit-Attention: Adrian Danis <ada...@google.com>
Gerrit-Comment-Date: Fri, 22 May 2026 17:09:23 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/ec6951db1445841710b3a367c6569ced9f6631a7-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
unsatisfied_requirement
open
diffy

'James Robinson (Gerrit)' via owners-override

unread,
May 22, 2026, 2:41:53 PM (2 days ago) May 22
to Adam Barth, fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com, Adrian Danis, Owners Override
Attention needed from Adam Barth and Adrian Danis

James Robinson voted and added 1 comment

Votes added by James Robinson

Code-Review+2

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
James Robinson . resolved

We should think about how to group these libraries at some point. At this rate, we're going to end up with a spread of libraries in src/lib and zircon/system/ulib, it would be good to put them into a single place with an appropriate set of OWNERS and documentation describing the constraints for Rust libraries usable in kernel mode.

Open in Gerrit

Related details

Attention is currently required from:
  • Adam Barth
  • Adrian Danis
Submit Requirements:
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: fuchsia
    Gerrit-Branch: main
    Gerrit-Change-Id: Ib5fc37a371a54da90a4f0900adccbc2ecebe2b73
    Gerrit-Change-Number: 1623779
    Gerrit-PatchSet: 1
    Gerrit-Owner: Adam Barth <aba...@google.com>
    Gerrit-Reviewer: Adam Barth <aba...@google.com>
    Gerrit-Reviewer: Adrian Danis <ada...@google.com>
    Gerrit-Reviewer: James Robinson <jam...@google.com>
    Gerrit-CC: Owners Override <owners-...@fuchsia.dev>
    Gerrit-Attention: Adam Barth <aba...@google.com>
    Gerrit-Attention: Adrian Danis <ada...@google.com>
    Gerrit-Comment-Date: Fri, 22 May 2026 18:41:46 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes

    --
    You received this message because you are subscribed to the Google Groups "owners-override" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
    To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/f7ff66da6404b13db3c13db212ce662376ad9e4e-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
    unsatisfied_requirement
    satisfied_requirement
    open
    diffy

    'Adam Barth (Gerrit)' via owners-override

    unread,
    May 22, 2026, 3:31:50 PM (2 days ago) May 22
    to Roland McGrath, James Robinson, fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com, Adrian Danis, Owners Override
    Attention needed from Adrian Danis

    Adam Barth added 1 comment

    Patchset-level comments
    James Robinson . resolved

    We should think about how to group these libraries at some point. At this rate, we're going to end up with a spread of libraries in src/lib and zircon/system/ulib, it would be good to put them into a single place with an appropriate set of OWNERS and documentation describing the constraints for Rust libraries usable in kernel mode.

    Adam Barth

    I had originally put `zr` and `kalloc` in `//zircon/system/ulib` but Roland told me I should move them to `//src/lib`:

    https://fuchsia-review.googlesource.com/c/fuchsia/+/1592595/12/zircon/system/ulib/zr/README.md

    Happy to put things wherever folks would like.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Adrian Danis
    Submit Requirements:
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: fuchsia
    Gerrit-Branch: main
    Gerrit-Change-Id: Ib5fc37a371a54da90a4f0900adccbc2ecebe2b73
    Gerrit-Change-Number: 1623779
    Gerrit-PatchSet: 1
    Gerrit-Owner: Adam Barth <aba...@google.com>
    Gerrit-Reviewer: Adam Barth <aba...@google.com>
    Gerrit-Reviewer: Adrian Danis <ada...@google.com>
    Gerrit-Reviewer: James Robinson <jam...@google.com>
    Gerrit-CC: Owners Override <owners-...@fuchsia.dev>
    Gerrit-CC: Roland McGrath <mcgr...@google.com>
    Gerrit-Attention: Adrian Danis <ada...@google.com>
    Gerrit-Comment-Date: Fri, 22 May 2026 19:31:45 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: James Robinson <jam...@google.com>

    --
    You received this message because you are subscribed to the Google Groups "owners-override" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
    To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/f54ef32f42b8edf3ada4fa1382a987293f411300-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
    unsatisfied_requirement
    satisfied_requirement
    open
    diffy

    'James Robinson (Gerrit)' via owners-override

    unread,
    May 22, 2026, 4:29:45 PM (2 days ago) May 22
    to Adam Barth, Roland McGrath, fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com, Adrian Danis, Owners Override
    Attention needed from Adam Barth and Adrian Danis

    James Robinson voted Owners-Override+1

    Owners-Override+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Adam Barth
    • Adrian Danis
    Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: fuchsia
    Gerrit-Branch: main
    Gerrit-Change-Id: Ib5fc37a371a54da90a4f0900adccbc2ecebe2b73
    Gerrit-Change-Number: 1623779
    Gerrit-PatchSet: 1
    Gerrit-Owner: Adam Barth <aba...@google.com>
    Gerrit-Reviewer: Adam Barth <aba...@google.com>
    Gerrit-Reviewer: Adrian Danis <ada...@google.com>
    Gerrit-Reviewer: James Robinson <jam...@google.com>
    Gerrit-CC: Owners Override <owners-...@fuchsia.dev>
    Gerrit-CC: Roland McGrath <mcgr...@google.com>
    Gerrit-Attention: Adam Barth <aba...@google.com>
    Gerrit-Attention: Adrian Danis <ada...@google.com>
    Gerrit-Comment-Date: Fri, 22 May 2026 20:29:37 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes

    --
    You received this message because you are subscribed to the Google Groups "owners-override" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
    To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/56cb1a7f1e3e1fa12bc7954aa8e868c97c4fd3a6-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
    satisfied_requirement
    open
    diffy

    'fuchsia-internal-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)' via owners-override

    unread,
    May 22, 2026, 4:31:06 PM (2 days ago) May 22
    to Adam Barth, James Robinson, Roland McGrath, Adrian Danis, Owners Override
    Commit message:
    [kmutex] Create src/lib/kmutex

    This directory will contain a crate for working with Rust Mutex objects
    in the Zircon kernel.
    Bug: b/507423574
    Change-Id: Ib5fc37a371a54da90a4f0900adccbc2ecebe2b73
    Commit-Queue: Adam Barth <aba...@google.com>
    Owners-Override: James Robinson <jam...@google.com>
    Reviewed-by: James Robinson <jam...@google.com>
    Fuchsia-Auto-Submit: Adam Barth <aba...@google.com>
    Files:
    • A src/lib/kmutex/OWNERS
    Change size: XS
    Delta: 1 file changed, 2 insertions(+), 0 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +2 by James Robinson
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: fuchsia
    Gerrit-Branch: main
    Gerrit-Change-Id: Ib5fc37a371a54da90a4f0900adccbc2ecebe2b73
    Gerrit-Change-Number: 1623779
    Gerrit-PatchSet: 2
    Gerrit-Owner: Adam Barth <aba...@google.com>
    Gerrit-Reviewer: Adam Barth <aba...@google.com>
    Gerrit-Reviewer: Adrian Danis <ada...@google.com>
    Gerrit-Reviewer: James Robinson <jam...@google.com>
    Gerrit-CC: Owners Override <owners-...@fuchsia.dev>
    Gerrit-CC: Roland McGrath <mcgr...@google.com>

    --
    You received this message because you are subscribed to the Google Groups "owners-override" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
    To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/debe389c7ebf33e357a133e7676f27df528436fc-HTML%40fuchsia-review.googlesource.com.
    open
    diffy
    satisfied_requirement

    'global-integration-ci-builder@fuchsia-infra.iam.gserviceaccount.com (Gerrit)' via owners-override

    unread,
    May 22, 2026, 4:34:46 PM (2 days ago) May 22
    to Adam Barth, fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com, James Robinson, Roland McGrath, Adrian Danis, Owners Override

    Message from global-integra...@fuchsia-infra.iam.gserviceaccount.com

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: fuchsia
    Gerrit-Branch: main
    Gerrit-Change-Id: Ib5fc37a371a54da90a4f0900adccbc2ecebe2b73
    Gerrit-Change-Number: 1623779
    Gerrit-PatchSet: 2
    Gerrit-Owner: Adam Barth <aba...@google.com>
    Gerrit-Reviewer: Adam Barth <aba...@google.com>
    Gerrit-Reviewer: Adrian Danis <ada...@google.com>
    Gerrit-Reviewer: James Robinson <jam...@google.com>
    Gerrit-CC: Owners Override <owners-...@fuchsia.dev>
    Gerrit-CC: Roland McGrath <mcgr...@google.com>
    Gerrit-Comment-Date: Fri, 22 May 2026 20:34:44 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: No

    --
    You received this message because you are subscribed to the Google Groups "owners-override" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
    To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/260a9ee309bba639f205e9b9f0e6e476459e5624-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
    satisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages