[M] Change in fuchsia/fuchsia[main]: [rust][clippy] fix or-fun-call clippy lints

2 views
Skip to first unread message

'Colin Nelson (Gerrit)' via owners-override

unread,
Jul 30, 2025, 11:35:50 AMJul 30
to Owners Override
Attention needed from Owners Override

Colin Nelson has uploaded the change for review

Colin Nelson would like Owners Override to review this change.

Commit message

[rust][clippy] fix or-fun-call clippy lints
Bug: b/434717998
Change-Id: Ic01eb29f885338519ad4bd2ec61ffd1d6a6a636c

Change diff


Change information

Files:
  • M src/connectivity/bluetooth/core/bt-gap/src/host_dispatcher.rs
  • M src/connectivity/bluetooth/lib/fuchsia-bluetooth/src/expectation.rs
  • M src/connectivity/bluetooth/profiles/bt-a2dp/src/main.rs
  • M src/connectivity/bluetooth/profiles/bt-hfp-audio-gateway/src/inspect.rs
  • M src/connectivity/bluetooth/profiles/bt-hfp-audio-gateway/src/peer/task.rs
  • M src/connectivity/bluetooth/tools/bt-cli/src/main.rs
  • M src/connectivity/network/netlink/src/routes.rs
  • M src/developer/ffx/config/src/mapping/home.rs
  • M src/developer/ffx/config/src/mapping/mod.rs
  • M src/developer/ffx/plugins/audio/common/src/lib.rs
  • M src/developer/ffx/plugins/audio/device/src/info.rs
  • M src/developer/ffx/plugins/emulator/engines/src/qemu_based/mod.rs
  • M src/developer/ffx/tools/bluetooth/src/peer/src/lib.rs
  • M src/devices/lib/bind/src/debugger/debug_dump.rs
  • M src/lib/analytics/rust/src/ga4_metrics_service.rs
  • M src/lib/fuchsia-lockfile/src/lib.rs
  • M src/power/metrics-logger/src/gpu_usage_logger.rs
  • M src/power/metrics-logger/src/sensor_logger.rs
  • M src/sys/lib/component_debug/src/cli/list.rs
Change size: M
Delta: 19 files changed, 59 insertions(+), 43 deletions(-)
Open in Gerrit

Related details

Attention is currently required from:
  • Owners Override
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: Ic01eb29f885338519ad4bd2ec61ffd1d6a6a636c
Gerrit-Change-Number: 1333637
Gerrit-PatchSet: 2
Gerrit-Owner: Colin Nelson <colnn...@google.com>
Gerrit-Reviewer: Caslyn Tonelli <cas...@google.com>
Gerrit-Reviewer: Colin Nelson <colnn...@google.com>
Gerrit-Reviewer: Erick Tryzelaar <etryz...@google.com>
Gerrit-Reviewer: Marie Janssen <jam...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/701f5e1d208243dcc5f5572f49b744506f2ad8d8-HTML%40fuchsia-review.googlesource.com.
unsatisfied_requirement
satisfied_requirement
open
diffy

'James Robinson (Gerrit)' via owners-override

unread,
Jul 30, 2025, 11:48:35 AMJul 30
to Colin Nelson, Owners Override, Erick Tryzelaar, Caslyn Tonelli, Marie Janssen, GI Try Builder, CQ Bot
Attention needed from Colin Nelson and Owners Override

James Robinson voted Code-Review+2

Code-Review+2
Open in Gerrit

Related details

Attention is currently required from:
  • Colin Nelson
  • Owners Override
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: Ic01eb29f885338519ad4bd2ec61ffd1d6a6a636c
Gerrit-Change-Number: 1333637
Gerrit-PatchSet: 2
Gerrit-Owner: Colin Nelson <colnn...@google.com>
Gerrit-Reviewer: Caslyn Tonelli <cas...@google.com>
Gerrit-Reviewer: Colin Nelson <colnn...@google.com>
Gerrit-Reviewer: Erick Tryzelaar <etryz...@google.com>
Gerrit-Reviewer: James Robinson <jam...@google.com>
Gerrit-Reviewer: Marie Janssen <jam...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Colin Nelson <colnn...@google.com>
Gerrit-Comment-Date: Wed, 30 Jul 2025 15:48:27 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/2ddcb0b226049bc21f0a171b2eed52ad1a349887-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
unsatisfied_requirement
satisfied_requirement
open
diffy

'James Robinson (Gerrit)' via owners-override

unread,
Jul 30, 2025, 11:48:38 AMJul 30
to Colin Nelson, Owners Override, Erick Tryzelaar, Caslyn Tonelli, Marie Janssen, GI Try Builder, CQ Bot
Attention needed from Colin Nelson and Owners Override

James Robinson voted Owners-Override+1

Owners-Override+1
Open in Gerrit

Related details

Attention is currently required from:
  • Colin Nelson
  • Owners Override
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: Ic01eb29f885338519ad4bd2ec61ffd1d6a6a636c
Gerrit-Change-Number: 1333637
Gerrit-PatchSet: 2
Gerrit-Owner: Colin Nelson <colnn...@google.com>
Gerrit-Reviewer: Caslyn Tonelli <cas...@google.com>
Gerrit-Reviewer: Colin Nelson <colnn...@google.com>
Gerrit-Reviewer: Erick Tryzelaar <etryz...@google.com>
Gerrit-Reviewer: James Robinson <jam...@google.com>
Gerrit-Reviewer: Marie Janssen <jam...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Colin Nelson <colnn...@google.com>
Gerrit-Comment-Date: Wed, 30 Jul 2025 15:48:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/4ab9e40cb05492baee697e6ecbd3da03d71c94e4-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy

'Adam Barth (Gerrit)' via owners-override

unread,
Jul 30, 2025, 12:05:28 PMJul 30
to Colin Nelson, James Robinson, Owners Override, Erick Tryzelaar, Caslyn Tonelli, Marie Janssen, GI Try Builder, CQ Bot
Attention needed from Colin Nelson and Owners Override

Adam Barth voted Owners-Override+1

Owners-Override+1
Open in Gerrit

Related details

Attention is currently required from:
  • Colin Nelson
  • Owners Override
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: Ic01eb29f885338519ad4bd2ec61ffd1d6a6a636c
Gerrit-Change-Number: 1333637
Gerrit-PatchSet: 2
Gerrit-Owner: Colin Nelson <colnn...@google.com>
Gerrit-Reviewer: Adam Barth <aba...@google.com>
Gerrit-Reviewer: Caslyn Tonelli <cas...@google.com>
Gerrit-Reviewer: Colin Nelson <colnn...@google.com>
Gerrit-Reviewer: Erick Tryzelaar <etryz...@google.com>
Gerrit-Reviewer: James Robinson <jam...@google.com>
Gerrit-Reviewer: Marie Janssen <jam...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Colin Nelson <colnn...@google.com>
Gerrit-Comment-Date: Wed, 30 Jul 2025 16:05:21 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/8400ffde383afc024208b567d01ed182e60fc464-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy

'CQ Bot (Gerrit)' via owners-override

unread,
Jul 30, 2025, 1:38:31 PMJul 30
to Colin Nelson, Adam Barth, James Robinson, Owners Override, Erick Tryzelaar, Caslyn Tonelli, Marie Janssen, GI Try Builder

CQ Bot submitted the change

Change information

Commit message:
[rust][clippy] fix or-fun-call clippy lints
Bug: b/434717998
Change-Id: Ic01eb29f885338519ad4bd2ec61ffd1d6a6a636c
Fuchsia-Auto-Submit: Colin Nelson <colnn...@google.com>
Reviewed-by: Caslyn Tonelli <cas...@google.com>
Reviewed-by: Marie Janssen <jam...@google.com>
Reviewed-by: Erick Tryzelaar <etryz...@google.com>
Owners-Override: James Robinson <jam...@google.com>
Commit-Queue: Colin Nelson <colnn...@google.com>
Owners-Override: Adam Barth <aba...@google.com>
Reviewed-by: James Robinson <jam...@google.com>
Files:
  • M src/connectivity/bluetooth/core/bt-gap/src/host_dispatcher.rs
  • M src/connectivity/bluetooth/lib/fuchsia-bluetooth/src/expectation.rs
  • M src/connectivity/bluetooth/profiles/bt-a2dp/src/main.rs
  • M src/connectivity/bluetooth/profiles/bt-hfp-audio-gateway/src/inspect.rs
  • M src/connectivity/bluetooth/profiles/bt-hfp-audio-gateway/src/peer/task.rs
  • M src/connectivity/bluetooth/tools/bt-cli/src/main.rs
  • M src/connectivity/network/netlink/src/routes.rs
  • M src/developer/ffx/config/src/mapping/home.rs
  • M src/developer/ffx/config/src/mapping/mod.rs
  • M src/developer/ffx/plugins/audio/common/src/lib.rs
  • M src/developer/ffx/plugins/audio/device/src/info.rs
  • M src/developer/ffx/plugins/emulator/engines/src/qemu_based/mod.rs
  • M src/developer/ffx/tools/bluetooth/src/peer/src/lib.rs
  • M src/devices/lib/bind/src/debugger/debug_dump.rs
  • M src/lib/analytics/rust/src/ga4_metrics_service.rs
  • M src/lib/fuchsia-lockfile/src/lib.rs
  • M src/power/metrics-logger/src/gpu_usage_logger.rs
  • M src/power/metrics-logger/src/sensor_logger.rs
  • M src/sys/lib/component_debug/src/cli/list.rs
Change size: M
Delta: 19 files changed, 59 insertions(+), 43 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +2 by Marie Janssen, +2 by James Robinson, +2 by Caslyn Tonelli, +2 by Erick Tryzelaar
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: Ic01eb29f885338519ad4bd2ec61ffd1d6a6a636c
Gerrit-Change-Number: 1333637
Gerrit-PatchSet: 3
Gerrit-Owner: Colin Nelson <colnn...@google.com>
Gerrit-Reviewer: Adam Barth <aba...@google.com>
Gerrit-Reviewer: Caslyn Tonelli <cas...@google.com>
Gerrit-Reviewer: Colin Nelson <colnn...@google.com>
Gerrit-Reviewer: Erick Tryzelaar <etryz...@google.com>
Gerrit-Reviewer: James Robinson <jam...@google.com>
Gerrit-Reviewer: Marie Janssen <jam...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/6f7bc1b86fe4eb95a59d288378a687a14ddc07a6-HTML%40fuchsia-review.googlesource.com.
open
diffy
satisfied_requirement

'GI Roller (Gerrit)' via owners-override

unread,
Jul 30, 2025, 1:46:15 PMJul 30
to Colin Nelson, CQ Bot, Adam Barth, James Robinson, Owners Override, Erick Tryzelaar, Caslyn Tonelli, Marie Janssen, GI Try Builder

Message from GI Roller

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: Ic01eb29f885338519ad4bd2ec61ffd1d6a6a636c
Gerrit-Change-Number: 1333637
Gerrit-PatchSet: 3
Gerrit-Owner: Colin Nelson <colnn...@google.com>
Gerrit-Reviewer: Adam Barth <aba...@google.com>
Gerrit-Reviewer: Caslyn Tonelli <cas...@google.com>
Gerrit-Reviewer: Colin Nelson <colnn...@google.com>
Gerrit-Reviewer: Erick Tryzelaar <etryz...@google.com>
Gerrit-Reviewer: James Robinson <jam...@google.com>
Gerrit-Reviewer: Marie Janssen <jam...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Comment-Date: Wed, 30 Jul 2025 17:46:12 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/bf20c0922353c30a9a9f1a0a970e0d35ef420f0e-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages