[XL] Change in fuchsia/fuchsia[main]: [cpp][cleanup] Remove redundant C++14 compatibility

2 views

Skip to first unread message

'Ian McKellar (Gerrit)' via owners-override

unread,

May 16, 2025, 8:16:27 PM5/16/25

to Owners Override

Attention needed from John Wittrock and Owners Override

Ian McKellar has uploaded the change for review

Ian McKellar would like Owners Override to review this change.

Commit message

[cpp][cleanup] Remove redundant C++14 compatibility

We dropped support for C++14 about 3 years ago. This cleans up some
lingering, unused C++14 compatibility abstractions such as:
 - `#if __cplusplus >= 201703L` guards around C++17 language / library
   feature use.
 - `cpp17::` from stdcompat that will just pass through to the standard
   implementation, but which add confusion and indirection.
 - partial implementations of C++17 features across various libraries.

Since we haven't built with C++14 in at least 3 years the only impact
should be that our code is a little cleaner and our build graph is a
little sparser.

Change-Id: I0d3da411d0082a5f77dbb11414326199fee44ebc

Change diff

Change information

Files:

M docs/development/drivers/tutorials/fidl-tutorial.md
M docs/reference/fidl/bindings/cpp-bindings.md
M examples/fidl/cpp/services/server/BUILD.gn
M manifests/third_party/gfxstream
M manifests/third_party/goldfish-opengl
M sdk/ctf/build/scripts/testdata/fidl.h
M sdk/ctf/tests/pkg/fidl/cpp/BUILD.gn
M sdk/ctf/tests/pkg/fidl/cpp/bits_unittest.cc
M sdk/ctf/tests/pkg/fidl/cpp/string_unittest.cc
M sdk/lib/async-loop-testing/cpp/BUILD.gn
M sdk/lib/async-loop-testing/cpp/async-loop-testing.api
M sdk/lib/async-loop-testing/cpp/include/lib/async-loop/testing/cpp/real_loop.h
M sdk/lib/async/BUILD.gn
M sdk/lib/async/async-cpp.api
M sdk/lib/async/include/lib/async/cpp/sequence_checker.h
M sdk/lib/async/sequence_checker.cc
M sdk/lib/async/test/sequence_checker_tests.cc
M sdk/lib/async_patterns/cpp/tests/BUILD.gn
M sdk/lib/component/outgoing/cpp/BUILD.gn
M sdk/lib/component/outgoing/cpp/component_outgoing_cpp.api
M sdk/lib/component/outgoing/cpp/outgoing_directory.cc
M sdk/lib/component/outgoing/cpp/outgoing_directory.h
M sdk/lib/diagnostics/reader/cpp/inspect.h
M sdk/lib/driver/logging/cpp/driver_logging_cpp.api
M sdk/lib/driver/logging/cpp/internal/logger_internal.h
M sdk/lib/driver/logging/cpp/logger.cc
M sdk/lib/driver/logging/cpp/logger.h
M sdk/lib/driver/outgoing/cpp/driver_outgoing_cpp.api
M sdk/lib/driver/outgoing/cpp/outgoing_directory.h
M sdk/lib/driver/platform-device/cpp/pdev.cc
M sdk/lib/driver/platform-device/cpp/pdev.h
M sdk/lib/driver/platform-device/cpp/tests/pdev-test.cc
M sdk/lib/driver/runtime/driver_runtime_cpp.api
M sdk/lib/driver/runtime/driver_runtime_env_cpp.api
M sdk/lib/driver/runtime/include/lib/fdf/cpp/dispatcher.h
M sdk/lib/driver/runtime/include/lib/fdf/cpp/env.h
M sdk/lib/driver/runtime/testing/cpp/driver_runtime_testing_cpp.api
M sdk/lib/driver/runtime/testing/cpp/internal/test_dispatcher_builder.h
M sdk/lib/driver/testing/cpp/driver_runtime.h
M sdk/lib/driver/testing/cpp/driver_testing_cpp.api
M sdk/lib/fdio/tests/BUILD.gn
M sdk/lib/fidl/cpp/fidl_cpp_base_v2.api
M sdk/lib/fidl/cpp/fidl_cpp_v2.api
M sdk/lib/fidl/cpp/include/lib/fidl/cpp/any_error_in.h
M sdk/lib/fidl/cpp/include/lib/fidl/cpp/client.h
M sdk/lib/fidl/cpp/include/lib/fidl/cpp/natural_coding_traits.h
M sdk/lib/fidl/cpp/include/lib/fidl/cpp/natural_types.h
M sdk/lib/fidl/cpp/tests/dispatcher/BUILD.gn
M sdk/lib/fidl/cpp/tests/dispatcher/request_response_wrapper_test.cc
M sdk/lib/fidl/cpp/tests/natural_types/bits_test.cc
M sdk/lib/fidl/cpp/wire/fidl_cpp_wire.api
M sdk/lib/fidl/cpp/wire/include/lib/fidl/cpp/wire/traits.h
M sdk/lib/fidl/cpp/wire/include/lib/fidl/cpp/wire/wire_types.h
M sdk/lib/fidl/hlcpp/BUILD.gn
M sdk/lib/fidl/hlcpp/fidl_cpp.api
M sdk/lib/fidl/hlcpp/fidl_cpp_base.api
M sdk/lib/fidl/hlcpp/include/lib/fidl/cpp/coding_traits.h
M sdk/lib/fidl/hlcpp/include/lib/fidl/cpp/interface_handle.h
M sdk/lib/fidl/hlcpp/include/lib/fidl/cpp/interface_request.h
M sdk/lib/fidl/hlcpp/include/lib/fidl/cpp/internal/header.h
M sdk/lib/fidl/hlcpp/include/lib/fidl/cpp/internal/natural_types_header.h
M sdk/lib/fidl/hlcpp/include/lib/fidl/cpp/string.h
M sdk/lib/fidl/hlcpp/include/lib/fidl/cpp/unknown_interactions_hlcpp.h
M sdk/lib/fidl/hlcpp/include/lib/fidl/cpp/vector.h
M sdk/lib/fidl_base/BUILD.gn
M sdk/lib/fidl_base/decoding_and_validating.cc
M sdk/lib/fidl_base/fidl_base.api
M sdk/lib/fidl_base/include/lib/fidl/internal.h
M sdk/lib/fidl_driver/fidl_driver_natural.api
M sdk/lib/fidl_driver/fidl_driver_transport.api
M sdk/lib/fidl_driver/include/lib/fidl_driver/cpp/natural_client.h
M sdk/lib/fidl_driver/include/lib/fidl_driver/cpp/transport.h
M sdk/lib/fidl_driver/tests/conversion/BUILD.gn
M sdk/lib/fit-promise/BUILD.gn
M sdk/lib/fit-promise/fit-promise.api
M sdk/lib/fit-promise/include/lib/fpromise/promise.h
M sdk/lib/fit-promise/include/lib/fpromise/promise_internal.h
M sdk/lib/fit-promise/include/lib/fpromise/result.h
M sdk/lib/fit/fit.api
M sdk/lib/fit/include/lib/fit/function.h
M sdk/lib/fit/include/lib/fit/inline_any.h
M sdk/lib/fit/include/lib/fit/internal/inline_any.h
M sdk/lib/fit/include/lib/fit/internal/result.h
M sdk/lib/fit/include/lib/fit/internal/utility.h
M sdk/lib/fit/include/lib/fit/nullable.h
M sdk/lib/fit/include/lib/fit/result.h
M sdk/lib/fit/include/lib/fit/traits.h
M sdk/lib/fit/test/inline_any_tests.cc
M sdk/lib/fit/test/traits_tests.cc
M sdk/lib/fuchsia-mem-ext/fuchsia-mem-ext.cc
M sdk/lib/fuchsia-mem-ext/include/lib/fuchsia-mem-ext/fuchsia-mem-ext.h
M sdk/lib/inspect/component/cpp/inspect_component_cpp.api
M sdk/lib/inspect/component/cpp/service.h
M sdk/lib/inspect/component/cpp/tree_handler_settings.h
M sdk/lib/inspect/contrib/cpp/BUILD.gn
M sdk/lib/inspect/contrib/cpp/read_visitor.h
M sdk/lib/inspect/contrib/cpp/read_visitor_unittest.cc
M sdk/lib/inspect/inspect.api
M sdk/lib/sys/component/cpp/testing/internal/convert.cc
M sdk/lib/sys/component/cpp/testing/internal/convert.h
M sdk/lib/sys/component/cpp/testing/internal/local_component_runner.cc
M sdk/lib/sys/component/cpp/testing/internal/local_component_runner.h
M sdk/lib/sys/component/cpp/testing/realm_builder.cc
M sdk/lib/sys/component/cpp/testing/realm_builder.h
M sdk/lib/sys/component/cpp/testing/realm_builder_types.h
M sdk/lib/sys/component/cpp/testing/sys_component_cpp_testing.api
M sdk/lib/sys/component/cpp/tests/utils.cc
M sdk/lib/sys/component/cpp/tests/utils.h
M sdk/lib/syslog/cpp/BUILD.gn
M sdk/lib/syslog/cpp/host/encoder.h
M sdk/lib/syslog/cpp/host/logging_backend.cc
M sdk/lib/syslog/cpp/log_message_impl.h
M sdk/lib/syslog/cpp/log_structure_unittest.cc
M sdk/lib/syslog/cpp/logging_backend_fuchsia.cc
M sdk/lib/syslog/cpp/syslog_cpp.api
M sdk/lib/syslog/structured_backend/BUILD.gn
M sdk/lib/syslog/structured_backend/cpp/fuchsia_syslog.cc
M sdk/lib/syslog/structured_backend/cpp/fuchsia_syslog.h
M sdk/lib/syslog/structured_backend/syslog_structured_backend.api
M sdk/lib/ui/scenic/cpp/BUILD.gn
M sdk/lib/zx/zx.api
M src/bringup/bin/netsvc/netifc-discover.cc
M src/bringup/bin/netsvc/netifc-discover.h
M src/bringup/bin/netsvc/netifc.cc
M src/bringup/bin/netsvc/netifc.h
M src/camera/bin/device/device_impl_client.cc
M src/connectivity/network/testing/netemul/network-context/lib/fake_endpoint.h
M src/connectivity/network/testing/netemul/sync-manager/lib/bus.cc
M src/connectivity/openthread/third_party/openthread/platform/bootstrap_fidl_impl.cc
M src/connectivity/openthread/third_party/openthread/platform/bootstrap_fidl_impl.h
M src/developer/debug/e2e_tests/ffx_debug_agent_bridge.cc
M src/developer/debug/zxdb/client/system.cc
M src/developer/debug/zxdb/expr/pretty_type_manager.cc
M src/developer/forensics/crash_reports/log_tags.h
M src/developer/forensics/crash_reports/snapshot_persistence_metadata.h
M src/developer/forensics/feedback_data/system_log_recorder/reader.cc
M src/devices/bin/driver_loader/BUILD.gn
M src/devices/bin/driver_loader/diagnostics.h
M src/devices/bin/driver_runtime/microbenchmarks/one_way.cc
M src/devices/bin/driver_runtime/microbenchmarks/round_trips.cc
M src/devices/board/lib/acpi/fidl.cc
M src/devices/lib/log/log.cc
M src/devices/lib/log/log.h
M src/diagnostics/lib/cpp-log-tester/BUILD.gn
M src/diagnostics/validator/inspect/lib/cpp/BUILD.gn
M src/diagnostics/validator/inspect/lib/cpp/validator_puppet.cc
M src/diagnostics/validator/logs/sink/puppet/sdk/puppet.cc
M src/firmware/gigaboot/cpp/BUILD.gn
M src/firmware/gigaboot/cpp/tests/BUILD.gn
M src/graphics/display/lib/driver-framework-migration-utils/dispatcher/BUILD.gn
M src/graphics/magma/lib/magma_service/sys_driver/primary_fidl_server.cc
M src/graphics/magma/lib/magma_service/sys_driver/primary_fidl_server.h
M src/lib/diagnostics/accessor2logger/tests/BUILD.gn
M src/lib/diagnostics/accessor2logger/tests/log_message_unittest.cc
M src/lib/fidl/contrib/tests/fpromise/BUILD.gn
M src/lib/fidl_codec/wire_parser_test.cc
M src/lib/intl/lookup/cpp/lookup.h
M src/lib/testing/loop_fixture/BUILD.gn
M src/lib/vmo_store/growable_slab.h
M src/lib/vmo_store/map_pin_test.cc
M src/lib/vmo_store/storage_types.h
M src/lib/vmo_store/typed_store_test.cc
M src/lib/vmo_store/vmo_store.h
M src/media/audio/audio_core/verbose_log.h
M src/media/codec/codecs/vaapi/third_party/chromium/BUILD.gn
M src/media/drivers/amlogic_decoder/h264_multi_decoder.cc
M src/media/lib/codec_impl/BUILD.gn
M src/media/lib/codec_impl/codec_impl.cc
M src/media/lib/codec_impl/fake_map_range.cc
M src/media/lib/codec_impl/include/lib/media/codec_impl/codec_impl.h
M src/media/lib/codec_impl/include/lib/media/codec_impl/fake_map_range.h
M src/media/lib/codec_impl/unit_tests/BUILD.gn
M src/media/lib/codec_impl/unit_tests/test_fake_map_range.cc
M src/media/third_party/chromium_media/media/gpu/h264_decoder.cc
M src/media/third_party/chromium_media/media/video/h264_parser.h
M src/performance/lib/fxt/include/lib/fxt/argument.h
M src/performance/lib/fxt/include/lib/fxt/string_ref.h
M src/performance/lib/fxt/include/lib/fxt/thread_ref.h
M src/performance/lib/trace_converters/BUILD.gn
M src/performance/lib/trace_converters/chromium_exporter.cc
M src/storage/volume_image/utils/block_writer.h
M src/sysmem/server/snapshot_annotation_register.cc
M src/tests/fidl/compatibility/cpp/BUILD.gn
M src/tests/fidl/compatibility/cpp/main.cc
M src/ui/a11y/lib/gesture_manager/tests/mocks/mock_gesture_listener.h
M src/ui/scenic/lib/scenic/util/error_reporter.cc
M src/ui/scenic/lib/shutdown/shutdown_manager.h
M src/virtualization/bin/vmm/device/phys_mem.h
M third_party/pigweed/backends/pw_log/log_sink.cc
M tools/fidl/fidlgen_hlcpp/codegen/types_bits.tmpl
M tools/fidl/fidlgen_hlcpp/codegen/types_enum.tmpl
M tools/fidl/fidlgen_hlcpp/codegen/types_struct.tmpl
M tools/fidl/fidlgen_hlcpp/codegen/types_table.tmpl
M tools/fidl/fidlgen_hlcpp/codegen/types_union.tmpl
M tools/fidl/fidlgen_hlcpp/goldens/aliases.cc.golden
M tools/fidl/fidlgen_hlcpp/goldens/aliases.h.golden
M tools/fidl/fidlgen_hlcpp/goldens/anonymous.cc.golden
M tools/fidl/fidlgen_hlcpp/goldens/anonymous.h.golden
M tools/fidl/fidlgen_hlcpp/goldens/arrays.cc.golden
M tools/fidl/fidlgen_hlcpp/goldens/arrays.h.golden
M tools/fidl/fidlgen_hlcpp/goldens/bindings_denylist.cc.golden
M tools/fidl/fidlgen_hlcpp/goldens/bindings_denylist.h.golden
M tools/fidl/fidlgen_hlcpp/goldens/bits.h.golden
M tools/fidl/fidlgen_hlcpp/goldens/bits_constants.h.golden
M tools/fidl/fidlgen_hlcpp/goldens/byte_and_bytes.cc.golden
M tools/fidl/fidlgen_hlcpp/goldens/byte_and_bytes.h.golden
M tools/fidl/fidlgen_hlcpp/goldens/consts.h.golden
M tools/fidl/fidlgen_hlcpp/goldens/doc_comments.cc.golden
M tools/fidl/fidlgen_hlcpp/goldens/doc_comments.h.golden
M tools/fidl/fidlgen_hlcpp/goldens/driver_one_way.cc.golden
M tools/fidl/fidlgen_hlcpp/goldens/driver_one_way.h.golden
M tools/fidl/fidlgen_hlcpp/goldens/driver_two_way.cc.golden
M tools/fidl/fidlgen_hlcpp/goldens/driver_two_way.h.golden
M tools/fidl/fidlgen_hlcpp/goldens/empty_struct.cc.golden
M tools/fidl/fidlgen_hlcpp/goldens/empty_struct.h.golden
M tools/fidl/fidlgen_hlcpp/goldens/encapsulated_structs.cc.golden
M tools/fidl/fidlgen_hlcpp/goldens/encapsulated_structs.h.golden
M tools/fidl/fidlgen_hlcpp/goldens/enum.h.golden
M tools/fidl/fidlgen_hlcpp/goldens/error.cc.golden
M tools/fidl/fidlgen_hlcpp/goldens/error.h.golden
M tools/fidl/fidlgen_hlcpp/goldens/error_syntax.cc.golden
M tools/fidl/fidlgen_hlcpp/goldens/error_syntax.h.golden
M tools/fidl/fidlgen_hlcpp/goldens/escaping.cc.golden
M tools/fidl/fidlgen_hlcpp/goldens/escaping.h.golden
M tools/fidl/fidlgen_hlcpp/goldens/handles.cc.golden
M tools/fidl/fidlgen_hlcpp/goldens/handles.h.golden
M tools/fidl/fidlgen_hlcpp/goldens/handles_in_types.cc.golden
M tools/fidl/fidlgen_hlcpp/goldens/handles_in_types.h.golden
M tools/fidl/fidlgen_hlcpp/goldens/imported_const_values.cc.golden
M tools/fidl/fidlgen_hlcpp/goldens/imported_const_values.h.golden
M tools/fidl/fidlgen_hlcpp/goldens/inheritance.cc.golden
M tools/fidl/fidlgen_hlcpp/goldens/inheritance.h.golden
M tools/fidl/fidlgen_hlcpp/goldens/inheritance_with_recursive_decl.cc.golden
M tools/fidl/fidlgen_hlcpp/goldens/inheritance_with_recursive_decl.h.golden
M tools/fidl/fidlgen_hlcpp/goldens/nullable.cc.golden
M tools/fidl/fidlgen_hlcpp/goldens/nullable.h.golden
M tools/fidl/fidlgen_hlcpp/goldens/padding.cc.golden
M tools/fidl/fidlgen_hlcpp/goldens/padding.h.golden
M tools/fidl/fidlgen_hlcpp/goldens/placement_of_attributes.cc.golden
M tools/fidl/fidlgen_hlcpp/goldens/placement_of_attributes.h.golden
M tools/fidl/fidlgen_hlcpp/goldens/protocol_layouts.cc.golden
M tools/fidl/fidlgen_hlcpp/goldens/protocol_layouts.h.golden
M tools/fidl/fidlgen_hlcpp/goldens/protocol_layouts_same_library.cc.golden
M tools/fidl/fidlgen_hlcpp/goldens/protocol_layouts_same_library.h.golden
M tools/fidl/fidlgen_hlcpp/goldens/protocol_payloads.cc.golden
M tools/fidl/fidlgen_hlcpp/goldens/protocol_payloads.h.golden
M tools/fidl/fidlgen_hlcpp/goldens/protocol_request.cc.golden
M tools/fidl/fidlgen_hlcpp/goldens/protocol_request.h.golden
M tools/fidl/fidlgen_hlcpp/goldens/protocols.cc.golden
M tools/fidl/fidlgen_hlcpp/goldens/protocols.h.golden
M tools/fidl/fidlgen_hlcpp/goldens/request_flexible_envelope.cc.golden
M tools/fidl/fidlgen_hlcpp/goldens/request_flexible_envelope.h.golden
M tools/fidl/fidlgen_hlcpp/goldens/serializable.cc.golden
M tools/fidl/fidlgen_hlcpp/goldens/serializable.h.golden
M tools/fidl/fidlgen_hlcpp/goldens/struct.cc.golden
M tools/fidl/fidlgen_hlcpp/goldens/struct.h.golden
M tools/fidl/fidlgen_hlcpp/goldens/struct_default_value_enum_library_reference.cc.golden
M tools/fidl/fidlgen_hlcpp/goldens/struct_default_value_enum_library_reference.h.golden
M tools/fidl/fidlgen_hlcpp/goldens/table.cc.golden
M tools/fidl/fidlgen_hlcpp/goldens/table.h.golden
M tools/fidl/fidlgen_hlcpp/goldens/time.cc.golden
M tools/fidl/fidlgen_hlcpp/goldens/time.h.golden
M tools/fidl/fidlgen_hlcpp/goldens/transitive_dependencies.cc.golden
M tools/fidl/fidlgen_hlcpp/goldens/transitive_dependencies.h.golden
M tools/fidl/fidlgen_hlcpp/goldens/types_in_protocols.cc.golden
M tools/fidl/fidlgen_hlcpp/goldens/types_in_protocols.h.golden
M tools/fidl/fidlgen_hlcpp/goldens/union.cc.golden
M tools/fidl/fidlgen_hlcpp/goldens/union.h.golden
M tools/fidl/fidlgen_hlcpp/goldens/union_sandwich.cc.golden
M tools/fidl/fidlgen_hlcpp/goldens/union_sandwich.h.golden
M tools/fidl/fidlgen_hlcpp/goldens/unknown_interactions.cc.golden
M tools/fidl/fidlgen_hlcpp/goldens/unknown_interactions.h.golden
M tools/fidl/fidlgen_hlcpp/goldens/vectors.cc.golden
M tools/fidl/fidlgen_hlcpp/goldens/vectors.h.golden
M tools/fidl/fidlgen_hlcpp/goldens/versions.cc.golden
M tools/fidl/fidlgen_hlcpp/goldens/versions.h.golden
M zircon/kernel/phys/test/debugdata-propagation/debugdata-test.cc
M zircon/public/sysroot_sdk/sysroot.api
M zircon/system/public/zircon/compiler.h
M zircon/system/ulib/inspect/include/lib/inspect/cpp/health.h
M zircon/system/ulib/inspect/include/lib/inspect/cpp/hierarchy.h
M zircon/system/ulib/inspect/include/lib/inspect/cpp/inspector.h
M zircon/system/ulib/inspect/include/lib/inspect/cpp/vmo/block.h
M zircon/system/ulib/inspect/include/lib/inspect/cpp/vmo/heap.h
M zircon/system/ulib/inspect/include/lib/inspect/cpp/vmo/snapshot.h
M zircon/system/ulib/inspect/include/lib/inspect/cpp/vmo/state.h
M zircon/system/ulib/inspect/include/lib/inspect/cpp/vmo/types.h
M zircon/system/ulib/inspect/inspector.cc
M zircon/system/ulib/inspect/reader.cc
M zircon/system/ulib/inspect/tests/inspect_unittest.cc
M zircon/system/ulib/inspect/tests/state_unittest.cc
M zircon/system/ulib/inspect/vmo/snapshot.cc
M zircon/system/ulib/inspect/vmo/state.cc
M zircon/system/ulib/inspect/vmo/types.cc
M zircon/system/ulib/syslog/fx_logger.cc
M zircon/system/ulib/trace-reader/BUILD.gn
M zircon/system/ulib/trace-reader/include/trace-reader/records.h
M zircon/system/ulib/trace-reader/records.cc
M zircon/system/ulib/trace-reader/test/records_tests.cc
M zircon/system/ulib/zx/include/lib/zx/time.h
M zircon/system/ulib/zx/test/zx-test.cc
M zircon/system/ulib/zxtest/BUILD.gn
M zircon/system/ulib/zxtest/include/zxtest/base/parameterized-value-impl.h
M zircon/system/ulib/zxtest/include/zxtest/base/parameterized-value.h
M zircon/system/ulib/zxtest/include/zxtest/base/runner.h
M zircon/system/ulib/zxtest/runner.cc
M zircon/system/utest/core/futex/BUILD.gn
M zircon/system/utest/core/futex/futex.cc

Change size: XL

Delta: 308 files changed, 1858 insertions(+), 1991 deletions(-)

Open in Gerrit

Related details

Attention is currently required from:

John Wittrock
Owners Override

Submit Requirements:

API-Review
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/5363a692c9f1f1b3c6b900ec064fb60577ac193f-HTML%40fuchsia-review.googlesource.com.

satisfied_requirement

open

diffy

'Ian McKellar (Gerrit)' via owners-override

unread,

May 16, 2025, 8:16:31 PM5/16/25

to Owners Override, Adam Barth, John Wittrock, GI Try Builder, CQ Bot

Attention needed from John Wittrock and Owners Override

Ian McKellar voted and added 2 comments

Votes added by Ian McKellar

Fuchsia-Auto-Submit

2 comments

Patchset-level comments

File-level comment, Patchset 8:

John Wittrock . resolved

LGTM for the files I have OWNERS FOR, modulo the question about whether you meant to update third_party.

Ian McKellar

Acknowledged

File manifests/third_party/gfxstream

Line 7, Patchset 8: revision="5cf6229af5de3214d25542a64566bb452d710a72"/>

John Wittrock . resolved

Is this change deliberate?

Ian McKellar

Yep - now we can roll dependencies as part of a CL. I don't think we have rollers on these so I'm updating these to point to the CLs that update our use of these APIs in those deps.

Open in Gerrit

Related details

Attention is currently required from:

John Wittrock
Owners Override

Submit Requirements:

API-Review
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/5363a692c9f1f1b3c6b900ec064fb60577ac193f-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

satisfied_requirement

open

diffy

'James Robinson (Gerrit)' via owners-override

unread,

May 19, 2025, 11:19:57 AM5/19/25

to Ian McKellar, Owners Override, Adam Barth, John Wittrock, GI Try Builder, CQ Bot

Attention needed from Ian McKellar, John Wittrock and Owners Override

James Robinson voted Owners-Override+1

Owners-Override

Open in Gerrit

Related details

Attention is currently required from:

Ian McKellar
John Wittrock
Owners Override

Submit Requirements:

API-Review
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/83c57abecc8d035208d6fbf4a7b3184adf6ce64d-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

satisfied_requirement

open

diffy

'CQ Bot (Gerrit)' via owners-override

unread,

May 19, 2025, 12:37:01 PM5/19/25

to Ian McKellar, Auto-Submit, James Robinson, Owners Override, Adam Barth, John Wittrock, GI Try Builder

CQ Bot submitted the change with unreviewed changes

Unreviewed changes

9 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: manifests/third_party/gfxstream
Insertions: 1, Deletions: 1.

@@ -4,7 +4,7 @@
     <project name="third_party/android/platform/hardware/google/gfxstream"
              path="third_party/gfxstream/src"
              remote="https://fuchsia.googlesource.com/third_party/android.googlesource.com/platform/hardware/google/gfxstream"
-             revision="5cf6229af5de3214d25542a64566bb452d710a72"/>
+             revision="30f306a629ff067bf3af18d46b8b73836b4d9980"/>
     <project name="third_party/android/platform/hardware/google/aemu"
              path="third_party/gfxstream/aemu/src"
              remote="https://fuchsia.googlesource.com/third_party/android.googlesource.com/platform/hardware/google/aemu"
```

Change information

Commit message:

[cpp][cleanup] Remove redundant C++14 compatibility

We dropped support for C++14 about 3 years ago. This cleans up some
lingering, unused C++14 compatibility abstractions such as:
 - `#if __cplusplus >= 201703L` guards around C++17 language / library
   feature use.
 - `cpp17::` from stdcompat that will just pass through to the standard
   implementation, but which add confusion and indirection.
 - partial implementations of C++17 features across various libraries.

Since we haven't built with C++14 in at least 3 years the only impact
should be that our code is a little cleaner and our build graph is a
little sparser.

Change-Id: I0d3da411d0082a5f77dbb11414326199fee44ebc

Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1278668

Reviewed-by: Adam Barth <aba...@google.com>

Fuchsia-Auto-Submit: Ian McKellar <ian...@google.com>

Owners-Override: James Robinson <jam...@google.com>

Commit-Queue: Auto-Submit <auto-subm...@fuchsia-internal-service-accts.iam.gserviceaccount.com>

API-Review: Adam Barth <aba...@google.com>

Branch: refs/heads/main

Submit Requirements: