[M] Change in fuchsia/fuchsia[main]: [rust] Use array_windows instead of windows

0 views
Skip to first unread message

'Sen Jiang (Gerrit)' via owners-override

unread,
Apr 9, 2026, 6:46:42 PM (3 days ago) Apr 9
to Owners Override
Attention needed from Owners Override

Sen Jiang has uploaded the change for review

Sen Jiang would like Owners Override to review this change.

Commit message

[rust] Use array_windows instead of windows

[array_windows] is the const generic version of [windows], and has the
same semantics, where the size of `windows()`, or the array size of
`array_windows()` is larger than the slice size, then both functions
return an iterator with no values.

[windows]: https://doc.rust-lang.org/stable/std/primitive.slice.html#method.windows
[array_windows]: https://doc.rust-lang.org/stable/std/primitive.slice.html#method.array_windows
Change-Id: Iecc89e7c186a46cdbdb19df956cc5667a53d6cfa

Change diff


Change information

Files:
  • M src/connectivity/network/dns/src/main.rs
  • M src/developer/ffx/plugins/profile/memory/src/digest.rs
  • M src/developer/ffx/tools/playground/src/presentation.rs
  • M src/graphics/lib/compute/rive-rs/src/math/bezier.rs
  • M src/graphics/lib/compute/surpass/src/path.rs
  • M src/lib/fdomain/container/src/lib.rs
  • M src/lib/ui/carnelian/src/view/strategies/flatland.rs
  • M src/power/cpu-manager/src/cpu_control_handler.rs
  • M src/power/cpu-manager/src/cpu_device_handler.rs
  • M src/storage/fxfs/platform/src/fuchsia/fxblob/blob.rs
  • M src/storage/fxfs/src/object_store/extent_mapping_iterator.rs
  • M src/storage/gpt/rust/src/format.rs
  • M src/storage/gpt/rust/src/lib.rs
  • M src/storage/lib/sparse/rust/src/lib.rs
  • M src/ui/lib/input_pipeline/src/gestures/motion.rs
  • M src/ui/lib/input_pipeline/src/gestures/scroll.rs
Change size: M
Delta: 16 files changed, 64 insertions(+), 90 deletions(-)
Open in Gerrit

Related details

Attention is currently required from:
  • Owners Override
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: Iecc89e7c186a46cdbdb19df956cc5667a53d6cfa
Gerrit-Change-Number: 1567974
Gerrit-PatchSet: 2
Gerrit-Owner: Sen Jiang <se...@google.com>
Gerrit-Reviewer: Erick Tryzelaar <etryz...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Reviewer: Sen Jiang <se...@google.com>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/aabea1d106e2c0af203a1dce70d543f2c9ffaff8-HTML%40fuchsia-review.googlesource.com.
unsatisfied_requirement
satisfied_requirement
open
diffy

'James Robinson (Gerrit)' via owners-override

unread,
Apr 9, 2026, 6:49:38 PM (3 days ago) Apr 9
to Sen Jiang, Owners Override, Erick Tryzelaar, GI Try Builder, CQ Bot
Attention needed from Owners Override and Sen Jiang

James Robinson voted Owners-Override+1

Owners-Override+1
Open in Gerrit

Related details

Attention is currently required from:
  • Owners Override
  • Sen Jiang
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: Iecc89e7c186a46cdbdb19df956cc5667a53d6cfa
Gerrit-Change-Number: 1567974
Gerrit-PatchSet: 2
Gerrit-Owner: Sen Jiang <se...@google.com>
Gerrit-Reviewer: Erick Tryzelaar <etryz...@google.com>
Gerrit-Reviewer: James Robinson <jam...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Reviewer: Sen Jiang <se...@google.com>
Gerrit-Attention: Sen Jiang <se...@google.com>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Comment-Date: Thu, 09 Apr 2026 22:49:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/07a932351855da01905df25193d6729c9f9551a5-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy

'Sen Jiang (Gerrit)' via owners-override

unread,
Apr 10, 2026, 1:34:01 PM (2 days ago) Apr 10
to James Robinson, Owners Override, Erick Tryzelaar, GI Try Builder, CQ Bot
Attention needed from Owners Override

Sen Jiang voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Owners Override
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: Iecc89e7c186a46cdbdb19df956cc5667a53d6cfa
Gerrit-Change-Number: 1567974
Gerrit-PatchSet: 2
Gerrit-Owner: Sen Jiang <se...@google.com>
Gerrit-Reviewer: Erick Tryzelaar <etryz...@google.com>
Gerrit-Reviewer: James Robinson <jam...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Reviewer: Sen Jiang <se...@google.com>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Comment-Date: Fri, 10 Apr 2026 17:33:53 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/6a75fe27d10017118075a73cf6938d327aa89b93-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy

'CQ Bot (Gerrit)' via owners-override

unread,
Apr 10, 2026, 2:46:47 PM (2 days ago) Apr 10
to Sen Jiang, James Robinson, Owners Override, Erick Tryzelaar, GI Try Builder

CQ Bot submitted the change

Unreviewed changes

1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:
[rust] Use array_windows instead of windows

[array_windows] is the const generic version of [windows], and has the
same semantics, where the size of `windows()`, or the array size of
`array_windows()` is larger than the slice size, then both functions
return an iterator with no values.

[windows]: https://doc.rust-lang.org/stable/std/primitive.slice.html#method.windows
[array_windows]: https://doc.rust-lang.org/stable/std/primitive.slice.html#method.array_windows
Change-Id: Iecc89e7c186a46cdbdb19df956cc5667a53d6cfa
Reviewed-by: Erick Tryzelaar <etryz...@google.com>
Owners-Override: James Robinson <jam...@google.com>
Commit-Queue: Sen Jiang <se...@google.com>
Files:
  • M src/connectivity/network/dns/src/main.rs
  • M src/developer/ffx/plugins/profile/memory/src/digest.rs
  • M src/developer/ffx/tools/playground/src/presentation.rs
  • M src/graphics/lib/compute/rive-rs/src/math/bezier.rs
  • M src/graphics/lib/compute/surpass/src/path.rs
  • M src/lib/fdomain/container/src/lib.rs
  • M src/lib/ui/carnelian/src/view/strategies/flatland.rs
  • M src/power/cpu-manager/src/cpu_control_handler.rs
  • M src/power/cpu-manager/src/cpu_device_handler.rs
  • M src/storage/fxfs/platform/src/fuchsia/fxblob/blob.rs
  • M src/storage/fxfs/src/object_store/extent_mapping_iterator.rs
  • M src/storage/gpt/rust/src/format.rs
  • M src/storage/gpt/rust/src/lib.rs
  • M src/storage/lib/sparse/rust/src/lib.rs
  • M src/ui/lib/input_pipeline/src/gestures/motion.rs
  • M src/ui/lib/input_pipeline/src/gestures/scroll.rs
Change size: M
Delta: 16 files changed, 64 insertions(+), 90 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +2 by Erick Tryzelaar
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: Iecc89e7c186a46cdbdb19df956cc5667a53d6cfa
Gerrit-Change-Number: 1567974
Gerrit-PatchSet: 3
Gerrit-Owner: Sen Jiang <se...@google.com>
Gerrit-Reviewer: Erick Tryzelaar <etryz...@google.com>
Gerrit-Reviewer: James Robinson <jam...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Reviewer: Sen Jiang <se...@google.com>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/f930b6102f2eac58deefc9a1efb1c1d5e71dba7e-HTML%40fuchsia-review.googlesource.com.
open
diffy
satisfied_requirement

'GI Roller (Gerrit)' via owners-override

unread,
Apr 10, 2026, 2:50:00 PM (2 days ago) Apr 10
to Sen Jiang, CQ Bot, James Robinson, Owners Override, Erick Tryzelaar, GI Try Builder

Message from GI Roller

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: Iecc89e7c186a46cdbdb19df956cc5667a53d6cfa
Gerrit-Change-Number: 1567974
Gerrit-PatchSet: 3
Gerrit-Owner: Sen Jiang <se...@google.com>
Gerrit-Reviewer: Erick Tryzelaar <etryz...@google.com>
Gerrit-Reviewer: James Robinson <jam...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Reviewer: Sen Jiang <se...@google.com>
Gerrit-Comment-Date: Fri, 10 Apr 2026 18:49:57 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/63d793c1b18ac6a1f5ea374645363f18d7dd9b71-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages