[L] Change in fuchsia/fuchsia[main]: [rust] Fix new clippy lints

4 views
Skip to first unread message

'Erick Tryzelaar (Gerrit)' via owners-override

unread,
Apr 23, 2024, 9:36:40 AMApr 23
to Owners Override
Attention needed from Joseph Ryan and Owners Override

Joseph Ryan has uploaded the change for review

Erick Tryzelaar would like Owners Override to review this change authored by Joseph Ryan.

Commit message

[rust] Fix new clippy lints

Lots of clippy::legacy-numeric-constants and a couple redundant
attributes
Fixed: b/333545295
Change-Id: I2983df8cb6e97d25848a2c8f91b0e42a09de2ba3

Change diff


Change information

Files:
  • M src/bringup/bin/netsvc/test/integration/src/lib.rs
  • M src/connectivity/bluetooth/lib/fuchsia-bluetooth/src/types/id.rs
  • M src/connectivity/bluetooth/profiles/bt-avrcp-target/src/media/media_sessions.rs
  • M src/connectivity/bluetooth/profiles/bt-avrcp-target/src/media/media_types.rs
  • M src/connectivity/bluetooth/profiles/bt-avrcp-target/src/tests/mod.rs
  • M src/connectivity/network/dhcpv4/lib/src/server.rs
  • M src/connectivity/network/dhcpv6/core/src/client.rs
  • M src/connectivity/wlan/testing/hw-sim/src/test_utils.rs
  • M src/connectivity/wlan/testing/hw-sim/test/multiple_clients_ap/src/lib.rs
  • M src/connectivity/wlan/testing/hw-sim/test/set_country/src/lib.rs
  • M src/connectivity/wlan/wlancfg/src/util/testing/mod.rs
  • M src/diagnostics/archivist/src/diagnostics.rs
  • M src/diagnostics/archivist/src/logs/budget.rs
  • M src/diagnostics/archivist/src/logs/buffer/arc_list.rs
  • M src/diagnostics/archivist/src/testing.rs
  • M src/diagnostics/iquery/src/text_formatter.rs
  • M src/diagnostics/lib/triage/src/metrics/metric_value.rs
  • M src/diagnostics/sampler/src/executor.rs
  • M src/diagnostics/validator/inspect/src/data.rs
  • M src/diagnostics/validator/inspect/src/trials.rs
  • M src/lib/diagnostics/hierarchy/rust/src/serialization/deserialize.rs
  • M src/lib/diagnostics/inspect/rust/src/writer/state.rs
  • M src/lib/diagnostics/selectors/src/parser.rs
  • M src/lib/fuchsia-hyper/src/fuchsia.rs
  • M src/lib/zircon/rust/fuchsia-zircon-types/src/lib.rs
  • M src/performance/lib/fxt/rust/src/session.rs
  • M src/performance/lib/fxt/rust/tests/src/integration_test.rs
  • M src/performance/lib/fxt/rust/tests/src/provider_puppet.rs
  • M src/starnix/kernel/device/magma/file.rs
  • M src/storage/ext4/read-only/src/readers.rs
  • M src/sys/pkg/bin/omaha-client/src/metrics.rs
  • M src/sys/time/timekeeper/src/clock_manager.rs
  • M src/ui/lib/input_pipeline/src/input_device.rs
  • M tools/zedmon/client/src/zedmon.rs
Change size: L
Delta: 34 files changed, 123 insertions(+), 133 deletions(-)
Open in Gerrit

Related details

Attention is currently required from:
  • Joseph Ryan
  • Owners Override
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I2983df8cb6e97d25848a2c8f91b0e42a09de2ba3
Gerrit-Change-Number: 1034098
Gerrit-PatchSet: 3
Gerrit-Owner: Joseph Ryan <jose...@google.com>
Gerrit-Reviewer: Erick Tryzelaar <etryz...@google.com>
Gerrit-Reviewer: Gwen Mittertreiner <gm...@google.com>
Gerrit-Reviewer: Joseph Ryan <jose...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Joseph Ryan <jose...@google.com>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/7953c3e4cdb6612166ba94425eea305526b651f7-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy

'Erick Tryzelaar (Gerrit)' via owners-override

unread,
Apr 23, 2024, 9:36:44 AMApr 23
to Joseph Ryan, Owners Override, Gwen Mittertreiner, CQ Bot
Attention needed from Joseph Ryan and Owners Override

Erick Tryzelaar added 1 comment

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Erick Tryzelaar . resolved

Adding owners-override since this is just cleaning up some minor lints for a rust update.

Open in Gerrit

Related details

Attention is currently required from:
  • Joseph Ryan
  • Owners Override
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I2983df8cb6e97d25848a2c8f91b0e42a09de2ba3
Gerrit-Change-Number: 1034098
Gerrit-PatchSet: 3
Gerrit-Owner: Joseph Ryan <jose...@google.com>
Gerrit-Reviewer: Erick Tryzelaar <etryz...@google.com>
Gerrit-Reviewer: Gwen Mittertreiner <gm...@google.com>
Gerrit-Reviewer: Joseph Ryan <jose...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Joseph Ryan <jose...@google.com>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Comment-Date: Tue, 23 Apr 2024 13:36:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/7953c3e4cdb6612166ba94425eea305526b651f7-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy

'Adam Barth (Gerrit)' via owners-override

unread,
Apr 23, 2024, 11:41:10 AMApr 23
to Joseph Ryan, Owners Override, Erick Tryzelaar, Gwen Mittertreiner, CQ Bot
Attention needed from Joseph Ryan and Owners Override

Adam Barth voted Owners-Override+1

Owners-Override+1
Open in Gerrit

Related details

Attention is currently required from:
  • Joseph Ryan
  • Owners Override
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I2983df8cb6e97d25848a2c8f91b0e42a09de2ba3
Gerrit-Change-Number: 1034098
Gerrit-PatchSet: 3
Gerrit-Owner: Joseph Ryan <jose...@google.com>
Gerrit-Reviewer: Adam Barth <aba...@google.com>
Gerrit-Reviewer: Erick Tryzelaar <etryz...@google.com>
Gerrit-Reviewer: Gwen Mittertreiner <gm...@google.com>
Gerrit-Reviewer: Joseph Ryan <jose...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Joseph Ryan <jose...@google.com>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Comment-Date: Tue, 23 Apr 2024 15:41:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/c3df53d8f2994b28f7c6cc97c433a59a1da1450e-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy

'CQ Bot (Gerrit)' via owners-override

unread,
Apr 23, 2024, 1:39:26 PMApr 23
to Joseph Ryan, Auto-Submit, Adam Barth, Owners Override, Erick Tryzelaar, Gwen Mittertreiner

CQ Bot submitted the change

Change information

Commit message:
[rust] Fix new clippy lints

Lots of clippy::legacy-numeric-constants and a couple redundant
attributes
Fixed: b/333545295
Change-Id: I2983df8cb6e97d25848a2c8f91b0e42a09de2ba3
Reviewed-by: Gwen Mittertreiner <gm...@google.com>
Fuchsia-Auto-Submit: Joseph Ryan <jose...@google.com>
Reviewed-by: Erick Tryzelaar <etryz...@google.com>
Owners-Override: Adam Barth <aba...@google.com>
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +2 by Gwen Mittertreiner, +2 by Erick Tryzelaar
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I2983df8cb6e97d25848a2c8f91b0e42a09de2ba3
Gerrit-Change-Number: 1034098
Gerrit-PatchSet: 4
Gerrit-Owner: Joseph Ryan <jose...@google.com>
Gerrit-Reviewer: Adam Barth <aba...@google.com>
Gerrit-Reviewer: Erick Tryzelaar <etryz...@google.com>
Gerrit-Reviewer: Gwen Mittertreiner <gm...@google.com>
Gerrit-Reviewer: Joseph Ryan <jose...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/0359be995eb2af919a47bbc63c3eb74e29a1b64b-HTML%40fuchsia-review.googlesource.com.
open
diffy
satisfied_requirement

'GI Roller (Gerrit)' via owners-override

unread,
Apr 23, 2024, 1:44:06 PMApr 23
to Joseph Ryan, CQ Bot, Auto-Submit, Adam Barth, Owners Override, Erick Tryzelaar, Gwen Mittertreiner

Message from GI Roller

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I2983df8cb6e97d25848a2c8f91b0e42a09de2ba3
Gerrit-Change-Number: 1034098
Gerrit-PatchSet: 4
Gerrit-Owner: Joseph Ryan <jose...@google.com>
Gerrit-Reviewer: Adam Barth <aba...@google.com>
Gerrit-Reviewer: Auto-Submit <auto-...@fuchsia-infra.iam.gserviceaccount.com>
Gerrit-Reviewer: Erick Tryzelaar <etryz...@google.com>
Gerrit-Reviewer: Gwen Mittertreiner <gm...@google.com>
Gerrit-Reviewer: Joseph Ryan <jose...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Comment-Date: Tue, 23 Apr 2024 17:43:58 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/771d028da2f312ce23af999bee7f700bdd3da484-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages