'David Dorwin (Gerrit)' via owners-override

unread,

May 29, 2025, 8:55:16 PM5/29/25

to Owners Override

Attention needed from Owners Override and Roland McGrath

David Dorwin has uploaded the change for review

David Dorwin would like Owners Override to review this change.

Commit message

[idk][memory_barriers] Move memory_barriers to //sdk

Move the "memory_barriers" target from //src to //sdk and make its
include path consistent with other SDK libraries.

The header path in the IDK changes from
"pkg/memory_barriers/include/src/lib/memory_barriers/memory_barriers.h"
to "pkg/memory_barriers/include/lib/memory_barriers/memory_barriers.h".

Change-Id: Iac833f51467fa0a10526a1a94bfc0a45ad8ac25d

Change diff

Change information

Files:

M build/sdk/BUILD.gn
M sdk/BUILD.gn
A sdk/lib/memory_barriers/BUILD.gn
A sdk/lib/memory_barriers/OWNERS
A sdk/lib/memory_barriers/include/lib/memory_barriers/memory_barriers.h
M src/lib/memory_barriers/BUILD.gn
A src/lib/memory_barriers/OWNERS
M src/lib/memory_barriers/memory_barriers.h
M src/media/audio/drivers/aml-g12-pdm/BUILD.gn
M src/media/audio/drivers/aml-g12-pdm/audio-stream-in.cc
M src/media/audio/drivers/aml-g12-pdm/test/BUILD.gn
M src/media/audio/drivers/aml-g12-tdm/composite-server.cc
M src/media/drivers/amlogic_decoder/BUILD.gn
M src/media/drivers/amlogic_decoder/amlogic-video.cc
M src/media/drivers/amlogic_decoder/codec_adapter_h264_multi.cc
M src/media/drivers/amlogic_decoder/codec_adapter_vp9.cc
M src/media/drivers/amlogic_decoder/decoder_core.h
M src/media/drivers/amlogic_decoder/hevcdec.cc
M src/media/drivers/amlogic_decoder/mpeg12_decoder.cc
M src/media/drivers/amlogic_decoder/parser.cc
M src/media/drivers/amlogic_decoder/vdec1.cc
M src/media/drivers/amlogic_decoder/vp9_decoder.cc
M src/media/lib/codec_impl/BUILD.gn
M src/media/lib/codec_impl/codec_buffer.cc
M src/media/lib/internal_buffer/BUILD.gn
M src/media/lib/internal_buffer/internal_buffer.cc
M src/sysmem/server/BUILD.gn
M src/sysmem/server/logical_buffer_collection.cc

Change size: M

Delta: 28 files changed, 135 insertions(+), 112 deletions(-)

Open in Gerrit

Related details

Attention is currently required from:

Owners Override
Roland McGrath

Submit Requirements:

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/22fa7473d75bfa69000ca958f299ee6f365509a5-HTML%40fuchsia-review.googlesource.com.

satisfied_requirement

open

diffy

'David Dorwin (Gerrit)' via owners-override

unread,

May 29, 2025, 8:55:20 PM5/29/25

to Owners Override, Dustin Green, Christopher Anderson, Roland McGrath, David Turner, Android Build Huckle Nudge, Jiaming Li, Jay Zhuang, GI Try Builder, CQ Bot

Attention needed from Owners Override and Roland McGrath

David Dorwin voted and added 1 comment

Votes added by David Dorwin

Fuchsia-Auto-Submit

+1

1 comment

Patchset-level comments

File-level comment, Patchset 7 (Latest):

David Dorwin . resolved

OO, please approve `//src/lib/memory_barriers/`. I've added an OWNERS file.

Open in Gerrit

Related details

Attention is currently required from:

Owners Override
Roland McGrath

Submit Requirements:

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/22fa7473d75bfa69000ca958f299ee6f365509a5-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

satisfied_requirement

open

diffy

'Hunter Freyer (Gerrit)' via owners-override

unread,

Jun 3, 2025, 3:45:24 PM6/3/25

to David Dorwin, Owners Override, Dustin Green, Christopher Anderson, Roland McGrath, David Turner, Android Build Huckle Nudge, Jiaming Li, Jay Zhuang, GI Try Builder, CQ Bot

Attention needed from David Dorwin, Owners Override and Roland McGrath

Hunter Freyer voted Owners-Override+1

Owners-Override

+1

Open in Gerrit

Related details

Attention is currently required from:

David Dorwin
Owners Override
Roland McGrath

Submit Requirements:

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/ca3ab8e6dc085bec7c544765e7313a483c326699-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

satisfied_requirement

open

diffy

'CQ Bot (Gerrit)' via owners-override

unread,

Jun 3, 2025, 7:05:16 PM6/3/25

to David Dorwin, Hunter Freyer, Owners Override, Dustin Green, Christopher Anderson, Roland McGrath, David Turner, Android Build Huckle Nudge, Jiaming Li, Jay Zhuang, GI Try Builder

CQ Bot submitted the change with unreviewed changes

Unreviewed changes

6 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: src/lib/memory_barriers/OWNERS
Insertions: 1, Deletions: 0.

@@ -0,0 +1 @@
+include /src/sysmem/OWNERS
```

Change information

Commit message:

[idk][memory_barriers] Move memory_barriers to //sdk

Move the "memory_barriers" target from //src to //sdk and make its
include path consistent with other SDK libraries.

The header path in the IDK changes from
"pkg/memory_barriers/include/src/lib/memory_barriers/memory_barriers.h"
to "pkg/memory_barriers/include/lib/memory_barriers/memory_barriers.h".

Change-Id: Iac833f51467fa0a10526a1a94bfc0a45ad8ac25d

Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1273894

Fuchsia-Auto-Submit: David Dorwin <ddo...@google.com>

Reviewed-by: Dustin Green <dusti...@google.com>

Reviewed-by: David Turner <di...@google.com>

Reviewed-by: Christopher Anderson <c...@google.com>

Owners-Override: Hunter Freyer <hjfr...@google.com>

Reviewed-by: Jiaming Li <liji...@google.com>

Commit-Queue: David Dorwin <ddo...@google.com>

Branch: refs/heads/main

Submit Requirements:

Code-Review: +2 by Jiaming Li, +2 by Dustin Green, +2 by Christopher Anderson, +1 by David Turner

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--

You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/b96d2ad8c7656413fce5607cbdc9a72b754b7e47-HTML%40fuchsia-review.googlesource.com.

open

diffy

satisfied_requirement

'GI Roller (Gerrit)' via owners-override

unread,

Jun 3, 2025, 7:15:56 PM6/3/25

to David Dorwin, CQ Bot, Hunter Freyer, Owners Override, Dustin Green, Christopher Anderson, Roland McGrath, David Turner, Android Build Huckle Nudge, Jiaming Li, Jay Zhuang, GI Try Builder

Message from GI Roller

Change has been successfully rolled: http://go/roll-cl/b3ca4fe9e661c7c3ffe0d743deab39a0392571b9

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/7356125da6d43ecd29f3b9490a5d82a4f6241451-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

satisfied_requirement

open

diffy

Reply all

Reply to author

Forward

[M] Change in fuchsia/fuchsia[main]: [idk][memory_barriers] Move memory_barriers to //sdk

'David Dorwin (Gerrit)' via owners-override

David Dorwin has uploaded the change for review

Commit message

Change diff

Change information

Related details

'David Dorwin (Gerrit)' via owners-override

David Dorwin voted and added 1 comment

Votes added by David Dorwin

1 comment

Related details

'Hunter Freyer (Gerrit)' via owners-override

Hunter Freyer voted Owners-Override+1

Related details

'CQ Bot (Gerrit)' via owners-override

CQ Bot submitted the change with unreviewed changes

Unreviewed changes

Change information

'GI Roller (Gerrit)' via owners-override

Message from GI Roller

Related details