'Mitchell Kember (Gerrit)' via owners-override

unread,

Apr 1, 2024, 7:02:07 PMApr 1

to Joseph Ryan, Owners Override, Erick Tryzelaar

Attention needed from Erick Tryzelaar, Joseph Ryan and Owners Override

Mitchell Kember has uploaded the change for review

Mitchell Kember would like Joseph Ryan, Owners Override and Erick Tryzelaar to review this change.

Commit message

[rust] Silence new dead_code lints

This adds #[allow(dead_code)] or renames fields to start with an
underscore, to silence the new "field is never read" lints. This will
unblock rolling the Rust toolchain.

Bug: 332349074 (roll toolchain)

Bug: 332385167, 332389972, 332390332, 332392008, 42148629 (fix lints)

Change-Id: I04a7b644eeb8ee31d9ea4e3c9d14b8a7d6441ff9

Change diff

Change information

Files:

M src/connectivity/bluetooth/profiles/bt-device-id/src/device_id/server.rs
M src/connectivity/bluetooth/tools/bt-bredr-profile/src/types.rs
M src/connectivity/bluetooth/tools/bt-fct-hci/src/types.rs
M src/connectivity/network/netstack3/core/src/ip/types.rs
M src/connectivity/network/netstack3/src/bindings.rs
M src/connectivity/wlan/lib/bitfield/src/parse.rs
M src/lib/fuchsia-async/src/runtime/fuchsia/executor/instrumentation.rs
M src/power/broker/src/topology.rs
M src/sys/component_manager/lib/sandbox/src/registry.rs
M src/ui/examples/flatland-view-provider/src/internal_message.rs

Change size: M

Delta: 10 files changed, 44 insertions(+), 14 deletions(-)

Open in Gerrit

Related details

Attention is currently required from:

Erick Tryzelaar
Joseph Ryan
Owners Override

Submit Requirements:

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/5e84b52edf24e3f1adebb277132d049ec68fa35d-HTML%40fuchsia-review.googlesource.com.

unsatisfied_requirement

open

diffy

'Mitchell Kember (Gerrit)' via owners-override

unread,

Apr 1, 2024, 7:02:10 PMApr 1

to Erick Tryzelaar, Joseph Ryan, Owners Override

Attention needed from Erick Tryzelaar, Joseph Ryan and Owners Override

Mitchell Kember voted

Commit-Queue	+1
Fuchsia-Auto-Submit	+1

Open in Gerrit

Related details

Attention is currently required from:

Erick Tryzelaar
Joseph Ryan
Owners Override

Submit Requirements:

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/5e84b52edf24e3f1adebb277132d049ec68fa35d-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

unsatisfied_requirement

open

diffy

'James Robinson (Gerrit)' via owners-override

unread,

Apr 1, 2024, 7:34:51 PMApr 1

to Mitchell Kember, CQ Bot, Erick Tryzelaar, Joseph Ryan, Owners Override

Attention needed from Erick Tryzelaar, Joseph Ryan, Mitchell Kember and Owners Override

James Robinson voted Owners-Override+1

Owners-Override

+1

Open in Gerrit

Related details

Attention is currently required from:

Erick Tryzelaar
Joseph Ryan
Mitchell Kember
Owners Override

Submit Requirements:

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/5b6e656b8d99cd5a260d972d75b12193a67c4639-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

unsatisfied_requirement

open

diffy

'Mitchell Kember (Gerrit)' via owners-override

unread,

Apr 1, 2024, 7:56:24 PMApr 1

to James Robinson, CQ Bot, Erick Tryzelaar, Joseph Ryan, Owners Override

Attention needed from Erick Tryzelaar, Joseph Ryan and Owners Override

Mitchell Kember voted Fuchsia-Auto-Submit+0

Fuchsia-Auto-Submit

+0

Open in Gerrit

Related details

Attention is currently required from:

Erick Tryzelaar
Joseph Ryan
Owners Override

Submit Requirements:

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/c7cf3ec9dc075bc14313c43c64a612302d9a8e68-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

unsatisfied_requirement

open

diffy

'Erick Tryzelaar (Gerrit)' via owners-override

unread,

Apr 2, 2024, 7:20:54 AMApr 2

to Mitchell Kember, James Robinson, CQ Bot, Joseph Ryan, Owners Override

Attention needed from James Robinson, Joseph Ryan, Mitchell Kember and Owners Override

Erick Tryzelaar added 3 comments

File src/connectivity/wlan/lib/bitfield/src/parse.rs

Line 65, Patchset 2 (Latest): _as_keyword: Token![as],

Erick Tryzelaar . unresolved

Should this and below be some variation of this?


```suggestion
    // TODO(https://fxbug.dev/42148629): Remove or explain #[allow(dead_code)].
    #[allow(dead_code)]
    _as_keyword: Token![as],
```

Line 67, Patchset 2 (Latest): _paren: token::Paren,

Erick Tryzelaar . unresolved

```suggestion
    // TODO(https://fxbug.dev/42148629): Remove or explain #[allow(dead_code)].
    #[allow(dead_code)]
    _paren: token::Paren,
```

Line 85, Patchset 2 (Latest): _underscore: Token![_],

Erick Tryzelaar . unresolved

```suggestion
        // TODO(https://fxbug.dev/42148629): Remove or explain #[allow(dead_code)].
        #[allow(dead_code)]
        _underscore: Token![_],
```

Open in Gerrit

Related details

Attention is currently required from:

James Robinson
Joseph Ryan
Mitchell Kember
Owners Override

Submit Requirements:

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/ca887b6401f81f2c1e9e593d7146f914d89b1afd-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

unsatisfied_requirement

open

diffy

'Erick Tryzelaar (Gerrit)' via owners-override

unread,

Apr 2, 2024, 7:21:50 AMApr 2

to Mitchell Kember, James Robinson, CQ Bot, Joseph Ryan, Owners Override

Attention needed from James Robinson, Joseph Ryan, Mitchell Kember and Owners Override

Erick Tryzelaar voted Code-Review+2

Code-Review

+2

Open in Gerrit

Related details

Attention is currently required from:

James Robinson
Joseph Ryan
Mitchell Kember
Owners Override

Submit Requirements:

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--

You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/e89ef1d04451ef7577b45e65d1b179952d576f7c-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

satisfied_requirement

open

diffy

'James Robinson (Gerrit)' via owners-override

unread,

Apr 2, 2024, 1:07:22 PMApr 2

to Mitchell Kember, Erick Tryzelaar, CQ Bot, Joseph Ryan, Owners Override

Attention needed from Joseph Ryan, Mitchell Kember and Owners Override

James Robinson added 1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

James Robinson . resolved

Mitchell - feel free to ping me once the comments are addressed for a new O-O+1 (since a new patch will drop the bit)

Open in Gerrit

Related details

Attention is currently required from:

Joseph Ryan
Mitchell Kember
Owners Override

Submit Requirements:

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--

You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/cbb7f36435eb2065632df9d7b064e1881b97172a-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

satisfied_requirement

open

diffy

'Mitchell Kember (Gerrit)' via owners-override

unread,

Apr 2, 2024, 3:22:25 PMApr 2

to Erick Tryzelaar, James Robinson, CQ Bot, Joseph Ryan, Owners Override

Attention needed from Joseph Ryan and Owners Override

Mitchell Kember added 3 comments

File src/connectivity/wlan/lib/bitfield/src/parse.rs

Line 65, Patchset 2 (Latest): _as_keyword: Token![as],

Erick Tryzelaar . resolved

Should this and below be some variation of this?


```suggestion
    // TODO(https://fxbug.dev/42148629): Remove or explain #[allow(dead_code)].
    #[allow(dead_code)]
    _as_keyword: Token![as],
```

Mitchell Kember

The leading underscore prevents the warning. For most other places I added TODOs and #[allow]s, but here I think it's clear it's just for parsing and is intentionally never read, so I added the underscore myself.

Line 67, Patchset 2 (Latest): _paren: token::Paren,

Erick Tryzelaar . resolved

```suggestion
    // TODO(https://fxbug.dev/42148629): Remove or explain #[allow(dead_code)].
    #[allow(dead_code)]
    _paren: token::Paren,
```

Mitchell Kember

Same as other comment

Line 85, Patchset 2 (Latest): _underscore: Token![_],

Erick Tryzelaar . resolved

```suggestion
        // TODO(https://fxbug.dev/42148629): Remove or explain #[allow(dead_code)].
        #[allow(dead_code)]
        _underscore: Token![_],
```

Mitchell Kember

Same as other comment

Open in Gerrit

Related details

Attention is currently required from:

Joseph Ryan
Owners Override

Submit Requirements:

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/3316d8e4ebfe677e7290a13975ce7bbe1fb79fa9-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

satisfied_requirement

open

diffy

'James Robinson (Gerrit)' via owners-override

unread,

Apr 2, 2024, 3:25:36 PMApr 2

to Mitchell Kember, Erick Tryzelaar, CQ Bot, Joseph Ryan, Owners Override

Attention needed from Joseph Ryan, Mitchell Kember and Owners Override

James Robinson voted Owners-Override+1

Owners-Override

+1

Open in Gerrit

Related details

Attention is currently required from:

Joseph Ryan
Mitchell Kember
Owners Override

Submit Requirements:

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--

You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/14f4deb06faf00ccbd12459107a48cacb76adbbc-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

satisfied_requirement

open

diffy

'Mitchell Kember (Gerrit)' via owners-override

unread,

Apr 2, 2024, 3:32:26 PMApr 2

to James Robinson, Erick Tryzelaar, CQ Bot, Joseph Ryan, Owners Override

Attention needed from Joseph Ryan and Owners Override

Mitchell Kember voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention is currently required from:

Joseph Ryan
Owners Override

Submit Requirements:

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/c23a251de0b15c3679ef6c20deb39bfe48065882-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

satisfied_requirement

open

diffy

'CQ Bot (Gerrit)' via owners-override

unread,

Apr 2, 2024, 4:27:03 PMApr 2

to Mitchell Kember, James Robinson, Erick Tryzelaar, Joseph Ryan, Owners Override

CQ Bot submitted the change

Change information

Commit message:

[rust] Silence new dead_code lints

This adds #[allow(dead_code)] or renames fields to start with an
underscore, to silence the new "field is never read" lints. This will
unblock rolling the Rust toolchain.

Bug: 332349074 (roll toolchain)

Bug: 332385167, 332389972, 332390332, 332392008, 332405442 (fix lints)

Bug: 332406669, 332406747, 332407032, 332407468, 332407981 (fix lints)

Bug: 332408215, 332408218, 42148629 (fix lints)

Change-Id: I04a7b644eeb8ee31d9ea4e3c9d14b8a7d6441ff9

Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1018328

Reviewed-by: Erick Tryzelaar <etryz...@google.com>

Owners-Override: James Robinson <jam...@google.com>

Commit-Queue: Mitchell Kember <mke...@google.com>

Files:

M src/connectivity/bluetooth/profiles/bt-a2dp/src/pcm_audio.rs
M src/connectivity/bluetooth/profiles/bt-device-id/src/device_id/server.rs
M src/connectivity/bluetooth/profiles/bt-hfp-audio-gateway/src/peer/sco_state.rs
M src/connectivity/bluetooth/profiles/bt-hfp-hands-free/src/peer/hf_indicators.rs
M src/connectivity/bluetooth/profiles/bt-hfp-hands-free/src/peer/procedure_manipulated_state.rs
M src/connectivity/bluetooth/profiles/bt-map-mce/src/messaging_client.rs

M src/connectivity/bluetooth/tools/bt-bredr-profile/src/types.rs
M src/connectivity/bluetooth/tools/bt-fct-hci/src/types.rs
M src/connectivity/network/netstack3/core/src/ip/types.rs
M src/connectivity/network/netstack3/src/bindings.rs
M src/connectivity/wlan/lib/bitfield/src/parse.rs

M src/connectivity/wlan/lib/mlme/rust/src/client/state.rs
M src/connectivity/wlan/lib/sme/src/client/inspect.rs
M src/connectivity/wlan/lib/sme/src/client/mod.rs
M src/connectivity/wlan/wlancfg/src/mode_management/iface_manager.rs
M src/connectivity/wlan/wlandevicemonitor/src/device.rs
M src/connectivity/wlan/wlandevicemonitor/src/inspect.rs
M src/connectivity/wlan/wlanix/src/ifaces.rs
M src/developer/ffx/plugins/assembly/src/base_package.rs
M src/developer/ffx/plugins/assembly/src/subpackage_blobs_package.rs
M src/diagnostics/archivist/src/diagnostics.rs
M src/lib/fuchsia-async/src/runtime/fuchsia/executor/instrumentation.rs
M src/power/broker/src/topology.rs
M src/power/shutdown-shim/tests/src/shutdown_mocks.rs
M src/security/lib/scrutiny/plugins/src/verify/collection.rs
M src/settings/service/integration_tests/input_tests/src/common.rs
M src/storage/fshost/src/environment.rs
M src/storage/fshost/src/service.rs
M src/sys/component_manager/lib/sandbox/src/registry.rs
M src/sys/component_manager/src/builtin_environment.rs
M src/sys/component_manager/src/model/events/dispatcher.rs
M src/sys/pkg/lib/isolated-swd/src/updater.rs
M src/ui/examples/flatland-view-provider/src/internal_message.rs
M src/ui/tests/scenic-stress-tests/src/flatland_instance.rs

Change size: M

Delta: 34 files changed, 163 insertions(+), 23 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +2 by Erick Tryzelaar

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--

You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/eadadb690e846829f0689e39fc6fe73653cdc433-HTML%40fuchsia-review.googlesource.com.

open

diffy

satisfied_requirement

'GI Roller (Gerrit)' via owners-override

unread,

Apr 2, 2024, 4:34:53 PMApr 2

to CQ Bot, Mitchell Kember, James Robinson, Erick Tryzelaar, Joseph Ryan, Owners Override

Message from GI Roller

Change has been successfully rolled: http://go/roll-cl/202797a9c7144b35ffedd7f3f2a10bc1e6a6d691

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/9ee5bae0db336b1b6817de72cd73d850534f5a7d-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

satisfied_requirement

open

diffy

Reply all

Reply to author

Forward

[M] Change in fuchsia/fuchsia[main]: [rust] Silence new dead_code lints

'Mitchell Kember (Gerrit)' via owners-override

Mitchell Kember has uploaded the change for review

Commit message

Change diff

Change information

Related details

'Mitchell Kember (Gerrit)' via owners-override

Mitchell Kember voted

Related details

'James Robinson (Gerrit)' via owners-override

James Robinson voted Owners-Override+1

Related details

'Mitchell Kember (Gerrit)' via owners-override

Mitchell Kember voted Fuchsia-Auto-Submit+0

Related details

'Erick Tryzelaar (Gerrit)' via owners-override

Erick Tryzelaar added 3 comments

Related details

'Erick Tryzelaar (Gerrit)' via owners-override

Erick Tryzelaar voted Code-Review+2

Related details

'James Robinson (Gerrit)' via owners-override

James Robinson added 1 comment

Related details

'Mitchell Kember (Gerrit)' via owners-override

Mitchell Kember added 3 comments

Related details

'James Robinson (Gerrit)' via owners-override

James Robinson voted Owners-Override+1

Related details

'Mitchell Kember (Gerrit)' via owners-override

Mitchell Kember voted Commit-Queue+2

Related details

'CQ Bot (Gerrit)' via owners-override

CQ Bot submitted the change

Change information

'GI Roller (Gerrit)' via owners-override

Message from GI Roller

Related details