[L] Change in fuchsia/fuchsia[main]: [fshost] Remove fuchsia.fshost.Netboot config parameter
2 views
Skip to first unread message
'Brandon Castellano (Gerrit)' via owners-override
Jul 18, 2025, 1:41:40 PMJul 18
to Owners Override, Chris Suter
Attention needed from Chris Suter and Owners Override
Brandon Castellano has uploaded the change for review![]( "Open in Gerrit")
Brandon Castellano would like Owners Override and Chris Suter to review this change.
Commit message
[fshost] Remove fuchsia.fshost.Netboot config parameter
Netbooting no longer depends on fshost or the paver, so we don't need to
plumb this through fshost any longer. Now, we can rely purely on
fuchsia.fshost.RamdiskImage to determine if we should allow recovery
capabilities or not. This also reduces confusion between the two
parameters, as both were used to gate recovery functionality.
Bug: 377560660
Change-Id: I106ab06a3beb715181b21d3d879be0f7b0dba65e
Change diff
Change information
Files:
- M sdk/fidl/fuchsia.fshost/fshost.fidl
- M src/devices/testing/driver-integration-test-shim/BUILD.gn
- M src/devices/testing/driver-integration-test-shim/fixture.cc
- M src/devices/testing/driver-integration-test-shim/include/lib/driver-integration-test/fixture.h
- M src/lib/assembly/platform_configuration/src/subsystems/storage.rs
- M src/security/tests/pkg_test/tests/access_ota_blob_as_executable/meta/access_ota_blob_as_executable.cml
- M src/security/tests/pkg_test/tests/bad_signature_update/meta/bad_signature_update.cml
- M src/storage/fshost/BUILD.gn
- M src/storage/fshost/generated_fshost_config.gni
- M src/storage/fshost/integration/src/fshost_builder.rs
- M src/storage/fshost/integration/src/lib.rs
- M src/storage/fshost/integration/src/mocks.rs
- M src/storage/fshost/integration/tests/fshost_integration_test.rs
- M src/storage/fshost/integration/tests/write_data_file.rs
- M src/storage/fshost/meta/config.cml
- M src/storage/fshost/meta/fshost.bootstrap_shard.cml
- D src/storage/fshost/src/boot_args.rs
- M src/storage/fshost/src/config.rs
- M src/storage/fshost/src/main.rs
- M src/storage/fshost/src/matcher.rs
- M src/storage/fshost/src/service.rs
- M src/storage/fshost/testing/BUILD.gn
- M src/storage/lib/paver/gpt.cc
- M src/storage/lib/paver/test/device-partitioner-test.cc
- M src/sys/root/root.cml
Change size: L
Delta: 25 files changed, 29 insertions(+), 269 deletions(-)
Related details
Attention is currently required from:
- Chris Suter
- Owners Override
Submit Requirements:
API-Review
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/5dc1f5ac94c85d23305cbb5bebc4df7f74336eb7-HTML%40fuchsia-review.googlesource.com.
'Chris Suter (Gerrit)' via owners-override
Jul 20, 2025, 9:24:42 PMJul 20
to Brandon Castellano, Owners Override, Stephen Demos, fuchsia-c...@fuchsia-infra.iam.gserviceaccount.com, GI Try Builder, CQ Bot
Attention needed from Brandon Castellano and Owners Override
Chris Suter voted API-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Brandon Castellano
- Owners Override
Submit Requirements:
API-Review
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/017b0cde681b3fb7d8b2ae37a17a6cafd01b7998-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'Adam Barth (Gerrit)' via owners-override
Jul 21, 2025, 12:19:19 AMJul 21
to Brandon Castellano, Chris Suter, Owners Override, Stephen Demos, fuchsia-c...@fuchsia-infra.iam.gserviceaccount.com, GI Try Builder, CQ Bot
Attention needed from Brandon Castellano and Owners Override
Adam Barth voted Owners-Override+1![]( "Open in Gerrit")
| Owners-Override | +1 |
Related details
Attention is currently required from:
- Brandon Castellano
- Owners Override
Submit Requirements:
API-Review
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/babe54f3649e8821154844207a156bc1da65dd83-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'Brandon Castellano (Gerrit)' via owners-override
Jul 21, 2025, 2:48:34 PMJul 21
to Adam Barth, Chris Suter, Owners Override, Stephen Demos, fuchsia-c...@fuchsia-infra.iam.gserviceaccount.com, GI Try Builder, CQ Bot
Attention needed from Owners Override
Brandon Castellano voted Commit-Queue+2![]( "Open in Gerrit")
Attention is currently required from:
- Owners Override
Submit Requirements:
API-Review
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/f9b0812269e5a56c80fa13965c6d2d58cd9cf0be-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'CQ Bot (Gerrit)' via owners-override
Jul 21, 2025, 2:51:48 PMJul 21
to Brandon Castellano, Adam Barth, Chris Suter, Owners Override, Stephen Demos, fuchsia-c...@fuchsia-infra.iam.gserviceaccount.com, GI Try Builder
CQ Bot submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
4 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: src/storage/lib/paver/gpt.cc
Insertions: 1, Deletions: 1.
@@ -404,7 +404,7 @@
}
ERROR(
"Unable to find a GPT on this device with the expected partitions.\n"
- "Attempting to reinitialize partition tables; this only works on eng/recovery builds!\n"
+ "Attempting to reinitialize partition tables; this only works on recovery builds!\n"
"If this fails, please run init-partition-tables to re-initialize the device.\n"
"Device path: %s\n",
std::get<1>(candidate_gpts[0]).c_str());
```
Change information
Commit message:
[fshost] Remove fuchsia.fshost.Netboot config parameter
Netbooting no longer depends on fshost or the paver, so we don't need to
plumb this through fshost any longer. Now, we can rely purely on
fuchsia.fshost.RamdiskImage to determine if we should allow recovery
capabilities or not. This also reduces confusion between the two
parameters, as both were used to gate recovery functionality.
Bug: 377560660
Change-Id: I106ab06a3beb715181b21d3d879be0f7b0dba65e
Reviewed-by: Stephen Demos <sde...@google.com>
Mega-CQ: Brandon Castellano <bcas...@google.com>
Commit-Queue: Brandon Castellano <bcas...@google.com>
API-Review: Chris Suter <csu...@google.com>
Owners-Override: Adam Barth <aba...@google.com>
Branch: refs/heads/main
Submit Requirements:
API-Review: +1 by Chris Suter
Code-Review: +2 by Stephen Demos
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/93a61a1d1851655977d48371d2227583114dbc53-HTML%40fuchsia-review.googlesource.com.To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'GI Roller (Gerrit)' via owners-override
Jul 21, 2025, 3:10:54 PMJul 21
to Brandon Castellano, CQ Bot, Adam Barth, Chris Suter, Owners Override, Stephen Demos, fuchsia-c...@fuchsia-infra.iam.gserviceaccount.com, GI Try Builder
Message from GI Roller![]( "Open in Gerrit")
Change has been successfully rolled: https://turquoise-internal-review.googlesource.com/1019916
Related details
Attention set is empty
Submit Requirements:
API-Review
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/c28e4a5b1735cfa841bcf70898fde0ac167921ee-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
Reply all
Reply to author
Forward
0 new messages