Groups keyboard shortcuts have been updated
Dismiss
See shortcuts

[S] Change in fuchsia/fuchsia[main]: [rust][toolchain] Remove references to old Fuchsia triples

0 views
Skip to first unread message

'Tyler Mandry (Gerrit)' via owners-override

unread,
May 6, 2024, 6:44:00 PM5/6/24
to Owners Override
Attention needed from David Koloski and Owners Override

Tyler Mandry has uploaded the change for review

Tyler Mandry would like Owners Override to review this change.

Commit message

[rust][toolchain] Remove references to old Fuchsia triples
Bug: 310271984
Change-Id: I20e9bb7befc5969f2645ae21e881ca19c2eac0b3

Change diff


Change information

Files:
  • M build/bazel/toolchains/rust/rust.BUILD.bazel
  • M build/config/arm64/BUILD.gn
  • M build/rbe/fuchsia.py
  • M build/rbe/fuchsia_test.py
  • M docs/development/languages/rust/bloat.md
  • M docs/development/languages/rust/external_crates.md
  • M scripts/generate_cargo.py
  • M scripts/rust/build_fuchsia_from_rust_ci.sh
  • M scripts/sdk/gn/base/build/config/BUILD.gn
  • M src/performance/lib/gperftools/README.TXT
  • M src/storage/lib/vfs/README.md
  • M zircon/kernel/arch/arm64/include/arch/current_thread.h
Change size: S
Delta: 12 files changed, 21 insertions(+), 25 deletions(-)
Open in Gerrit

Related details

Attention is currently required from:
  • David Koloski
  • Owners Override
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I20e9bb7befc5969f2645ae21e881ca19c2eac0b3
Gerrit-Change-Number: 1043251
Gerrit-PatchSet: 1
Gerrit-Owner: Tyler Mandry <tma...@google.com>
Gerrit-Reviewer: David Fang <fan...@google.com>
Gerrit-Reviewer: David Koloski <dkol...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Reviewer: Tyler Mandry <tma...@google.com>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: David Koloski <dkol...@google.com>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/46c34c183a0cb778165871e73d31cd143869b3ec-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy

'Tyler Mandry (Gerrit)' via owners-override

unread,
May 6, 2024, 6:44:11 PM5/6/24
to Owners Override, David Fang, CQ Bot, David Koloski
Attention needed from David Koloski and Owners Override

Tyler Mandry voted Fuchsia-Auto-Submit+1

Fuchsia-Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • David Koloski
  • Owners Override
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I20e9bb7befc5969f2645ae21e881ca19c2eac0b3
Gerrit-Change-Number: 1043251
Gerrit-PatchSet: 1
Gerrit-Owner: Tyler Mandry <tma...@google.com>
Gerrit-Reviewer: David Fang <fan...@google.com>
Gerrit-Reviewer: David Koloski <dkol...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Reviewer: Tyler Mandry <tma...@google.com>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: David Koloski <dkol...@google.com>
Gerrit-Comment-Date: Mon, 06 May 2024 22:44:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/7a1068ea30bc7f724bc941e2e6df394da0321d51-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy

'James Robinson (Gerrit)' via owners-override

unread,
May 6, 2024, 6:50:15 PM5/6/24
to Tyler Mandry, Owners Override, David Fang, CQ Bot, David Koloski
Attention needed from David Koloski, Owners Override and Tyler Mandry

James Robinson voted Owners-Override+1

Owners-Override+1
Open in Gerrit

Related details

Attention is currently required from:
  • David Koloski
  • Owners Override
  • Tyler Mandry
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I20e9bb7befc5969f2645ae21e881ca19c2eac0b3
Gerrit-Change-Number: 1043251
Gerrit-PatchSet: 1
Gerrit-Owner: Tyler Mandry <tma...@google.com>
Gerrit-Reviewer: David Fang <fan...@google.com>
Gerrit-Reviewer: David Koloski <dkol...@google.com>
Gerrit-Reviewer: James Robinson <jam...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Reviewer: Tyler Mandry <tma...@google.com>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Tyler Mandry <tma...@google.com>
Gerrit-Attention: David Koloski <dkol...@google.com>
Gerrit-Comment-Date: Mon, 06 May 2024 22:50:08 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/8cd9a8f6cd428e682201d235b1ae4540f5b1aec9-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy

'Adam Barth (Gerrit)' via owners-override

unread,
May 6, 2024, 7:01:06 PM5/6/24
to Tyler Mandry, James Robinson, Owners Override, David Fang, CQ Bot, David Koloski
Attention needed from David Koloski, Owners Override and Tyler Mandry

Adam Barth voted Owners-Override+1

Owners-Override+1
Open in Gerrit

Related details

Attention is currently required from:
  • David Koloski
  • Owners Override
  • Tyler Mandry
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I20e9bb7befc5969f2645ae21e881ca19c2eac0b3
Gerrit-Change-Number: 1043251
Gerrit-PatchSet: 1
Gerrit-Owner: Tyler Mandry <tma...@google.com>
Gerrit-Reviewer: Adam Barth <aba...@google.com>
Gerrit-Reviewer: David Fang <fan...@google.com>
Gerrit-Reviewer: David Koloski <dkol...@google.com>
Gerrit-Reviewer: James Robinson <jam...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Reviewer: Tyler Mandry <tma...@google.com>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Tyler Mandry <tma...@google.com>
Gerrit-Attention: David Koloski <dkol...@google.com>
Gerrit-Comment-Date: Mon, 06 May 2024 23:00:58 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/151f07065248279b9ae5c0341d73ea139f769232-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy

'Tyler Mandry (Gerrit)' via owners-override

unread,
May 6, 2024, 7:08:41 PM5/6/24
to Adam Barth, James Robinson, Owners Override, David Fang, CQ Bot, David Koloski
Attention needed from David Koloski and Owners Override

Tyler Mandry voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • David Koloski
  • Owners Override
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I20e9bb7befc5969f2645ae21e881ca19c2eac0b3
Gerrit-Change-Number: 1043251
Gerrit-PatchSet: 1
Gerrit-Owner: Tyler Mandry <tma...@google.com>
Gerrit-Reviewer: Adam Barth <aba...@google.com>
Gerrit-Reviewer: David Fang <fan...@google.com>
Gerrit-Reviewer: David Koloski <dkol...@google.com>
Gerrit-Reviewer: James Robinson <jam...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Reviewer: Tyler Mandry <tma...@google.com>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: David Koloski <dkol...@google.com>
Gerrit-Comment-Date: Mon, 06 May 2024 23:08:34 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/bb3951e17953a1ddb39137086e11b1a012473053-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy

'CQ Bot (Gerrit)' via owners-override

unread,
May 6, 2024, 8:21:27 PM5/6/24
to Tyler Mandry, Adam Barth, James Robinson, Owners Override, David Fang, David Koloski

CQ Bot submitted the change

Change information

Commit message:
[rust][toolchain] Remove references to old Fuchsia triples
Bug: 310271984
Change-Id: I20e9bb7befc5969f2645ae21e881ca19c2eac0b3
Fuchsia-Auto-Submit: Tyler Mandry <tma...@google.com>
Owners-Override: James Robinson <jam...@google.com>
Commit-Queue: Tyler Mandry <tma...@google.com>
Owners-Override: Adam Barth <aba...@google.com>
Reviewed-by: David Fang <fan...@google.com>
Files:
  • M build/bazel/toolchains/rust/rust.BUILD.bazel
  • M build/config/arm64/BUILD.gn
  • M build/rbe/fuchsia.py
  • M build/rbe/fuchsia_test.py
  • M docs/development/languages/rust/bloat.md
  • M docs/development/languages/rust/external_crates.md
  • M scripts/generate_cargo.py
  • M scripts/rust/build_fuchsia_from_rust_ci.sh
  • M scripts/sdk/gn/base/build/config/BUILD.gn
  • M src/performance/lib/gperftools/README.TXT
  • M src/storage/lib/vfs/README.md
  • M zircon/kernel/arch/arm64/include/arch/current_thread.h
Change size: S
Delta: 12 files changed, 21 insertions(+), 25 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +2 by David Fang
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I20e9bb7befc5969f2645ae21e881ca19c2eac0b3
Gerrit-Change-Number: 1043251
Gerrit-PatchSet: 2
Gerrit-Owner: Tyler Mandry <tma...@google.com>
Gerrit-Reviewer: Adam Barth <aba...@google.com>
Gerrit-Reviewer: David Fang <fan...@google.com>
Gerrit-Reviewer: David Koloski <dkol...@google.com>
Gerrit-Reviewer: James Robinson <jam...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Reviewer: Tyler Mandry <tma...@google.com>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/7746a969aae3fc26ee6c9f393ab928ca4bc7749d-HTML%40fuchsia-review.googlesource.com.
open
diffy
satisfied_requirement

'GI Roller (Gerrit)' via owners-override

unread,
May 6, 2024, 8:23:28 PM5/6/24
to Tyler Mandry, CQ Bot, Adam Barth, James Robinson, Owners Override, David Fang, David Koloski

Message from GI Roller

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I20e9bb7befc5969f2645ae21e881ca19c2eac0b3
Gerrit-Change-Number: 1043251
Gerrit-PatchSet: 2
Gerrit-Owner: Tyler Mandry <tma...@google.com>
Gerrit-Reviewer: Adam Barth <aba...@google.com>
Gerrit-Reviewer: David Fang <fan...@google.com>
Gerrit-Reviewer: David Koloski <dkol...@google.com>
Gerrit-Reviewer: James Robinson <jam...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Reviewer: Tyler Mandry <tma...@google.com>
Gerrit-Comment-Date: Tue, 07 May 2024 00:23:20 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/5c602a0964b34ac2a6edb2e5022c0fee915cf568-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages