[S] Change in fuchsia/fuchsia[main]: [fx][config] Move the fx config README.md into /tools/devshell

0 views
Skip to first unread message

'Jiaming Li (Gerrit)' via owners-override

unread,
Nov 11, 2025, 5:46:43 PM (4 days ago) Nov 11
to Owners Override
Attention needed from Chase Latta and Owners Override

Jiaming Li has uploaded the change for review

Jiaming Li would like Owners Override to review this change.

Commit message

[fx][config] Move the fx config README.md into /tools/devshell
Change-Id: I861e807ccb41e3c92ade461509c24c4e5d50681c

Change diff

diff --git a/.fx/config/README.md b/.fx/config/README.md
deleted file mode 100644
index fe32e9b..0000000
--- a/.fx/config/README.md
+++ /dev/null
@@ -1,13 +0,0 @@
-# fx configs
-
-Place configuration files that influence `fx` operation in this directory.
-
-* `build-auth` reflects configuration that influences authentication for
- build services like RBE and ResultStore. Settings are auto-detected,
- but can be manually overridden. Used by `fx rbe auth` and `fx build`.
-* `build-metrics` controls pushing of RBE logs and metrics to BigQuery.
- Set by `fx build-metrics`, and used by `fx build`.
-* `build-profile` controls profiling local memory and network usage during
- build. Set by `fx build-profile`, and used by `fx build`.
-* `metrics` controls per-tree behaviors of sending fx metrics to Google
- Analytics.
diff --git a/.gitignore b/.gitignore
index be7615f..8c5c7f6 100644
--- a/.gitignore
+++ b/.gitignore
@@ -64,7 +64,6 @@
# instead of adding new top-level files, to avoid cluttering this .gitignore
# file and the top level of local checkouts.
/.fx/
-!/.fx/config/README.md
.fx-build-dir
.fx-metrics-config
.fx-multi-list
diff --git a/tools/devshell/README.md b/tools/devshell/README.md
index 9749730..d55c998 100644
--- a/tools/devshell/README.md
+++ b/tools/devshell/README.md
@@ -123,6 +123,20 @@
users should not rely on them - only the above list are to be preserved
(unless marked deprecated).

+## fx configs
+
+Place configuration files that influence `fx` operation in the `.fx/config` directory.
+
+* `build-auth` reflects configuration that influences authentication for
+ build services like RBE and ResultStore. Settings are auto-detected,
+ but can be manually overridden. Used by `fx rbe auth` and `fx build`.
+* `build-metrics` controls pushing of RBE logs and metrics to BigQuery.
+ Set by `fx build-metrics`, and used by `fx build`.
+* `build-profile` controls profiling local memory and network usage during
+ build. Set by `fx build-profile`, and used by `fx build`.
+* `metrics` controls per-tree behaviors of sending fx metrics to Google
+ Analytics.
+
## Optional features

`fx` supports the definition of optional features that are enabled by default
diff --git a/tools/devshell/lib/vars.sh b/tools/devshell/lib/vars.sh
index cb36453..e8ed23e 100644
--- a/tools/devshell/lib/vars.sh
+++ b/tools/devshell/lib/vars.sh
@@ -53,6 +53,10 @@
# in the names of any cached artifacts to make naming collisions less likely.
export FX_CACHE_DIR="${FUCHSIA_DIR}/.fx"

+# If the fx config does not exist, create it.
+FX_CONFIG_DIR="${FX_CACHE_DIR}/config"
+[ -d "${FX_CONFIG_DIR}" ] || mkdir -p "${FX_CONFIG_DIR}"
+
# This allows LLVM utilities to perform debuginfod lookups for public artifacts.
# See https://sourceware.org/elfutils/Debuginfod.html.
# TODO(111990): Replace this with a local authenticating proxy to support access
@@ -70,7 +74,7 @@
# If build profiling is enabled, collect system stats during build,
# including CPU, memory, disk I/O...
BUILD_PROFILE_ENABLED=1
-readonly fx_build_profile_config="${FUCHSIA_DIR}/.fx/config/build-profile"
+readonly fx_build_profile_config="${FX_CONFIG_DIR}/build-profile"
readonly fx_build_profile_config_old="${FUCHSIA_DIR}/.fx-build-profile-config"
if [[ -f "$fx_build_profile_config_old" ]]; then
fx-info "Moving $fx_build_profile_config_old to new location $fx_build_profile_config. No further action is necessary."
@@ -88,7 +92,7 @@

# If ResultStore is enabled, wrap builds with ResultStore tools.
RESULTSTORE_ENABLED=0
-readonly fx_resultstore_config="${FUCHSIA_DIR}/.fx/config/resultstore"
+readonly fx_resultstore_config="${FX_CONFIG_DIR}/resultstore"
if [[ -f "$fx_resultstore_config" ]]; then
# shellcheck source=/dev/null
source "$fx_resultstore_config"

Change information

Files:
  • D .fx/config/README.md
  • M .gitignore
  • M tools/devshell/README.md
  • M tools/devshell/lib/vars.sh
Change size: S
Delta: 4 files changed, 20 insertions(+), 16 deletions(-)
Open in Gerrit

Related details

Attention is currently required from:
  • Chase Latta
  • Owners Override
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I861e807ccb41e3c92ade461509c24c4e5d50681c
Gerrit-Change-Number: 1420228
Gerrit-PatchSet: 2
Gerrit-Owner: Jiaming Li <liji...@google.com>
Gerrit-Reviewer: Chase Latta <chase...@google.com>
Gerrit-Reviewer: David Fang <fan...@google.com>
Gerrit-Reviewer: Jiaming Li <liji...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Chase Latta <chase...@google.com>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/a3de4d53ae244e65ca2e3283a6fe6133626f6492-HTML%40fuchsia-review.googlesource.com.
unsatisfied_requirement
satisfied_requirement
open
diffy

'Jiaming Li (Gerrit)' via owners-override

unread,
Nov 11, 2025, 5:46:48 PM (4 days ago) Nov 11
to Owners Override, David Fang, Chase Latta, GI Try Builder, CQ Bot
Attention needed from Chase Latta and Owners Override

Jiaming Li added 1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Jiaming Li . resolved

Apply Owners Override as the sole owner of .fx/config file is OOO until end of the week.

Open in Gerrit

Related details

Attention is currently required from:
  • Chase Latta
  • Owners Override
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I861e807ccb41e3c92ade461509c24c4e5d50681c
Gerrit-Change-Number: 1420228
Gerrit-PatchSet: 2
Gerrit-Owner: Jiaming Li <liji...@google.com>
Gerrit-Reviewer: Chase Latta <chase...@google.com>
Gerrit-Reviewer: David Fang <fan...@google.com>
Gerrit-Reviewer: Jiaming Li <liji...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Chase Latta <chase...@google.com>
Gerrit-Comment-Date: Tue, 11 Nov 2025 22:46:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/a3de4d53ae244e65ca2e3283a6fe6133626f6492-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
unsatisfied_requirement
satisfied_requirement
open
diffy

'Adam Barth (Gerrit)' via owners-override

unread,
Nov 11, 2025, 5:51:04 PM (4 days ago) Nov 11
to Jiaming Li, Owners Override, David Fang, Chase Latta, GI Try Builder, CQ Bot
Attention needed from Chase Latta, Jiaming Li and Owners Override

Adam Barth voted Code-Review+2

Code-Review+2
Open in Gerrit

Related details

Attention is currently required from:
  • Chase Latta
  • Jiaming Li
  • Owners Override
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I861e807ccb41e3c92ade461509c24c4e5d50681c
Gerrit-Change-Number: 1420228
Gerrit-PatchSet: 2
Gerrit-Owner: Jiaming Li <liji...@google.com>
Gerrit-Reviewer: Adam Barth <aba...@google.com>
Gerrit-Reviewer: Chase Latta <chase...@google.com>
Gerrit-Reviewer: David Fang <fan...@google.com>
Gerrit-Reviewer: Jiaming Li <liji...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Chase Latta <chase...@google.com>
Gerrit-Attention: Jiaming Li <liji...@google.com>
Gerrit-Comment-Date: Tue, 11 Nov 2025 22:50:57 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/e49fd810eaf7cc4b67b013bb0d6fa8b3dcbcce17-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
unsatisfied_requirement
satisfied_requirement
open
diffy

'Adam Barth (Gerrit)' via owners-override

unread,
Nov 11, 2025, 5:51:18 PM (4 days ago) Nov 11
to Jiaming Li, Owners Override, David Fang, Chase Latta, GI Try Builder, CQ Bot
Attention needed from Chase Latta, Jiaming Li and Owners Override

Adam Barth voted Owners-Override+1

Owners-Override+1
Open in Gerrit

Related details

Attention is currently required from:
  • Chase Latta
  • Jiaming Li
  • Owners Override
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I861e807ccb41e3c92ade461509c24c4e5d50681c
Gerrit-Change-Number: 1420228
Gerrit-PatchSet: 2
Gerrit-Owner: Jiaming Li <liji...@google.com>
Gerrit-Reviewer: Adam Barth <aba...@google.com>
Gerrit-Reviewer: Chase Latta <chase...@google.com>
Gerrit-Reviewer: David Fang <fan...@google.com>
Gerrit-Reviewer: Jiaming Li <liji...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Chase Latta <chase...@google.com>
Gerrit-Attention: Jiaming Li <liji...@google.com>
Gerrit-Comment-Date: Tue, 11 Nov 2025 22:51:11 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/75b58fde57a7da27e60be13616e3989530653063-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy

'Jiaming Li (Gerrit)' via owners-override

unread,
Nov 11, 2025, 5:54:00 PM (4 days ago) Nov 11
to Adam Barth, Owners Override, David Fang, Chase Latta, GI Try Builder, CQ Bot
Attention needed from Chase Latta and Owners Override

Jiaming Li voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Chase Latta
  • Owners Override
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I861e807ccb41e3c92ade461509c24c4e5d50681c
Gerrit-Change-Number: 1420228
Gerrit-PatchSet: 2
Gerrit-Owner: Jiaming Li <liji...@google.com>
Gerrit-Reviewer: Adam Barth <aba...@google.com>
Gerrit-Reviewer: Chase Latta <chase...@google.com>
Gerrit-Reviewer: David Fang <fan...@google.com>
Gerrit-Reviewer: Jiaming Li <liji...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Chase Latta <chase...@google.com>
Gerrit-Comment-Date: Tue, 11 Nov 2025 22:53:51 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/3cbb95d002d40a7ccee639f73bd5637444520cc4-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy

'David Fang (Gerrit)' via owners-override

unread,
Nov 11, 2025, 6:02:30 PM (4 days ago) Nov 11
to Jiaming Li, Rundong Du, Adam Barth, Owners Override, Chase Latta, GI Try Builder, CQ Bot
Attention needed from Chase Latta, Jiaming Li and Owners Override

David Fang voted Code-Review+2

Code-Review+2
Open in Gerrit

Related details

Attention is currently required from:
  • Chase Latta
  • Jiaming Li
  • Owners Override
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I861e807ccb41e3c92ade461509c24c4e5d50681c
Gerrit-Change-Number: 1420228
Gerrit-PatchSet: 2
Gerrit-Owner: Jiaming Li <liji...@google.com>
Gerrit-Reviewer: Adam Barth <aba...@google.com>
Gerrit-Reviewer: Chase Latta <chase...@google.com>
Gerrit-Reviewer: David Fang <fan...@google.com>
Gerrit-Reviewer: Jiaming Li <liji...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-CC: Rundong Du <rund...@google.com>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Chase Latta <chase...@google.com>
Gerrit-Attention: Jiaming Li <liji...@google.com>
Gerrit-Comment-Date: Tue, 11 Nov 2025 23:02:23 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/5646ed99cac7ff42ef83c2002cd63e3ac5a32eca-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy

'Chase Latta (Gerrit)' via owners-override

unread,
Nov 11, 2025, 6:30:18 PM (4 days ago) Nov 11
to Jiaming Li, Rundong Du, Adam Barth, Owners Override, David Fang, GI Try Builder, CQ Bot
Attention needed from Jiaming Li and Owners Override

Chase Latta voted Code-Review+2

Code-Review+2
Open in Gerrit

Related details

Attention is currently required from:
  • Jiaming Li
  • Owners Override
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I861e807ccb41e3c92ade461509c24c4e5d50681c
Gerrit-Change-Number: 1420228
Gerrit-PatchSet: 2
Gerrit-Owner: Jiaming Li <liji...@google.com>
Gerrit-Reviewer: Adam Barth <aba...@google.com>
Gerrit-Reviewer: Chase Latta <chase...@google.com>
Gerrit-Reviewer: David Fang <fan...@google.com>
Gerrit-Reviewer: Jiaming Li <liji...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-CC: Rundong Du <rund...@google.com>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Jiaming Li <liji...@google.com>
Gerrit-Comment-Date: Tue, 11 Nov 2025 23:30:11 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/17b24a1855d22ec09cf1eed355568ba032f3b7b5-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy

'CQ Bot (Gerrit)' via owners-override

unread,
Nov 11, 2025, 7:39:52 PM (3 days ago) Nov 11
to Jiaming Li, Chase Latta, Rundong Du, Adam Barth, Owners Override, David Fang, GI Try Builder

CQ Bot submitted the change

Change information

Commit message:
[fx][config] Move the fx config README.md into /tools/devshell
Change-Id: I861e807ccb41e3c92ade461509c24c4e5d50681c
Reviewed-by: Chase Latta <chase...@google.com>
Reviewed-by: David Fang <fan...@google.com>
Owners-Override: Adam Barth <aba...@google.com>
Reviewed-by: Adam Barth <aba...@google.com>
Commit-Queue: Jiaming Li <liji...@google.com>
Files:
  • D .fx/config/README.md
  • M .gitignore
  • M tools/devshell/README.md
  • M tools/devshell/lib/vars.sh
Change size: S
Delta: 4 files changed, 20 insertions(+), 16 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +2 by Adam Barth, +2 by David Fang, +2 by Chase Latta
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I861e807ccb41e3c92ade461509c24c4e5d50681c
Gerrit-Change-Number: 1420228
Gerrit-PatchSet: 3
Gerrit-Owner: Jiaming Li <liji...@google.com>
Gerrit-Reviewer: Adam Barth <aba...@google.com>
Gerrit-Reviewer: Chase Latta <chase...@google.com>
Gerrit-Reviewer: David Fang <fan...@google.com>
Gerrit-Reviewer: Jiaming Li <liji...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-CC: Rundong Du <rund...@google.com>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/1205f10d7261e92e3fee0778e3b59146a98f2ba6-HTML%40fuchsia-review.googlesource.com.
open
diffy
satisfied_requirement

'GI Roller (Gerrit)' via owners-override

unread,
Nov 11, 2025, 7:49:19 PM (3 days ago) Nov 11
to Jiaming Li, CQ Bot, Chase Latta, Rundong Du, Adam Barth, Owners Override, David Fang, GI Try Builder

Message from GI Roller

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I861e807ccb41e3c92ade461509c24c4e5d50681c
Gerrit-Change-Number: 1420228
Gerrit-PatchSet: 3
Gerrit-Owner: Jiaming Li <liji...@google.com>
Gerrit-Reviewer: Adam Barth <aba...@google.com>
Gerrit-Reviewer: Chase Latta <chase...@google.com>
Gerrit-Reviewer: David Fang <fan...@google.com>
Gerrit-Reviewer: Jiaming Li <liji...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-CC: Rundong Du <rund...@google.com>
Gerrit-Comment-Date: Wed, 12 Nov 2025 00:49:16 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/3c7806584951c327c78a2f888cae414bd6b8fc5e-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages