[L] Change in fuchsia/fuchsia[main]: [sched] Delete sched cmdline tool

0 views
Skip to first unread message

'Anirudh Mathukumilli (Gerrit)' via owners-override

unread,
Feb 16, 2024, 1:13:40 AM2/16/24
to Owners Override, Aaron Wood, Corey Tabaka, CQ Bot
Attention needed from Owners Override

Anirudh Mathukumilli added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Anirudh Mathukumilli . resolved

Adding the owners override as it looks like `//src/developer/sched` never correctly set up an OWNERS file. I've already approved this code's deletion with the relevant stakeholders, and they've +2'd the change. I just need the owners override to make gerrit happy.

Open in Gerrit

Related details

Attention is currently required from:
  • Owners Override
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I892e6dfc9936a8c084e114912dbf92347a41ce2a
Gerrit-Change-Number: 991228
Gerrit-PatchSet: 1
Gerrit-Owner: Anirudh Mathukumilli <rudy...@google.com>
Gerrit-Reviewer: Aaron Wood <aaro...@google.com>
Gerrit-Reviewer: Anirudh Mathukumilli <rudy...@google.com>
Gerrit-Reviewer: Corey Tabaka <ei...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Comment-Date: Fri, 16 Feb 2024 06:13:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/5024a4d0757c63dd201cf2d07918300eb0a2fa92-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy

'Anirudh Mathukumilli (Gerrit)' via owners-override

unread,
Feb 16, 2024, 1:13:40 AM2/16/24
to Owners Override
Attention needed from Owners Override

Anirudh Mathukumilli has uploaded the change for review

Anirudh Mathukumilli would like Owners Override to review this change.

Commit message

[sched] Delete sched cmdline tool

This cmdline tool was originally used to set thread priority from the
CLI, but is no longer used, and it uses the legacy ProfileProvider APIs,
so I'm deleting it.
Bug: 323262398
Change-Id: I892e6dfc9936a8c084e114912dbf92347a41ce2a

Change diff


Change information

Files:
  • M build/cpp/hlcpp_visibility.gni
  • M bundles/packages/prod/BUILD.gn
  • M bundles/packages/tests/BUILD.gn
  • D src/developer/sched/BUILD.gn
  • D src/developer/sched/README.md
  • D src/developer/sched/args.cc
  • D src/developer/sched/args.h
  • D src/developer/sched/main.cc
  • D src/developer/sched/meta/sched_tests.cml
  • D src/developer/sched/sched.cc
  • D src/developer/sched/sched.h
  • D src/developer/sched/sched_test.cc
Change size: L
Delta: 12 files changed, 0 insertions(+), 519 deletions(-)
Open in Gerrit

Related details

Attention is currently required from:
  • Owners Override
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I892e6dfc9936a8c084e114912dbf92347a41ce2a
Gerrit-Change-Number: 991228
Gerrit-PatchSet: 1
Gerrit-Owner: Anirudh Mathukumilli <rudy...@google.com>
Gerrit-Reviewer: Aaron Wood <aaro...@google.com>
Gerrit-Reviewer: Anirudh Mathukumilli <rudy...@google.com>
Gerrit-Reviewer: Corey Tabaka <ei...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/5024a4d0757c63dd201cf2d07918300eb0a2fa92-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy

'Adam Barth (Gerrit)' via owners-override

unread,
Feb 16, 2024, 2:19:58 AM2/16/24
to Anirudh Mathukumilli, Owners Override, Aaron Wood, Corey Tabaka, CQ Bot
Attention needed from Anirudh Mathukumilli and Owners Override

Adam Barth voted Owners-Override+1

Owners-Override+1
Open in Gerrit

Related details

Attention is currently required from:
  • Anirudh Mathukumilli
  • Owners Override
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I892e6dfc9936a8c084e114912dbf92347a41ce2a
Gerrit-Change-Number: 991228
Gerrit-PatchSet: 1
Gerrit-Owner: Anirudh Mathukumilli <rudy...@google.com>
Gerrit-Reviewer: Aaron Wood <aaro...@google.com>
Gerrit-Reviewer: Adam Barth <aba...@google.com>
Gerrit-Reviewer: Anirudh Mathukumilli <rudy...@google.com>
Gerrit-Reviewer: Corey Tabaka <ei...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Anirudh Mathukumilli <rudy...@google.com>
Gerrit-Comment-Date: Fri, 16 Feb 2024 07:19:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/2292521ecb1da3f10e18a2d0372574d30e7cc02f-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy

'CQ Bot (Gerrit)' via owners-override

unread,
Feb 16, 2024, 3:27:41 AM2/16/24
to Anirudh Mathukumilli, Auto-Submit, Adam Barth, Owners Override, Aaron Wood, Corey Tabaka

CQ Bot submitted the change

Change information

Commit message:
[sched] Delete sched cmdline tool

This cmdline tool was originally used to set thread priority from the
CLI, but is no longer used, and it uses the legacy ProfileProvider APIs,
so I'm deleting it.
Bug: 323262398
Change-Id: I892e6dfc9936a8c084e114912dbf92347a41ce2a
Reviewed-by: Corey Tabaka <ei...@google.com>
Owners-Override: Adam Barth <aba...@google.com>
Reviewed-by: Aaron Wood <aaro...@google.com>
Fuchsia-Auto-Submit: Anirudh Mathukumilli <rudy...@google.com>
Files:
  • M build/cpp/hlcpp_visibility.gni
  • M bundles/packages/prod/BUILD.gn
  • M bundles/packages/tests/BUILD.gn
  • D src/developer/sched/BUILD.gn
  • D src/developer/sched/README.md
  • D src/developer/sched/args.cc
  • D src/developer/sched/args.h
  • D src/developer/sched/main.cc
  • D src/developer/sched/meta/sched_tests.cml
  • D src/developer/sched/sched.cc
  • D src/developer/sched/sched.h
  • D src/developer/sched/sched_test.cc
Change size: L
Delta: 12 files changed, 0 insertions(+), 519 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +2 by Aaron Wood, +2 by Corey Tabaka
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I892e6dfc9936a8c084e114912dbf92347a41ce2a
Gerrit-Change-Number: 991228
Gerrit-PatchSet: 2
Gerrit-Owner: Anirudh Mathukumilli <rudy...@google.com>
Gerrit-Reviewer: Aaron Wood <aaro...@google.com>
Gerrit-Reviewer: Adam Barth <aba...@google.com>
Gerrit-Reviewer: Anirudh Mathukumilli <rudy...@google.com>
Gerrit-Reviewer: Corey Tabaka <ei...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/5c2363979647f044757cfe1b26bb0db17c15ef20-HTML%40fuchsia-review.googlesource.com.
open
diffy
satisfied_requirement

'GI Roller (Gerrit)' via owners-override

unread,
Feb 16, 2024, 3:29:48 AM2/16/24
to Anirudh Mathukumilli, CQ Bot, Auto-Submit, Adam Barth, Owners Override, Aaron Wood, Corey Tabaka

Message from GI Roller

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I892e6dfc9936a8c084e114912dbf92347a41ce2a
Gerrit-Change-Number: 991228
Gerrit-PatchSet: 2
Gerrit-Owner: Anirudh Mathukumilli <rudy...@google.com>
Gerrit-Reviewer: Aaron Wood <aaro...@google.com>
Gerrit-Reviewer: Adam Barth <aba...@google.com>
Gerrit-Reviewer: Anirudh Mathukumilli <rudy...@google.com>
Gerrit-Reviewer: Auto-Submit <auto-...@fuchsia-infra.iam.gserviceaccount.com>
Gerrit-Reviewer: Corey Tabaka <ei...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Comment-Date: Fri, 16 Feb 2024 08:29:43 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/4b8183d82d3f1200ca777455dc5074a94c755f6f-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages