[L] Change in fuchsia/fuchsia[main]: [fshost] Remove BlockWatcher
2 views
Skip to first unread message
'James Sullivan (Gerrit)' via owners-override
Oct 9, 2024, 6:59:04 PM10/9/24
to Owners Override
Attention needed from Owners Override
James Sullivan has uploaded the change for review![]( "Open in Gerrit")
James Sullivan would like Owners Override to review this change.
Commit message
[fshost] Remove BlockWatcher
Fixed: 371048873
Change-Id: Id9d3f66ff21d860240983eebc726f2f892b3e140
Change diff
Change information
Files:
- M sdk/fidl/fuchsia.fshost/fshost.fidl
- M src/bringup/bin/console/meta/console.shard.cml
- M src/developer/sshd-host/meta/sshd-host.cml
- M src/developer/sshd-host/meta/sshd-host.core_shard.cml
- M src/developer/sshd-host/meta/sshd.cml
- M src/devices/testing/driver-integration-test-shim/fixture.cc
- M src/firmware/fastboot-tcp/meta/fastboot_tcp.cml
- M src/firmware/fastboot-tcp/meta/fastboot_tcp.core_shard.cml
- M src/firmware/fastboot-usb/meta/fastboot_usb.cml
- M src/firmware/fastboot-usb/meta/fastboot_usb.core_shard.cml
- M src/storage/fshost/BUILD.gn
- M src/storage/fshost/integration/src/fshost_builder.rs
- M src/storage/fshost/integration/tests/fshost_integration_test.rs
- M src/storage/fshost/meta/base_fshost.cml
- M src/storage/fshost/meta/fshost.bootstrap_shard.cml
- M src/storage/fshost/src/main.rs
- M src/storage/fshost/src/service.rs
- M src/storage/fshost/src/watcher.rs
- M src/sys/core/meta/core.root_shard.cml
Change size: L
Delta: 19 files changed, 32 insertions(+), 311 deletions(-)
Related details
Attention is currently required from:
- Owners Override
Submit Requirements:
API-Review
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/eb3e588a99bb4d8374b1f16f601a34b11e542b57-HTML%40fuchsia-review.googlesource.com.
'James Sullivan (Gerrit)' via owners-override
Oct 9, 2024, 6:59:07 PM10/9/24
to Owners Override, Chris Suter, Stephen Demos, CQ Bot, Fuchsia Try Builder, fuchsia-c...@fuchsia-infra.iam.gserviceaccount.com
Attention needed from Owners Override
James Sullivan voted Fuchsia-Auto-Submit+1![]( "Open in Gerrit")
| Fuchsia-Auto-Submit | +1 |
Related details
Attention is currently required from:
- Owners Override
Submit Requirements:
API-Review
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/eb3e588a99bb4d8374b1f16f601a34b11e542b57-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'Adam Barth (Gerrit)' via owners-override
Oct 9, 2024, 11:22:46 PM10/9/24
to James Sullivan, Owners Override, Chris Suter, Stephen Demos, CQ Bot, Fuchsia Try Builder, fuchsia-c...@fuchsia-infra.iam.gserviceaccount.com
Attention needed from James Sullivan and Owners Override
Adam Barth voted Owners-Override+1![]( "Open in Gerrit")
Attention is currently required from:
- James Sullivan
- Owners Override
Submit Requirements:
API-Review
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/50191b431cd30e6e16d777254d555974d4b20e95-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'CQ Bot (Gerrit)' via owners-override
Oct 10, 2024, 1:38:07 AM10/10/24
to James Sullivan, Auto-Submit, Adam Barth, Owners Override, Chris Suter, Stephen Demos, Fuchsia Try Builder, fuchsia-c...@fuchsia-infra.iam.gserviceaccount.com
CQ Bot submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
10 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: src/storage/fshost/meta/fshost.bootstrap_shard.cml
Insertions: 5, Deletions: 8.
The diff is too large to show. Please review the diff.
```
```
The name of the file: src/storage/fshost/src/watcher.rs
Insertions: 1, Deletions: 2.
The diff is too large to show. Please review the diff.
```
Change information
Commit message:
[fshost] Remove BlockWatcher
Fixed: 371048873
Change-Id: Id9d3f66ff21d860240983eebc726f2f892b3e140
Reviewed-by: Stephen Demos <sde...@google.com>
Commit-Queue: Auto-Submit <auto-...@fuchsia-infra.iam.gserviceaccount.com>
Fuchsia-Auto-Submit: James Sullivan <jfsu...@google.com>
API-Review: Chris Suter <csu...@google.com>
Owners-Override: Adam Barth <aba...@google.com>
Files:
- M sdk/fidl/fuchsia.fshost/fshost.fidl
- M src/bringup/bin/console/meta/console.shard.cml
- M src/developer/sshd-host/meta/sshd-host.cml
- M src/developer/sshd-host/meta/sshd-host.core_shard.cml
- M src/developer/sshd-host/meta/sshd.cml
- M src/devices/testing/driver-integration-test-shim/fixture.cc
- M src/firmware/fastboot-tcp/meta/fastboot_tcp.cml
- M src/firmware/fastboot-tcp/meta/fastboot_tcp.core_shard.cml
- M src/firmware/fastboot-usb/meta/fastboot_usb.cml
- M src/firmware/fastboot-usb/meta/fastboot_usb.core_shard.cml
- M src/storage/fshost/BUILD.gn
- M src/storage/fshost/integration/src/fshost_builder.rs
- M src/storage/fshost/integration/tests/fshost_integration_test.rs
- M src/storage/fshost/meta/base_fshost.cml
- M src/storage/fshost/meta/fshost.bootstrap_shard.cml
- M src/storage/fshost/src/main.rs
- M src/storage/fshost/src/service.rs
- M src/storage/fshost/src/watcher.rs
- M src/sys/core/meta/core.root_shard.cml
Change size: L
Delta: 19 files changed, 32 insertions(+), 311 deletions(-)
Branch: refs/heads/main
Submit Requirements:
API-Review: +1 by Chris Suter
Code-Review: +2 by Stephen Demos
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/6a3bb760c2dc6f4ebcf2a6d91fffa5ecce5d159e-HTML%40fuchsia-review.googlesource.com.To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'GI Roller (Gerrit)' via owners-override
Oct 10, 2024, 1:45:00 AM10/10/24
to James Sullivan, CQ Bot, Auto-Submit, Adam Barth, Owners Override, Chris Suter, Stephen Demos, Fuchsia Try Builder, fuchsia-c...@fuchsia-infra.iam.gserviceaccount.com
Message from GI Roller![]( "Open in Gerrit")
Change has been successfully rolled: http://go/roll-cl/4186975139969c1a99b85aeebfb27c8f490b80eb
Related details
Attention set is empty
Submit Requirements:
API-Review
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/a41e66c112ea05e3cb8162b6e68b7e473e257268-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
Reply all
Reply to author
Forward
0 new messages