Groups keyboard shortcuts have been updated
Dismiss
See shortcuts

[M] Change in fuchsia/fuchsia[main]: [role_manager] Remove obsolete profile provider routes

0 views
Skip to first unread message

'Anirudh Mathukumilli (Gerrit)' via owners-override

unread,
Mar 26, 2024, 3:42:04 PM3/26/24
to Owners Override
Attention needed from Owners Override

Anirudh Mathukumilli has uploaded the change for review

Anirudh Mathukumilli would like Owners Override to review this change.

Commit message

[role_manager] Remove obsolete profile provider routes

All users of fuchsia.scheduler.ProfileProvider have been migrated to
fuchsia.scheduler.RoleManager except for netstack2, so remove all the
other routes.

I also needed to prserve the console launcher routes as the svchost
bringup tests are run via the console.
Bug: 323262398
Change-Id: I12b81e61bfe8d29f786479cf8dec3d317c6b52eb

Change diff


Change information

Files:
  • M sdk/ctf/test_realm/meta/test-collection.shard.cml
  • M src/chromium/web_runner_tests/meta/web_runner_integration_tests.cml
  • M src/connectivity/network/meta/common.shard.cml
  • M src/devices/bin/driver_framework/meta/driver_framework.shard.cml
  • M src/recovery/system/meta/tests/system_recovery_fdr_test.cml
  • M src/security/tests/pkg_test/tests/access_ota_blob_as_executable/meta/access_ota_blob_as_executable.cml
  • M src/security/tests/pkg_test/tests/bad_signature_update/meta/bad_signature_update.cml
  • M src/sys/bootstrap/meta/bootstrap.cml
  • M src/sys/core/meta/core.cml
  • M src/sys/testing/meta/chromium_system_test_realm.shard.cml
  • M src/sys/testing/meta/chromium_test_realm.shard.cml
Change size: M
Delta: 11 files changed, 19 insertions(+), 44 deletions(-)
Open in Gerrit

Related details

Attention is currently required from:
  • Owners Override
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I12b81e61bfe8d29f786479cf8dec3d317c6b52eb
Gerrit-Change-Number: 1015572
Gerrit-PatchSet: 6
Gerrit-Owner: Anirudh Mathukumilli <rudy...@google.com>
Gerrit-Reviewer: Anirudh Mathukumilli <rudy...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/fdd3a42298a4c5acb937719a412448709dac2609-HTML%40fuchsia-review.googlesource.com.
unsatisfied_requirement
open
diffy

'Anirudh Mathukumilli (Gerrit)' via owners-override

unread,
Mar 26, 2024, 3:42:06 PM3/26/24
to Owners Override, CQ Bot
Attention needed from Owners Override

Anirudh Mathukumilli added 1 comment

Patchset-level comments
File-level comment, Patchset 6 (Latest):
Anirudh Mathukumilli . resolved

Adding the owners override as this change spans many OWNERS domains but is purely mechanical.

Open in Gerrit

Related details

Attention is currently required from:
  • Owners Override
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I12b81e61bfe8d29f786479cf8dec3d317c6b52eb
Gerrit-Change-Number: 1015572
Gerrit-PatchSet: 6
Gerrit-Owner: Anirudh Mathukumilli <rudy...@google.com>
Gerrit-Reviewer: Anirudh Mathukumilli <rudy...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Comment-Date: Tue, 26 Mar 2024 19:42:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/fdd3a42298a4c5acb937719a412448709dac2609-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
unsatisfied_requirement
open
diffy

'Adam Barth (Gerrit)' via owners-override

unread,
Mar 26, 2024, 3:43:53 PM3/26/24
to Anirudh Mathukumilli, Corey Tabaka, Owners Override, CQ Bot
Attention needed from Anirudh Mathukumilli, Corey Tabaka and Owners Override

Adam Barth voted Owners-Override+1

Owners-Override+1
Open in Gerrit

Related details

Attention is currently required from:
  • Anirudh Mathukumilli
  • Corey Tabaka
  • Owners Override
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I12b81e61bfe8d29f786479cf8dec3d317c6b52eb
Gerrit-Change-Number: 1015572
Gerrit-PatchSet: 6
Gerrit-Owner: Anirudh Mathukumilli <rudy...@google.com>
Gerrit-Reviewer: Adam Barth <aba...@google.com>
Gerrit-Reviewer: Anirudh Mathukumilli <rudy...@google.com>
Gerrit-Reviewer: Corey Tabaka <ei...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Anirudh Mathukumilli <rudy...@google.com>
Gerrit-Attention: Corey Tabaka <ei...@google.com>
Gerrit-Comment-Date: Tue, 26 Mar 2024 19:43:46 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/306d51d50a3570798af0171be23b3bdf220a71fc-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
unsatisfied_requirement
open
diffy

'Corey Tabaka (Gerrit)' via owners-override

unread,
Mar 26, 2024, 4:07:48 PM3/26/24
to Anirudh Mathukumilli, Adam Barth, Owners Override, CQ Bot
Attention needed from Anirudh Mathukumilli and Owners Override

Corey Tabaka voted Code-Review+2

Code-Review+2
Open in Gerrit

Related details

Attention is currently required from:
  • Anirudh Mathukumilli
  • Owners Override
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I12b81e61bfe8d29f786479cf8dec3d317c6b52eb
Gerrit-Change-Number: 1015572
Gerrit-PatchSet: 6
Gerrit-Owner: Anirudh Mathukumilli <rudy...@google.com>
Gerrit-Reviewer: Adam Barth <aba...@google.com>
Gerrit-Reviewer: Anirudh Mathukumilli <rudy...@google.com>
Gerrit-Reviewer: Corey Tabaka <ei...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Anirudh Mathukumilli <rudy...@google.com>
Gerrit-Comment-Date: Tue, 26 Mar 2024 20:07:41 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/27eadfda3a40b88bf977d192ab57a7efb1f9dd4d-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy

'Anirudh Mathukumilli (Gerrit)' via owners-override

unread,
Mar 26, 2024, 5:24:17 PM3/26/24
to Corey Tabaka, Adam Barth, Owners Override, CQ Bot
Attention needed from Owners Override

Anirudh Mathukumilli voted

Commit-Queue+2
Fuchsia-Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Owners Override
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I12b81e61bfe8d29f786479cf8dec3d317c6b52eb
Gerrit-Change-Number: 1015572
Gerrit-PatchSet: 6
Gerrit-Owner: Anirudh Mathukumilli <rudy...@google.com>
Gerrit-Reviewer: Adam Barth <aba...@google.com>
Gerrit-Reviewer: Anirudh Mathukumilli <rudy...@google.com>
Gerrit-Reviewer: Corey Tabaka <ei...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Comment-Date: Tue, 26 Mar 2024 21:24:13 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/540c9a678f77bad4df06dad73ef0421ff8fba868-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy

'CQ Bot (Gerrit)' via owners-override

unread,
Mar 26, 2024, 6:03:55 PM3/26/24
to Anirudh Mathukumilli, Corey Tabaka, Adam Barth, Owners Override

CQ Bot submitted the change

Change information

Commit message:
[role_manager] Remove obsolete profile provider routes

All users of fuchsia.scheduler.ProfileProvider have been migrated to
fuchsia.scheduler.RoleManager except for netstack2, so remove all the
other routes.

I also needed to prserve the console launcher routes as the svchost
bringup tests are run via the console.
Bug: 323262398
Change-Id: I12b81e61bfe8d29f786479cf8dec3d317c6b52eb
Commit-Queue: Anirudh Mathukumilli <rudy...@google.com>
Owners-Override: Adam Barth <aba...@google.com>
Reviewed-by: Corey Tabaka <ei...@google.com>
Fuchsia-Auto-Submit: Anirudh Mathukumilli <rudy...@google.com>
Files:
  • M sdk/ctf/test_realm/meta/test-collection.shard.cml
  • M src/chromium/web_runner_tests/meta/web_runner_integration_tests.cml
  • M src/connectivity/network/meta/common.shard.cml
  • M src/devices/bin/driver_framework/meta/driver_framework.shard.cml
  • M src/recovery/system/meta/tests/system_recovery_fdr_test.cml
  • M src/security/tests/pkg_test/tests/access_ota_blob_as_executable/meta/access_ota_blob_as_executable.cml
  • M src/security/tests/pkg_test/tests/bad_signature_update/meta/bad_signature_update.cml
  • M src/sys/bootstrap/meta/bootstrap.cml
  • M src/sys/core/meta/core.cml
  • M src/sys/testing/meta/chromium_system_test_realm.shard.cml
  • M src/sys/testing/meta/chromium_test_realm.shard.cml
Change size: M
Delta: 11 files changed, 19 insertions(+), 44 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +2 by Corey Tabaka
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I12b81e61bfe8d29f786479cf8dec3d317c6b52eb
Gerrit-Change-Number: 1015572
Gerrit-PatchSet: 7
Gerrit-Owner: Anirudh Mathukumilli <rudy...@google.com>
Gerrit-Reviewer: Adam Barth <aba...@google.com>
Gerrit-Reviewer: Anirudh Mathukumilli <rudy...@google.com>
Gerrit-Reviewer: Corey Tabaka <ei...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/5bf5d6bb60d3bc201bdf338648121675820f26fc-HTML%40fuchsia-review.googlesource.com.
open
diffy
satisfied_requirement

'GI Roller (Gerrit)' via owners-override

unread,
Mar 26, 2024, 6:06:57 PM3/26/24
to Anirudh Mathukumilli, CQ Bot, Corey Tabaka, Adam Barth, Owners Override

Message from GI Roller

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I12b81e61bfe8d29f786479cf8dec3d317c6b52eb
Gerrit-Change-Number: 1015572
Gerrit-PatchSet: 7
Gerrit-Owner: Anirudh Mathukumilli <rudy...@google.com>
Gerrit-Reviewer: Adam Barth <aba...@google.com>
Gerrit-Reviewer: Anirudh Mathukumilli <rudy...@google.com>
Gerrit-Reviewer: Corey Tabaka <ei...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Comment-Date: Tue, 26 Mar 2024 22:06:51 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/10059f8dde1f6b3ea7aacae66a014be42307b262-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages