[XL] Change in fuchsia/fuchsia[main]: [fidl-format] Do not outdent multi-digit ordinals

0 views
Skip to first unread message

'Mitchell Kember (Gerrit)' via owners-override

unread,
Mar 28, 2024, 7:31:54 PMMar 28
to Clayton Wilkinson, Owners Override, Yifei Teng
Attention needed from Clayton Wilkinson and Owners Override

Mitchell Kember has uploaded the change for review

Mitchell Kember would like Clayton Wilkinson and Owners Override to review this change.

Commit message

[fidl-format] Do not outdent multi-digit ordinals

This changes fidl-format to indent all table/union ordinals to the same
column. Previously, it outdented ordinals with multiple digits to make
the colons line up. This was unexpected for many users, especially when
the table fields are far apart and it just looks like a formatting bug.
Bug: 327031370
Change-Id: Id891134d1d9807da8de52f8704c403526ba3382e

Change diff


Change information

Files:
  • M examples/fidl/new/key_value_store/use_generic_values/fidl/key_value_store.test.fidl
  • M sdk/fidl/fuchsia.accessibility.semantics/node.fidl
  • M sdk/fidl/fuchsia.audio.device/registry.fidl
  • M sdk/fidl/fuchsia.bluetooth.avrcp/types.fidl
  • M sdk/fidl/fuchsia.bluetooth.bredr/sco.fidl
  • M sdk/fidl/fuchsia.bluetooth.bredr/service.fidl
  • M sdk/fidl/fuchsia.bluetooth.map/types.fidl
  • M sdk/fidl/fuchsia.bluetooth.sys/peer.fidl
  • M sdk/fidl/fuchsia.component.config/value.fidl
  • M sdk/fidl/fuchsia.component.decl/capability.fidl
  • M sdk/fidl/fuchsia.component.decl/component.fidl
  • M sdk/fidl/fuchsia.component.decl/config.fidl
  • M sdk/fidl/fuchsia.component.decl/offer.fidl
  • M sdk/fidl/fuchsia.component.internal/config.fidl
  • M sdk/fidl/fuchsia.component.runner/component_runner.fidl
  • M sdk/fidl/fuchsia.component/events.fidl
  • M sdk/fidl/fuchsia.driver.test/realm.fidl
  • M sdk/fidl/fuchsia.hardware.audio.signalprocessing/dynamics.fidl
  • M sdk/fidl/fuchsia.hardware.audio/stream_config.fidl
  • M sdk/fidl/fuchsia.hardware.network.driver/network-device.fidl
  • M sdk/fidl/fuchsia.hardware.network/device.fidl
  • M sdk/fidl/fuchsia.hardware.network/history.fidl
  • M sdk/fidl/fuchsia.hardware.platform.bus/platform-bus.fidl
  • M sdk/fidl/fuchsia.hwinfo/hwinfo.fidl
  • M sdk/fidl/fuchsia.identity.ctap/make_credential.fidl
  • M sdk/fidl/fuchsia.intl/time_zones.fidl
  • M sdk/fidl/fuchsia.io.test/io.test.fidl
  • M sdk/fidl/fuchsia.io/node2.fidl
  • M sdk/fidl/fuchsia.kernel/kernel-stats.fidl
  • M sdk/fidl/fuchsia.lowpan.device/counters.fidl
  • M sdk/fidl/fuchsia.lowpan.driver/driver.fidl
  • M sdk/fidl/fuchsia.lowpan.experimental/telemetry.fidl
  • M sdk/fidl/fuchsia.lowpan.test/device_test.fidl
  • M sdk/fidl/fuchsia.media/stream_processor.fidl
  • M sdk/fidl/fuchsia.mediacodec/codec_factory.fidl
  • M sdk/fidl/fuchsia.modular.session/modular_config.fidl
  • M sdk/fidl/fuchsia.modular/module_data.fidl
  • M sdk/fidl/fuchsia.net.dhcp/options.fidl
  • M sdk/fidl/fuchsia.net.mdns/common.fidl
  • M sdk/fidl/fuchsia.posix.socket/socket.fidl
  • M sdk/fidl/fuchsia.power.battery/battery.fidl
  • M sdk/fidl/fuchsia.sysmem2/constraints.fidl
  • M sdk/fidl/fuchsia.terminal/profiles.fidl
  • M sdk/fidl/fuchsia.ui.gfx/commands.fidl
  • M sdk/fidl/fuchsia.ui.gfx/events.fidl
  • M sdk/fidl/fuchsia.ui.gfx/resources.fidl
  • M sdk/fidl/fuchsia.ui.gfx/types.fidl
  • M sdk/fidl/fuchsia.ui.pointerinjector/config.fidl
  • M sdk/fidl/fuchsia.ui.pointerinjector/event.fidl
  • M sdk/fidl/fuchsia.virtualization/guest_config.fidl
  • M sdk/fidl/fuchsia.virtualization/guest_manager.fidl
  • M sdk/fidl/fuchsia.web/context.fidl
  • M sdk/fidl/fuchsia.wlan.softmac/softmac.fidl
  • M src/developer/ffx/fidl/target.fidl
  • M src/devices/tools/fidlgen_banjo/tests/fidl/types.test.fidl
  • M src/diagnostics/validator/inspect/fidl/inspect_puppet.fidl
  • M src/lib/fidl_codec/testdata/types.test.fidl
  • M src/storage/ext4/server/fidl/ext4_readonly.fidl
  • M src/sys/fuzzing/fidl/options.fidl
  • M src/sys/pkg/fidl/fuchsia.update.installer/progress.fidl
  • M src/tests/benchmarks/fidl/benchmark_suite/table.gen.test.fidl
  • M src/tests/benchmarks/fidl/benchmark_suite/table_reserved.gen.test.fidl
  • M src/tests/benchmarks/fidl/benchmark_suite/union.gen.test.fidl
  • M src/tests/fidl/compatibility/fidl/compatibility_service.test.fidl
  • M tools/fidl/fidlc/src/span_sequence.cc
  • M tools/fidl/fidlc/src/span_sequence.h
  • M tools/fidl/fidlc/src/span_sequence_tree_visitor.cc
  • M tools/fidl/fidlc/testdata/table.test.fidl
  • M tools/fidl/fidlc/tests/fidl/bad/fi-0092.test.fidl
  • M tools/fidl/fidlc/tests/fidl/bad/fi-0093.test.fidl
  • M tools/fidl/fidlc/tests/fidl/good/fi-0092.test.fidl
  • M tools/fidl/fidlc/tests/fidl/good/fi-0093.test.fidl
  • M tools/fidl/fidlc/tests/formatter_tests.cc
  • M tools/fidl/measure-tape/testdata/measuretape.test.fidl
Change size: XL
Delta: 74 files changed, 1241 insertions(+), 1299 deletions(-)
Open in Gerrit

Related details

Attention is currently required from:
  • Clayton Wilkinson
  • Owners Override
Submit Requirements:
  • requirement is not satisfiedAPI-Review
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: Id891134d1d9807da8de52f8704c403526ba3382e
Gerrit-Change-Number: 1017261
Gerrit-PatchSet: 1
Gerrit-Owner: Mitchell Kember <mke...@google.com>
Gerrit-Reviewer: Clayton Wilkinson <wilkin...@google.com>
Gerrit-Reviewer: Mitchell Kember <mke...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-CC: Yifei Teng <yif...@google.com>
Gerrit-Attention: Clayton Wilkinson <wilkin...@google.com>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/1245aa411c96c32bf688b65f8e87837bc4ac4829-HTML%40fuchsia-review.googlesource.com.
unsatisfied_requirement
open
diffy

'Mitchell Kember (Gerrit)' via owners-override

unread,
Mar 28, 2024, 7:31:57 PMMar 28
to Clayton Wilkinson, Owners Override, Yifei Teng
Attention needed from Clayton Wilkinson and Owners Override

Mitchell Kember voted

Commit-Queue+1
Fuchsia-Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Clayton Wilkinson
  • Owners Override
Submit Requirements:
  • requirement is not satisfiedAPI-Review
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: Id891134d1d9807da8de52f8704c403526ba3382e
Gerrit-Change-Number: 1017261
Gerrit-PatchSet: 1
Gerrit-Owner: Mitchell Kember <mke...@google.com>
Gerrit-Reviewer: Clayton Wilkinson <wilkin...@google.com>
Gerrit-Reviewer: Mitchell Kember <mke...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-CC: Yifei Teng <yif...@google.com>
Gerrit-Attention: Clayton Wilkinson <wilkin...@google.com>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Comment-Date: Thu, 28 Mar 2024 23:31:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/1245aa411c96c32bf688b65f8e87837bc4ac4829-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
unsatisfied_requirement
open
diffy

'Yifei Teng (Gerrit)' via owners-override

unread,
Mar 28, 2024, 7:42:58 PMMar 28
to Mitchell Kember, fuchsia-c...@fuchsia-infra.iam.gserviceaccount.com, CQ Bot, Clayton Wilkinson, Owners Override
Attention needed from Clayton Wilkinson, Mitchell Kember and Owners Override

Yifei Teng added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Yifei Teng . resolved

Thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Clayton Wilkinson
  • Mitchell Kember
  • Owners Override
Submit Requirements:
  • requirement is not satisfiedAPI-Review
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: Id891134d1d9807da8de52f8704c403526ba3382e
Gerrit-Change-Number: 1017261
Gerrit-PatchSet: 1
Gerrit-Owner: Mitchell Kember <mke...@google.com>
Gerrit-Reviewer: Clayton Wilkinson <wilkin...@google.com>
Gerrit-Reviewer: Mitchell Kember <mke...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Clayton Wilkinson <wilkin...@google.com>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Mitchell Kember <mke...@google.com>
Gerrit-Comment-Date: Thu, 28 Mar 2024 23:42:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/c20418031e10c6f9240ea883717a352e8ba3c62d-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
unsatisfied_requirement
open
diffy

'Mitchell Kember (Gerrit)' via owners-override

unread,
Mar 29, 2024, 2:18:36 PMMar 29
to Ian McKellar, fuchsia-c...@fuchsia-infra.iam.gserviceaccount.com, CQ Bot, Clayton Wilkinson, Owners Override, Yifei Teng
Attention needed from Clayton Wilkinson, Ian McKellar and Owners Override

Mitchell Kember voted Fuchsia-Auto-Submit+1

Fuchsia-Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Clayton Wilkinson
  • Ian McKellar
  • Owners Override
Submit Requirements:
  • requirement is not satisfiedAPI-Review
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: Id891134d1d9807da8de52f8704c403526ba3382e
Gerrit-Change-Number: 1017261
Gerrit-PatchSet: 2
Gerrit-Owner: Mitchell Kember <mke...@google.com>
Gerrit-Reviewer: Clayton Wilkinson <wilkin...@google.com>
Gerrit-Reviewer: Ian McKellar <ian...@google.com>
Gerrit-Reviewer: Mitchell Kember <mke...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-CC: Yifei Teng <yif...@google.com>
Gerrit-Attention: Clayton Wilkinson <wilkin...@google.com>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Ian McKellar <ian...@google.com>
Gerrit-Comment-Date: Fri, 29 Mar 2024 18:18:30 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/06ad61413dc707719b38d639bbde1a37a384cedd-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
unsatisfied_requirement
open
diffy

'Clayton Wilkinson (Gerrit)' via owners-override

unread,
Mar 29, 2024, 2:31:30 PMMar 29
to Mitchell Kember, Ian McKellar, fuchsia-c...@fuchsia-infra.iam.gserviceaccount.com, CQ Bot, Owners Override, Yifei Teng
Attention needed from Ian McKellar, Mitchell Kember and Owners Override

Clayton Wilkinson voted Code-Review+2

Code-Review+2
Open in Gerrit

Related details

Attention is currently required from:
  • Ian McKellar
  • Mitchell Kember
  • Owners Override
Submit Requirements:
    • requirement is not satisfiedAPI-Review
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: fuchsia
    Gerrit-Branch: main
    Gerrit-Change-Id: Id891134d1d9807da8de52f8704c403526ba3382e
    Gerrit-Change-Number: 1017261
    Gerrit-PatchSet: 2
    Gerrit-Owner: Mitchell Kember <mke...@google.com>
    Gerrit-Reviewer: Clayton Wilkinson <wilkin...@google.com>
    Gerrit-Reviewer: Ian McKellar <ian...@google.com>
    Gerrit-Reviewer: Mitchell Kember <mke...@google.com>
    Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
    Gerrit-CC: Yifei Teng <yif...@google.com>
    Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
    Gerrit-Attention: Mitchell Kember <mke...@google.com>
    Gerrit-Attention: Ian McKellar <ian...@google.com>
    Gerrit-Comment-Date: Fri, 29 Mar 2024 18:31:24 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes

    --
    You received this message because you are subscribed to the Google Groups "owners-override" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
    To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/8618c0aca3d197845c5866704009d85906444202-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
    unsatisfied_requirement
    satisfied_requirement
    open
    diffy

    'Clayton Wilkinson (Gerrit)' via owners-override

    unread,
    Mar 29, 2024, 2:36:10 PMMar 29
    to Mitchell Kember, Ian McKellar, fuchsia-c...@fuchsia-infra.iam.gserviceaccount.com, CQ Bot, Owners Override, Yifei Teng
    Attention needed from Ian McKellar, Mitchell Kember and Owners Override

    Clayton Wilkinson voted API-Review+1

    API-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Ian McKellar
    • Mitchell Kember
    • Owners Override
    Submit Requirements:
    • requirement satisfiedAPI-Review
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: fuchsia
    Gerrit-Branch: main
    Gerrit-Change-Id: Id891134d1d9807da8de52f8704c403526ba3382e
    Gerrit-Change-Number: 1017261
    Gerrit-PatchSet: 2
    Gerrit-Owner: Mitchell Kember <mke...@google.com>
    Gerrit-Reviewer: Clayton Wilkinson <wilkin...@google.com>
    Gerrit-Reviewer: Ian McKellar <ian...@google.com>
    Gerrit-Reviewer: Mitchell Kember <mke...@google.com>
    Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
    Gerrit-CC: Yifei Teng <yif...@google.com>
    Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
    Gerrit-Attention: Mitchell Kember <mke...@google.com>
    Gerrit-Attention: Ian McKellar <ian...@google.com>
    Gerrit-Comment-Date: Fri, 29 Mar 2024 18:36:05 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes

    --
    You received this message because you are subscribed to the Google Groups "owners-override" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
    To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/49d736ccc850e13aa7b02826885e5900063bcd67-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
    satisfied_requirement
    open
    diffy

    'Hunter Freyer (Gerrit)' via owners-override

    unread,
    Mar 29, 2024, 3:59:49 PMMar 29
    to Mitchell Kember, Clayton Wilkinson, Ian McKellar, fuchsia-c...@fuchsia-infra.iam.gserviceaccount.com, CQ Bot, Owners Override, Yifei Teng
    Attention needed from Ian McKellar, Mitchell Kember and Owners Override

    Hunter Freyer voted Owners-Override+1

    Owners-Override+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Ian McKellar
    • Mitchell Kember
    • Owners Override
    Submit Requirements:
    • requirement satisfiedAPI-Review
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: fuchsia
    Gerrit-Branch: main
    Gerrit-Change-Id: Id891134d1d9807da8de52f8704c403526ba3382e
    Gerrit-Change-Number: 1017261
    Gerrit-PatchSet: 3
    Gerrit-Owner: Mitchell Kember <mke...@google.com>
    Gerrit-Reviewer: Clayton Wilkinson <wilkin...@google.com>
    Gerrit-Reviewer: Hunter Freyer <hjfr...@google.com>
    Gerrit-Reviewer: Ian McKellar <ian...@google.com>
    Gerrit-Reviewer: Mitchell Kember <mke...@google.com>
    Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
    Gerrit-CC: Yifei Teng <yif...@google.com>
    Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
    Gerrit-Attention: Mitchell Kember <mke...@google.com>
    Gerrit-Attention: Ian McKellar <ian...@google.com>
    Gerrit-Comment-Date: Fri, 29 Mar 2024 19:59:44 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes

    --
    You received this message because you are subscribed to the Google Groups "owners-override" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
    To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/147eb813df6ba0fc3d670bcd01ff0578555f7e41-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
    satisfied_requirement
    open
    diffy

    'CQ Bot (Gerrit)' via owners-override

    unread,
    Mar 29, 2024, 4:37:22 PMMar 29
    to Mitchell Kember, Auto-Submit, Hunter Freyer, Clayton Wilkinson, Ian McKellar, fuchsia-c...@fuchsia-infra.iam.gserviceaccount.com, Owners Override, Yifei Teng

    CQ Bot submitted the change with unreviewed changes

    Unreviewed changes

    2 is the latest approved patch-set.
    The change was submitted with unreviewed changes in the following files:

    ```
    The name of the file: scripts/shac/fidl.star
    Insertions: 3, Deletions: 1.

    The diff is too large to show. Please review the diff.
    ```

    Change information

    Commit message:
    [fidl-format] Do not outdent multi-digit ordinals

    This changes fidl-format to indent all table/union ordinals to the same
    column. Previously, it outdented ordinals with multiple digits to make
    the colons line up. This was unexpected for many users, especially when
    the table fields are far apart and it just looks like a formatting bug.
    Bug: 327031370
    Change-Id: Id891134d1d9807da8de52f8704c403526ba3382e
    Fuchsia-Auto-Submit: Mitchell Kember <mke...@google.com>
    Owners-Override: Hunter Freyer <hjfr...@google.com>
    Reviewed-by: Clayton Wilkinson <wilkin...@google.com>
    API-Review: Clayton Wilkinson <wilkin...@google.com>
    Files:
    • M examples/fidl/new/key_value_store/use_generic_values/fidl/key_value_store.test.fidl
    • M scripts/shac/fidl.star
    • M tools/fidl/fidlc/goldens/table.index.json.golden
    • M tools/fidl/fidlc/goldens/table.json.golden
    • M tools/fidl/fidlc/src/span_sequence.cc
    • M tools/fidl/fidlc/src/span_sequence.h
    • M tools/fidl/fidlc/src/span_sequence_tree_visitor.cc
    • M tools/fidl/fidlc/testdata/table.test.fidl
    • M tools/fidl/fidlc/tests/fidl/bad/fi-0092.test.fidl
    • M tools/fidl/fidlc/tests/fidl/bad/fi-0093.test.fidl
    • M tools/fidl/fidlc/tests/fidl/good/fi-0092.test.fidl
    • M tools/fidl/fidlc/tests/fidl/good/fi-0093.test.fidl
    • M tools/fidl/fidlc/tests/formatter_tests.cc
    • M tools/fidl/measure-tape/testdata/measuretape.test.fidl
      Change size: XL
      Delta: 77 files changed, 1411 insertions(+), 1467 deletions(-)
      Branch: refs/heads/main
      Submit Requirements:
      • requirement satisfiedAPI-Review: +1 by Clayton Wilkinson
      • requirement satisfiedCode-Review: +2 by Clayton Wilkinson
      Open in Gerrit
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: merged
      Gerrit-Project: fuchsia
      Gerrit-Branch: main
      Gerrit-Change-Id: Id891134d1d9807da8de52f8704c403526ba3382e
      Gerrit-Change-Number: 1017261
      Gerrit-PatchSet: 4
      Gerrit-Owner: Mitchell Kember <mke...@google.com>
      Gerrit-Reviewer: Auto-Submit <auto-...@fuchsia-infra.iam.gserviceaccount.com>
      Gerrit-Reviewer: Clayton Wilkinson <wilkin...@google.com>
      Gerrit-Reviewer: Hunter Freyer <hjfr...@google.com>
      Gerrit-Reviewer: Ian McKellar <ian...@google.com>
      Gerrit-Reviewer: Mitchell Kember <mke...@google.com>
      Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>

      --
      You received this message because you are subscribed to the Google Groups "owners-override" group.
      To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
      To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/0ec64abf879fd54dd57dda55dd9d30668f4757e8-HTML%40fuchsia-review.googlesource.com.
      open
      diffy
      satisfied_requirement

      'GI Roller (Gerrit)' via owners-override

      unread,
      Mar 29, 2024, 4:41:34 PMMar 29
      to CQ Bot, Mitchell Kember, Auto-Submit, Hunter Freyer, Clayton Wilkinson, Ian McKellar, fuchsia-c...@fuchsia-infra.iam.gserviceaccount.com, Owners Override, Yifei Teng

      Message from GI Roller

      Open in Gerrit

      Related details

      Attention set is empty
      Submit Requirements:
      • requirement satisfiedAPI-Review
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: fuchsia
      Gerrit-Branch: main
      Gerrit-Change-Id: Id891134d1d9807da8de52f8704c403526ba3382e
      Gerrit-Change-Number: 1017261
      Gerrit-PatchSet: 4
      Gerrit-Owner: Mitchell Kember <mke...@google.com>
      Gerrit-Reviewer: Auto-Submit <auto-...@fuchsia-infra.iam.gserviceaccount.com>
      Gerrit-Reviewer: Clayton Wilkinson <wilkin...@google.com>
      Gerrit-Reviewer: Hunter Freyer <hjfr...@google.com>
      Gerrit-Reviewer: Ian McKellar <ian...@google.com>
      Gerrit-Reviewer: Mitchell Kember <mke...@google.com>
      Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
      Gerrit-Comment-Date: Fri, 29 Mar 2024 20:41:27 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: No

      --
      You received this message because you are subscribed to the Google Groups "owners-override" group.
      To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
      To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/276b518dfeb0643d048be0c27ab07be2928d8429-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
      satisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages