[S] Change in fuchsia/fuchsia[main]: [logs] Explicitly depend on LogSink shards

['Brian Bosak (Gerrit)' via owners-override]

Attention needed from Owners Override

Brian Bosak has uploaded the change for review

Brian Bosak would like Owners Override to review this change.

Commit message

[logs] Explicitly depend on LogSink shards

Currently, these CML files depend on the LogSink shard
implicitly through RealmBuilder. These multiple layers
of shard nesting are causing problems with migrating
out-of-tree LogSink users to the diagnostics dictionary,
so implicit dependencies are being migrated to explicit dependenies
in preparation for the removal of the LogSink shard from
RealmBuilder.

Bug: 404543928

Change-Id: Iae229e1242ad47d05fb118241863a67d8ce4cf08

Change diff

Change information

Files:

• M src/connectivity/bluetooth/testing/hci-emulator-client/meta/hci-emulator-client-tests.cml
• M src/connectivity/bluetooth/tests/bt-access-integration-tests/meta/bt-access-integration-tests.cml
• M src/connectivity/bluetooth/tests/bt-bonding-integration/meta/bt-bonding-integration-tests.cml
• M src/connectivity/bluetooth/tests/bt-bootstrap-integration/meta/bt-bootstrap-integration-tests.cml
• M src/connectivity/bluetooth/tests/bt-host-integration/meta/bt-host-integration-tests.cml
• M src/connectivity/bluetooth/tests/bt-inspect-integration/meta/bt-inspect-integration-tests.cml
• M src/connectivity/bluetooth/tests/bt-le-integration/meta/bt-le-integration-tests.cml
• M src/connectivity/bluetooth/tests/bt-profile-integration/meta/bt-profile-integration-tests.cml
• M src/diagnostics/validator/logs/ddk/meta/ddk-log-test.cml
• M src/lib/fuchsia-component-test/tests/meta/fuchsia-component-test-tests.cml
• M src/lib/fuchsia-component-test/tests/meta/offered-cap-passthrough-test.cml
• M src/sys/component_manager/tests/resolvers/protocol/meta/resolver_api_test.cml
• M src/ui/a11y/lib/view/tests/meta/flatland-a11y-view-test.cml
• M src/ui/a11y/lib/view/tests/meta/flatland-scene-integration-test.cml
• M src/ui/tests/integration_graphics_tests/carnelian-pixel-tests/meta/carnelian_pixel_test.cml

Change size: S

Delta: 15 files changed, 20 insertions(+), 0 deletions(-)

Open in Gerrit

Related details

Attention is currently required from:

• Owners Override

Submit Requirements:

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: newchange

Gerrit-Project: fuchsia

Gerrit-Branch: main

Gerrit-Change-Id: Iae229e1242ad47d05fb118241863a67d8ce4cf08

Gerrit-Change-Number: 1232024

Gerrit-PatchSet: 1

Gerrit-Owner: Brian Bosak <bbo...@google.com>

Gerrit-Reviewer: Brian Bosak <bbo...@google.com>

Gerrit-Reviewer: Miguel Flores <migue...@google.com>

Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>

Gerrit-CC: CQ Bot <fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: GI Try Builder <global-integrat...@fuchsia-infra.iam.gserviceaccount.com>

Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/f3f6d76c375f0ae85815b8a6763c9411a8d13aa3-HTML%40fuchsia-review.googlesource.com.

['James Robinson (Gerrit)' via owners-override]

Attention needed from Brian Bosak and Owners Override

James Robinson voted and added 2 comments

Votes added by James Robinson

Owners-Override

+1

2 comments

Patchset-level comments

File-level comment, Patchset 1 (Latest):

James Robinson . resolved

I'll set O-O+1 again after fixing the spelling error if that clears the bit.

Commit Message

Line 13, Patchset 1 (Latest):so implicit dependencies are being migrated to explicit dependenies

James Robinson . unresolved

Please fix this WARNING reported by Spellchecker: "dependenies" is a possible misspelling of "dependencies".

Analyzer Description: Checks for common typos.
Owner: chops-so...@google.com

"dependenies" is a possible misspelling of "dependencies".

To bypass Spellchecker, add a footer with DISABLE_SPELLCHECKER

Open in Gerrit

Related details

Attention is currently required from:

• Brian Bosak
• Owners Override

Submit Requirements:

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: fuchsia

Gerrit-Branch: main

Gerrit-Change-Id: Iae229e1242ad47d05fb118241863a67d8ce4cf08

Gerrit-Change-Number: 1232024

Gerrit-PatchSet: 1

Gerrit-Owner: Brian Bosak <bbo...@google.com>

Gerrit-Reviewer: Brian Bosak <bbo...@google.com>

Gerrit-Reviewer: James Robinson <jam...@google.com>

Gerrit-Reviewer: Miguel Flores <migue...@google.com>

Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>

Gerrit-CC: CQ Bot <fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: GI Try Builder <global-integrat...@fuchsia-infra.iam.gserviceaccount.com>

Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>

Gerrit-Attention: Brian Bosak <bbo...@google.com>

Gerrit-Comment-Date: Wed, 19 Mar 2025 19:10:07 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/8631ea43fc91025d5b32a1fcc9b4b4486327f169-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

['Brian Bosak (Gerrit)' via owners-override]

Attention needed from James Robinson and Owners Override

Brian Bosak added 1 comment

Commit Message

Line 13, Patchset 1:so implicit dependencies are being migrated to explicit dependenies

James Robinson . resolved

Please fix this WARNING reported by Spellchecker: "dependenies" is a possible misspelling of "dependencies".

Analyzer Description: Checks for common typos.
Owner: chops-so...@google.com

"dependenies" is a possible misspelling of "dependencies".

To bypass Spellchecker, add a footer with DISABLE_SPELLCHECKER

Brian Bosak

Done

Open in Gerrit

Related details

Attention is currently required from:

• James Robinson
• Owners Override

Submit Requirements:

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: fuchsia

Gerrit-Branch: main

Gerrit-Change-Id: Iae229e1242ad47d05fb118241863a67d8ce4cf08

Gerrit-Change-Number: 1232024

Gerrit-PatchSet: 2

Gerrit-Owner: Brian Bosak <bbo...@google.com>

Gerrit-Reviewer: Brian Bosak <bbo...@google.com>

Gerrit-Reviewer: James Robinson <jam...@google.com>

Gerrit-Reviewer: Miguel Flores <migue...@google.com>

Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>

Gerrit-CC: CQ Bot <fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: GI Try Builder <global-integrat...@fuchsia-infra.iam.gserviceaccount.com>

Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>

Gerrit-Attention: James Robinson <jam...@google.com>

Gerrit-Comment-Date: Wed, 19 Mar 2025 19:11:28 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: James Robinson <jam...@google.com>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/2f4f6f5889617c980f4228d84af58c22192ebd42-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

['Brian Bosak (Gerrit)' via owners-override]

Attention needed from James Robinson and Owners Override

Brian Bosak voted Commit-Queue+2

Commit-Queue

+2

Gerrit-Comment-Date: Wed, 19 Mar 2025 19:11:43 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/d318cb93c8b3906409aae1aa40638ed54add212c-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

['CQ Bot (Gerrit)' via owners-override]

CQ Bot submitted the change

Unreviewed changes

1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:

[logs] Explicitly depend on LogSink shards

Currently, these CML files depend on the LogSink shard
implicitly through RealmBuilder. These multiple layers
of shard nesting are causing problems with migrating
out-of-tree LogSink users to the diagnostics dictionary,

so implicit dependencies are being migrated to explicit dependencies

in preparation for the removal of the LogSink shard from
RealmBuilder.

Bug: 404543928

Change-Id: Iae229e1242ad47d05fb118241863a67d8ce4cf08

Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1232024

Owners-Override: James Robinson <jam...@google.com>

Reviewed-by: Miguel Flores <migue...@google.com>

Commit-Queue: Brian Bosak <bbo...@google.com>

Files:

• M src/connectivity/bluetooth/testing/hci-emulator-client/meta/hci-emulator-client-tests.cml
• M src/connectivity/bluetooth/tests/bt-access-integration-tests/meta/bt-access-integration-tests.cml
• M src/connectivity/bluetooth/tests/bt-bonding-integration/meta/bt-bonding-integration-tests.cml
• M src/connectivity/bluetooth/tests/bt-bootstrap-integration/meta/bt-bootstrap-integration-tests.cml
• M src/connectivity/bluetooth/tests/bt-host-integration/meta/bt-host-integration-tests.cml
• M src/connectivity/bluetooth/tests/bt-inspect-integration/meta/bt-inspect-integration-tests.cml
• M src/connectivity/bluetooth/tests/bt-le-integration/meta/bt-le-integration-tests.cml
• M src/connectivity/bluetooth/tests/bt-profile-integration/meta/bt-profile-integration-tests.cml
• M src/diagnostics/validator/logs/ddk/meta/ddk-log-test.cml
• M src/lib/fuchsia-component-test/tests/meta/fuchsia-component-test-tests.cml
• M src/lib/fuchsia-component-test/tests/meta/offered-cap-passthrough-test.cml
• M src/sys/component_manager/tests/resolvers/protocol/meta/resolver_api_test.cml
• M src/ui/a11y/lib/view/tests/meta/flatland-a11y-view-test.cml
• M src/ui/a11y/lib/view/tests/meta/flatland-scene-integration-test.cml
• M src/ui/tests/integration_graphics_tests/carnelian-pixel-tests/meta/carnelian_pixel_test.cml

Change size: S

Delta: 15 files changed, 20 insertions(+), 0 deletions(-)

Branch: refs/heads/main

Submit Requirements:

• Code-Review: +2 by Miguel Flores

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: fuchsia

Gerrit-Branch: main

Gerrit-Change-Id: Iae229e1242ad47d05fb118241863a67d8ce4cf08

Gerrit-Change-Number: 1232024

Gerrit-PatchSet: 3

Gerrit-Owner: Brian Bosak <bbo...@google.com>

Gerrit-Reviewer: Brian Bosak <bbo...@google.com>

Gerrit-Reviewer: CQ Bot <fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: James Robinson <jam...@google.com>

Gerrit-Reviewer: Miguel Flores <migue...@google.com>

Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>

Gerrit-CC: GI Try Builder <global-integrat...@fuchsia-infra.iam.gserviceaccount.com>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/1184f5bad3de8f43f706f83109b6d9f075b585a4-HTML%40fuchsia-review.googlesource.com.

['GI Roller (Gerrit)' via owners-override]

Message from GI Roller

Change has been successfully rolled: http://go/roll-cl/9d41ee09654b5a5918b8397d4f8d9855b87f2ceb

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: fuchsia

Gerrit-Branch: main

Gerrit-Change-Id: Iae229e1242ad47d05fb118241863a67d8ce4cf08

Gerrit-Change-Number: 1232024

Gerrit-PatchSet: 3

Gerrit-Owner: Brian Bosak <bbo...@google.com>

Gerrit-Reviewer: Brian Bosak <bbo...@google.com>

Gerrit-Reviewer: CQ Bot <fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: James Robinson <jam...@google.com>

Gerrit-Reviewer: Miguel Flores <migue...@google.com>

Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>

Gerrit-CC: GI Roller <global-integra...@fuchsia-infra.iam.gserviceaccount.com>

Gerrit-CC: GI Try Builder <global-integrat...@fuchsia-infra.iam.gserviceaccount.com>

Gerrit-Comment-Date: Wed, 19 Mar 2025 19:38:31 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: No

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/dad638aefeba9b342824be1031ca5a1f0755ee5a-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.