[S] Change in fuchsia/fuchsia[main]: [rust] fix clippy lint errors

0 views
Skip to first unread message

'Steven Grady (Gerrit)' via owners-override

unread,
Sep 9, 2025, 1:55:53 PM (yesterday) Sep 9
to Owners Override
Attention needed from Naomi Mccracken, Owners Override and Sean Olson

Steven Grady has uploaded the change for review

Steven Grady would like Owners Override to review this change.

Commit message

[rust] fix clippy lint errors

The latest compiler was reporting a "clippy::useless-vec" in various
places, preventing a roll of rustc.
Change-Id: I6a6a69644d415d1ea8a31e19fc804cb860884dd7

Change diff

diff --git a/src/connectivity/wlan/wlancfg/src/client/scan/mod.rs b/src/connectivity/wlan/wlancfg/src/client/scan/mod.rs
index b2185ab..98e21c1 100644
--- a/src/connectivity/wlan/wlancfg/src/client/scan/mod.rs
+++ b/src/connectivity/wlan/wlancfg/src/client/scan/mod.rs
@@ -7,7 +7,7 @@
 use crate::config_management::SavedNetworksManagerApi;
 use crate::mode_management::iface_manager_api::{IfaceManagerApi, SmeForScan};
 use crate::telemetry::{ScanEventInspectData, ScanIssue, TelemetryEvent, TelemetrySender};
-use anyhow::{format_err, Error};
+use anyhow::{Error, format_err};
 use async_trait::async_trait;
 use fuchsia_async::{self as fasync, DurationExt, TimeoutExt};
 use fuchsia_component::client::connect_to_protocol;
@@ -483,13 +483,13 @@
         generate_channel, generate_random_sme_scan_result, run_until_completion,
     };
     use assert_matches::assert_matches;
-    use fidl::endpoints::{create_proxy, ControlHandle, Responder};
+    use fidl::endpoints::{ControlHandle, Responder, create_proxy};
     use futures::future;
     use futures::task::Poll;
     use std::pin::pin;
     use test_case::test_case;
     use wlan_common::ie::IeType;
-    use wlan_common::scan::{write_vmo, Compatible, Incompatible};
+    use wlan_common::scan::{Compatible, Incompatible, write_vmo};
     use wlan_common::security::SecurityDescriptor;
     use wlan_common::test_utils::fake_frames::fake_unknown_rsne;
     use wlan_common::test_utils::fake_stas::IesOverrides;
@@ -589,8 +589,8 @@
     }
 
     /// Creates a Client wrapper.
-    async fn create_iface_manager(
-    ) -> (Arc<Mutex<FakeIfaceManager>>, fidl_sme::ClientSmeRequestStream) {
+    async fn create_iface_manager()
+    -> (Arc<Mutex<FakeIfaceManager>>, fidl_sme::ClientSmeRequestStream) {
         let (client_sme, remote) = create_proxy::<fidl_sme::ClientSmeMarker>();
         let iface_manager = FakeIfaceManager::new(client_sme);
         let iface_manager = Arc::new(Mutex::new(iface_manager));
@@ -1137,7 +1137,7 @@
             ),
         };
 
-        let sme_results = vec![
+        let sme_results = [
             first_result.clone(),
             second_result.clone(),
             // same bssid as first_result
diff --git a/src/sys/pkg/tests/pkg-cache/src/inspect.rs b/src/sys/pkg/tests/pkg-cache/src/inspect.rs
index 525ef4f..f9736d64 100644
--- a/src/sys/pkg/tests/pkg-cache/src/inspect.rs
+++ b/src/sys/pkg/tests/pkg-cache/src/inspect.rs
@@ -415,7 +415,7 @@
 #[fuchsia::test]
 async fn retained_index_updated_and_persisted() {
     let env = TestEnv::builder().build().await;
-    let packages = vec![
+    let packages = [
         PackageBuilder::new("pkg-a").build().await.unwrap(),
         PackageBuilder::new("multi-pkg-a")
             .add_resource_at("bin/foo", "a-bin-foo".as_bytes())
diff --git a/src/sys/pkg/tests/pkg-cache/src/retained_packages.rs b/src/sys/pkg/tests/pkg-cache/src/retained_packages.rs
index 630f67f..4883302f 100644
--- a/src/sys/pkg/tests/pkg-cache/src/retained_packages.rs
+++ b/src/sys/pkg/tests/pkg-cache/src/retained_packages.rs
@@ -26,7 +26,7 @@
     ];
 
     // Packages to be written to BlobFS to emulate data available for GC.
-    let garbage_packages = vec![
+    let garbage_packages = [
         PackageBuilder::new("pkg-b").build().await.unwrap(),
         PackageBuilder::new("multi-pkg-b")
             .add_resource_at("bin/bar", "b-bin-bar".as_bytes())

Change information

Files:
Change size: S
Delta: 3 files changed, 8 insertions(+), 8 deletions(-)
Open in Gerrit

Related details

Attention is currently required from:
  • Naomi Mccracken
  • Owners Override
  • Sean Olson
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I6a6a69644d415d1ea8a31e19fc804cb860884dd7
Gerrit-Change-Number: 1364338
Gerrit-PatchSet: 2
Gerrit-Owner: Steven Grady <slg...@google.com>
Gerrit-Reviewer: Erick Tryzelaar <etryz...@google.com>
Gerrit-Reviewer: Naomi Mccracken <nmccr...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Reviewer: Sean Olson <sean...@google.com>
Gerrit-Reviewer: Steven Grady <slg...@google.com>
Gerrit-Attention: Sean Olson <sean...@google.com>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Naomi Mccracken <nmccr...@google.com>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/e505ac61135968e174c02a4c7842ace7448edec6-HTML%40fuchsia-review.googlesource.com.
unsatisfied_requirement
satisfied_requirement
open
diffy

'Sean Olson (Gerrit)' via owners-override

unread,
2:47 PM (3 hours ago) 2:47 PM
to Steven Grady, Owners Override, Naomi Mccracken, Erick Tryzelaar, GI Try Builder, CQ Bot
Attention needed from Naomi Mccracken, Owners Override and Steven Grady

Sean Olson voted Code-Review+2

Code-Review+2
Open in Gerrit

Related details

Attention is currently required from:
  • Naomi Mccracken
  • Owners Override
  • Steven Grady
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I6a6a69644d415d1ea8a31e19fc804cb860884dd7
Gerrit-Change-Number: 1364338
Gerrit-PatchSet: 2
Gerrit-Owner: Steven Grady <slg...@google.com>
Gerrit-Reviewer: Erick Tryzelaar <etryz...@google.com>
Gerrit-Reviewer: Naomi Mccracken <nmccr...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Reviewer: Sean Olson <sean...@google.com>
Gerrit-Reviewer: Steven Grady <slg...@google.com>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Steven Grady <slg...@google.com>
Gerrit-Attention: Naomi Mccracken <nmccr...@google.com>
Gerrit-Comment-Date: Wed, 10 Sep 2025 18:47:16 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/f051eb3e2a87f42e047e2bfa4d14f59ab6f7dff1-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy

'Steven Grady (Gerrit)' via owners-override

unread,
2:57 PM (3 hours ago) 2:57 PM
to Sean Olson, Owners Override, Naomi Mccracken, Erick Tryzelaar, GI Try Builder, CQ Bot
Attention needed from Naomi Mccracken and Owners Override

Steven Grady voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Naomi Mccracken
  • Owners Override
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I6a6a69644d415d1ea8a31e19fc804cb860884dd7
Gerrit-Change-Number: 1364338
Gerrit-PatchSet: 3
Gerrit-Owner: Steven Grady <slg...@google.com>
Gerrit-Reviewer: Erick Tryzelaar <etryz...@google.com>
Gerrit-Reviewer: Naomi Mccracken <nmccr...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Reviewer: Sean Olson <sean...@google.com>
Gerrit-Reviewer: Steven Grady <slg...@google.com>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Naomi Mccracken <nmccr...@google.com>
Gerrit-Comment-Date: Wed, 10 Sep 2025 18:57:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/047fcd068243192d30cba11bdfb249df52feb102-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy

'CQ Bot (Gerrit)' via owners-override

unread,
4:11 PM (2 hours ago) 4:11 PM
to Steven Grady, Sean Olson, Owners Override, Naomi Mccracken, Erick Tryzelaar, GI Try Builder

CQ Bot submitted the change

Unreviewed changes

2 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:
[rust] fix clippy lint errors

The latest compiler was reporting a "clippy::useless-vec" in various
places, preventing a roll of rustc.
Change-Id: I6a6a69644d415d1ea8a31e19fc804cb860884dd7
Reviewed-by: Sean Olson <sean...@google.com>
Reviewed-by: Erick Tryzelaar <etryz...@google.com>
Commit-Queue: Steven Grady <slg...@google.com>
Files:
Change size: S
Delta: 3 files changed, 8 insertions(+), 8 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +2 by Sean Olson, +2 by Erick Tryzelaar
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I6a6a69644d415d1ea8a31e19fc804cb860884dd7
Gerrit-Change-Number: 1364338
Gerrit-PatchSet: 4
Gerrit-Owner: Steven Grady <slg...@google.com>
Gerrit-Reviewer: Erick Tryzelaar <etryz...@google.com>
Gerrit-Reviewer: Naomi Mccracken <nmccr...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Reviewer: Sean Olson <sean...@google.com>
Gerrit-Reviewer: Steven Grady <slg...@google.com>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/dd2592ffa946aa6b529cb82ef65bbae767d062d4-HTML%40fuchsia-review.googlesource.com.
open
diffy
satisfied_requirement

'GI Roller (Gerrit)' via owners-override

unread,
4:14 PM (2 hours ago) 4:14 PM
to Steven Grady, CQ Bot, Sean Olson, Owners Override, Naomi Mccracken, Erick Tryzelaar, GI Try Builder

Message from GI Roller

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I6a6a69644d415d1ea8a31e19fc804cb860884dd7
Gerrit-Change-Number: 1364338
Gerrit-PatchSet: 4
Gerrit-Owner: Steven Grady <slg...@google.com>
Gerrit-Reviewer: Erick Tryzelaar <etryz...@google.com>
Gerrit-Reviewer: Naomi Mccracken <nmccr...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Reviewer: Sean Olson <sean...@google.com>
Gerrit-Reviewer: Steven Grady <slg...@google.com>
Gerrit-Comment-Date: Wed, 10 Sep 2025 20:14:39 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/e2b5e28544c32030242581de2347cf8385eeb88b-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages