'Chris Suter (Gerrit)' via owners-override

unread,

Aug 6, 2025, 5:55:51 PMAug 6

to Owners Override

Attention needed from Dustin Green and Owners Override

Chris Suter has uploaded the change for review

Chris Suter would like Owners Override to review this change.

Commit message

[sysmem] Check the log severity

Fixed: 436565839

Change-Id: Ia2ca45642dd98718920241ecc2baae86b935f624

Change diff

diff --git a/src/sysmem/server/logging.cc b/src/sysmem/server/logging.cc
index e2756db..5553916 100644
--- a/src/sysmem/server/logging.cc
+++ b/src/sysmem/server/logging.cc
@@ -26,6 +26,9 @@
 void vLogToCallback(::fuchsia_logging::LogSeverity severity, const char* file, int line,
                     const char* prefix, const char* format, va_list args,
                     const LogCallback& log_callback) {
+  if (!fuchsia_logging::IsSeverityEnabled(severity)) {
+    return;
+  }
   fbl::String new_format;
   if (prefix) {
     new_format = fbl::StringPrintf("[%s] %s", prefix, format);

Change information

Files:

M src/sysmem/server/logging.cc

Change size: XS

Delta: 1 file changed, 3 insertions(+), 0 deletions(-)

Open in Gerrit

Related details

Attention is currently required from:

Dustin Green
Owners Override

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/68b917a623d0d4697c5993aa56a0aee012376c26-HTML%40fuchsia-review.googlesource.com.

unsatisfied_requirement

satisfied_requirement

open

diffy

'Chris Suter (Gerrit)' via owners-override

unread,

Aug 6, 2025, 5:56:04 PMAug 6

to Owners Override, Francois Rousseau, GI Try Builder, Dustin Green, CQ Bot

Attention needed from Dustin Green and Owners Override

Chris Suter added 1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Chris Suter . resolved

Adding fuchsia-owners-override so as not to delay this fix which a few folks have noticed. Separately, it would be good to get more OWNERS added to src/sysmem.

Open in Gerrit

Related details

Attention is currently required from:

Dustin Green
Owners Override

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/68b917a623d0d4697c5993aa56a0aee012376c26-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

unsatisfied_requirement

satisfied_requirement

open

diffy

'James Robinson (Gerrit)' via owners-override

unread,

Aug 6, 2025, 6:01:44 PMAug 6

to Chris Suter, Owners Override, Francois Rousseau, GI Try Builder, Dustin Green, CQ Bot

Attention needed from Chris Suter, Dustin Green and Owners Override

James Robinson voted Code-Review+2

Code-Review

+2

Open in Gerrit

Related details

Attention is currently required from:

Chris Suter
Dustin Green
Owners Override

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/c77a7d6427152ffef8aae72dd342e11d6675aaee-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

unsatisfied_requirement

satisfied_requirement

open

diffy

'James Robinson (Gerrit)' via owners-override

unread,

Aug 6, 2025, 6:01:53 PMAug 6

to Chris Suter, Owners Override, Francois Rousseau, GI Try Builder, Dustin Green, CQ Bot

Attention needed from Chris Suter, Dustin Green and Owners Override

James Robinson voted Owners-Override+1

Owners-Override

+1

Open in Gerrit

Related details

Attention is currently required from:

Chris Suter
Dustin Green
Owners Override

Submit Requirements:

Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/0c9b33fe9f4e824823e745ac93c7beb6c3767b15-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

satisfied_requirement

open

diffy

'Dustin Green (Gerrit)' via owners-override

unread,

Aug 6, 2025, 7:01:29 PMAug 6

to Chris Suter, James Robinson, Owners Override, Francois Rousseau, GI Try Builder, CQ Bot

Attention needed from Chris Suter and Owners Override

Dustin Green voted Code-Review+2

Code-Review

+2

Open in Gerrit

Related details

Attention is currently required from:

Chris Suter
Owners Override

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/1d0536e1335fd184af0fe79defb2a642151ca512-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

satisfied_requirement

open

diffy

'CQ Bot (Gerrit)' via owners-override

unread,

Aug 6, 2025, 7:03:53 PMAug 6

to Chris Suter, Dustin Green, James Robinson, Owners Override, Francois Rousseau, GI Try Builder

CQ Bot submitted the change

Change information

Commit message:

[sysmem] Check the log severity

Fixed: 436565839

Change-Id: Ia2ca45642dd98718920241ecc2baae86b935f624

Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1339044

Commit-Queue: Chris Suter <csu...@google.com>

Reviewed-by: Francois Rousseau <frou...@google.com>

Reviewed-by: James Robinson <jam...@google.com>

Owners-Override: James Robinson <jam...@google.com>

Reviewed-by: Dustin Green <dusti...@google.com>

Fuchsia-Auto-Submit: Chris Suter <csu...@google.com>

Files:

M src/sysmem/server/logging.cc

Change size: XS

Delta: 1 file changed, 3 insertions(+), 0 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +2 by Francois Rousseau, +2 by James Robinson, +2 by Dustin Green

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/bb1a855dbabc98fedf58a87ed3d8cddf4bff03b8-HTML%40fuchsia-review.googlesource.com.

open

diffy

satisfied_requirement

'GI Roller (Gerrit)' via owners-override

unread,

Aug 6, 2025, 7:12:12 PMAug 6

to Chris Suter, CQ Bot, Dustin Green, James Robinson, Owners Override, Francois Rousseau, GI Try Builder

Message from GI Roller

Change has been successfully rolled: https://turquoise-internal-review.googlesource.com/1026603

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/e2f277a3d144b91dc7d90e8ab732055d0b8bd2e3-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

satisfied_requirement

open

diffy

Reply all

Reply to author

Forward

[XS] Change in fuchsia/fuchsia[main]: [sysmem] Check the log severity

'Chris Suter (Gerrit)' via owners-override

Chris Suter has uploaded the change for review

Commit message

Change diff

Change information

Related details

'Chris Suter (Gerrit)' via owners-override

Chris Suter added 1 comment

Related details

'James Robinson (Gerrit)' via owners-override

James Robinson voted Code-Review+2

Related details

'James Robinson (Gerrit)' via owners-override

James Robinson voted Owners-Override+1

Related details

'Dustin Green (Gerrit)' via owners-override

Dustin Green voted Code-Review+2

Related details

'CQ Bot (Gerrit)' via owners-override

CQ Bot submitted the change

Change information

'GI Roller (Gerrit)' via owners-override

Message from GI Roller

Related details