Groups keyboard shortcuts have been updated
Dismiss
See shortcuts

[XS] Change in fuchsia/fuchsia[main]: [fuzzing][realmfuzzer] Fix -Wimplicit-int-conversion errors

0 views
Skip to first unread message

'Paul Kirth (Gerrit)' via owners-override

unread,
Mar 26, 2025, 12:39:17 PMMar 26
to Owners Override
Attention needed from Aaron Green, Dzmitry Yatsushkevich, Laura Peskin, Marco Vanotti and Owners Override

Paul Kirth has uploaded the change for review

Paul Kirth would like Owners Override to review this change.

Commit message

[fuzzing][realmfuzzer] Fix -Wimplicit-int-conversion errors

New versions of clang will start warning about more cases when the
conversion happens.
Bug: 402753152
Change-Id: I8a6ec9d91e2e460bf983924ace3205b7a8c5ebf5

Change diff

diff --git a/src/sys/fuzzing/realmfuzzer/engine/mutagen.cc b/src/sys/fuzzing/realmfuzzer/engine/mutagen.cc
index 7439a82..2493e7c 100644
--- a/src/sys/fuzzing/realmfuzzer/engine/mutagen.cc
+++ b/src/sys/fuzzing/realmfuzzer/engine/mutagen.cc
@@ -5,6 +5,7 @@
 #include "src/sys/fuzzing/realmfuzzer/engine/mutagen.h"
 
 #include <lib/syslog/cpp/macros.h>
+#include <cstdint>
 
 namespace fuzzing {
 namespace {
@@ -195,7 +196,7 @@
     T adjustment = ((randval >> 2) & 0x1f) - 16;
     memcpy(&val, data, sizeof(val));
     if (!adjustment) {
-      val = -val;
+      val = static_cast<uint8_t>(-val);
     } else if (do_bswap) {
       val = Bswap<T>(Bswap<T>(val) + adjustment);
     } else {

Change information

Files:
  • M src/sys/fuzzing/realmfuzzer/engine/mutagen.cc
Change size: XS
Delta: 1 file changed, 2 insertions(+), 1 deletion(-)
Open in Gerrit

Related details

Attention is currently required from:
  • Aaron Green
  • Dzmitry Yatsushkevich
  • Laura Peskin
  • Marco Vanotti
  • Owners Override
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I8a6ec9d91e2e460bf983924ace3205b7a8c5ebf5
Gerrit-Change-Number: 1235512
Gerrit-PatchSet: 6
Gerrit-Owner: Paul Kirth <paul...@google.com>
Gerrit-Reviewer: Aaron Green <aaron...@google.com>
Gerrit-Reviewer: Dzmitry Yatsushkevich <dmit...@google.com>
Gerrit-Reviewer: Laura Peskin <pe...@google.com>
Gerrit-Reviewer: Marco Vanotti <mvan...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Reviewer: Paul Kirth <paul...@google.com>
Gerrit-Attention: Laura Peskin <pe...@google.com>
Gerrit-Attention: Aaron Green <aaron...@google.com>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Marco Vanotti <mvan...@google.com>
Gerrit-Attention: Dzmitry Yatsushkevich <dmit...@google.com>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/d527fbd5b131c855769159b2821a272950de32da-HTML%40fuchsia-review.googlesource.com.
unsatisfied_requirement
open
diffy

'Paul Kirth (Gerrit)' via owners-override

unread,
Mar 26, 2025, 12:39:31 PMMar 26
to Owners Override, Laura Peskin, GI Try Builder, CQ Bot, Aaron Green, Marco Vanotti, Dzmitry Yatsushkevich
Attention needed from Aaron Green, Dzmitry Yatsushkevich, Laura Peskin, Marco Vanotti and Owners Override

Paul Kirth voted Fuchsia-Auto-Submit+1

Fuchsia-Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Aaron Green
  • Dzmitry Yatsushkevich
  • Laura Peskin
  • Marco Vanotti
  • Owners Override
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I8a6ec9d91e2e460bf983924ace3205b7a8c5ebf5
Gerrit-Change-Number: 1235512
Gerrit-PatchSet: 6
Gerrit-Owner: Paul Kirth <paul...@google.com>
Gerrit-Reviewer: Aaron Green <aaron...@google.com>
Gerrit-Reviewer: Dzmitry Yatsushkevich <dmit...@google.com>
Gerrit-Reviewer: Laura Peskin <pe...@google.com>
Gerrit-Reviewer: Marco Vanotti <mvan...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Reviewer: Paul Kirth <paul...@google.com>
Gerrit-Attention: Laura Peskin <pe...@google.com>
Gerrit-Attention: Aaron Green <aaron...@google.com>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Marco Vanotti <mvan...@google.com>
Gerrit-Attention: Dzmitry Yatsushkevich <dmit...@google.com>
Gerrit-Comment-Date: Wed, 26 Mar 2025 16:39:11 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/d527fbd5b131c855769159b2821a272950de32da-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
unsatisfied_requirement
open
diffy

'James Robinson (Gerrit)' via owners-override

unread,
Mar 26, 2025, 12:47:44 PMMar 26
to Paul Kirth, Owners Override, Laura Peskin, GI Try Builder, CQ Bot, Aaron Green, Marco Vanotti, Dzmitry Yatsushkevich
Attention needed from Aaron Green, Dzmitry Yatsushkevich, Laura Peskin, Marco Vanotti, Owners Override and Paul Kirth

James Robinson voted Owners-Override+1

Owners-Override+1
Open in Gerrit

Related details

Attention is currently required from:
  • Aaron Green
  • Dzmitry Yatsushkevich
  • Laura Peskin
  • Marco Vanotti
  • Owners Override
  • Paul Kirth
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I8a6ec9d91e2e460bf983924ace3205b7a8c5ebf5
Gerrit-Change-Number: 1235512
Gerrit-PatchSet: 6
Gerrit-Owner: Paul Kirth <paul...@google.com>
Gerrit-Reviewer: Aaron Green <aaron...@google.com>
Gerrit-Reviewer: Dzmitry Yatsushkevich <dmit...@google.com>
Gerrit-Reviewer: James Robinson <jam...@google.com>
Gerrit-Reviewer: Laura Peskin <pe...@google.com>
Gerrit-Reviewer: Marco Vanotti <mvan...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Reviewer: Paul Kirth <paul...@google.com>
Gerrit-Attention: Laura Peskin <pe...@google.com>
Gerrit-Attention: Paul Kirth <paul...@google.com>
Gerrit-Attention: Aaron Green <aaron...@google.com>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Marco Vanotti <mvan...@google.com>
Gerrit-Attention: Dzmitry Yatsushkevich <dmit...@google.com>
Gerrit-Comment-Date: Wed, 26 Mar 2025 16:47:38 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/62973be36f9abc11728d091b33022bd37e9730e7-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
unsatisfied_requirement
open
diffy

'Marco Vanotti (Gerrit)' via owners-override

unread,
Mar 26, 2025, 1:55:54 PMMar 26
to Paul Kirth, Marco Vanotti, James Robinson, Owners Override, Laura Peskin, GI Try Builder, CQ Bot, Aaron Green, Dzmitry Yatsushkevich
Attention needed from Aaron Green, Dzmitry Yatsushkevich, Laura Peskin, Owners Override and Paul Kirth

Marco Vanotti voted Code-Review+2

Code-Review+2
Open in Gerrit

Related details

Attention is currently required from:
  • Aaron Green
  • Dzmitry Yatsushkevich
  • Laura Peskin
  • Owners Override
  • Paul Kirth
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I8a6ec9d91e2e460bf983924ace3205b7a8c5ebf5
Gerrit-Change-Number: 1235512
Gerrit-PatchSet: 6
Gerrit-Owner: Paul Kirth <paul...@google.com>
Gerrit-Reviewer: Aaron Green <aaron...@google.com>
Gerrit-Reviewer: Dzmitry Yatsushkevich <dmit...@google.com>
Gerrit-Reviewer: James Robinson <jam...@google.com>
Gerrit-Reviewer: Laura Peskin <pe...@google.com>
Gerrit-Reviewer: Marco Vanotti <mvan...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Reviewer: Paul Kirth <paul...@google.com>
Gerrit-Attention: Laura Peskin <pe...@google.com>
Gerrit-Attention: Paul Kirth <paul...@google.com>
Gerrit-Attention: Aaron Green <aaron...@google.com>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Dzmitry Yatsushkevich <dmit...@google.com>
Gerrit-Comment-Date: Wed, 26 Mar 2025 17:55:49 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/bfd41eaca602c74b3126c41f08d93c8a9154e5bc-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy

'CQ Bot (Gerrit)' via owners-override

unread,
Mar 26, 2025, 2:04:09 PMMar 26
to Paul Kirth, Auto-Submit, Marco Vanotti, James Robinson, Owners Override, Laura Peskin, GI Try Builder, Aaron Green, Dzmitry Yatsushkevich

CQ Bot submitted the change

Change information

Commit message:
[fuzzing][realmfuzzer] Fix -Wimplicit-int-conversion errors

New versions of clang will start warning about more cases when the
conversion happens.
Bug: 402753152
Change-Id: I8a6ec9d91e2e460bf983924ace3205b7a8c5ebf5
Fuchsia-Auto-Submit: Paul Kirth <paul...@google.com>
Owners-Override: James Robinson <jam...@google.com>
Reviewed-by: Marco Vanotti <mvan...@google.com>
Files:
  • M src/sys/fuzzing/realmfuzzer/engine/mutagen.cc
Change size: XS
Delta: 1 file changed, 2 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +2 by Marco Vanotti
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I8a6ec9d91e2e460bf983924ace3205b7a8c5ebf5
Gerrit-Change-Number: 1235512
Gerrit-PatchSet: 7
Gerrit-Owner: Paul Kirth <paul...@google.com>
Gerrit-Reviewer: Aaron Green <aaron...@google.com>
Gerrit-Reviewer: Dzmitry Yatsushkevich <dmit...@google.com>
Gerrit-Reviewer: James Robinson <jam...@google.com>
Gerrit-Reviewer: Laura Peskin <pe...@google.com>
Gerrit-Reviewer: Marco Vanotti <mvan...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Reviewer: Paul Kirth <paul...@google.com>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/98ca58e378acbcc7990575ccd79a85aedde69e9a-HTML%40fuchsia-review.googlesource.com.
open
diffy
satisfied_requirement

'GI Roller (Gerrit)' via owners-override

unread,
Mar 26, 2025, 2:12:54 PMMar 26
to Paul Kirth, CQ Bot, Auto-Submit, Marco Vanotti, James Robinson, Owners Override, Laura Peskin, GI Try Builder, Aaron Green, Dzmitry Yatsushkevich

Message from GI Roller

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I8a6ec9d91e2e460bf983924ace3205b7a8c5ebf5
Gerrit-Change-Number: 1235512
Gerrit-PatchSet: 7
Gerrit-Owner: Paul Kirth <paul...@google.com>
Gerrit-Reviewer: Aaron Green <aaron...@google.com>
Gerrit-Reviewer: Auto-Submit <auto-...@fuchsia-infra.iam.gserviceaccount.com>
Gerrit-Reviewer: Dzmitry Yatsushkevich <dmit...@google.com>
Gerrit-Reviewer: James Robinson <jam...@google.com>
Gerrit-Reviewer: Laura Peskin <pe...@google.com>
Gerrit-Reviewer: Marco Vanotti <mvan...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Reviewer: Paul Kirth <paul...@google.com>
Gerrit-Comment-Date: Wed, 26 Mar 2025 18:12:51 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/f916deafb6aa16a3cc64a0c79315b2749cdd8f7b-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages