[L] Change in fuchsia/fuchsia[main]: [rust][zx] Make zx-status no_std
0 views
Skip to first unread message
'Adam Perry (Gerrit)' via owners-override
May 5, 2026, 11:58:44 AM (2 days ago) May 5
to Owners Override
Attention needed from Adam Barth and Owners Override
Adam Barth has uploaded the change for review![]( "Open in Gerrit")
Adam Perry would like Owners Override to review this change authored by Adam Barth.
Commit message
[rust][zx] Make zx-status no_std
This CL moves the conversions that depend on std into a separate
zx-status-ext crate. This change lets us make the zx-status crate
no_std.
Bug: b/507423574
Depends-on: turquoise-internal:I08b6f04b527e32cdb749a2b33680c5a0a3bbe349
Change-Id: I8eb964038a6be6256ff92444784611c53272991c
Change diff
Change information
Files:
- M build/bazel2gn_verification_targets.gni
- A sdk/rust/zx-status-ext/BUILD.bazel
- A sdk/rust/zx-status-ext/BUILD.gn
- A sdk/rust/zx-status-ext/src/lib.rs
- M sdk/rust/zx-status/src/lib.rs
- M sdk/rust/zx/BUILD.gn
- M sdk/rust/zx/src/lib.rs
- M sdk/rust/zx/src/stream.rs
- M src/connectivity/bluetooth/lib/fuchsia-audio-codec/src/stream_processor.rs
- M src/connectivity/bluetooth/lib/fuchsia-bluetooth/BUILD.gn
- M src/connectivity/bluetooth/lib/fuchsia-bluetooth/src/types/channel.rs
- M src/connectivity/bluetooth/lib/fuchsia-bluetooth/src/types/channel/socket.rs
- M src/connectivity/bluetooth/tools/tests/bt-tool-cli-tests/src/lib.rs
- M src/connectivity/lib/network-device/rust/src/session/buffer/pool.rs
- M src/connectivity/lowpan/drivers/lowpan-ot-driver/src/driver/api.rs
- M src/connectivity/overnet/lib/core/BUILD.gn
- M src/connectivity/overnet/lib/core/src/proxy/handle/socket.rs
- M src/developer/ffx/tools/playground/BUILD.gn
- M src/developer/ffx/tools/playground/src/host_fs.rs
- M src/developer/remote-control/test/BUILD.gn
- M src/developer/remote-control/test/src/lib.rs
- M src/lib/fdio/rust/src/lib.rs
- M src/lib/fuchsia-async/BUILD.bazel
- M src/lib/fuchsia-async/BUILD.gn
- M src/lib/fuchsia-async/src/handle/emulated/socket.rs
- M src/lib/fuchsia-async/src/handle/zircon/socket.rs
- M src/lib/fuchsia-async/src/net/fuchsia/mod.rs
- M src/lib/fuchsia-async/src/net/fuchsia/tcp.rs
- M src/lib/fuchsia-async/src/net/fuchsia/udp.rs
- M src/lib/fuchsia-fs/BUILD.gn
- M src/lib/fuchsia-fs/src/file/async_read_at.rs
- M src/lib/fuchsia-fs/src/file/async_reader.rs
- M src/lib/fuchsia-hyper/src/fuchsia.rs
- M src/lib/network/fidl_fuchsia_posix_socket_ext/src/lib.rs
- M src/storage/fuchsia-fatfs/src/directory.rs
- M src/sys/component_manager/tests/rights/BUILD.gn
- M src/sys/component_manager/tests/rights/use_dir_rights.rs
- M src/testing/sl4f/src/common_utils/common.rs
Change size: L
Delta: 38 files changed, 296 insertions(+), 181 deletions(-)
Related details
Attention is currently required from:
- Adam Barth
- Owners Override
Submit Requirements:
Code-Owners
Code-Review
Dependencies-Satisfied
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/a589734b050a56de9d844b5de7ce3384c4029a83-HTML%40fuchsia-review.googlesource.com.
'Adam Perry (Gerrit)' via owners-override
May 5, 2026, 11:58:46 AM (2 days ago) May 5
to Adam Barth, Owners Override, Marie Janssen, global-integrat...@fuchsia-infra.iam.gserviceaccount.com, fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com
Attention needed from Adam Barth and Owners Override
Adam Perry voted and added 1 comment![]( "Open in Gerrit")
Votes added by Adam Perry
| Commit-Queue | +1 |
| Fuchsia-Auto-Submit | +1 |
1 comment
File src/connectivity/lib/network-device/rust/src/session/buffer/pool.rs
Line 996, Patchset 1:
.map_err(|TryFromIntError { .. }| zx::Status::OUT_OF_RANGE.into_io_error())?;Marie Janssen . resolved
Adam Perrycould avoid adding StatusExt here (and below) by directly using io::Error::InvalidInput
Done
Related details
Attention is currently required from:
- Adam Barth
- Owners Override
Submit Requirements:
Code-Owners
Code-Review
Dependencies-Satisfied
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/a589734b050a56de9d844b5de7ce3384c4029a83-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'Adam Barth (Gerrit)' via owners-override
May 5, 2026, 11:59:50 AM (2 days ago) May 5
to Adam Perry, Owners Override, Marie Janssen, global-integrat...@fuchsia-infra.iam.gserviceaccount.com, fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com
Attention needed from Adam Perry and Owners Override
Adam Barth voted Owners-Override+1![]( "Open in Gerrit")
Attention is currently required from:
- Adam Perry
- Owners Override
Submit Requirements:
Code-Owners
Code-Review
Dependencies-Satisfied
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/e046e12f0d063ccef38423b3bf4d14481a9dd222-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'Adam Barth (Gerrit)' via owners-override
May 5, 2026, 12:01:25 PM (2 days ago) May 5
to Adam Perry, Owners Override, Marie Janssen, global-integrat...@fuchsia-infra.iam.gserviceaccount.com, fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com
Attention needed from Adam Perry and Owners Override
Adam Barth voted and added 1 comment![]( "Open in Gerrit")
Votes added by Adam Barth
| Code-Review | +0 |
| Owners-Override | +0 |
1 comment
Patchset-level comments
File-level comment, Patchset 9 (Latest):
Adam Barth . resolved
Looks like someone else will need to approve because I made an earlier draft of this CL.
Related details
Attention is currently required from:
- Adam Perry
- Owners Override
Submit Requirements:
Code-Owners
Code-Review
Dependencies-Satisfied
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/a2e6d2ed18990b726130b60f9072b58c0c3e4488-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'Kevin Lindkvist (Gerrit)' via owners-override
May 5, 2026, 12:08:24 PM (2 days ago) May 5
to Adam Perry, Adam Barth, Owners Override, Marie Janssen, global-integrat...@fuchsia-infra.iam.gserviceaccount.com, fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com
Attention needed from Adam Barth, Adam Perry and Owners Override
Kevin Lindkvist voted Owners-Override+1![]( "Open in Gerrit")
Attention is currently required from:
- Adam Barth
- Adam Perry
- Owners Override
Submit Requirements:
Code-Owners
Code-Review
Dependencies-Satisfied
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/295e3610dd1115d951510e6a493ed733e5ef5197-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'Adam Perry (Gerrit)' via owners-override
May 5, 2026, 12:24:33 PM (2 days ago) May 5
to Adam Barth, Kevin Lindkvist, Owners Override, Marie Janssen, global-integrat...@fuchsia-infra.iam.gserviceaccount.com, fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com
Attention needed from Adam Barth, Kevin Lindkvist and Owners Override
Adam Perry voted and added 1 comment![]( "Open in Gerrit")
Votes added by Adam Perry
| Commit-Queue | +1 |
| Fuchsia-Auto-Submit | +1 |
1 comment
File src/developer/ffx/tools/playground/src/host_fs.rs
Line 369, Patchset 9:
entry.file_type().map_err(|e| IoErrorKindExt::to_status(e.kind()))?,Adam Barth . resolved
Adam PerryShould we make an easier spelling for this pattern?
I considered adding another trait and decided to just shorten these to `e.kind().to_status()`. If the pattern shows up a lot more it might be worth adding a trait, LMK if you think it's worth doing and I'll put up a follow-up.
Related details
Attention is currently required from:
- Adam Barth
- Kevin Lindkvist
- Owners Override
Submit Requirements:
Code-Owners
Code-Review
Dependencies-Satisfied
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/a5d921377384e6847583070ad4620dfaacf6c7cb-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'Kevin Lindkvist (Gerrit)' via owners-override
May 5, 2026, 2:58:50 PM (2 days ago) May 5
to Adam Perry, Adam Barth, Owners Override, Marie Janssen, global-integrat...@fuchsia-infra.iam.gserviceaccount.com, fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com
Attention needed from Adam Barth, Adam Perry and Owners Override
Kevin Lindkvist voted Owners-Override+1![]( "Open in Gerrit")
Attention is currently required from:
- Adam Barth
- Adam Perry
- Owners Override
Submit Requirements:
Code-Owners
Code-Review
Dependencies-Satisfied
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/742321b281d67896037291cde76b432c54c2a5ba-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'fuchsia-internal-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)' via owners-override
May 5, 2026, 3:00:37 PM (2 days ago) May 5
to Adam Barth, cl-deps...@fuchsia-internal-service-accts.iam.gserviceaccount.com, Kevin Lindkvist, Adam Perry, Owners Override, Marie Janssen, global-integrat...@fuchsia-infra.iam.gserviceaccount.com
fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
1 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: src/connectivity/bluetooth/lib/fuchsia-bluetooth/src/types/channel/socket.rs
Insertions: 464, Deletions: 0.
The diff is too large to show. Please review the diff.
```
```
The name of the file: src/storage/fuchsia-fatfs/src/directory.rs
Insertions: 5, Deletions: 4.
The diff is too large to show. Please review the diff.
```
```
The name of the file: src/sys/component_manager/tests/rights/use_dir_rights.rs
Insertions: 5, Deletions: 2.
The diff is too large to show. Please review the diff.
```
```
The name of the file: src/connectivity/bluetooth/tools/tests/bt-tool-cli-tests/src/lib.rs
Insertions: 10, Deletions: 7.
The diff is too large to show. Please review the diff.
```
```
The name of the file: sdk/rust/zx/src/lib.rs
Insertions: 1, Deletions: 2.
The diff is too large to show. Please review the diff.
```
```
The name of the file: src/connectivity/bluetooth/lib/fuchsia-bluetooth/BUILD.gn
Insertions: 1, Deletions: 0.
The diff is too large to show. Please review the diff.
```
```
The name of the file: src/connectivity/lib/network-device/rust/src/session/buffer/pool.rs
Insertions: 9, Deletions: 7.
The diff is too large to show. Please review the diff.
```
```
The name of the file: build/bazel2gn_verification_targets.gni
Insertions: 1, Deletions: 0.
The diff is too large to show. Please review the diff.
```
```
The name of the file: sdk/rust/zx/src/status_ext.rs
Insertions: 0, Deletions: 5.
The diff is too large to show. Please review the diff.
```
```
The name of the file: sdk/rust/zx/BUILD.gn
Insertions: 0, Deletions: 1.
The diff is too large to show. Please review the diff.
```
```
The name of the file: src/developer/remote-control/test/BUILD.gn
Insertions: 1, Deletions: 0.
The diff is too large to show. Please review the diff.
```
```
The name of the file: src/sys/component_manager/tests/rights/BUILD.gn
Insertions: 1, Deletions: 0.
The diff is too large to show. Please review the diff.
```
```
The name of the file: src/developer/ffx/tools/playground/BUILD.gn
Insertions: 1, Deletions: 0.
The diff is too large to show. Please review the diff.
```
```
The name of the file: src/connectivity/bluetooth/lib/fuchsia-bluetooth/src/types/channel.rs
Insertions: 3, Deletions: 30.
The diff is too large to show. Please review the diff.
```
```
The name of the file: src/developer/remote-control/test/src/lib.rs
Insertions: 5, Deletions: 3.
The diff is too large to show. Please review the diff.
```
```
The name of the file: src/developer/ffx/tools/playground/src/host_fs.rs
Insertions: 21, Deletions: 18.
The diff is too large to show. Please review the diff.
```
Change information
Commit message:
[rust][zx] Make zx-status no_std
This CL moves the conversions that depend on std into a separate
zx-status-ext crate. This change lets us make the zx-status crate
no_std.
Bug: b/507423574
Depends-on: turquoise-internal:I08b6f04b527e32cdb749a2b33680c5a0a3bbe349
Change-Id: I8eb964038a6be6256ff92444784611c53272991c
Reviewed-by: Marie Janssen <jam...@google.com>
Commit-Queue: Adam Perry <adam...@google.com>
Fuchsia-Auto-Submit: Adam Perry <adam...@google.com>
Owners-Override: Kevin Lindkvist <lind...@google.com>
Delta: 38 files changed, 281 insertions(+), 181 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +2 by Marie Janssen
Dependencies-Satisfied: +1 by cl-deps...@fuchsia-internal-service-accts.iam.gserviceaccount.com
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/e30210b83a6c4c100ac88e8114518d752ed8e68b-HTML%40fuchsia-review.googlesource.com.To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'global-integration-ci-builder@fuchsia-infra.iam.gserviceaccount.com (Gerrit)' via owners-override
May 5, 2026, 3:15:15 PM (2 days ago) May 5
to Adam Barth, fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com, cl-deps...@fuchsia-internal-service-accts.iam.gserviceaccount.com, Kevin Lindkvist, Adam Perry, Owners Override, Marie Janssen, global-integrat...@fuchsia-infra.iam.gserviceaccount.com
Message from global-integra...@fuchsia-infra.iam.gserviceaccount.com![]( "Open in Gerrit")
Change has been successfully rolled: https://turquoise-internal-review.googlesource.com/1255698
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Dependencies-Satisfied
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/27e9f2de8e04b48611dcf4407921c4e47a51a2f1-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
Reply all
Reply to author
Forward
0 new messages