[XL] Change in fuchsia/fuchsia[main]: [scripts][shac] Add custom linter rules for skill files.

0 views
Skip to first unread message

'Kyo Lee (Gerrit)' via owners-override

unread,
2:22 AM (21 hours ago) 2:22 AM
to Owners Override
Attention needed from Aaron Wood, Chase Latta, Oliver Newman and Owners Override

Kyo Lee has uploaded the change for review

Kyo Lee would like Owners Override to review this change.

Commit message

[scripts][shac] Add custom linter rules for skill files.

This adds the `skill_linter` tool to validate and format `SKILL.md`
files. The tool is integrated with SHAC to support automated
formatting via `fx format-code`.
Test: fx test skill_linter_test
Test: fx format-code --files=scripts/skill_linter/skill_linter.py
Change-Id: I4309a9b9f6738707f1e1388503e4ea4158a91ecb

Change diff


Change information

Files:
  • M scripts/BUILD.gn
  • M scripts/shac/main.star
  • A scripts/shac/skills.star
  • A scripts/skill_linter/BUILD.gn
  • A scripts/skill_linter/OWNERS
  • A scripts/skill_linter/README.md
  • A scripts/skill_linter/skill_linter.py
  • A scripts/skill_linter/skill_linter_test.py
Change size: XL
Delta: 8 files changed, 1140 insertions(+), 0 deletions(-)
Open in Gerrit

Related details

Attention is currently required from:
  • Aaron Wood
  • Chase Latta
  • Oliver Newman
  • Owners Override
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I4309a9b9f6738707f1e1388503e4ea4158a91ecb
Gerrit-Change-Number: 1584836
Gerrit-PatchSet: 64
Gerrit-Owner: Kyo Lee <ky...@google.com>
Gerrit-Reviewer: Aaron Wood <aaro...@google.com>
Gerrit-Reviewer: Jerry Belton <jce...@google.com>
Gerrit-Reviewer: Kyo Lee <ky...@google.com>
Gerrit-Reviewer: Oliver Newman <oliver...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-CC: Chase Latta <chase...@google.com>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Chase Latta <chase...@google.com>
Gerrit-Attention: Oliver Newman <oliver...@google.com>
Gerrit-Attention: Aaron Wood <aaro...@google.com>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/9bfd6c8b0b2e6a19fae3296b4d5df9b573b2bbf8-HTML%40fuchsia-review.googlesource.com.
unsatisfied_requirement
satisfied_requirement
open
diffy

'Adam Barth (Gerrit)' via owners-override

unread,
12:52 PM (10 hours ago) 12:52 PM
to Kyo Lee, Owners Override, Aaron Wood, Chase Latta, Oliver Newman, Jerry Belton, global-integrat...@fuchsia-infra.iam.gserviceaccount.com, fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com
Attention needed from Aaron Wood, Chase Latta, Kyo Lee, Oliver Newman and Owners Override

Adam Barth voted and added 1 comment

Votes added by Adam Barth

Owners-Override+1

1 comment

Patchset-level comments
File-level comment, Patchset 64 (Latest):
Adam Barth . resolved

scripts/skill_linter/OWNERS LGTM

Open in Gerrit

Related details

Attention is currently required from:
  • Aaron Wood
  • Chase Latta
  • Kyo Lee
  • Oliver Newman
  • Owners Override
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I4309a9b9f6738707f1e1388503e4ea4158a91ecb
Gerrit-Change-Number: 1584836
Gerrit-PatchSet: 64
Gerrit-Owner: Kyo Lee <ky...@google.com>
Gerrit-Reviewer: Aaron Wood <aaro...@google.com>
Gerrit-Reviewer: Adam Barth <aba...@google.com>
Gerrit-Attention: Kyo Lee <ky...@google.com>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Chase Latta <chase...@google.com>
Gerrit-Attention: Oliver Newman <oliver...@google.com>
Gerrit-Attention: Aaron Wood <aaro...@google.com>
Gerrit-Comment-Date: Wed, 29 Apr 2026 16:51:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/7d9cce8eeb892c5b28c725427b60304884dbacdd-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy

'Oliver Newman (Gerrit)' via owners-override

unread,
1:29 PM (10 hours ago) 1:29 PM
to Kyo Lee, Adam Barth, Owners Override, Aaron Wood, Chase Latta, Jerry Belton, global-integrat...@fuchsia-infra.iam.gserviceaccount.com, fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com
Attention needed from Aaron Wood, Adam Barth, Chase Latta, Kyo Lee and Owners Override

Oliver Newman voted and added 3 comments

Votes added by Oliver Newman

Code-Review+2

3 comments

File scripts/shac/skills.star
Line 36, Patchset 65 (Latest):
# Check for fatal crashes or failure to produce JSON.
if res.retcode != 0 or not res.stdout.strip().startswith("["):
ctx.emit.finding(
level = "error",
message = "Skill linter error:\n%s" % res.stderr,
)
continue
Oliver Newman . unresolved

Nit: I'd rather just remove `raise_on_failure = False` and let shac handle the non-zero exit code.

Line 50, Patchset 65 (Latest): message = finding.get("message", "Skill linter finding."),
Oliver Newman . unresolved
The script already sets `message` to a default value if it's not set, so no need for `get()`.
```suggestion
                message = finding["message"],
```
File scripts/skill_linter/skill_linter.py
Line 606, Patchset 65 (Latest): logging.info(f"PASSED: '{skill_name}' is valid.")
Oliver Newman . unresolved

Please fix this WARNING reported by autoreview issue finding: If `fixit` is false and there are validation errors, this branch will execute and unconditionally log `PASSED: '{skill_name}' is valid.` after logging the errors.

Consider guarding this log message so it only prints if the file is genuinely valid:
```python
elif not errors and not warnings and new_content == original_content:
    logging.info(f"PASSED: '{skill_name}' is valid.")
```
Open in Gerrit

Related details

Attention is currently required from:
  • Aaron Wood
  • Adam Barth
  • Chase Latta
  • Kyo Lee
  • Owners Override
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I4309a9b9f6738707f1e1388503e4ea4158a91ecb
Gerrit-Change-Number: 1584836
Gerrit-PatchSet: 65
Gerrit-Owner: Kyo Lee <ky...@google.com>
Gerrit-Reviewer: Aaron Wood <aaro...@google.com>
Gerrit-Reviewer: Adam Barth <aba...@google.com>
Gerrit-Reviewer: Jerry Belton <jce...@google.com>
Gerrit-Reviewer: Kyo Lee <ky...@google.com>
Gerrit-Reviewer: Oliver Newman <oliver...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-CC: Chase Latta <chase...@google.com>
Gerrit-Attention: Kyo Lee <ky...@google.com>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Chase Latta <chase...@google.com>
Gerrit-Attention: Adam Barth <aba...@google.com>
Gerrit-Attention: Aaron Wood <aaro...@google.com>
Gerrit-Comment-Date: Wed, 29 Apr 2026 17:29:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/8fd9448faae90f286644fe9dc5d694fe6e19a1eb-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
unsatisfied_requirement
satisfied_requirement
open
diffy

'Kyo Lee (Gerrit)' via owners-override

unread,
1:46 PM (10 hours ago) 1:46 PM
to Oliver Newman, Adam Barth, Owners Override, Aaron Wood, Chase Latta, Jerry Belton, global-integrat...@fuchsia-infra.iam.gserviceaccount.com, fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com
Attention needed from Aaron Wood, Adam Barth, Chase Latta and Owners Override

Kyo Lee added 3 comments

File scripts/shac/skills.star

# Check for fatal crashes or failure to produce JSON.
if res.retcode != 0 or not res.stdout.strip().startswith("["):
ctx.emit.finding(
level = "error",
message = "Skill linter error:\n%s" % res.stderr,
)
continue
Oliver Newman . resolved

Nit: I'd rather just remove `raise_on_failure = False` and let shac handle the non-zero exit code.

Kyo Lee

Done

Line 50, Patchset 65: message = finding.get("message", "Skill linter finding."),
Oliver Newman . resolved
The script already sets `message` to a default value if it's not set, so no need for `get()`.
```suggestion
                message = finding["message"],
```
Kyo Lee

Done

File scripts/skill_linter/skill_linter.py
Line 606, Patchset 65: logging.info(f"PASSED: '{skill_name}' is valid.")
Oliver Newman . resolved

Please fix this WARNING reported by autoreview issue finding: If `fixit` is false and there are validation errors, this branch will execute and unconditionally log `PASSED: '{skill_name}' is valid.` after logging the errors.

Consider guarding this log message so it only prints if the file is genuinely valid:
```python
elif not errors and not warnings and new_content == original_content:
    logging.info(f"PASSED: '{skill_name}' is valid.")
```
Kyo Lee

Done

Open in Gerrit

Related details

Attention is currently required from:
  • Aaron Wood
  • Adam Barth
  • Chase Latta
  • Owners Override
Submit Requirements:
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: fuchsia
    Gerrit-Branch: main
    Gerrit-Change-Id: I4309a9b9f6738707f1e1388503e4ea4158a91ecb
    Gerrit-Change-Number: 1584836
    Gerrit-PatchSet: 66
    Gerrit-Owner: Kyo Lee <ky...@google.com>
    Gerrit-Reviewer: Aaron Wood <aaro...@google.com>
    Gerrit-Reviewer: Adam Barth <aba...@google.com>
    Gerrit-Reviewer: Jerry Belton <jce...@google.com>
    Gerrit-Reviewer: Kyo Lee <ky...@google.com>
    Gerrit-Reviewer: Oliver Newman <oliver...@google.com>
    Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
    Gerrit-CC: Chase Latta <chase...@google.com>
    Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
    Gerrit-Attention: Chase Latta <chase...@google.com>
    Gerrit-Attention: Adam Barth <aba...@google.com>
    Gerrit-Attention: Aaron Wood <aaro...@google.com>
    Gerrit-Comment-Date: Wed, 29 Apr 2026 17:46:01 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Oliver Newman <oliver...@google.com>

    --
    You received this message because you are subscribed to the Google Groups "owners-override" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
    To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/b67d4ed116d147c5feeb455ab685638a2196e112-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
    unsatisfied_requirement
    satisfied_requirement
    open
    diffy

    'Aaron Wood (Gerrit)' via owners-override

    unread,
    2:40 PM (9 hours ago) 2:40 PM
    to Kyo Lee, Oliver Newman, Adam Barth, Owners Override, Chase Latta, Jerry Belton, global-integrat...@fuchsia-infra.iam.gserviceaccount.com, fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com
    Attention needed from Adam Barth, Chase Latta, Kyo Lee and Owners Override

    Aaron Wood voted Code-Review+2

    Code-Review+2
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Adam Barth
    • Chase Latta
    • Kyo Lee
    • Owners Override
    Submit Requirements:
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: fuchsia
    Gerrit-Branch: main
    Gerrit-Change-Id: I4309a9b9f6738707f1e1388503e4ea4158a91ecb
    Gerrit-Change-Number: 1584836
    Gerrit-PatchSet: 67
    Gerrit-Owner: Kyo Lee <ky...@google.com>
    Gerrit-Reviewer: Aaron Wood <aaro...@google.com>
    Gerrit-Reviewer: Adam Barth <aba...@google.com>
    Gerrit-Reviewer: Jerry Belton <jce...@google.com>
    Gerrit-Reviewer: Kyo Lee <ky...@google.com>
    Gerrit-Reviewer: Oliver Newman <oliver...@google.com>
    Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
    Gerrit-CC: Chase Latta <chase...@google.com>
    Gerrit-Attention: Kyo Lee <ky...@google.com>
    Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
    Gerrit-Attention: Chase Latta <chase...@google.com>
    Gerrit-Attention: Adam Barth <aba...@google.com>
    Gerrit-Comment-Date: Wed, 29 Apr 2026 18:40:19 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes

    --
    You received this message because you are subscribed to the Google Groups "owners-override" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
    To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/a5d43b552ac6ef964ed9eef1b5c945171fe9b2b5-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
    unsatisfied_requirement
    satisfied_requirement
    open
    diffy

    'Adam Barth (Gerrit)' via owners-override

    unread,
    4:01 PM (7 hours ago) 4:01 PM
    to Kyo Lee, Aaron Wood, Oliver Newman, Owners Override, Chase Latta, Jerry Belton, global-integrat...@fuchsia-infra.iam.gserviceaccount.com, fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com
    Attention needed from Chase Latta, Kyo Lee and Owners Override

    Adam Barth voted Owners-Override+1

    Owners-Override+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Chase Latta
    • Kyo Lee
    • Owners Override
    Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: fuchsia
    Gerrit-Branch: main
    Gerrit-Change-Id: I4309a9b9f6738707f1e1388503e4ea4158a91ecb
    Gerrit-Change-Number: 1584836
    Gerrit-PatchSet: 67
    Gerrit-Owner: Kyo Lee <ky...@google.com>
    Gerrit-Reviewer: Aaron Wood <aaro...@google.com>
    Gerrit-Reviewer: Adam Barth <aba...@google.com>
    Gerrit-Reviewer: Jerry Belton <jce...@google.com>
    Gerrit-Reviewer: Kyo Lee <ky...@google.com>
    Gerrit-Reviewer: Oliver Newman <oliver...@google.com>
    Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
    Gerrit-CC: Chase Latta <chase...@google.com>
    Gerrit-Attention: Kyo Lee <ky...@google.com>
    Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
    Gerrit-Attention: Chase Latta <chase...@google.com>
    Gerrit-Comment-Date: Wed, 29 Apr 2026 20:01:12 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes

    --
    You received this message because you are subscribed to the Google Groups "owners-override" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
    To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/a835b67346b800617e9567ed347b85b62f6c0d7d-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
    satisfied_requirement
    open
    diffy

    'Kyo Lee (Gerrit)' via owners-override

    unread,
    4:02 PM (7 hours ago) 4:02 PM
    to Adam Barth, Aaron Wood, Oliver Newman, Owners Override, Chase Latta, Jerry Belton, global-integrat...@fuchsia-infra.iam.gserviceaccount.com, fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com
    Attention needed from Chase Latta and Owners Override

    Kyo Lee voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Chase Latta
    • Owners Override
    Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: fuchsia
    Gerrit-Branch: main
    Gerrit-Change-Id: I4309a9b9f6738707f1e1388503e4ea4158a91ecb
    Gerrit-Change-Number: 1584836
    Gerrit-PatchSet: 67
    Gerrit-Owner: Kyo Lee <ky...@google.com>
    Gerrit-Reviewer: Aaron Wood <aaro...@google.com>
    Gerrit-Reviewer: Adam Barth <aba...@google.com>
    Gerrit-Reviewer: Jerry Belton <jce...@google.com>
    Gerrit-Reviewer: Kyo Lee <ky...@google.com>
    Gerrit-Reviewer: Oliver Newman <oliver...@google.com>
    Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
    Gerrit-CC: Chase Latta <chase...@google.com>
    Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
    Gerrit-Attention: Chase Latta <chase...@google.com>
    Gerrit-Comment-Date: Wed, 29 Apr 2026 20:01:54 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes

    --
    You received this message because you are subscribed to the Google Groups "owners-override" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
    To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/c570de104f6bdef9d4c21570035442af47f19451-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
    satisfied_requirement
    open
    diffy

    'fuchsia-internal-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)' via owners-override

    unread,
    4:02 PM (7 hours ago) 4:02 PM
    to Kyo Lee, Adam Barth, Aaron Wood, Oliver Newman, Owners Override, Chase Latta, Jerry Belton, global-integrat...@fuchsia-infra.iam.gserviceaccount.com
    Commit message:
    [scripts][shac] Add custom linter rules for skill files.

    This adds the `skill_linter` tool to validate and format `SKILL.md`
    files. The tool is integrated with SHAC to support automated
    formatting via `fx format-code`.
    Test: fx test skill_linter_test
    Test: fx format-code --files=scripts/skill_linter/skill_linter.py
    Change-Id: I4309a9b9f6738707f1e1388503e4ea4158a91ecb
    Commit-Queue: Kyo Lee <ky...@google.com>
    Reviewed-by: Aaron Wood <aaro...@google.com>
    Reviewed-by: Jerry Belton <jce...@google.com>
    Reviewed-by: Oliver Newman <oliver...@google.com>
    Owners-Override: Adam Barth <aba...@google.com>
    Files:
    • M scripts/BUILD.gn
    • M scripts/shac/main.star
    • A scripts/shac/skills.star
    • A scripts/skill_linter/BUILD.gn
    • A scripts/skill_linter/OWNERS
    • A scripts/skill_linter/README.md
    • A scripts/skill_linter/skill_linter.py
    • A scripts/skill_linter/skill_linter_test.py
    Change size: XL
    Delta: 8 files changed, 1160 insertions(+), 0 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +2 by Jerry Belton, +2 by Aaron Wood, +2 by Oliver Newman
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: fuchsia
    Gerrit-Branch: main
    Gerrit-Change-Id: I4309a9b9f6738707f1e1388503e4ea4158a91ecb
    Gerrit-Change-Number: 1584836
    Gerrit-PatchSet: 68
    Gerrit-Owner: Kyo Lee <ky...@google.com>
    Gerrit-Reviewer: Aaron Wood <aaro...@google.com>
    Gerrit-Reviewer: Adam Barth <aba...@google.com>
    Gerrit-Reviewer: Jerry Belton <jce...@google.com>
    Gerrit-Reviewer: Kyo Lee <ky...@google.com>
    Gerrit-Reviewer: Oliver Newman <oliver...@google.com>
    Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>

    --
    You received this message because you are subscribed to the Google Groups "owners-override" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
    To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/9852ac50c85bbe8b3722686e85628bb89d3d925d-HTML%40fuchsia-review.googlesource.com.
    open
    diffy
    satisfied_requirement

    'global-integration-ci-builder@fuchsia-infra.iam.gserviceaccount.com (Gerrit)' via owners-override

    unread,
    4:05 PM (7 hours ago) 4:05 PM
    to Kyo Lee, fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com, Adam Barth, Aaron Wood, Oliver Newman, Owners Override, Chase Latta, Jerry Belton, global-integrat...@fuchsia-infra.iam.gserviceaccount.com

    Message from global-integra...@fuchsia-infra.iam.gserviceaccount.com

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: fuchsia
    Gerrit-Branch: main
    Gerrit-Change-Id: I4309a9b9f6738707f1e1388503e4ea4158a91ecb
    Gerrit-Change-Number: 1584836
    Gerrit-PatchSet: 68
    Gerrit-Owner: Kyo Lee <ky...@google.com>
    Gerrit-Reviewer: Aaron Wood <aaro...@google.com>
    Gerrit-Reviewer: Adam Barth <aba...@google.com>
    Gerrit-Reviewer: Jerry Belton <jce...@google.com>
    Gerrit-Reviewer: Kyo Lee <ky...@google.com>
    Gerrit-Reviewer: Oliver Newman <oliver...@google.com>
    Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
    Gerrit-CC: Chase Latta <chase...@google.com>

    --
    You received this message because you are subscribed to the Google Groups "owners-override" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
    To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/eccb5d77e30989d42901f35c12ea39d18f8599ac-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
    satisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages