Groups keyboard shortcuts have been updated
Dismiss
See shortcuts

[L] Change in fuchsia/fuchsia[main]: [predicates] Support fit::result<>.

0 views
Skip to first unread message

'Hunter Freyer (Gerrit)' via owners-override

unread,
Mar 31, 2025, 4:34:28 PMMar 31
to Owners Override
Attention needed from Owners Override

Hunter Freyer has uploaded the change for review

Hunter Freyer would like Owners Override to review this change.

Commit message

[predicates] Support fit::result<>.

This is an extension of fxrev.dev/1075223 to support fit::result, not
just zx::result (the latter being a subclass). fit::result<zx_status_t,
T> continues to have the same experience that zx::result<T> has before
this CL.

In particular, this means you can use ASSERT_OK on the result of a FIDL
call, which pleases me.

Updates a random subset of examples to take advantage of this.
Change-Id: I7e29a54ec7686a803c3e390b157a56bcc15c16ef

Change diff


Change information

Files:
  • M examples/drivers/metadata/test/BUILD.gn
  • M examples/drivers/metadata/test/metadata_example_test.cc
  • M examples/drivers/transport/zircon/rust/child/BUILD.gn
  • M examples/drivers/transport/zircon/rust/child/child-driver-test.cc
  • M examples/drivers/transport/zircon/rust/parent/BUILD.gn
  • M examples/drivers/transport/zircon/rust/parent/parent-driver-test.cc
  • M examples/fidl/calculator/cpp/integration_test/BUILD.gn
  • M examples/fidl/calculator/cpp/integration_test/calc_integration_test.cc
  • M examples/power/wake_lease/cpp/BUILD.gn
  • M examples/power/wake_lease/cpp/wake_lease_integration_test.cc
  • M src/lib/testing/predicates/BUILD.gn
  • M src/lib/testing/predicates/predicates_test.cc
  • M src/lib/testing/predicates/status.cc
  • M src/lib/testing/predicates/status.h
Change size: L
Delta: 14 files changed, 430 insertions(+), 128 deletions(-)
Open in Gerrit

Related details

Attention is currently required from:
  • Owners Override
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I7e29a54ec7686a803c3e390b157a56bcc15c16ef
Gerrit-Change-Number: 1238472
Gerrit-PatchSet: 6
Gerrit-Owner: Hunter Freyer <hjfr...@google.com>
Gerrit-Reviewer: Bruno Dal Bo <bruno...@google.com>
Gerrit-Reviewer: Hunter Freyer <hjfr...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/473ede8099fb8998412f5849c96d85f063fe761e-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy

'Adam Barth (Gerrit)' via owners-override

unread,
Mar 31, 2025, 4:51:59 PMMar 31
to Hunter Freyer, Owners Override, Bruno Dal Bo, GI Try Builder, CQ Bot
Attention needed from Hunter Freyer and Owners Override

Adam Barth voted Owners-Override+1

Owners-Override+1
Open in Gerrit

Related details

Attention is currently required from:
  • Hunter Freyer
  • Owners Override
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I7e29a54ec7686a803c3e390b157a56bcc15c16ef
Gerrit-Change-Number: 1238472
Gerrit-PatchSet: 6
Gerrit-Owner: Hunter Freyer <hjfr...@google.com>
Gerrit-Reviewer: Adam Barth <aba...@google.com>
Gerrit-Reviewer: Bruno Dal Bo <bruno...@google.com>
Gerrit-Reviewer: Hunter Freyer <hjfr...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Hunter Freyer <hjfr...@google.com>
Gerrit-Comment-Date: Mon, 31 Mar 2025 20:51:53 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/b58d8efee7f877ec983b48e422c45d2c76457489-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy

'CQ Bot (Gerrit)' via owners-override

unread,
Mar 31, 2025, 5:05:01 PMMar 31
to Hunter Freyer, Auto-Submit, Adam Barth, Owners Override, Bruno Dal Bo, GI Try Builder

CQ Bot submitted the change

Change information

Commit message:
[predicates] Support fit::result<>.

This is an extension of fxrev.dev/1075223 to support fit::result, not
just zx::result (the latter being a subclass). fit::result<zx_status_t,
T> continues to have the same experience that zx::result<T> has before
this CL.

In particular, this means you can use ASSERT_OK on the result of a FIDL
call, which pleases me.

Updates a random subset of examples to take advantage of this.
Change-Id: I7e29a54ec7686a803c3e390b157a56bcc15c16ef
Owners-Override: Adam Barth <aba...@google.com>
Fuchsia-Auto-Submit: Hunter Freyer <hjfr...@google.com>
Reviewed-by: Bruno Dal Bo <bruno...@google.com>
Files:
  • M examples/drivers/metadata/test/BUILD.gn
  • M examples/drivers/metadata/test/metadata_example_test.cc
  • M examples/drivers/transport/zircon/rust/child/BUILD.gn
  • M examples/drivers/transport/zircon/rust/child/child-driver-test.cc
  • M examples/drivers/transport/zircon/rust/parent/BUILD.gn
  • M examples/drivers/transport/zircon/rust/parent/parent-driver-test.cc
  • M examples/fidl/calculator/cpp/integration_test/BUILD.gn
  • M examples/fidl/calculator/cpp/integration_test/calc_integration_test.cc
  • M examples/power/wake_lease/cpp/BUILD.gn
  • M examples/power/wake_lease/cpp/wake_lease_integration_test.cc
  • M src/lib/testing/predicates/BUILD.gn
  • M src/lib/testing/predicates/predicates_test.cc
  • M src/lib/testing/predicates/status.cc
  • M src/lib/testing/predicates/status.h
Change size: L
Delta: 14 files changed, 430 insertions(+), 128 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +2 by Bruno Dal Bo
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I7e29a54ec7686a803c3e390b157a56bcc15c16ef
Gerrit-Change-Number: 1238472
Gerrit-PatchSet: 7
Gerrit-Owner: Hunter Freyer <hjfr...@google.com>
Gerrit-Reviewer: Adam Barth <aba...@google.com>
Gerrit-Reviewer: Auto-Submit <auto-...@fuchsia-infra.iam.gserviceaccount.com>
Gerrit-Reviewer: Bruno Dal Bo <bruno...@google.com>
Gerrit-Reviewer: Hunter Freyer <hjfr...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/66a93acbda117d478e5eae027be405c1248fcafb-HTML%40fuchsia-review.googlesource.com.
open
diffy
satisfied_requirement

'GI Roller (Gerrit)' via owners-override

unread,
Mar 31, 2025, 5:13:51 PMMar 31
to Hunter Freyer, CQ Bot, Auto-Submit, Adam Barth, Owners Override, Bruno Dal Bo, GI Try Builder

Message from GI Roller

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I7e29a54ec7686a803c3e390b157a56bcc15c16ef
Gerrit-Change-Number: 1238472
Gerrit-PatchSet: 7
Gerrit-Owner: Hunter Freyer <hjfr...@google.com>
Gerrit-Reviewer: Adam Barth <aba...@google.com>
Gerrit-Reviewer: Auto-Submit <auto-...@fuchsia-infra.iam.gserviceaccount.com>
Gerrit-Reviewer: Bruno Dal Bo <bruno...@google.com>
Gerrit-Reviewer: Hunter Freyer <hjfr...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Comment-Date: Mon, 31 Mar 2025 21:13:48 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/ce42d8a87a188c274f6ce430fbd50318704a2901-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages