[XS] Change in fuchsia/fuchsia[main]: [magma] Prepare for switch to IOBuffers for logging

['Chris Suter (Gerrit)' via owners-override]

Attention needed from Matt Sandy and Owners Override

Chris Suter has uploaded the change for review

Chris Suter would like Owners Override to review this change.

Commit message

[magma] Prepare for switch to IOBuffers for logging

Bug: 441642041

Bug: 377963307

Change-Id: Ic0c70a33ff19dab8237ca45c56790c39733c8c51

Change diff

diff --git a/src/graphics/lib/magma/gnbuild/imported_symbols.allowlist b/src/graphics/lib/magma/gnbuild/imported_symbols.allowlist
index 6514e3a..f4f73e3 100644
--- a/src/graphics/lib/magma/gnbuild/imported_symbols.allowlist
+++ b/src/graphics/lib/magma/gnbuild/imported_symbols.allowlist
@@ -465,6 +465,7 @@
 zx_handle_replace
 zx_interrupt_bind
 zx_interrupt_create
+zx_iob_writev
 zx_iommu_create
 zx_job_create
 zx_object_get_child
diff --git a/src/graphics/magma/tests/integration/meta/magma_conformance_tests_child.shard.cml b/src/graphics/magma/tests/integration/meta/magma_conformance_tests_child.shard.cml
index 7687247..bb61eef 100644
--- a/src/graphics/magma/tests/integration/meta/magma_conformance_tests_child.shard.cml
+++ b/src/graphics/magma/tests/integration/meta/magma_conformance_tests_child.shard.cml
@@ -3,7 +3,11 @@
 // found in the LICENSE file.
 {
     include: [
-        "//src/sys/test_runners/gtest/default.shard.cml",
+        // TODO(https://fxbug.dev/441642041): Stabilize zx_iob_create_shared_region
+        // We use the zxtest runner for VDSO next which is currently required
+        // for some of the IOB API which is used by logging fakes. We can switch
+        // back to the default runner when it is stabilised.
+        "//src/sys/test_runners/gtest/zxtest.shard.cml",
         "syslog/client.shard.cml",
     ],
     use: [

Change information

Files:

• M src/graphics/lib/magma/gnbuild/imported_symbols.allowlist
• M src/graphics/magma/tests/integration/meta/magma_conformance_tests_child.shard.cml

Change size: XS

Delta: 2 files changed, 6 insertions(+), 1 deletion(-)

Open in Gerrit

Related details

Attention is currently required from:

• Matt Sandy
• Owners Override

Submit Requirements:

• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: newchange

Gerrit-Project: fuchsia

Gerrit-Branch: main

Gerrit-Change-Id: Ic0c70a33ff19dab8237ca45c56790c39733c8c51

Gerrit-Change-Number: 1356526

Gerrit-PatchSet: 2

Gerrit-Owner: Chris Suter <csu...@google.com>

Gerrit-Reviewer: Chris Suter <csu...@google.com>

Gerrit-Reviewer: Matt Sandy <msa...@google.com>

Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>

Gerrit-CC: CQ Bot <fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: GI Try Builder <global-integrat...@fuchsia-infra.iam.gserviceaccount.com>

Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>

Gerrit-Attention: Matt Sandy <msa...@google.com>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/084cd7088b57fbcbff5d1722a4142951d9d6b769-HTML%40fuchsia-review.googlesource.com.

['Chris Suter (Gerrit)' via owners-override]

Attention needed from Matt Sandy and Owners Override

Chris Suter voted and added 1 comment

Votes added by Chris Suter

Fuchsia-Auto-Submit

+1

1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Chris Suter . resolved

Adding owners override in the hope that I can get this reviewed earlier than it might otherwise.

Open in Gerrit

Related details

Attention is currently required from:

• Matt Sandy
• Owners Override

Submit Requirements:

• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: fuchsia

Gerrit-Branch: main

Gerrit-Change-Id: Ic0c70a33ff19dab8237ca45c56790c39733c8c51

Gerrit-Change-Number: 1356526

Gerrit-PatchSet: 2

Gerrit-Owner: Chris Suter <csu...@google.com>

Gerrit-Reviewer: Chris Suter <csu...@google.com>

Gerrit-Reviewer: Matt Sandy <msa...@google.com>

Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>

Gerrit-CC: CQ Bot <fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: GI Try Builder <global-integrat...@fuchsia-infra.iam.gserviceaccount.com>

Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>

Gerrit-Attention: Matt Sandy <msa...@google.com>

Gerrit-Comment-Date: Mon, 01 Sep 2025 03:19:54 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/084cd7088b57fbcbff5d1722a4142951d9d6b769-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

['Adam Barth (Gerrit)' via owners-override]

Attention needed from Chris Suter, Matt Sandy and Owners Override

Adam Barth voted Owners-Override+1

Owners-Override

+1

Open in Gerrit

Related details

Attention is currently required from:

• Chris Suter
• Matt Sandy
• Owners Override

Submit Requirements:

• Code-Owners

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: fuchsia

Gerrit-Branch: main

Gerrit-Change-Id: Ic0c70a33ff19dab8237ca45c56790c39733c8c51

Gerrit-Change-Number: 1356526

Gerrit-PatchSet: 2

Gerrit-Owner: Chris Suter <csu...@google.com>

Gerrit-Reviewer: Adam Barth <aba...@google.com>

Gerrit-Reviewer: Chris Suter <csu...@google.com>

Gerrit-Reviewer: Matt Sandy <msa...@google.com>

Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>

Gerrit-CC: CQ Bot <fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: GI Try Builder <global-integrat...@fuchsia-infra.iam.gserviceaccount.com>

Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>

Gerrit-Attention: Matt Sandy <msa...@google.com>

Gerrit-Attention: Chris Suter <csu...@google.com>

Gerrit-Comment-Date: Tue, 02 Sep 2025 00:20:33 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/6080a628b4b63bc0cfc88cf686c7d5581c9b1819-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

['Adam Barth (Gerrit)' via owners-override]

Attention needed from Chris Suter, Matt Sandy and Owners Override

Adam Barth voted Code-Review+2

Code-Review

+2

Open in Gerrit

Related details

Attention is currently required from:

• Chris Suter
• Matt Sandy
• Owners Override

Submit Requirements:

• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: fuchsia

Gerrit-Branch: main

Gerrit-Change-Id: Ic0c70a33ff19dab8237ca45c56790c39733c8c51

Gerrit-Change-Number: 1356526

Gerrit-PatchSet: 2

Gerrit-Owner: Chris Suter <csu...@google.com>

Gerrit-Reviewer: Adam Barth <aba...@google.com>

Gerrit-Reviewer: Chris Suter <csu...@google.com>

Gerrit-Reviewer: Matt Sandy <msa...@google.com>

Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>

Gerrit-CC: CQ Bot <fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: GI Try Builder <global-integrat...@fuchsia-infra.iam.gserviceaccount.com>

Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>

Gerrit-Attention: Matt Sandy <msa...@google.com>

Gerrit-Attention: Chris Suter <csu...@google.com>

Gerrit-Comment-Date: Tue, 02 Sep 2025 00:20:51 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/90844a1a182f7a17ab667257083aa2768c4b5197-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

['CQ Bot (Gerrit)' via owners-override]

CQ Bot submitted the change

Change information

Commit message:

[magma] Prepare for switch to IOBuffers for logging

Bug: 441642041

Bug: 377963307

Change-Id: Ic0c70a33ff19dab8237ca45c56790c39733c8c51

Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1356526

Fuchsia-Auto-Submit: Chris Suter <csu...@google.com>

Commit-Queue: Chris Suter <csu...@google.com>

Owners-Override: Adam Barth <aba...@google.com>

Reviewed-by: Adam Barth <aba...@google.com>

Files:

• M src/graphics/lib/magma/gnbuild/imported_symbols.allowlist
• M src/graphics/magma/tests/integration/meta/magma_conformance_tests_child.shard.cml

Change size: XS

Delta: 2 files changed, 6 insertions(+), 1 deletion(-)

Branch: refs/heads/main

Submit Requirements:

• Code-Review: +2 by Adam Barth

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: fuchsia

Gerrit-Branch: main

Gerrit-Change-Id: Ic0c70a33ff19dab8237ca45c56790c39733c8c51

Gerrit-Change-Number: 1356526

Gerrit-PatchSet: 3

Gerrit-Owner: Chris Suter <csu...@google.com>

Gerrit-Reviewer: Adam Barth <aba...@google.com>

Gerrit-Reviewer: CQ Bot <fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Chris Suter <csu...@google.com>

Gerrit-Reviewer: Matt Sandy <msa...@google.com>

Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>

Gerrit-CC: GI Try Builder <global-integrat...@fuchsia-infra.iam.gserviceaccount.com>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/1d797c02ba236638073ea3866b243b3ce853b4c0-HTML%40fuchsia-review.googlesource.com.

['GI Roller (Gerrit)' via owners-override]

Message from GI Roller

Change has been successfully rolled: https://turquoise-internal-review.googlesource.com/1039183

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: fuchsia

Gerrit-Branch: main

Gerrit-Change-Id: Ic0c70a33ff19dab8237ca45c56790c39733c8c51

Gerrit-Change-Number: 1356526

Gerrit-PatchSet: 3

Gerrit-Owner: Chris Suter <csu...@google.com>

Gerrit-Reviewer: Adam Barth <aba...@google.com>

Gerrit-Reviewer: CQ Bot <fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Chris Suter <csu...@google.com>

Gerrit-Reviewer: Matt Sandy <msa...@google.com>

Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>

Gerrit-CC: GI Roller <global-integra...@fuchsia-infra.iam.gserviceaccount.com>

Gerrit-CC: GI Try Builder <global-integrat...@fuchsia-infra.iam.gserviceaccount.com>

Gerrit-Comment-Date: Tue, 02 Sep 2025 01:03:06 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: No

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/3410dee5647d5787ec3cc71fc117d34e6bdcc8da-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.