[XS] Change in fuchsia/fuchsia[main]: [magma] Prepare for switch to IOBuffers for logging
0 views
Skip to first unread message
'Chris Suter (Gerrit)' via owners-override
Aug 31, 2025, 11:20:01 PMAug 31
to Owners Override
Attention needed from Matt Sandy and Owners Override
Chris Suter has uploaded the change for review![]( "Open in Gerrit")
Chris Suter would like Owners Override to review this change.
Commit message
[magma] Prepare for switch to IOBuffers for logging
Bug: 441642041
Bug: 377963307
Change-Id: Ic0c70a33ff19dab8237ca45c56790c39733c8c51
Change diff
diff --git a/src/graphics/lib/magma/gnbuild/imported_symbols.allowlist b/src/graphics/lib/magma/gnbuild/imported_symbols.allowlist
index 6514e3a..f4f73e3 100644
--- a/src/graphics/lib/magma/gnbuild/imported_symbols.allowlist
+++ b/src/graphics/lib/magma/gnbuild/imported_symbols.allowlist
@@ -465,6 +465,7 @@
zx_handle_replace
zx_interrupt_bind
zx_interrupt_create
+zx_iob_writev
zx_iommu_create
zx_job_create
zx_object_get_child
diff --git a/src/graphics/magma/tests/integration/meta/magma_conformance_tests_child.shard.cml b/src/graphics/magma/tests/integration/meta/magma_conformance_tests_child.shard.cml
index 7687247..bb61eef 100644
--- a/src/graphics/magma/tests/integration/meta/magma_conformance_tests_child.shard.cml
+++ b/src/graphics/magma/tests/integration/meta/magma_conformance_tests_child.shard.cml
@@ -3,7 +3,11 @@
// found in the LICENSE file.
{
include: [
- "//src/sys/test_runners/gtest/default.shard.cml",
+ // TODO(https://fxbug.dev/441642041): Stabilize zx_iob_create_shared_region
+ // We use the zxtest runner for VDSO next which is currently required
+ // for some of the IOB API which is used by logging fakes. We can switch
+ // back to the default runner when it is stabilised.
+ "//src/sys/test_runners/gtest/zxtest.shard.cml",
"syslog/client.shard.cml",
],
use: [
Change information
Files:
- M src/graphics/lib/magma/gnbuild/imported_symbols.allowlist
- M src/graphics/magma/tests/integration/meta/magma_conformance_tests_child.shard.cml
Change size: XS
Delta: 2 files changed, 6 insertions(+), 1 deletion(-)
Related details
Attention is currently required from:
- Matt Sandy
- Owners Override
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/084cd7088b57fbcbff5d1722a4142951d9d6b769-HTML%40fuchsia-review.googlesource.com.
'Chris Suter (Gerrit)' via owners-override
Aug 31, 2025, 11:20:14 PMAug 31
to Owners Override, Matt Sandy, GI Try Builder, CQ Bot
Attention needed from Matt Sandy and Owners Override
Chris Suter voted and added 1 comment![]( "Open in Gerrit")
Votes added by Chris Suter
| Fuchsia-Auto-Submit | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Chris Suter . resolved
Adding owners override in the hope that I can get this reviewed earlier than it might otherwise.
Related details
Attention is currently required from:
- Matt Sandy
- Owners Override
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/084cd7088b57fbcbff5d1722a4142951d9d6b769-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'Adam Barth (Gerrit)' via owners-override
Sep 1, 2025, 8:20:44 PMSep 1
to Chris Suter, Owners Override, Matt Sandy, GI Try Builder, CQ Bot
Attention needed from Chris Suter, Matt Sandy and Owners Override
Adam Barth voted Owners-Override+1![]( "Open in Gerrit")
Attention is currently required from:
- Chris Suter
- Matt Sandy
- Owners Override
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/6080a628b4b63bc0cfc88cf686c7d5581c9b1819-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'Adam Barth (Gerrit)' via owners-override
Sep 1, 2025, 8:20:59 PMSep 1
to Chris Suter, Owners Override, Matt Sandy, GI Try Builder, CQ Bot
Attention needed from Chris Suter, Matt Sandy and Owners Override
Adam Barth voted Code-Review+2![]( "Open in Gerrit")
| Code-Review | +2 |
Related details
Attention is currently required from:
- Chris Suter
- Matt Sandy
- Owners Override
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/90844a1a182f7a17ab667257083aa2768c4b5197-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'CQ Bot (Gerrit)' via owners-override
Sep 1, 2025, 9:00:49 PMSep 1
to Chris Suter, Adam Barth, Owners Override, Matt Sandy, GI Try Builder
CQ Bot submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[magma] Prepare for switch to IOBuffers for logging
Bug: 441642041
Bug: 377963307
Change-Id: Ic0c70a33ff19dab8237ca45c56790c39733c8c51
Fuchsia-Auto-Submit: Chris Suter <csu...@google.com>
Commit-Queue: Chris Suter <csu...@google.com>
Owners-Override: Adam Barth <aba...@google.com>
Reviewed-by: Adam Barth <aba...@google.com>
Files:
- M src/graphics/lib/magma/gnbuild/imported_symbols.allowlist
- M src/graphics/magma/tests/integration/meta/magma_conformance_tests_child.shard.cml
Change size: XS
Delta: 2 files changed, 6 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +2 by Adam Barth
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/1d797c02ba236638073ea3866b243b3ce853b4c0-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'GI Roller (Gerrit)' via owners-override
Sep 1, 2025, 9:03:10 PMSep 1
to Chris Suter, CQ Bot, Adam Barth, Owners Override, Matt Sandy, GI Try Builder
Message from GI Roller![]( "Open in Gerrit")
Change has been successfully rolled: https://turquoise-internal-review.googlesource.com/1039183
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/3410dee5647d5787ec3cc71fc117d34e6bdcc8da-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
Reply all
Reply to author
Forward
0 new messages