[XS] Change in fuchsia/fuchsia[main]: [camera-gym] Add a missing <cstdint> include

0 views
Skip to first unread message

'Petr Hosek (Gerrit)' via owners-override

unread,
Apr 17, 2024, 1:21:12 PMApr 17
to Owners Override
Attention needed from John Sasinowski, Matt Thiffault and Owners Override

Petr Hosek has uploaded the change for review

Petr Hosek would like Owners Override to review this change.

Commit message

[camera-gym] Add a missing <cstdint> include

libc++ recently removed a transitive include of <cstdint> from <tuple>
which caused this code to fail to compile because it uses uint32_t
without including <cstdint>.
Change-Id: I27173574b43c5811fb0a92105604767f9607e603

Change diff

diff --git a/src/camera/bin/camera-gym/screen_util.h b/src/camera/bin/camera-gym/screen_util.h
index cb16883..7fced40 100644
--- a/src/camera/bin/camera-gym/screen_util.h
+++ b/src/camera/bin/camera-gym/screen_util.h
@@ -4,6 +4,7 @@
 #ifndef SRC_CAMERA_BIN_CAMERA_GYM_SCREEN_UTIL_H_
 #define SRC_CAMERA_BIN_CAMERA_GYM_SCREEN_UTIL_H_
 
+#include <cstdint>
 #include <tuple>
 
 namespace screen_util {

Change information

Files:
  • M src/camera/bin/camera-gym/screen_util.h
Change size: XS
Delta: 1 file changed, 1 insertion(+), 0 deletions(-)
Open in Gerrit

Related details

Attention is currently required from:
  • John Sasinowski
  • Matt Thiffault
  • Owners Override
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I27173574b43c5811fb0a92105604767f9607e603
Gerrit-Change-Number: 1029973
Gerrit-PatchSet: 1
Gerrit-Owner: Petr Hosek <pho...@google.com>
Gerrit-Reviewer: John Sasinowski <jsasi...@google.com>
Gerrit-Reviewer: Matt Thiffault <mthif...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Reviewer: Petr Hosek <pho...@google.com>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Matt Thiffault <mthif...@google.com>
Gerrit-Attention: John Sasinowski <jsasi...@google.com>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/f04f89dec261cf01b58d0621bb20bc299eca1f1d-HTML%40fuchsia-review.googlesource.com.
unsatisfied_requirement
open
diffy

'James Robinson (Gerrit)' via owners-override

unread,
Apr 17, 2024, 1:39:20 PMApr 17
to Petr Hosek, Owners Override, CQ Bot, Matt Thiffault, John Sasinowski
Attention needed from John Sasinowski, Matt Thiffault, Owners Override and Petr Hosek

James Robinson voted

Code-Review+2
Owners-Override+1
Open in Gerrit

Related details

Attention is currently required from:
  • John Sasinowski
  • Matt Thiffault
  • Owners Override
  • Petr Hosek
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I27173574b43c5811fb0a92105604767f9607e603
Gerrit-Change-Number: 1029973
Gerrit-PatchSet: 1
Gerrit-Owner: Petr Hosek <pho...@google.com>
Gerrit-Reviewer: James Robinson <jam...@google.com>
Gerrit-Reviewer: John Sasinowski <jsasi...@google.com>
Gerrit-Reviewer: Matt Thiffault <mthif...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Reviewer: Petr Hosek <pho...@google.com>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Petr Hosek <pho...@google.com>
Gerrit-Attention: Matt Thiffault <mthif...@google.com>
Gerrit-Attention: John Sasinowski <jsasi...@google.com>
Gerrit-Comment-Date: Wed, 17 Apr 2024 17:39:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/cd4006118a68e20d977a9502b3cea3f6bfe0d29f-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy

'CQ Bot (Gerrit)' via owners-override

unread,
Apr 17, 2024, 1:39:55 PMApr 17
to Petr Hosek, Auto-Submit, James Robinson, Owners Override, Matt Thiffault, John Sasinowski

CQ Bot submitted the change

Change information

Commit message:
[camera-gym] Add a missing <cstdint> include

libc++ recently removed a transitive include of <cstdint> from <tuple>
which caused this code to fail to compile because it uses uint32_t
without including <cstdint>.
Change-Id: I27173574b43c5811fb0a92105604767f9607e603
Owners-Override: James Robinson <jam...@google.com>
Reviewed-by: James Robinson <jam...@google.com>
Fuchsia-Auto-Submit: Petr Hosek <pho...@google.com>
Files:
  • M src/camera/bin/camera-gym/screen_util.h
Change size: XS
Delta: 1 file changed, 1 insertion(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +2 by James Robinson
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I27173574b43c5811fb0a92105604767f9607e603
Gerrit-Change-Number: 1029973
Gerrit-PatchSet: 2
Gerrit-Owner: Petr Hosek <pho...@google.com>
Gerrit-Reviewer: Auto-Submit <auto-...@fuchsia-infra.iam.gserviceaccount.com>
Gerrit-Reviewer: James Robinson <jam...@google.com>
Gerrit-Reviewer: John Sasinowski <jsasi...@google.com>
Gerrit-Reviewer: Matt Thiffault <mthif...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Reviewer: Petr Hosek <pho...@google.com>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/3cba3baa8d849d1bdedaeb56bc49a48ed0d69c0b-HTML%40fuchsia-review.googlesource.com.
open
diffy
satisfied_requirement

'GI Roller (Gerrit)' via owners-override

unread,
Apr 17, 2024, 1:43:21 PMApr 17
to Petr Hosek, CQ Bot, Auto-Submit, James Robinson, Owners Override, Matt Thiffault, John Sasinowski

Message from GI Roller

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I27173574b43c5811fb0a92105604767f9607e603
Gerrit-Change-Number: 1029973
Gerrit-PatchSet: 2
Gerrit-Owner: Petr Hosek <pho...@google.com>
Gerrit-Reviewer: Auto-Submit <auto-...@fuchsia-infra.iam.gserviceaccount.com>
Gerrit-Reviewer: James Robinson <jam...@google.com>
Gerrit-Reviewer: John Sasinowski <jsasi...@google.com>
Gerrit-Reviewer: Matt Thiffault <mthif...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Reviewer: Petr Hosek <pho...@google.com>
Gerrit-Comment-Date: Wed, 17 Apr 2024 17:43:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/434d58d203b9f4f5112ce1fd249ca8ab22491811-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages