[L] Change in fuchsia/fuchsia[main]: [rust] Migrate fuchsia to std::io::Error::other
12 views
Skip to first unread message
'Erick Tryzelaar (Gerrit)' via owners-override
Mar 5, 2025, 8:30:20 PM3/5/25
to Owners Override
Attention needed from Owners Override
Erick Tryzelaar has uploaded the change for review![]( "Open in Gerrit")
Erick Tryzelaar would like Owners Override to review this change.
Commit message
[rust] Migrate fuchsia to std::io::Error::other
Clippy now suggests migrating from:
```
std::io::Error::new(ErrorKind::Other, ...)
```
to the shorter:
```
std::io::Error::other(...)
```
Change-Id: I9ce628c35250b774f3cf4e03f6c66f0a5369b2cc
Change diff
Change information
Files:
- M src/connectivity/bluetooth/lib/fuchsia-audio-codec/src/stream_processor.rs
- M src/connectivity/bluetooth/lib/fuchsia-audio-device/src/audio_frame_sink.rs
- M src/connectivity/bluetooth/profiles/bt-a2dp/src/media/player.rs
- M src/connectivity/lib/ping/src/lib.rs
- M src/connectivity/network/dhcpv6/client/src/client.rs
- M src/developer/ffx/config/domain/src/config_domain.rs
- M src/developer/ffx/lib/fastboot/transport/interface/src/tcp.rs
- M src/developer/ffx/lib/fastboot/transport/interface/src/udp.rs
- M src/developer/ffx/plugins/audio/common/src/lib.rs
- M src/firmware/fastboot-tcp/src/fastboot.rs
- M src/lib/async-gunzip/src/errors.rs
- M src/lib/async-utils/src/async_once/mod.rs
- M src/lib/fuchsia-async/src/net/fuchsia/udp.rs
- M src/lib/fuchsia-fs/src/file/async_read_at.rs
- M src/lib/fuchsia-fs/src/file/async_read_at_ext.rs
- M src/lib/fuchsia-fs/src/file/async_reader.rs
- M src/lib/fuchsia-fs/src/file/buffered_async_read_at.rs
- M src/lib/fuchsia-hyper/src/fuchsia.rs
- M src/lib/fuchsia-hyper/src/lib.rs
- M src/lib/fuchsia-hyper/src/not_fuchsia.rs
- M src/lib/fuchsia-lockfile/src/lib.rs
- M src/lib/usb_bulk/rust/src/lib.rs
- M src/lib/usb_rs/src/usb_osx/iokit_wrappers.rs
- M src/security/lib/scrutiny/utils/src/io/mod.rs
- M src/storage/lib/block_client/rust/src/cache.rs
- M src/sys/component_manager/tests/rights/use_dir_rights.rs
- M src/sys/pkg/lib/fuchsia-repo/src/repository/gcs_repository.rs
- M src/sys/pkg/lib/fuchsia-repo/src/repository/http_repository.rs
- M src/sys/pkg/lib/fuchsia-repo/src/util.rs
- M src/virtualization/tests/virtio_block_test_util/src/linux_main.rs
- M src/virtualization/tests/virtio_net_test_util/src/linux_main.rs
- M src/virtualization/tests/virtio_rng_test_util/src/linux_main.rs
- M tools/cargo-gnaw/tests/platform_deps/vendor/anyhow/tests/common/mod.rs
- M tools/cargo-gnaw/tests/platform_deps/vendor/anyhow/tests/test_boxed.rs
- M tools/cargo-gnaw/tests/platform_deps/vendor/anyhow/tests/test_source.rs
- M tools/cargo-gnaw/tests/simple_deps/vendor/anyhow/tests/common/mod.rs
- M tools/cargo-gnaw/tests/simple_deps/vendor/anyhow/tests/test_boxed.rs
- M tools/cargo-gnaw/tests/simple_deps/vendor/anyhow/tests/test_source.rs
- M tools/zedmon/client/src/zedmon.rs
Change size: L
Delta: 39 files changed, 131 insertions(+), 252 deletions(-)
Related details
Attention is currently required from:
- Owners Override
Submit Requirements:
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/8764dee27aaf21e45ae055fedbd919909dff1466-HTML%40fuchsia-review.googlesource.com.
'Erick Tryzelaar (Gerrit)' via owners-override
Mar 5, 2025, 8:30:22 PM3/5/25
to Owners Override, Fuchsia Try Builder, Marie Janssen, GI Try Builder, CQ Bot
Attention needed from Owners Override
Erick Tryzelaar voted and added 1 comment![]( "Open in Gerrit")
Votes added by Erick Tryzelaar
| Fuchsia-Auto-Submit | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 4 (Latest):
Erick Tryzelaar . resolved
Adding owners override, since this is a large scale rollout of a trivial cleanup
Related details
Attention is currently required from:
- Owners Override
Submit Requirements:
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/8764dee27aaf21e45ae055fedbd919909dff1466-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'Laura Peskin (Gerrit)' via owners-override
Mar 5, 2025, 8:32:10 PM3/5/25
to Erick Tryzelaar, Owners Override, Fuchsia Try Builder, Marie Janssen, GI Try Builder, CQ Bot
Attention needed from Erick Tryzelaar and Owners Override
Laura Peskin voted and added 1 comment![]( "Open in Gerrit")
Votes added by Laura Peskin
| Code-Review | +2 |
1 comment
Patchset-level comments
Attention is currently required from:
- Erick Tryzelaar
- Owners Override
Submit Requirements:
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/a64a7e469ab7f12be0e1ef5e66aa7a717fa2c499-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'Adam Barth (Gerrit)' via owners-override
Mar 5, 2025, 11:27:57 PM3/5/25
to Erick Tryzelaar, Laura Peskin, Owners Override, Fuchsia Try Builder, Marie Janssen, GI Try Builder, CQ Bot
Attention needed from Erick Tryzelaar and Owners Override
Adam Barth voted Owners-Override+1![]( "Open in Gerrit")
| Owners-Override | +1 |
Related details
Attention is currently required from:
- Erick Tryzelaar
- Owners Override
Submit Requirements:
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/a57144f0169b940356c85228c5fd26ef132ccf2d-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'Erick Tryzelaar (Gerrit)' via owners-override
Mar 6, 2025, 3:55:50 PM3/6/25
to Owners Override
Attention needed from Adam Barth
Erick Tryzelaar has uploaded the change for review![]( "Open in Gerrit")
Erick Tryzelaar removed Owners Override from reviewers of this change.
Change information
Files:
- M src/sys/pkg/lib/fuchsia-merkle/src/tree.rs
- M src/sys/pkg/lib/fuchsia-repo/src/repository/gcs_repository.rs
- M src/sys/pkg/lib/fuchsia-repo/src/repository/http_repository.rs
- M src/sys/pkg/lib/fuchsia-repo/src/util.rs
- M src/virtualization/tests/virtio_block_test_util/src/linux_main.rs
- M src/virtualization/tests/virtio_net_test_util/src/linux_main.rs
- M src/virtualization/tests/virtio_rng_test_util/src/linux_main.rs
- M tools/cargo-gnaw/tests/platform_deps/vendor/anyhow/tests/common/mod.rs
- M tools/cargo-gnaw/tests/platform_deps/vendor/anyhow/tests/test_boxed.rs
- M tools/cargo-gnaw/tests/platform_deps/vendor/anyhow/tests/test_source.rs
- M tools/cargo-gnaw/tests/simple_deps/vendor/anyhow/tests/common/mod.rs
- M tools/cargo-gnaw/tests/simple_deps/vendor/anyhow/tests/test_boxed.rs
- M tools/cargo-gnaw/tests/simple_deps/vendor/anyhow/tests/test_source.rs
- M tools/zedmon/client/src/zedmon.rs
Change size: L
Delta: 40 files changed, 133 insertions(+), 254 deletions(-)
Related details
Attention is currently required from:
- Adam Barth
Submit Requirements:
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/6c970a96e34ca2a8656abd996d8ee79306b1bb5f-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'Erick Tryzelaar (Gerrit)' via owners-override
Mar 6, 2025, 3:56:18 PM3/6/25
to Owners Override
Attention needed from Adam Barth and Owners Override
Erick Tryzelaar has uploaded the change for review![]( "Open in Gerrit")
Erick Tryzelaar would like Owners Override to review this change.
Related details
- Adam Barth
- Owners Override
Submit Requirements:
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/ed437630b48288e65f766474945b2dae65c41ab6-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'Erick Tryzelaar (Gerrit)' via owners-override
Mar 6, 2025, 3:56:22 PM3/6/25
to Owners Override, Auto-Submit, Adam Barth, Laura Peskin, Fuchsia Try Builder, Marie Janssen, GI Try Builder, CQ Bot
Attention needed from Adam Barth and Owners Override
Erick Tryzelaar added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 5 (Latest):
Erick Tryzelaar . resolved
Re-adding owners override for review because I missed cleaning up an import in a test.
Related details
Attention is currently required from:
- Adam Barth
- Owners Override
Submit Requirements:
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/ed437630b48288e65f766474945b2dae65c41ab6-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'Adam Barth (Gerrit)' via owners-override
Mar 6, 2025, 5:51:15 PM3/6/25
to Erick Tryzelaar, Owners Override, Auto-Submit, Laura Peskin, Fuchsia Try Builder, Marie Janssen, GI Try Builder, CQ Bot
Attention needed from Erick Tryzelaar and Owners Override
Adam Barth voted Owners-Override+1![]( "Open in Gerrit")
Attention is currently required from:
- Erick Tryzelaar
- Owners Override
Submit Requirements:
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/d2aa335bab321f93fee09c45a055a9035aae8d72-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'CQ Bot (Gerrit)' via owners-override
Mar 6, 2025, 5:52:31 PM3/6/25
to Erick Tryzelaar, Adam Barth, Owners Override, Auto-Submit, Laura Peskin, Fuchsia Try Builder, Marie Janssen, GI Try Builder
CQ Bot submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
4 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: src/firmware/fastboot-tcp/src/fastboot.rs
Insertions: 1, Deletions: 1.
@@ -95,7 +95,7 @@
use super::*;
use crate::HANDSHAKE_MESSAGE;
use std::cmp::min;
- use std::io::{Error, ErrorKind};
+ use std::io::Error;
pub struct TestTransport {
pub data_stream: Vec<u8>,
```
```
The name of the file: src/sys/pkg/lib/fuchsia-merkle/src/tree.rs
Insertions: 1, Deletions: 1.
@@ -158,7 +158,7 @@
buf[0] = 0;
Ok(1)
} else {
- Err(io::Error::new(io::ErrorKind::Other, CUSTOM_ERROR_MESSAGE))
+ Err(io::Error::other(CUSTOM_ERROR_MESSAGE))
}
}
}
```
Change information
Commit message:
[rust] Migrate fuchsia to std::io::Error::other
Clippy now suggests migrating from:
```
std::io::Error::new(ErrorKind::Other, ...)
```
to the shorter:
```
std::io::Error::other(...)
```
Change-Id: I9ce628c35250b774f3cf4e03f6c66f0a5369b2cc
Owners-Override: Adam Barth <aba...@google.com>
Fuchsia-Auto-Submit: Erick Tryzelaar <etryz...@google.com>
Reviewed-by: Laura Peskin <pe...@google.com>
Reviewed-by: Marie Janssen <jam...@google.com>
Commit-Queue: Auto-Submit <auto-...@fuchsia-infra.iam.gserviceaccount.com>
Branch: refs/heads/main
Submit Requirements:
Code-Review: +2 by Marie Janssen, +2 by Laura Peskin
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/b4b1671097860facb7e1f1f14896f4a242c2ee98-HTML%40fuchsia-review.googlesource.com.To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'GI Roller (Gerrit)' via owners-override
Mar 6, 2025, 5:55:21 PM3/6/25
to Erick Tryzelaar, CQ Bot, Adam Barth, Owners Override, Auto-Submit, Laura Peskin, Fuchsia Try Builder, Marie Janssen, GI Try Builder
Message from GI Roller![]( "Open in Gerrit")
Change has been successfully rolled: http://go/roll-cl/caf4d48d9826125f00f552a51d45639cadb959d0
Related details
Attention set is empty
Submit Requirements:
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/76c201c5de7cee8c805e0c4438d25155a5b13c4c-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
Reply all
Reply to author
Forward
0 new messages