[M] Change in fuchsia/fuchsia[main]: [sorted-vec-map] Move into src/lib/collections
0 views
Skip to first unread message
'Erick Tryzelaar (Gerrit)' via owners-override
Apr 24, 2026, 8:31:47 PMApr 24
to Owners Override
Attention needed from Emircan Uysaler and Owners Override
Erick Tryzelaar has uploaded the change for review![]( "Open in Gerrit")
Erick Tryzelaar would like Owners Override to review this change.
Commit message
[sorted-vec-map] Move into src/lib/collections
We're trying to consolidate common Rust data structures into
src/lib/collections, which will hopefully improve discoverability for
users.
Change-Id: I637a91a4a0825ce52b0bfe452d0950e06a5d3da2
Change diff
Change information
Files:
- M src/lib/BUILD.gn
- R src/lib/collections/sorted-vec-map/BUILD.gn
- R src/lib/collections/sorted-vec-map/OWNERS
- R src/lib/collections/sorted-vec-map/src/lib.rs
- R src/lib/collections/sorted-vec-map/src/sorted_vec_map.rs
- R src/lib/collections/sorted-vec-map/src/sorted_vec_set.rs
- M src/storage/ext4/lib/metadata/BUILD.gn
- M src/storage/ext4/lib/metadata/src/lib.rs
- M src/ui/bin/scene_manager/BUILD.gn
- M src/ui/bin/scene_manager/src/input_pipeline.rs
- M src/ui/lib/input_pipeline/BUILD.gn
- M src/ui/lib/input_pipeline/src/gestures/gesture_arena.rs
- M src/ui/lib/input_pipeline/src/gestures/motion.rs
- M src/ui/lib/input_pipeline/src/gestures/one_finger_button.rs
- M src/ui/lib/input_pipeline/src/gestures/primary_tap.rs
- M src/ui/lib/input_pipeline/src/gestures/scroll.rs
- M src/ui/lib/input_pipeline/src/gestures/secondary_button.rs
- M src/ui/lib/input_pipeline/src/gestures/secondary_tap.rs
- M src/ui/lib/input_pipeline/src/gestures/tests/click.rs
- M src/ui/lib/input_pipeline/src/gestures/tests/motion.rs
- M src/ui/lib/input_pipeline/src/gestures/tests/one_finger_drag.rs
- M src/ui/lib/input_pipeline/src/gestures/tests/primary_tap.rs
- M src/ui/lib/input_pipeline/src/gestures/tests/scroll.rs
- M src/ui/lib/input_pipeline/src/gestures/tests/secondary_button.rs
- M src/ui/lib/input_pipeline/src/gestures/tests/secondary_tap.rs
- M src/ui/lib/input_pipeline/src/input_pipeline.rs
- M src/ui/lib/input_pipeline/src/inspect_handler.rs
- M src/ui/lib/input_pipeline/src/light_sensor/calibrator/calibrator_tests.rs
- M src/ui/lib/input_pipeline/src/light_sensor/led_watcher.rs
- M src/ui/lib/input_pipeline/src/light_sensor/types.rs
- M src/ui/lib/input_pipeline/src/light_sensor/types/types_tests.rs
- M src/ui/lib/input_pipeline/src/media_buttons_handler.rs
- M src/ui/lib/input_pipeline/src/mouse_binding.rs
- M src/ui/lib/input_pipeline/src/mouse_injector_handler.rs
- M src/ui/lib/input_pipeline/src/pointer_display_scale_handler.rs
- M src/ui/lib/input_pipeline/src/pointer_sensor_scale_handler.rs
- M src/ui/lib/input_pipeline/src/testing_utilities.rs
- M src/ui/lib/input_pipeline/src/touch_binding.rs
- M src/ui/lib/input_pipeline/src/touch_injector_handler.rs
Change size: M
Delta: 39 files changed, 58 insertions(+), 55 deletions(-)
Related details
Attention is currently required from:
- Emircan Uysaler
- Owners Override
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/b72432ad6577ad421ef370595836dd460be221b8-HTML%40fuchsia-review.googlesource.com.
'Erick Tryzelaar (Gerrit)' via owners-override
Apr 24, 2026, 8:31:52 PMApr 24
to Owners Override, Chris Drouillard, global-integrat...@fuchsia-infra.iam.gserviceaccount.com, Emircan Uysaler, Jianpeng Chao, fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com
Attention needed from Emircan Uysaler and Owners Override
Erick Tryzelaar voted and added 1 comment![]( "Open in Gerrit")
Votes added by Erick Tryzelaar
| Fuchsia-Auto-Submit | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 4 (Latest):
Erick Tryzelaar . resolved
Adding owners-override since this is moving a library in src/lib into src/lib/collections.
Related details
Attention is currently required from:
- Emircan Uysaler
- Owners Override
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/b72432ad6577ad421ef370595836dd460be221b8-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'Adam Barth (Gerrit)' via owners-override
Apr 24, 2026, 8:46:00 PMApr 24
to Erick Tryzelaar, Owners Override, Chris Drouillard, global-integrat...@fuchsia-infra.iam.gserviceaccount.com, Emircan Uysaler, Jianpeng Chao, fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com
Attention needed from Emircan Uysaler, Erick Tryzelaar and Owners Override
Adam Barth voted Owners-Override+1![]( "Open in Gerrit")
Attention is currently required from:
- Emircan Uysaler
- Erick Tryzelaar
- Owners Override
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/10c240c69d483e84d5096cba7c1d92f350e43552-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'Erick Tryzelaar (Gerrit)' via owners-override
Apr 27, 2026, 12:51:08 PMApr 27
to Adam Barth, Owners Override, Chris Drouillard, global-integrat...@fuchsia-infra.iam.gserviceaccount.com, Emircan Uysaler, Jianpeng Chao, fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com
Attention needed from Adam Barth, Emircan Uysaler and Owners Override
Erick Tryzelaar voted![]( "Open in Gerrit")
Attention is currently required from:
- Adam Barth
- Emircan Uysaler
- Owners Override
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/b6000d86a631e5fa3db9f804e8c92b8d0c968a7c-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'Erick Tryzelaar (Gerrit)' via owners-override
Apr 27, 2026, 3:19:00 PMApr 27
to Adam Barth, Owners Override, Chris Drouillard, global-integrat...@fuchsia-infra.iam.gserviceaccount.com, Emircan Uysaler, Jianpeng Chao, fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com
Attention needed from Adam Barth and Owners Override
Erick Tryzelaar voted and added 1 comment![]( "Open in Gerrit")
Votes added by Erick Tryzelaar
| Fuchsia-Auto-Submit | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 8 (Latest):
Erick Tryzelaar . resolved
Re-pinging owners-override@ since I had to rebase due to a merge conflict.
Related details
Attention is currently required from:
- Adam Barth
- Owners Override
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/29a1f7bbe1511170f05435f99aa54388400e91f8-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'Adam Barth (Gerrit)' via owners-override
Apr 27, 2026, 3:20:36 PMApr 27
to Erick Tryzelaar, Owners Override, Chris Drouillard, global-integrat...@fuchsia-infra.iam.gserviceaccount.com, Emircan Uysaler, Jianpeng Chao, fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com
Attention needed from Erick Tryzelaar and Owners Override
Adam Barth voted Owners-Override+1![]( "Open in Gerrit")
Attention is currently required from:
- Erick Tryzelaar
- Owners Override
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/7beb132fde6ed004e8c697dcbf7d725c47f46bf7-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'Erick Tryzelaar (Gerrit)' via owners-override
Apr 27, 2026, 3:20:58 PMApr 27
to Adam Barth, Owners Override, Chris Drouillard, global-integrat...@fuchsia-infra.iam.gserviceaccount.com, Emircan Uysaler, Jianpeng Chao, fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com
Attention needed from Owners Override
Erick Tryzelaar voted Commit-Queue+2![]( "Open in Gerrit")
Attention is currently required from:
- Owners Override
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/1a2f23186028618c40c667ada8005c9fbd096c8d-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'fuchsia-internal-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)' via owners-override
Apr 27, 2026, 3:22:11 PMApr 27
to Erick Tryzelaar, Adam Barth, Owners Override, Chris Drouillard, global-integrat...@fuchsia-infra.iam.gserviceaccount.com, Emircan Uysaler, Jianpeng Chao
fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
3 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: src/ui/lib/input_pipeline/src/gestures/tests/primary_tap.rs
Insertions: 1, Deletions: 0.
The diff is too large to show. Please review the diff.
```
```
The name of the file: src/ui/lib/input_pipeline/src/gestures/gesture_arena.rs
Insertions: 6, Deletions: 4.
The diff is too large to show. Please review the diff.
```
```
The name of the file: src/ui/lib/input_pipeline/src/inspect_handler.rs
Insertions: 2, Deletions: 1.
The diff is too large to show. Please review the diff.
```
```
The name of the file: src/ui/lib/input_pipeline/src/gestures/tests/secondary_tap.rs
Insertions: 1, Deletions: 0.
The diff is too large to show. Please review the diff.
```
```
The name of the file: src/ui/lib/input_pipeline/src/light_sensor/types.rs
Insertions: 1, Deletions: 1.
The diff is too large to show. Please review the diff.
```
```
The name of the file: src/ui/lib/input_pipeline/src/gestures/tests/one_finger_drag.rs
Insertions: 2, Deletions: 1.
The diff is too large to show. Please review the diff.
```
```
The name of the file: src/ui/lib/input_pipeline/src/touch_binding.rs
Insertions: 1, Deletions: 1.
The diff is too large to show. Please review the diff.
```
```
The name of the file: src/ui/lib/input_pipeline/src/gestures/one_finger_button.rs
Insertions: 1, Deletions: 2.
The diff is too large to show. Please review the diff.
```
```
The name of the file: src/ui/lib/input_pipeline/src/light_sensor/types/types_tests.rs
Insertions: 1, Deletions: 1.
The diff is too large to show. Please review the diff.
```
```
The name of the file: src/ui/lib/input_pipeline/src/light_sensor/led_watcher.rs
Insertions: 1, Deletions: 1.
The diff is too large to show. Please review the diff.
```
```
The name of the file: src/ui/lib/input_pipeline/src/gestures/secondary_tap.rs
Insertions: 1, Deletions: 1.
The diff is too large to show. Please review the diff.
```
```
The name of the file: src/ui/lib/input_pipeline/src/mouse_binding.rs
Insertions: 3, Deletions: 3.
The diff is too large to show. Please review the diff.
```
```
The name of the file: src/ui/lib/input_pipeline/src/gestures/tests/click.rs
Insertions: 2, Deletions: 1.
The diff is too large to show. Please review the diff.
```
```
The name of the file: src/ui/lib/input_pipeline/src/gestures/secondary_button.rs
Insertions: 1, Deletions: 2.
The diff is too large to show. Please review the diff.
```
```
The name of the file: src/ui/lib/input_pipeline/src/media_buttons_handler.rs
Insertions: 1, Deletions: 0.
The diff is too large to show. Please review the diff.
```
```
The name of the file: src/ui/lib/input_pipeline/src/testing_utilities.rs
Insertions: 1, Deletions: 2.
The diff is too large to show. Please review the diff.
```
```
The name of the file: src/ui/lib/input_pipeline/src/pointer_sensor_scale_handler.rs
Insertions: 1, Deletions: 1.
The diff is too large to show. Please review the diff.
```
```
The name of the file: src/ui/lib/input_pipeline/src/input_pipeline.rs
Insertions: 1, Deletions: 1.
The diff is too large to show. Please review the diff.
```
```
The name of the file: src/ui/lib/input_pipeline/src/gestures/utils.rs
Insertions: 2, Deletions: 2.
The diff is too large to show. Please review the diff.
```
```
The name of the file: src/ui/lib/input_pipeline/src/light_sensor/calibrator/calibrator_tests.rs
Insertions: 1, Deletions: 0.
The diff is too large to show. Please review the diff.
```
```
The name of the file: src/ui/lib/input_pipeline/src/gestures/tests/scroll.rs
Insertions: 2, Deletions: 1.
The diff is too large to show. Please review the diff.
```
```
The name of the file: src/ui/lib/input_pipeline/src/pointer_display_scale_handler.rs
Insertions: 1, Deletions: 1.
The diff is too large to show. Please review the diff.
```
```
The name of the file: src/ui/lib/input_pipeline/src/gestures/scroll.rs
Insertions: 1, Deletions: 1.
The diff is too large to show. Please review the diff.
```
```
The name of the file: src/ui/lib/input_pipeline/src/gestures/tests/motion.rs
Insertions: 2, Deletions: 1.
The diff is too large to show. Please review the diff.
```
```
The name of the file: src/ui/bin/scene_manager/BUILD.gn
Insertions: 1, Deletions: 0.
The diff is too large to show. Please review the diff.
```
```
The name of the file: src/ui/lib/input_pipeline/src/mouse_injector_handler.rs
Insertions: 1, Deletions: 1.
The diff is too large to show. Please review the diff.
```
```
The name of the file: src/ui/bin/scene_manager/src/input_pipeline.rs
Insertions: 1, Deletions: 1.
The diff is too large to show. Please review the diff.
```
```
The name of the file: src/ui/lib/input_pipeline/src/touch_injector_handler.rs
Insertions: 1, Deletions: 1.
The diff is too large to show. Please review the diff.
```
```
The name of the file: src/ui/lib/input_pipeline/src/gestures/tests/secondary_button.rs
Insertions: 6, Deletions: 2.
The diff is too large to show. Please review the diff.
```
```
The name of the file: src/ui/lib/input_pipeline/src/gestures/primary_tap.rs
Insertions: 1, Deletions: 1.
The diff is too large to show. Please review the diff.
```
```
The name of the file: src/ui/lib/input_pipeline/src/gestures/motion.rs
Insertions: 1, Deletions: 1.
The diff is too large to show. Please review the diff.
```
Change information
Commit message:
[sorted-vec-map] Move into src/lib/collections
We're trying to consolidate common Rust data structures into
src/lib/collections, which will hopefully improve discoverability for
users.
Change-Id: I637a91a4a0825ce52b0bfe452d0950e06a5d3da2
Reviewed-by: Chris Drouillard <cdr...@google.com>
Owners-Override: Adam Barth <aba...@google.com>
Commit-Queue: Erick Tryzelaar <etryz...@google.com>
Fuchsia-Auto-Submit: Erick Tryzelaar <etryz...@google.com>
Reviewed-by: Jianpeng Chao <chao...@google.com>
Files:
- M src/ui/lib/input_pipeline/src/gestures/utils.rs
- M src/ui/lib/input_pipeline/src/input_pipeline.rs
- M src/ui/lib/input_pipeline/src/inspect_handler.rs
- M src/ui/lib/input_pipeline/src/light_sensor/calibrator/calibrator_tests.rs
- M src/ui/lib/input_pipeline/src/light_sensor/led_watcher.rs
- M src/ui/lib/input_pipeline/src/light_sensor/types.rs
- M src/ui/lib/input_pipeline/src/light_sensor/types/types_tests.rs
- M src/ui/lib/input_pipeline/src/media_buttons_handler.rs
- M src/ui/lib/input_pipeline/src/mouse_binding.rs
- M src/ui/lib/input_pipeline/src/mouse_injector_handler.rs
- M src/ui/lib/input_pipeline/src/pointer_display_scale_handler.rs
- M src/ui/lib/input_pipeline/src/pointer_sensor_scale_handler.rs
- M src/ui/lib/input_pipeline/src/testing_utilities.rs
- M src/ui/lib/input_pipeline/src/touch_binding.rs
- M src/ui/lib/input_pipeline/src/touch_injector_handler.rs
Change size: M
Delta: 40 files changed, 59 insertions(+), 56 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +2 by Jianpeng Chao, +2 by Chris Drouillard
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/86579c0092194bc431e0d675535eecd96f6850aa-HTML%40fuchsia-review.googlesource.com.To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'global-integration-ci-builder@fuchsia-infra.iam.gserviceaccount.com (Gerrit)' via owners-override
Apr 27, 2026, 3:46:29 PMApr 27
to Erick Tryzelaar, fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com, Adam Barth, Owners Override, Chris Drouillard, global-integrat...@fuchsia-infra.iam.gserviceaccount.com, Emircan Uysaler, Jianpeng Chao
Message from global-integra...@fuchsia-infra.iam.gserviceaccount.com![]( "Open in Gerrit")
Change has been successfully rolled: https://turquoise-internal-review.googlesource.com/1247236
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/d5c6113e5d63aea8e3d46d8e9e3a2543c5db48d0-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
Reply all
Reply to author
Forward
0 new messages