'Adam Perry (Gerrit)' via owners-override

unread,

Jan 13, 2026, 6:05:30 PMJan 13

to Owners Override, Adam Barth

Attention needed from Adam Barth and Owners Override

Adam Perry has uploaded the change for review

Adam Perry would like Owners Override and Adam Barth to review this change.

Commit message

[zx][rs] Remove AsHandleRef::get_koid.

Replaced by inherent koid() methods on handle wrappers.

Bug: 434762683

Depends-on: turquoise-internal:Ib5f0746b1f75264f13b99a1a34bdee1f64028047

Change-Id: I0af59b76e9c81edb3de58a60bf43ce04444e9fda

Change diff

Change information

Files:

M examples/components/runner/colocated/src/main.rs
M examples/components/runner/colocated/src/program.rs
M sdk/lib/power/state_recorder/rust/src/lib.rs
M sdk/rust/zx/src/handle.rs
M sdk/rust/zx/src/iob.rs
M sdk/rust/zx/src/job.rs
M sdk/rust/zx/src/macros.rs
M sdk/rust/zx/src/process.rs
M src/bringup/bin/virtcon/src/log.rs
M src/connectivity/bluetooth/lib/fuchsia-audio-codec/src/sysmem_allocator.rs
M src/connectivity/lib/network-device/rust/tests/tun.rs
M src/connectivity/network/netstack3/src/bindings/bpf.rs
M src/connectivity/network/netstack3/src/bindings/filter.rs
M src/connectivity/network/netstack3/src/bindings/netdevice_worker.rs
M src/connectivity/network/netstack3/src/bindings/socket.rs
M src/connectivity/network/netstack3/src/bindings/socket/datagram.rs
M src/connectivity/network/netstack3/src/bindings/waker.rs
M src/connectivity/network/testing/ebpf_test_util/src/lib.rs
M src/connectivity/network/testing/netemul/rust/src/lib.rs
M src/connectivity/policy/netcfg/src/network/token_map.rs
M src/developer/ffx/lib/fuchsia-controller/src/commands.rs
M src/devices/bin/driver-host/src/driver_host.rs
M src/diagnostics/archivist/src/accessor.rs
M src/diagnostics/archivist/src/events/router.rs
M src/diagnostics/archivist/src/inspect/container.rs
M src/diagnostics/archivist/src/inspect/repository.rs
M src/diagnostics/archivist/src/inspect/servers/inspect_sink.rs
M src/diagnostics/archivist/src/main.rs
M src/diagnostics/validator/logs/sink/puppet/rust/src/main.rs
M src/fonts/tests/integration/src/old_api/mod.rs
M src/fonts/tests/integration/src/reviewed_api/util/mod.rs
M src/graphics/display/lib/rust/display-utils/src/image.rs
M src/lib/diagnostics/inspect/runtime/rust/src/lib.rs
M src/lib/diagnostics/log/bench/src/common.rs
M src/lib/diagnostics/log/rust/src/fuchsia/sink.rs
M src/lib/diagnostics/log/rust/src/fuchsia_28/sink.rs
M src/lib/fake-clock/svc/src/main.rs
M src/lib/fdomain/container/src/lib.rs
M src/lib/fidl/rust/external_tests/src/persistence.rs
M src/lib/fidl/rust/fidl/src/handle.rs
M src/lib/fuchsia-async/src/handle/emulated/mod.rs
M src/lib/fuchsia-component-test/tests/src/lib.rs
M src/lib/fuchsia-component/server/src/until_stalled.rs
M src/lib/process_builder/src/elf_load.rs
M src/lib/process_builder/src/process_args.rs
M src/lib/process_builder/test-utils/test_util.rs
M src/lib/ui/carnelian/src/view/strategies/display_direct.rs
M src/lib/ui/carnelian/src/view/strategies/flatland.rs
M src/lib/ui/fidl_fuchsia_ui_views_ext/src/lib.rs
M src/lib/ui/fuchsia-framebuffer/BUILD.gn
M src/lib/ui/fuchsia-framebuffer/src/sysmem.rs
M src/media/sessions/src/id.rs
M src/media/stream_processors/test/src/buffer_set.rs
M src/performance/memory/attribution/monitor/src/resources.rs
M src/performance/memory/heapdump/collector/src/process_v1.rs
M src/performance/memory/heapdump/instrumentation/src/profiler.rs
M src/power/broker/src/credentials.rs
M src/power/broker/src/main.rs
M src/power/power-manager/integration/lib/src/lib.rs
M src/power/system-activity-governor/integration/tests/src/main.rs
M src/starnix/kernel/core/bpf/program.rs
M src/starnix/kernel/core/execution/crash_reporter.rs
M src/starnix/kernel/core/fs/fuchsia/sync_file.rs
M src/starnix/kernel/core/mm/memory.rs
M src/starnix/kernel/core/task/kernel.rs
M src/starnix/kernel/core/task/memory_attribution.rs
M src/starnix/kernel/core/task/task.rs
M src/starnix/kernel/core/task/thread_group.rs
M src/starnix/kernel/core/task/tracing.rs
M src/starnix/kernel/core/time/hr_timer_manager.rs
M src/starnix/kernel/core/time/utc.rs
M src/starnix/kernel/core/vfs/socket/socket_backed_by_zxio.rs
M src/starnix/lib/kernel_manager/src/kernels.rs
M src/starnix/lib/kernel_manager/src/lib.rs
M src/starnix/lib/kernel_manager/src/proxy.rs
M src/starnix/lib/kernel_manager/src/suspend.rs
M src/starnix/lib/memory_pinning/src/shadow_process.rs
M src/starnix/lib/page_buf/src/lib.rs
M src/starnix/lib/starnix_kernel_runner/src/container.rs
M src/starnix/lib/starnix_sync/src/interruptible_event.rs
M src/starnix/modules/binderfs/remote_binder.rs
M src/starnix/modules/fastrpc/fastrpc.rs
M src/starnix/tests/memory_attribution/main.rs
M src/starnix/tests/scheduler/role_manager/src/main.rs
M src/storage/fshost/src/environment/publisher.rs
M src/storage/fuchsia-fatfs/src/filesystem.rs
M src/storage/fxfs/platform/src/fuchsia/component.rs
M src/storage/fxfs/platform/src/fuchsia/volume.rs
M src/storage/fxfs/platform/src/fuchsia/volumes_directory.rs
M src/storage/gpt/component/src/gpt.rs
M src/storage/lib/block_server/src/lib.rs
M src/storage/lib/fs_management/rust/src/filesystem.rs
M src/storage/lib/vfs/rust/src/token_registry.rs
M src/sys/component_manager/lib/sandbox/src/fidl/connector_router.rs
M src/sys/component_manager/lib/sandbox/src/fidl/data_router.rs
M src/sys/component_manager/lib/sandbox/src/fidl/dict.rs
M src/sys/component_manager/lib/sandbox/src/fidl/dictionary_router.rs
M src/sys/component_manager/lib/sandbox/src/fidl/dir_connector_router.rs
M src/sys/component_manager/lib/sandbox/src/fidl/dir_entry_router.rs
M src/sys/component_manager/lib/sandbox/src/fidl/registry.rs
M src/sys/component_manager/lib/sandbox/src/fidl/router.rs
M src/sys/component_manager/lib/sandbox/src/fidl/store.rs
M src/sys/component_manager/lib/sandbox/src/handle.rs
M src/sys/component_manager/src/bootfs.rs
M src/sys/component_manager/src/model/token.rs
M src/sys/component_manager/tests/controller/src/lib.rs
M src/sys/component_manager/tests/crash_introspect/BUILD.gn
M src/sys/component_manager/tests/crash_introspect/report_then_panic_on_start.rs
M src/sys/component_manager/tests/events/BUILD.gn
M src/sys/component_manager/tests/events/integration_test.rs
M src/sys/fuzzing/realmfuzzer/coverage/src/aggregator.rs
M src/sys/lib/elf_runner/src/crash_handler.rs
M src/sys/lib/elf_runner/src/lib.rs
M src/sys/lib/elf_runner/src/memory/reporter.rs
M src/sys/lib/elf_runner/src/process_launcher.rs
M src/sys/pkg/tests/pkgdir/src/file.rs
M src/sys/test_runners/src/elf/elf_component.rs
M src/sys/test_runners/src/launch.rs
M src/sys/time/testing/utc-handle-vendor/src/main.rs
M src/sys/time/timekeeper/alarms/src/lib.rs
M src/sys/time/timekeeper/alarms/src/timers.rs
M src/sys/time/timekeeper/src/clock_manager.rs
M src/sys/time/timekeeper/src/main.rs
M src/sys/time/timekeeper_integration/tests/faketime/integration.rs
M src/ui/bin/scene_manager/src/main.rs
M src/ui/bin/text/src/keyboard/keyboard3.rs
M src/ui/examples/flatland-rainbow/src/render_vk.rs
M src/ui/lib/input_pipeline/src/consumer_controls_binding.rs
M src/ui/lib/input_pipeline/src/media_buttons_handler.rs

Change size: L

Delta: 129 files changed, 374 insertions(+), 439 deletions(-)

Open in Gerrit

Related details

Attention is currently required from:

Adam Barth
Owners Override

Submit Requirements:

Code-Owners
Code-Review
Dependencies-Satisfied
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/0bc3236d88b2d44067bfc32ddff375120987484c-HTML%40fuchsia-review.googlesource.com.

unsatisfied_requirement

open

diffy

'Adam Perry (Gerrit)' via owners-override

unread,

Jan 13, 2026, 6:05:32 PMJan 13

to Adam Barth, Owners Override, GI Try Builder, CQ Bot

Attention needed from Adam Barth and Owners Override

Adam Perry voted Fuchsia-Auto-Submit+1

Fuchsia-Auto-Submit

+1

Open in Gerrit

Related details

Attention is currently required from:

Adam Barth
Owners Override

Submit Requirements:

Code-Owners
Code-Review
Dependencies-Satisfied
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/0bc3236d88b2d44067bfc32ddff375120987484c-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

unsatisfied_requirement

open

diffy

'James Robinson (Gerrit)' via owners-override

unread,

Jan 13, 2026, 6:10:07 PMJan 13

to Adam Perry, Adam Barth, Owners Override, GI Try Builder, CQ Bot

Attention needed from Adam Barth, Adam Perry and Owners Override

James Robinson voted

Code-Review	+2
Owners-Override	+1

Open in Gerrit

Related details

Attention is currently required from:

Adam Barth
Adam Perry
Owners Override

Submit Requirements:

Code-Owners
Code-Review

Dependencies-Satisfied

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/a8bae7da60897ba49437fb5bfa39ea2bbaa36faf-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

satisfied_requirement

unsatisfied_requirement

open

diffy

'Adam Barth (Gerrit)' via owners-override

unread,

Jan 13, 2026, 6:41:53 PMJan 13

to Adam Perry, James Robinson, Owners Override, GI Try Builder, CQ Bot

Attention needed from Adam Perry, James Robinson and Owners Override

Adam Barth voted Owners-Override+1

Owners-Override

+1

Open in Gerrit

Related details

Attention is currently required from:

Adam Perry
James Robinson
Owners Override

Submit Requirements:

Code-Owners
Code-Review
Dependencies-Satisfied
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/c97f1090252211760c78b9da194014d9f73ba45d-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

satisfied_requirement

unsatisfied_requirement

open

diffy

'Adam Perry (Gerrit)' via owners-override

unread,

Jan 13, 2026, 8:31:16 PMJan 13

to Adam Barth, James Robinson, Owners Override, GI Try Builder, CQ Bot

Attention needed from Adam Perry, James Robinson and Owners Override

Adam Perry voted and added 1 comment

Votes added by Adam Perry

Fuchsia-Auto-Submit

+0

1 comment

Patchset-level comments

File-level comment, Patchset 20 (Latest):

Adam Perry . resolved

Removing autosubmit because both workbench_eng.vim3-debug-lacewing builds failed with three repeated:

```
2026-01-13 16:04:46.529165 ffx: {"type":"unexpected","code":1,"message":"There was an error flashing \"zircon_r\" - /b/s/w/ir/out/not-default/obj/products/workbench/workbench_eng.vim3/product_bundle/system_r/zedboot.zbi: FlashError(FlashFailed { partition: \"zircon_r\", message: \"too large for partition\\0\\0\\0\\0\\0\\0\\0\\0\\0\\0\\0\\0\\0\\0\\0\\0\\0\\0\\0\\0\\0\\0\\0\\0\\0\\0\\0\\0\\0\\0\\0\\0\\0\\0\\0\\0\\0\" })"}
```

Don't see size checks going off and the builder's green in CI so going to investigate tomorrow.

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/f1d6f7d5f62dcb3e01a340182582da630d83a9da-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

satisfied_requirement

unsatisfied_requirement

open

diffy

'Adam Perry (Gerrit)' via owners-override

unread,

Jan 16, 2026, 4:16:13 PMJan 16

to Android Build Huckle Nudge, CL Deps Checker, Adam Barth, James Robinson, Owners Override, GI Try Builder, CQ Bot

Attention needed from James Robinson and Owners Override

Adam Perry voted Fuchsia-Auto-Submit+1

Fuchsia-Auto-Submit

+1

Open in Gerrit

Related details

Attention is currently required from:

James Robinson
Owners Override

Submit Requirements:

Code-Owners
Code-Review
Dependencies-Satisfied
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/41e4564c1eff84cf5d3f58db6b8f9ded5e5aae64-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

satisfied_requirement

unsatisfied_requirement

open

diffy

'CQ Bot (Gerrit)' via owners-override

unread,

Jan 16, 2026, 5:47:39 PMJan 16

to Adam Perry, CL Deps Checker, Android Build Huckle Nudge, Adam Barth, James Robinson, Owners Override, GI Try Builder

CQ Bot submitted the change with unreviewed changes

Unreviewed changes

19 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: src/lib/diagnostics/log/rust/src/fuchsia_28/sink.rs
Insertions: 0, Deletions: 1.

@@ -12,7 +12,6 @@
 use std::collections::HashSet;
 use std::io::Cursor;
 use std::sync::atomic::{AtomicU32, Ordering};
-use zx::{self as zx, AsHandleRef};
 
 #[derive(Default)]
 pub(crate) struct SinkConfig {
```

Change information

Commit message:

[zx][rs] Remove AsHandleRef::get_koid.

Replaced by inherent koid() methods on handle wrappers.

Bug: 434762683

Depends-on: turquoise-internal:Ib5f0746b1f75264f13b99a1a34bdee1f64028047

Change-Id: I0af59b76e9c81edb3de58a60bf43ce04444e9fda

Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1449576

Owners-Override: Adam Barth <aba...@google.com>

Fuchsia-Auto-Submit: Adam Perry <adam...@google.com>

Dependencies-Satisfied: CL Deps Checker <cl-deps...@fuchsia-internal-service-accts.iam.gserviceaccount.com>

Reviewed-by: James Robinson <jam...@google.com>

Commit-Queue: Adam Perry <adam...@google.com>

Delta: 129 files changed, 374 insertions(+), 440 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +2 by James Robinson
Dependencies-Satisfied: +1 by CL Deps Checker

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/91738a2e1ecd6d2af5973aa69f2e7181386636dd-HTML%40fuchsia-review.googlesource.com.

open

diffy

satisfied_requirement

'GI Roller (Gerrit)' via owners-override

unread,

Jan 16, 2026, 5:56:04 PMJan 16

to Adam Perry, CQ Bot, CL Deps Checker, Android Build Huckle Nudge, Adam Barth, James Robinson, Owners Override, GI Try Builder

Message from GI Roller

Change has been successfully rolled: https://turquoise-internal-review.googlesource.com/1142755

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Owners
Code-Review

Dependencies-Satisfied
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/21df23b75c031a5c86a964ef904749e52a69f749-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

satisfied_requirement

open

diffy

Reply all

Reply to author

Forward

[L] Change in fuchsia/fuchsia[main]: [zx][rs] Remove AsHandleRef::get_koid.

'Adam Perry (Gerrit)' via owners-override

Adam Perry has uploaded the change for review

Commit message

Change diff

Change information

Related details

'Adam Perry (Gerrit)' via owners-override

Adam Perry voted Fuchsia-Auto-Submit+1

Related details

'James Robinson (Gerrit)' via owners-override

James Robinson voted

Related details

'Adam Barth (Gerrit)' via owners-override

Adam Barth voted Owners-Override+1

Related details

'Adam Perry (Gerrit)' via owners-override

Adam Perry voted and added 1 comment

Votes added by Adam Perry

1 comment

'Adam Perry (Gerrit)' via owners-override

Adam Perry voted Fuchsia-Auto-Submit+1

Related details

'CQ Bot (Gerrit)' via owners-override

CQ Bot submitted the change with unreviewed changes

Unreviewed changes

Change information

'GI Roller (Gerrit)' via owners-override

Message from GI Roller

Related details