'Miguel Flores (Gerrit)' via owners-override

unread,

Apr 7, 2025, 12:34:30 PMApr 7

to Owners Override

Attention needed from Owners Override

Miguel Flores has uploaded the change for review

Miguel Flores would like Owners Override to review this change.

Commit message

[cml] Remove unnecessary fuchsia.logger.Log routes

These are no longer used by anything in the code.

Bug: 299990119

Change-Id: Ibbaffc207c9392ec564a08e3ae1f5ac3b49563c7

Change diff

Change information

Files:

M src/bringup/bin/console-launcher/meta/console-launcher.cml
M src/bringup/bin/console/meta/console.shard.cml
M src/developer/sshd-host/meta/sshd-host.cml
M src/developer/sshd-host/meta/sshd-host.core_shard.cml
M src/developer/sshd-host/meta/sshd.cml
M src/diagnostics/persistence/tests/test_topology.rs
M src/graphics/bin/opencl_loader/test/meta/opencl_loader_test.cml
M src/graphics/bin/opencl_loader/test/meta/opencl_loader_unittest.cml
M src/graphics/bin/vulkan_loader/test/meta/test_realm.cml
M src/graphics/bin/vulkan_loader/test/meta/vulkan_loader_unittest.cml
M src/graphics/tests/libopencl/meta/libopencl_test.cml
M src/graphics/tests/libvulkan/meta/libvulkan_test.cml
M src/performance/experimental/profiler/meta/profiler.cml
M src/performance/experimental/profiler/meta/profiler.core_shard.cml
M src/performance/experimental/profiler/tests/meta/profiler_integration_test.cml
M src/recovery/system/meta/core_shards/system_recovery.core_shard.cml
M src/recovery/system/meta/shards/ota.shard.cml
M src/session/bin/session_manager/meta/session_manager.core_shard.cml
M src/ui/bin/terminal/meta/terminal.cml

Change size: M

Delta: 19 files changed, 1 insertion(+), 75 deletions(-)

Open in Gerrit

Related details

Attention is currently required from:

Owners Override

Submit Requirements:

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/8962f82f27ad3292bfeb92ada1bb47e3f10d63c2-HTML%40fuchsia-review.googlesource.com.

satisfied_requirement

open

diffy

'Miguel Flores (Gerrit)' via owners-override

unread,

Apr 7, 2025, 12:34:34 PMApr 7

to Owners Override, Brian Bosak, GI Try Builder, CQ Bot, Fuchsia Try Builder

Attention needed from Owners Override

Miguel Flores voted and added 1 comment

Votes added by Miguel Flores

Commit-Queue	+1
Fuchsia-Auto-Submit	+1

1 comment

File src/bringup/bin/console/meta/console.shard.cml

File-level comment, Patchset 5:

Brian Bosak . resolved

File not formatted. Run `fx format-code` to fix.
Please fix.

Miguel Flores

Done

Open in Gerrit

Related details

Attention is currently required from:

Owners Override

Submit Requirements:

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/8962f82f27ad3292bfeb92ada1bb47e3f10d63c2-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

satisfied_requirement

open

diffy

'Miguel Flores (Gerrit)' via owners-override

unread,

Apr 7, 2025, 12:34:42 PMApr 7

to Owners Override, Brian Bosak, GI Try Builder, CQ Bot, Fuchsia Try Builder

Attention needed from Owners Override

Miguel Flores voted

Commit-Queue	+1
Fuchsia-Auto-Submit	+1

Open in Gerrit

Related details

Attention is currently required from:

Owners Override

Submit Requirements:

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/9ebf181693913b554e451965e059dc6888d003d7-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

satisfied_requirement

open

diffy

'James Robinson (Gerrit)' via owners-override

unread,

Apr 7, 2025, 12:48:26 PMApr 7

to Miguel Flores, Owners Override, Brian Bosak, GI Try Builder, CQ Bot, Fuchsia Try Builder

Attention needed from Miguel Flores and Owners Override

James Robinson voted Owners-Override+1

Owners-Override

+1

Open in Gerrit

Related details

Attention is currently required from:

Miguel Flores
Owners Override

Submit Requirements:

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/6550e30970d09181503d5438843f79d5d27a2206-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

satisfied_requirement

open

diffy

'Miguel Flores (Gerrit)' via owners-override

unread,

Apr 7, 2025, 1:00:04 PMApr 7

to James Robinson, Owners Override, Brian Bosak, GI Try Builder, CQ Bot, Fuchsia Try Builder

Attention needed from Owners Override

Miguel Flores voted Fuchsia-Auto-Submit+0

Fuchsia-Auto-Submit

+0

Open in Gerrit

Related details

Attention is currently required from:

Owners Override

Submit Requirements:

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/6092f45d8f8b40cb30cab153e689bb002d7ed77b-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

satisfied_requirement

open

diffy

'Miguel Flores (Gerrit)' via owners-override

unread,

Apr 7, 2025, 1:36:02 PMApr 7

to James Robinson, Owners Override, Brian Bosak, GI Try Builder, CQ Bot, Fuchsia Try Builder

Attention needed from Owners Override

Miguel Flores voted Fuchsia-Auto-Submit+1

Fuchsia-Auto-Submit

+1

Open in Gerrit

Related details

Attention is currently required from:

Owners Override

Submit Requirements:

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/3b29d24cc22c10319aea0cde71b95992356d13d5-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

satisfied_requirement

open

diffy

'CQ Bot (Gerrit)' via owners-override

unread,

Apr 7, 2025, 1:36:50 PMApr 7

to Miguel Flores, Auto-Submit, James Robinson, Owners Override, Brian Bosak, GI Try Builder, Fuchsia Try Builder

CQ Bot submitted the change with unreviewed changes

Unreviewed changes

5 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: src/bringup/bin/console/meta/console.shard.cml
Insertions: 1, Deletions: 3.

@@ -322,9 +322,7 @@
             to: "#console-launcher",
         },
         {
-            protocol: [
-                "fuchsia.diagnostics.LogSettings",
-            ],
+            protocol: [ "fuchsia.diagnostics.LogSettings" ],
             from: "#archivist",
             to: [
                 "#console",
```

Change information

Commit message:

[cml] Remove unnecessary fuchsia.logger.Log routes

These are no longer used by anything in the code.

Bug: 299990119

Change-Id: Ibbaffc207c9392ec564a08e3ae1f5ac3b49563c7

Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1245704

Commit-Queue: Auto-Submit <auto-...@fuchsia-infra.iam.gserviceaccount.com>

Reviewed-by: Brian Bosak <bbo...@google.com>

Fuchsia-Auto-Submit: Miguel Flores <migue...@google.com>

Owners-Override: James Robinson <jam...@google.com>

Files:

M src/bringup/bin/console-launcher/meta/console-launcher.cml
M src/bringup/bin/console/meta/console.shard.cml
M src/developer/sshd-host/meta/sshd-host.cml
M src/developer/sshd-host/meta/sshd-host.core_shard.cml
M src/developer/sshd-host/meta/sshd.cml
M src/diagnostics/persistence/tests/test_topology.rs
M src/graphics/bin/opencl_loader/test/meta/opencl_loader_test.cml
M src/graphics/bin/opencl_loader/test/meta/opencl_loader_unittest.cml
M src/graphics/bin/vulkan_loader/test/meta/test_realm.cml
M src/graphics/bin/vulkan_loader/test/meta/vulkan_loader_unittest.cml
M src/graphics/tests/libopencl/meta/libopencl_test.cml
M src/graphics/tests/libvulkan/meta/libvulkan_test.cml
M src/performance/experimental/profiler/meta/profiler.cml
M src/performance/experimental/profiler/meta/profiler.core_shard.cml
M src/performance/experimental/profiler/tests/meta/profiler_integration_test.cml
M src/recovery/system/meta/core_shards/system_recovery.core_shard.cml
M src/recovery/system/meta/shards/ota.shard.cml
M src/session/bin/session_manager/meta/session_manager.core_shard.cml
M src/ui/bin/terminal/meta/terminal.cml

Change size: M

Delta: 19 files changed, 1 insertion(+), 75 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +2 by Brian Bosak

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--

You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/e282bdd0ca1e784121554d09039ec4ce533efe7e-HTML%40fuchsia-review.googlesource.com.

open

diffy

satisfied_requirement

'GI Roller (Gerrit)' via owners-override

unread,

Apr 7, 2025, 1:44:33 PMApr 7

to Miguel Flores, CQ Bot, Auto-Submit, James Robinson, Owners Override, Brian Bosak, GI Try Builder, Fuchsia Try Builder

Message from GI Roller

Change has been successfully rolled: http://go/roll-cl/dc20d5dc839cdc2f7b22bb3fd1d65979a0dc2363

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/694ffb3b3679bb9e6b012b236efad79c18801a59-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

satisfied_requirement

open

diffy

Reply all

Reply to author

Forward

[M] Change in fuchsia/fuchsia[main]: [cml] Remove unnecessary fuchsia.logger.Log routes

'Miguel Flores (Gerrit)' via owners-override

Miguel Flores has uploaded the change for review

Commit message

Change diff

Change information

Related details

'Miguel Flores (Gerrit)' via owners-override

Miguel Flores voted and added 1 comment

Votes added by Miguel Flores

1 comment

Related details

'Miguel Flores (Gerrit)' via owners-override

Miguel Flores voted

Related details

'James Robinson (Gerrit)' via owners-override

James Robinson voted Owners-Override+1

Related details

'Miguel Flores (Gerrit)' via owners-override

Miguel Flores voted Fuchsia-Auto-Submit+0

Related details

'Miguel Flores (Gerrit)' via owners-override

Miguel Flores voted Fuchsia-Auto-Submit+1

Related details

'CQ Bot (Gerrit)' via owners-override

CQ Bot submitted the change with unreviewed changes

Unreviewed changes

Change information

'GI Roller (Gerrit)' via owners-override

Message from GI Roller

Related details