[XL] Change in fuchsia/fuchsia[main]: [inspect] Make DiagnosticsHierarchyGetter async
2 views
Skip to first unread message
'Clayton McCray (Gerrit)' via owners-override
May 19, 2025, 4:45:57 PM5/19/25
to Owners Override
Attention needed from Owners Override
Clayton McCray has uploaded the change for review![]( "Open in Gerrit")
Clayton McCray would like Owners Override to review this change.
Commit message
[inspect] Make DiagnosticsHierarchyGetter async
We previously used futures::block_on to make the trait synchronous.
Apparently, it is a bug to use Fuchsia specific things (such as the
timers we use in the readers lib) within a non-Fuchsia executor.
So this makes the trait async (which probably wasn't supported when
the trait was originally written) and updates all the places that
should now be async.
Bug: 409822059
Depends-on: turquoise-internal:Ib3d2917f05d84e482371f6a0e9e10b3f2e60a110
Change-Id: Icc8b9e1d361b510277cc7b81f73eafee13ef13a6
Change diff
Change information
Files:
- M examples/components/storage/src/main.rs
- M examples/diagnostics/inspect/rust-ergonomic/BUILD.gn
- M examples/diagnostics/inspect/rust-ergonomic/src/main.rs
- M src/connectivity/bluetooth/core/bt-gap/src/store/stash.rs
- M src/connectivity/bluetooth/lib/bt-a2dp/src/connected_peers.rs
- M src/connectivity/bluetooth/lib/fuchsia-bluetooth/BUILD.gn
- M src/connectivity/bluetooth/lib/fuchsia-bluetooth/src/inspect.rs
- M src/connectivity/bluetooth/lib/fuchsia-bluetooth/src/profile.rs
- M src/connectivity/bluetooth/lib/fuchsia-bluetooth/src/types/host_info.rs
- M src/connectivity/bluetooth/profiles/bt-a2dp/src/avrcp_relay.rs
- M src/connectivity/bluetooth/profiles/bt-a2dp/src/media/player_sink.rs
- M src/connectivity/bluetooth/profiles/bt-avrcp/src/metrics/mod.rs
- M src/connectivity/bluetooth/profiles/bt-avrcp/src/peer/inspect.rs
- M src/connectivity/bluetooth/profiles/bt-avrcp/src/peer/mod.rs
- M src/connectivity/bluetooth/profiles/bt-fastpair-provider/src/pairing.rs
- M src/connectivity/bluetooth/profiles/bt-fastpair-provider/src/provider.rs
- M src/connectivity/bluetooth/profiles/bt-hfp-audio-gateway/src/config.rs
- M src/connectivity/bluetooth/profiles/bt-hfp-audio-gateway/src/inspect.rs
- M src/connectivity/bluetooth/profiles/bt-hfp-audio-gateway/src/peer/procedure.rs
- M src/connectivity/bluetooth/profiles/bt-rfcomm/src/rfcomm/inspect.rs
- M src/connectivity/bluetooth/profiles/bt-rfcomm/src/rfcomm/session/channel.rs
- M src/connectivity/bluetooth/profiles/bt-rfcomm/src/rfcomm/session/mod.rs
- M src/connectivity/bluetooth/profiles/bt-rfcomm/src/rfcomm/session/multiplexer.rs
- M src/connectivity/bluetooth/tools/bt-snoop/src/tests.rs
- M src/connectivity/network/dns/src/main.rs
- M src/connectivity/network/netstack3/core/filter/BUILD.gn
- M src/connectivity/network/netstack3/core/filter/src/conntrack.rs
- M src/connectivity/network/netstack3/src/bindings/integration_tests.rs
- M src/connectivity/network/stack-migration/src/main.rs
- M src/connectivity/network/testing/netemul/service/src/main.rs
- M src/connectivity/network/tests/integration/inspect/src/ns2.rs
- M src/connectivity/policy/reachability/core/src/inspect.rs
- M src/connectivity/policy/reachability/core/src/lib.rs
- M src/connectivity/wlan/lib/sme/src/client/inspect.rs
- M src/connectivity/wlan/lib/sme/src/client/state/mod.rs
- M src/connectivity/wlan/lib/telemetry/src/processors/connect_disconnect.rs
- M src/connectivity/wlan/lib/telemetry/src/processors/power.rs
- M src/connectivity/wlan/lib/telemetry/src/processors/toggle_events.rs
- M src/connectivity/wlan/wlancfg/src/access_point/state_machine.rs
- M src/connectivity/wlan/wlancfg/src/client/connection_selection/bss_selection.rs
- M src/connectivity/wlan/wlancfg/src/client/connection_selection/mod.rs
- M src/connectivity/wlan/wlancfg/src/client/state_machine.rs
- M src/connectivity/wlan/wlancfg/src/mode_management/iface_manager.rs
- M src/connectivity/wlan/wlancfg/src/telemetry/mod.rs
- M src/connectivity/wlan/wlandevicemonitor/src/inspect.rs
- M src/diagnostics/archivist/src/configs.rs
- M src/diagnostics/archivist/src/diagnostics.rs
- M src/diagnostics/archivist/src/inspect/repository.rs
- M src/diagnostics/archivist/tests/integration/test_cases/src/logs/lifecycle.rs
- M src/diagnostics/persistence/src/inspect_server.rs
- M src/diagnostics/tools/inspect-hierarchy-analyzer/BUILD.gn
- M src/diagnostics/tools/inspect-hierarchy-analyzer/src/main.rs
- M src/fonts/src/font_service/asset/cache.rs
- M src/fonts/src/font_service/family.rs
- M src/fonts/src/font_service/inspect.rs
- M src/fonts/src/font_service/typeface/typeface.rs
- M src/lib/diagnostics/hierarchy/rust/src/lib.rs
- M src/lib/diagnostics/inspect/contrib/rust/src/graph/digraph.rs
- M src/lib/diagnostics/inspect/contrib/rust/src/id_enum.rs
- M src/lib/diagnostics/inspect/contrib/rust/src/inspectable/mod.rs
- M src/lib/diagnostics/inspect/contrib/rust/src/log/mod.rs
- M src/lib/diagnostics/inspect/contrib/rust/src/nodes/list.rs
- M src/lib/diagnostics/inspect/contrib/rust/src/nodes/lru_cache.rs
- M src/lib/diagnostics/inspect/contrib/rust/src/nodes/mod.rs
- M src/lib/diagnostics/inspect/derive/tests/src/main.rs
- M src/lib/diagnostics/inspect/rust/bench/reader/src/main.rs
- M src/lib/diagnostics/inspect/rust/bench/snapshot_filter/BUILD.gn
- M src/lib/diagnostics/inspect/rust/bench/snapshot_filter/src/main.rs
- M src/lib/diagnostics/inspect/rust/bench/utils/src/lib.rs
- M src/lib/diagnostics/inspect/rust/src/component.rs
- M src/lib/diagnostics/inspect/rust/src/health.rs
- M src/lib/diagnostics/inspect/rust/src/reader/mod.rs
- M src/lib/diagnostics/inspect/rust/src/stats.rs
- M src/lib/diagnostics/inspect/rust/src/writer/types/base.rs
- M src/lib/diagnostics/inspect/rust/src/writer/types/inspector.rs
- M src/lib/diagnostics/inspect/rust/src/writer/types/node.rs
- M src/lib/diagnostics/inspect/rust/src/writer/types/string_array.rs
- M src/lib/diagnostics/inspect/rust/src/writer/types/string_reference.rs
- M src/lib/diagnostics/inspect/rust/src/writer/types/value_list.rs
- M src/lib/diagnostics/inspect/rust/src/writer/utils.rs
- M src/lib/diagnostics/testing/diagnostics-assertions/rust/src/lib.rs
- M src/lib/windowed-stats/BUILD.gn
- M src/lib/windowed-stats/src/experimental/event/mod.rs
- M src/lib/windowed-stats/src/experimental/serve.rs
- M src/lib/windowed-stats/src/lib.rs
- M src/performance/memory/attribution/monitor/src/inspect_nodes/lib.rs
- M src/power/broker/src/broker.rs
- M src/power/broker/src/topology.rs
- M src/power/cpu-manager/src/rppm_handler.rs
- M src/power/cpu-manager/src/thermal_watcher.rs
- M src/power/metrics-logger/src/cpu_load_logger.rs
- M src/power/metrics-logger/src/gpu_usage_logger.rs
- M src/power/metrics-logger/src/main.rs
- M src/power/metrics-logger/src/network_activity_logger.rs
- M src/power/metrics-logger/src/sensor_logger.rs
- M src/power/power-manager/src/platform_metrics.rs
- M src/power/power-manager/src/system_power_mode_handler.rs
- M src/power/power-manager/src/system_profile_handler.rs
- M src/power/power-manager/src/temperature_handler.rs
- M src/power/power-manager/src/thermal_load_driver.rs
- M src/power/power-manager/src/thermal_state_handler.rs
- M src/power/shutdown-shim/src/shutdown_watcher.rs
- M src/power/system-activity-governor/integration/tests/src/main.rs
- M src/settings/inspect_utils/src/joinable_inspect_vecdeque.rs
- M src/settings/inspect_utils/src/managed_inspect_map.rs
- M src/settings/inspect_utils/src/managed_inspect_queue.rs
- M src/settings/service/src/config/default_settings.rs
- M src/settings/service/src/inspect/config_logger.rs
- M src/settings/service/src/inspect/listener_logger.rs
- M src/settings/storage/src/device_storage.rs
- M src/settings/storage/src/stash_logger.rs
- M src/starnix/kernel/fs/fuchsia/nmfs/manager.rs
- M src/sys/component_manager/lib/diagnostics/src/lifecycle.rs
- M src/sys/component_manager/lib/diagnostics/src/task_metrics/component_tree_stats.rs
- M src/sys/component_manager/lib/diagnostics/src/task_metrics/task_info.rs
- M src/sys/component_manager/src/builtin/ota_health_verification.rs
- M src/sys/component_manager/src/model/tests/diagnostics.rs
- M src/sys/pkg/bin/omaha-client/src/inspect.rs
- M src/sys/pkg/bin/omaha-client/src/observer/platform.rs
- M src/sys/pkg/bin/pkg-cache/src/index/writing.rs
- M src/sys/pkg/bin/pkg-resolver/src/cache/inspect.rs
- M src/sys/pkg/bin/pkg-resolver/src/inspect_util.rs
- M src/sys/pkg/bin/pkg-resolver/src/resolver_service/inspect.rs
- M src/sys/pkg/bin/pkg-resolver/src/rewrite_manager.rs
- M src/sys/pkg/bin/system-update-checker/src/update_monitor.rs
- M src/sys/pkg/bin/system-update-committer/src/metadata/inspect.rs
- M src/sys/pkg/bin/system-update-configurator/src/health.rs
- M src/sys/pkg/bin/system-updater/src/install_manager.rs
- M src/sys/pkg/lib/bounded-node/BUILD.gn
- M src/sys/pkg/lib/bounded-node/src/lib.rs
- M src/sys/pkg/lib/fidl-fuchsia-update-installer-ext/BUILD.gn
- M src/sys/pkg/lib/fidl-fuchsia-update-installer-ext/src/state.rs
- M src/sys/pkg/tests/pkg-cache/src/inspect.rs
- M src/sys/test_manager/src/self_diagnostics.rs
- M src/sys/time/httpsdate_time_source/src/diagnostics/inspect.rs
- M src/sys/time/lib/inspect-writable/tests/derive_test.rs
- M src/sys/time/timekeeper/src/diagnostics/inspect.rs
- M src/ui/lib/input_pipeline/src/autorepeater.rs
- M src/ui/lib/input_pipeline/src/chromebook_keyboard_handler.rs
- M src/ui/lib/input_pipeline/src/dead_keys_handler.rs
- M src/ui/lib/input_pipeline/src/factory_reset_handler.rs
- M src/ui/lib/input_pipeline/src/gestures/gesture_arena.rs
- M src/ui/lib/input_pipeline/src/keymap_handler.rs
- M src/ui/lib/input_pipeline/src/light_sensor/light_sensor_handler/light_sensor_handler_tests.rs
- M src/ui/lib/input_pipeline/src/modifier_handler.rs
- M src/ui/lib/input_pipeline/src/pointer_display_scale_handler.rs
- M src/ui/lib/input_pipeline/src/pointer_sensor_scale_handler.rs
- M src/ui/lib/input_pipeline/src/text_settings_handler.rs
- M src/virtualization/bin/vmm/device/virtio_balloon/src/balloon_device.rs
Change size: XL
Delta: 149 files changed, 967 insertions(+), 830 deletions(-)
Related details
Attention is currently required from:
- Owners Override
Submit Requirements:
Code-Review
Dependencies-Satisfied
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/0776ba8e71c254c0037346aa32623ba2a1ce9f03-HTML%40fuchsia-review.googlesource.com.
'James Robinson (Gerrit)' via owners-override
May 19, 2025, 6:42:25 PM5/19/25
to Clayton McCray, Owners Override, Christopher Johnson, Brian Bosak, GI Try Builder, CQ Bot
Attention needed from Clayton McCray and Owners Override
James Robinson voted Owners-Override+1![]( "Open in Gerrit")
Attention is currently required from:
- Clayton McCray
- Owners Override
Submit Requirements:
Code-Review
Dependencies-Satisfied
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/753c52fff2c49ae6db31daf6e31b2791a92f61f5-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'Clayton McCray (Gerrit)' via owners-override
May 20, 2025, 1:48:02 PM5/20/25
to CL Deps Checker, James Robinson, Owners Override, Christopher Johnson, Brian Bosak, GI Try Builder, CQ Bot
Attention needed from Owners Override
Clayton McCray voted Commit-Queue+2![]( "Open in Gerrit")
Attention is currently required from:
- Owners Override
Submit Requirements:
Code-Review
Dependencies-Satisfied
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/db00bbb3d1615c636ff9d79fa7983e1e5a2f25a8-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'Clayton McCray (Gerrit)' via owners-override
May 20, 2025, 3:09:46 PM5/20/25
to CL Deps Checker, James Robinson, Owners Override, Christopher Johnson, Brian Bosak, GI Try Builder, CQ Bot
Attention needed from Owners Override
Clayton McCray voted Fuchsia-Auto-Submit+1![]( "Open in Gerrit")
| Fuchsia-Auto-Submit | +1 |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/12f06bbc7237a53e9928824080180d7c4854a3b4-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'CQ Bot (Gerrit)' via owners-override
May 20, 2025, 3:46:41 PM5/20/25
to Clayton McCray, Auto-Submit, CL Deps Checker, James Robinson, Owners Override, Christopher Johnson, Brian Bosak, GI Try Builder
CQ Bot submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[inspect] Make DiagnosticsHierarchyGetter async
We previously used futures::block_on to make the trait synchronous.
Apparently, it is a bug to use Fuchsia specific things (such as the
timers we use in the readers lib) within a non-Fuchsia executor.
So this makes the trait async (which probably wasn't supported when
the trait was originally written) and updates all the places that
should now be async.
Bug: 409822059
Depends-on: turquoise-internal:Ib3d2917f05d84e482371f6a0e9e10b3f2e60a110
Change-Id: Icc8b9e1d361b510277cc7b81f73eafee13ef13a6
Fuchsia-Auto-Submit: Clayton McCray <clayto...@google.com>
Commit-Queue: Auto-Submit <auto-subm...@fuchsia-internal-service-accts.iam.gserviceaccount.com>
Reviewed-by: Brian Bosak <bbo...@google.com>
Owners-Override: James Robinson <jam...@google.com>
Reviewed-by: Christopher Johnson <crj...@google.com>
Dependencies-Satisfied: CL Deps Checker <cl-deps...@fuchsia-internal-service-accts.iam.gserviceaccount.com>
Branch: refs/heads/main
Submit Requirements:
Code-Review: +2 by Christopher Johnson, +2 by Brian Bosak
Dependencies-Satisfied: +1 by CL Deps Checker
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/6d6172b20fbd22e5807aefc04bd31b5e641ce0a3-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'GI Roller (Gerrit)' via owners-override
May 20, 2025, 3:49:56 PM5/20/25
to Clayton McCray, CQ Bot, Auto-Submit, CL Deps Checker, James Robinson, Owners Override, Christopher Johnson, Brian Bosak, GI Try Builder
Message from GI Roller![]( "Open in Gerrit")
Change has been successfully rolled: http://go/roll-cl/ad19085ee9961efc5ef65a8421d89996b9f07764
Related details
Attention set is empty
Submit Requirements:
Code-Review
Dependencies-Satisfied
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/c867a58cb7dd490baf44160b525fc6fa7cb1a3ba-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
Reply all
Reply to author
Forward
0 new messages