[L] Change in fuchsia/fuchsia[main]: [rust-3p] Allow fuchsia to use syn 2.x

0 views
Skip to first unread message

'Erick Tryzelaar (Gerrit)' via owners-override

unread,
Apr 1, 2024, 11:54:39 AMApr 1
to Owners Override, Paul Faria, CQ Bot

Erick Tryzelaar added 1 comment

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Erick Tryzelaar . resolved

Adding owners override since this touches a number of targets across Fuchsia, but it doesn't change any code.

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I16646b2a468d6831f7edf18a0030a01e822d54b7
Gerrit-Change-Number: 1016635
Gerrit-PatchSet: 3
Gerrit-Owner: Erick Tryzelaar <etryz...@google.com>
Gerrit-Reviewer: Erick Tryzelaar <etryz...@google.com>
Gerrit-Reviewer: Paul Faria <paul...@google.com>
Gerrit-CC: Owners Override <owners-...@fuchsia.dev>
Gerrit-Comment-Date: Mon, 01 Apr 2024 15:54:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/596db1a578f98faa62d41b9d6e1689b5daf41d4a-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy

'Erick Tryzelaar (Gerrit)' via owners-override

unread,
Apr 1, 2024, 11:54:39 AMApr 1
to Owners Override

Erick Tryzelaar has uploaded the change for review

Commit message

[rust-3p] Allow fuchsia to use syn 2.x

There were a number of breaking changes in syn 2.x. Since there are a
large number of fuchsia targets using syn 1.x, this switches the default
version exposed to fuchsia to 2.x, but allows legacy apps to still use
1.x. This should help prevent any new tech debt, and allow us to gracefully
migrate the legacy targets to syn 2.x over time.

Bug: 332277415
Change-Id: I16646b2a468d6831f7edf18a0030a01e822d54b7

Change diff


Change information

Files:
  • M src/connectivity/bluetooth/testing/test-harness-macro/BUILD.gn
  • M src/connectivity/lib/ip-test-macro/BUILD.gn
  • M src/connectivity/lib/ip-test-macro/test/BUILD.gn
  • M src/connectivity/lib/net-declare/BUILD.gn
  • M src/connectivity/lib/net-types/BUILD.gn
  • M src/connectivity/lowpan/lib/spinel_pack/spinel_pack_macros/BUILD.gn
  • M src/connectivity/network/lib/todo_unused/BUILD.gn
  • M src/connectivity/network/netstack3/core/macros/BUILD.gn
  • M src/connectivity/network/tests/integration/macros/BUILD.gn
  • M src/connectivity/network/tests/integration/multicast-forwarding/macros/BUILD.gn
  • M src/connectivity/wlan/lib/bitfield/BUILD.gn
  • M src/connectivity/wlan/lib/frame_writer/macro/BUILD.gn
  • M src/connectivity/wlan/lib/statemachine/macro/BUILD.gn
  • M src/developer/ffx/config/macro/proc_macro/BUILD.gn
  • M src/developer/ffx/core/macro/BUILD.gn
  • M src/developer/ffx/lib/fho/macro/BUILD.gn
  • M src/developer/ffx/lib/protocols/macros/BUILD.gn
  • M src/developer/ffx/lib/validation/proc_macro/BUILD.gn
  • M src/developer/ffx/plugins/fuzz/shell_args/BUILD.gn
  • M src/lib/assembly/file_relative_path/BUILD.gn
  • M src/lib/diagnostics/inspect/derive/macro/BUILD.gn
  • M src/lib/fidl_table_validation/fidl_table_validation_derive/BUILD.gn
  • M src/lib/from-enum/BUILD.gn
  • M src/lib/fuchsia-async-macro/BUILD.gn
  • M src/lib/fuchsia/macro/BUILD.gn
  • M src/lib/fuzzing/rust/BUILD.gn
  • M src/lib/include_bytes_from_working_dir/BUILD.gn
  • M src/lib/include_str_from_working_dir/BUILD.gn
  • M src/lib/testing/fixture/BUILD.gn
  • M src/starnix/lib/filter_methods_macro/BUILD.gn
  • M src/storage/fxfs/BUILD.gn
  • M src/storage/fxfs/trace/macros/BUILD.gn
  • M src/storage/lib/vfs/rust/macros/BUILD.gn
  • M src/storage/type-fprint/BUILD.gn
  • M src/sys/lib/cm_rust/BUILD.gn
  • M src/sys/time/lib/inspect-writable/macro/BUILD.gn
  • M third_party/rust_crates/BUILD.gn
  • M third_party/rust_crates/Cargo.lock
  • M third_party/rust_crates/Cargo.toml
  • M tools/lib/cml/macro/BUILD.gn
  • M tools/lib/config_client/BUILD.gn
  • M tools/lib/reference_doc/macro/BUILD.gn
  • M tools/shush/BUILD.gn
Change size: L
Delta: 43 files changed, 262 insertions(+), 46 deletions(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I16646b2a468d6831f7edf18a0030a01e822d54b7
Gerrit-Change-Number: 1016635
Gerrit-PatchSet: 3
Gerrit-Owner: Erick Tryzelaar <etryz...@google.com>
Gerrit-Reviewer: Erick Tryzelaar <etryz...@google.com>
Gerrit-Reviewer: Paul Faria <paul...@google.com>
Gerrit-CC: Owners Override <owners-...@fuchsia.dev>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/596db1a578f98faa62d41b9d6e1689b5daf41d4a-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy

'Erick Tryzelaar (Gerrit)' via owners-override

unread,
Apr 1, 2024, 12:42:46 PMApr 1
to Owners Override, Paul Faria, CQ Bot

Erick Tryzelaar added 1 comment

File third_party/rust_crates/BUILD.gn
Line 14880, Patchset 3 (Latest): visibility += [ ":*" ]
Paul Faria . resolved

Should the TODO link also be added here?

Erick Tryzelaar

No, this file is maintained by `fx update-rustc-third-party`, so it'd be removed the next time it's updated.

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I16646b2a468d6831f7edf18a0030a01e822d54b7
Gerrit-Change-Number: 1016635
Gerrit-PatchSet: 3
Gerrit-Owner: Erick Tryzelaar <etryz...@google.com>
Gerrit-Reviewer: Erick Tryzelaar <etryz...@google.com>
Gerrit-Reviewer: Paul Faria <paul...@google.com>
Gerrit-CC: Owners Override <owners-...@fuchsia.dev>
Gerrit-Comment-Date: Mon, 01 Apr 2024 16:42:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Faria <paul...@google.com>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/32c25d17c109f2d4dfb4c77f914e49d91400c48d-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy

'Hunter Freyer (Gerrit)' via owners-override

unread,
Apr 2, 2024, 10:05:02 AMApr 2
to Erick Tryzelaar, Owners Override, Paul Faria, CQ Bot
Attention needed from Erick Tryzelaar

Hunter Freyer voted Owners-Override+1

Owners-Override+1
Open in Gerrit

Related details

Attention is currently required from:
  • Erick Tryzelaar
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I16646b2a468d6831f7edf18a0030a01e822d54b7
Gerrit-Change-Number: 1016635
Gerrit-PatchSet: 3
Gerrit-Owner: Erick Tryzelaar <etryz...@google.com>
Gerrit-Reviewer: Erick Tryzelaar <etryz...@google.com>
Gerrit-Reviewer: Hunter Freyer <hjfr...@google.com>
Gerrit-Reviewer: Paul Faria <paul...@google.com>
Gerrit-CC: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Erick Tryzelaar <etryz...@google.com>
Gerrit-Comment-Date: Tue, 02 Apr 2024 14:04:56 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/0ae95898c3b34a267fae65b13bc166c580615759-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy

'CQ Bot (Gerrit)' via owners-override

unread,
Apr 2, 2024, 10:50:09 AMApr 2
to Erick Tryzelaar, Auto-Submit, Hunter Freyer, Owners Override, Paul Faria

CQ Bot submitted the change

Change information

Commit message:
[rust-3p] Allow fuchsia to use syn 2.x

There were a number of breaking changes in syn 2.x. Since there are a
large number of fuchsia targets using syn 1.x, this switches the default
version exposed to fuchsia to 2.x, but allows legacy apps to still use
1.x. This should help prevent any new tech debt, and allow us to gracefully
migrate the legacy targets to syn 2.x over time.

Bug: 332277415
Change-Id: I16646b2a468d6831f7edf18a0030a01e822d54b7
Fuchsia-Auto-Submit: Erick Tryzelaar <etryz...@google.com>
Reviewed-by: Paul Faria <paul...@google.com>
Owners-Override: Hunter Freyer <hjfr...@google.com>
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +2 by Paul Faria
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I16646b2a468d6831f7edf18a0030a01e822d54b7
Gerrit-Change-Number: 1016635
Gerrit-PatchSet: 4
Gerrit-Owner: Erick Tryzelaar <etryz...@google.com>
Gerrit-Reviewer: Auto-Submit <auto-...@fuchsia-infra.iam.gserviceaccount.com>
Gerrit-Reviewer: Erick Tryzelaar <etryz...@google.com>
Gerrit-Reviewer: Hunter Freyer <hjfr...@google.com>
Gerrit-Reviewer: Paul Faria <paul...@google.com>
Gerrit-CC: Owners Override <owners-...@fuchsia.dev>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/3ff647eb451951b816dd8379098c3ab722dfaacc-HTML%40fuchsia-review.googlesource.com.
open
diffy
satisfied_requirement

'GI Roller (Gerrit)' via owners-override

unread,
Apr 2, 2024, 10:53:06 AMApr 2
to CQ Bot, Erick Tryzelaar, Auto-Submit, Hunter Freyer, Owners Override, Paul Faria

Message from GI Roller

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I16646b2a468d6831f7edf18a0030a01e822d54b7
Gerrit-Change-Number: 1016635
Gerrit-PatchSet: 4
Gerrit-Owner: Erick Tryzelaar <etryz...@google.com>
Gerrit-Reviewer: Auto-Submit <auto-...@fuchsia-infra.iam.gserviceaccount.com>
Gerrit-Reviewer: Erick Tryzelaar <etryz...@google.com>
Gerrit-Reviewer: Hunter Freyer <hjfr...@google.com>
Gerrit-Reviewer: Paul Faria <paul...@google.com>
Gerrit-CC: Owners Override <owners-...@fuchsia.dev>
Gerrit-Comment-Date: Tue, 02 Apr 2024 14:53:01 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/0f1481a510d209cc65bd49b93bedb984b137b705-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages