[M] Change in fuchsia/fuchsia[main]: [version-history] Move users to version_history_data::HISTORY.

['Hunter Freyer (Gerrit)' via owners-override]

Attention needed from Adam Barth, David Dorwin and Owners Override

Hunter Freyer voted and added 6 comments

Votes added by Hunter Freyer

Commit-Queue	+1
Fuchsia-Auto-Submit	+1

6 comments

Commit Message

Line 7, Patchset 6:[version-history] Move users to version_history_static::HISTORY.

David Dorwin . resolved

It's not obvious to me that "static" means it includes the actual version data. Is there a better way to convey this - and perhaps that doing so has build implications?

Similarly, would `.../version-history...types` be better than the more generic `version_history` target that doesn't actually contain history?

Hunter Freyer

As discussed, renamed the "static" library to "data" in fxrev.dev/1088435

Line 7, Patchset 6:[version-history] Move users to version_history_static::HISTORY.

David Dorwin . resolved

Is this moving all users or just those that need more than the types? Please clarify.

Hunter Freyer

Done.

File src/developer/ffx/lib/errors/BUILD.gn

Line 21, Patchset 6: "//src/lib/versioning/version-history/rust/static",

David Dorwin . resolved

This lib seems likely to be widely depended on. I wonder if simplifying the single error message would be preferable. (This is out of scope for this CL.)

Hunter Freyer

Yeah, I had another CL to remove it, but it's less urgent now that I'm pursuing the "daily rotation" idea.

File src/lib/assembly/validate_product/BUILD.gn

Line 19, Patchset 6: "//src/lib/versioning/version-history/rust",

David Dorwin . resolved

Is this not indirectly deps'd by the new line? Maybe not until the next CL? Should we add that deps now so we can remove these in this CL?

Hunter Freyer

Indirect dependencies aren't a thing in Rust. Libraries that use both crates need to import both.

File src/lib/fuchsia-component-test/realm_builder_server/BUILD.gn

Line 55, Patchset 6: "//src/lib/versioning/version-history/rust/static",

David Dorwin . resolved

Just checking that only tests need the actual data, and the code needs the types (line 37). Is that right?

There are no non-test instances of `version_history`. Do the types have other names?

Hunter Freyer

I'm not sure what you mean. `resolver.rs` uses `version_history` here: https://fuchsia.googlesource.com/fuchsia/+/refs/changes/73/1084573/7/src/lib/fuchsia-component-test/realm_builder_server/src/resolver.rs#16

Generally speaking, Rust won't let you mess this up. If you use a crate, you need to depend on it. If you don't use it, you can't depend on it.

File src/sys/component_manager/BUILD.gn

Line 64, Patchset 6: "//src/lib/versioning/version-history/rust",

David Dorwin . resolved

Similar question about indirect deps here and in several other files below.

Hunter Freyer

Acknowledged

Open in Gerrit

Related details

Attention is currently required from:

• Adam Barth
• David Dorwin
• Owners Override

Submit Requirements:

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: fuchsia

Gerrit-Branch: main

Gerrit-Change-Id: I10fd3cc18c64ec75b19172c86b73a9e06a1c6704

Gerrit-Change-Number: 1084573

Gerrit-PatchSet: 7

Gerrit-Owner: Hunter Freyer <hjfr...@google.com>

Gerrit-Reviewer: Adam Barth <aba...@google.com>

Gerrit-Reviewer: David Dorwin <ddo...@google.com>

Gerrit-Reviewer: Hunter Freyer <hjfr...@google.com>

Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>

Gerrit-CC: CQ Bot <fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Fuchsia Try Builder <fuchsia-t...@fuchsia-infra.iam.gserviceaccount.com>

Gerrit-Attention: David Dorwin <ddo...@google.com>

Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>

Gerrit-Attention: Adam Barth <aba...@google.com>

Gerrit-Comment-Date: Wed, 24 Jul 2024 18:38:07 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

Comment-In-Reply-To: David Dorwin <ddo...@google.com>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/d1699bab5c5f1d7dc2bdffb9ee3494cee4d3c533-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

['Clayton Wilkinson (Gerrit)' via owners-override]

Attention needed from Adam Barth, David Dorwin, Hunter Freyer and Owners Override

Clayton Wilkinson voted Code-Review+2

Code-Review

+2

Open in Gerrit

Related details

Attention is currently required from:

• Adam Barth
• David Dorwin
• Hunter Freyer
• Owners Override

Submit Requirements:

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: fuchsia

Gerrit-Branch: main

Gerrit-Change-Id: I10fd3cc18c64ec75b19172c86b73a9e06a1c6704

Gerrit-Change-Number: 1084573

Gerrit-PatchSet: 7

Gerrit-Owner: Hunter Freyer <hjfr...@google.com>

Gerrit-Reviewer: Adam Barth <aba...@google.com>

Gerrit-Reviewer: Clayton Wilkinson <wilkin...@google.com>

Gerrit-Reviewer: David Dorwin <ddo...@google.com>

Gerrit-Reviewer: Hunter Freyer <hjfr...@google.com>

Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>

Gerrit-CC: CQ Bot <fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Fuchsia Try Builder <fuchsia-t...@fuchsia-infra.iam.gserviceaccount.com>

Gerrit-Attention: David Dorwin <ddo...@google.com>

Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>

Gerrit-Attention: Adam Barth <aba...@google.com>

Gerrit-Attention: Hunter Freyer <hjfr...@google.com>

Gerrit-Comment-Date: Wed, 24 Jul 2024 19:19:44 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/b8575288f59263ff1b7abd81541f3f3339479805-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

['David Dorwin (Gerrit)' via owners-override]

Attention needed from Adam Barth, Hunter Freyer and Owners Override

David Dorwin voted Code-Review+2

Code-Review

+2

Open in Gerrit

Related details

Attention is currently required from:

• Adam Barth
• Hunter Freyer
• Owners Override

Submit Requirements:

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: fuchsia

Gerrit-Branch: main

Gerrit-Change-Id: I10fd3cc18c64ec75b19172c86b73a9e06a1c6704

Gerrit-Change-Number: 1084573

Gerrit-PatchSet: 7

Gerrit-Owner: Hunter Freyer <hjfr...@google.com>

Gerrit-Reviewer: Adam Barth <aba...@google.com>

Gerrit-Reviewer: Clayton Wilkinson <wilkin...@google.com>

Gerrit-Reviewer: David Dorwin <ddo...@google.com>

Gerrit-Reviewer: Hunter Freyer <hjfr...@google.com>

Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>

Gerrit-CC: CQ Bot <fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Fuchsia Try Builder <fuchsia-t...@fuchsia-infra.iam.gserviceaccount.com>

Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>

Gerrit-Attention: Adam Barth <aba...@google.com>

Gerrit-Attention: Hunter Freyer <hjfr...@google.com>

Gerrit-Comment-Date: Wed, 24 Jul 2024 20:27:00 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/79c57df8b3c396281ca561abb1d54cedf90472f4-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

['Adam Barth (Gerrit)' via owners-override]

Attention needed from Hunter Freyer and Owners Override

Adam Barth voted Owners-Override+1

Owners-Override

+1

Open in Gerrit

Related details

Attention is currently required from:

• Hunter Freyer
• Owners Override

Submit Requirements:

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: fuchsia

Gerrit-Branch: main

Gerrit-Change-Id: I10fd3cc18c64ec75b19172c86b73a9e06a1c6704

Gerrit-Change-Number: 1084573

Gerrit-PatchSet: 8

Gerrit-Owner: Hunter Freyer <hjfr...@google.com>

Gerrit-Reviewer: Adam Barth <aba...@google.com>

Gerrit-Reviewer: Clayton Wilkinson <wilkin...@google.com>

Gerrit-Reviewer: David Dorwin <ddo...@google.com>

Gerrit-Reviewer: Hunter Freyer <hjfr...@google.com>

Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>

Gerrit-CC: CQ Bot <fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Fuchsia Try Builder <fuchsia-t...@fuchsia-infra.iam.gserviceaccount.com>

Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>

Gerrit-Attention: Hunter Freyer <hjfr...@google.com>

Gerrit-Comment-Date: Thu, 25 Jul 2024 15:37:45 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/247a8d1c2b979ceeaa334b7dcd399d120c0d1984-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

['CQ Bot (Gerrit)' via owners-override]

CQ Bot submitted the change with unreviewed changes

Unreviewed changes

7 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:

[version-history] Move users to version_history_data::HISTORY.

All the changes are trivial, moving from one library to the other. The
next CL will remove version_history::HISTORY, improving cache hits for
targets that just depend on the version_history types, not the data.

Bug: 353952180

Change-Id: I10fd3cc18c64ec75b19172c86b73a9e06a1c6704

Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1084573

Reviewed-by: Clayton Wilkinson <wilkin...@google.com>

Owners-Override: Adam Barth <aba...@google.com>

Fuchsia-Auto-Submit: Hunter Freyer <hjfr...@google.com>

Commit-Queue: Auto-Submit <auto-...@fuchsia-infra.iam.gserviceaccount.com>

Reviewed-by: David Dorwin <ddo...@google.com>

Files:

• M src/developer/ffx/daemon/target/BUILD.gn
• M src/developer/ffx/daemon/target/src/overnet/host_pipe.rs
• M src/developer/ffx/lib/errors/BUILD.gn
• M src/developer/ffx/lib/errors/src/lib.rs
• M src/developer/ffx/lib/fuchsia-controller/BUILD.gn
• M src/developer/ffx/lib/fuchsia-controller/src/env_context.rs
• M src/developer/ffx/lib/target/BUILD.gn
• M src/developer/ffx/lib/target/src/ssh_connector.rs
• M src/developer/ffx/lib/version/BUILD.gn
• M src/developer/ffx/lib/version/src/lib.rs
• M src/developer/remote-control/runner/BUILD.gn
• M src/developer/remote-control/runner/src/main.rs
• M src/lib/assembly/validate_product/BUILD.gn
• M src/lib/assembly/validate_product/src/lib.rs
• M src/lib/fuchsia-component-test/realm_builder_server/BUILD.gn
• M src/lib/fuchsia-component-test/realm_builder_server/src/main.rs
• M src/sys/component_manager/BUILD.gn
• M src/sys/component_manager/src/builtin/builtin_resolver.rs
• M src/sys/component_manager/src/builtin/fuchsia_boot_resolver.rs
• M src/sys/component_manager/src/model/actions/resolve.rs
• M src/sys/component_manager/src/model/resolver.rs
• M src/sys/component_manager/src/model/testing/mocks.rs
• M src/sys/component_manager/src/model/tests/routing.rs
• M src/sys/component_manager/tests/abi_compatibility/BUILD.gn
• M src/sys/component_manager/tests/abi_compatibility/src/integration_test.rs
• M src/sys/component_manager/tests/resolvers/cast/BUILD.gn
• M src/sys/component_manager/tests/resolvers/cast/integration_test.rs
• M src/sys/component_manager/tests/resolvers/custom/BUILD.gn
• M src/sys/component_manager/tests/resolvers/custom/src/resolver.rs
• M src/sys/lib/fidl-fuchsia-component-abi-ext/BUILD.gn
• M src/sys/lib/fidl-fuchsia-component-abi-ext/src/lib.rs
• M src/sys/pkg/lib/fuchsia-pkg/BUILD.gn
• M src/sys/pkg/lib/fuchsia-pkg/src/package_builder.rs
• M src/sys/pkg/lib/package-tool/BUILD.gn
• M src/sys/pkg/lib/package-tool/src/package_build.rs

Change size: M

Delta: 35 files changed, 59 insertions(+), 38 deletions(-)

Branch: refs/heads/main

Submit Requirements:

• Code-Review: +2 by David Dorwin, +2 by Clayton Wilkinson

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: fuchsia

Gerrit-Branch: main

Gerrit-Change-Id: I10fd3cc18c64ec75b19172c86b73a9e06a1c6704

Gerrit-Change-Number: 1084573

Gerrit-PatchSet: 9

Gerrit-Owner: Hunter Freyer <hjfr...@google.com>

Gerrit-Reviewer: Adam Barth <aba...@google.com>

Gerrit-Reviewer: Auto-Submit <auto-...@fuchsia-infra.iam.gserviceaccount.com>

Gerrit-Reviewer: CQ Bot <fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Clayton Wilkinson <wilkin...@google.com>

Gerrit-Reviewer: David Dorwin <ddo...@google.com>

Gerrit-Reviewer: Hunter Freyer <hjfr...@google.com>

Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>

Gerrit-CC: Fuchsia Try Builder <fuchsia-t...@fuchsia-infra.iam.gserviceaccount.com>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/c67f41e48c37f190e07eacd74cdf020295c6ecce-HTML%40fuchsia-review.googlesource.com.

['GI Roller (Gerrit)' via owners-override]

Message from GI Roller

Change has been successfully rolled: http://go/roll-cl/31e45a62f3d61a91c91813b501bd3f3e84234a61

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: fuchsia

Gerrit-Branch: main

Gerrit-Change-Id: I10fd3cc18c64ec75b19172c86b73a9e06a1c6704

Gerrit-Change-Number: 1084573

Gerrit-PatchSet: 9

Gerrit-Owner: Hunter Freyer <hjfr...@google.com>

Gerrit-Reviewer: Adam Barth <aba...@google.com>

Gerrit-Reviewer: Auto-Submit <auto-...@fuchsia-infra.iam.gserviceaccount.com>

Gerrit-Reviewer: CQ Bot <fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Clayton Wilkinson <wilkin...@google.com>

Gerrit-Reviewer: David Dorwin <ddo...@google.com>

Gerrit-Reviewer: Hunter Freyer <hjfr...@google.com>

Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>

Gerrit-CC: Fuchsia Try Builder <fuchsia-t...@fuchsia-infra.iam.gserviceaccount.com>

Gerrit-CC: GI Roller <global-integra...@fuchsia-infra.iam.gserviceaccount.com>

Gerrit-Comment-Date: Thu, 25 Jul 2024 16:28:30 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: No

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/a24e3f13fb7404cc28feb39d8743f20be37b3c8e-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.