[S] Change in fuchsia/fuchsia[main]: Revert "[cipd] Adds fastboot GBL to public checkout."

0 views
Skip to first unread message

'Betram Lalusha (Gerrit)' via owners-override

unread,
Jul 24, 2025, 4:08:14 PMJul 24
to Clayton Wilkinson, Jerry Belton, Owners Override, Oliver Newman, CQ Bot, Adam Barth, GI Try Builder, GI Roller
Attention needed from Clayton Wilkinson, Jerry Belton, Oliver Newman and Owners Override

Betram Lalusha has uploaded the change for review

Betram Lalusha would like Clayton Wilkinson, Jerry Belton, Owners Override, Oliver Newman and CQ Bot to review this change.

Commit message

Revert "[cipd] Adds fastboot GBL to public checkout."

This reverts commit 90f8dfbf0e254358f6b145dbc1b187575cc0baf2.

Reason for revert: Violates Fuchsia licensing guidelines

Bug: 404956008
Original change's description:
> [cipd] Adds fastboot GBL to public checkout.
>
> This will be used by a recipe uploading images required by NUC11s in
> fastboot over TCP.
>
> Bug: 404956008
> Change-Id: Iea6314a92affb35cff131807f63b702f385d99dd
> Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1325665
> Commit-Queue: Betram Lalusha <betram...@google.com>
> Reviewed-by: Oliver Newman <oliver...@google.com>
> Reviewed-by: Clayton Wilkinson <wilkin...@google.com>
Bug: 404956008
Change-Id: Ied6bcffe867043466820138e49fe76ee51f56af8

Change diff

diff --git a/manifests/jiri.lock b/manifests/jiri.lock
index 0635fb8..572c8a6 100644
--- a/manifests/jiri.lock
+++ b/manifests/jiri.lock
@@ -180,11 +180,6 @@
         "instance_id": "Em7GpaZS1IGYPgJGuss23_UVGR48ZQHf1v6ddx1E2xQC"
     },
     {
-        "package": "fuchsia/infra/images/nuc11/gbl_x86_64.efi",
-        "version": "bid:13801264",
-        "instance_id": "63ZUDc_-LyQBK4LEzKWbGL4n3c_Q6MC7DzbSN9y_eQsC"
-    },
-    {
         "package": "fuchsia/infra/lkg/linux-amd64",
         "version": "git_revision:6c1aba977be6e58e18c8b0d2bd64b3e51ae5e3f9",
         "instance_id": "rP5rpYRz1fBjzZFfSU6L0Fw9Kk_kY5nG9XVo8yTU1E0C"
diff --git a/manifests/prebuilts b/manifests/prebuilts
index 97510eb..91ef151 100644
--- a/manifests/prebuilts
+++ b/manifests/prebuilts
@@ -176,11 +176,6 @@
              platforms="linux-amd64,linux-arm64,mac-amd64,mac-arm64"
              path="prebuilt/third_party/pigz"/>
 
-     <!-- Fastboot GBL from Android Artifacts. -->
-     <package name="fuchsia/infra/images/nuc11/gbl_x86_64.efi"
-              path="prebuilt/infra/images/nuc11/gbl_x86_64.efi"
-              version="bid:13801264"/>
-
     <!--
         ************************************************************
         Tools maintained in fuchsia.git itself.
diff --git a/tools/check-licenses/result/_config.json b/tools/check-licenses/result/_config.json
index 6481834..9543890 100644
--- a/tools/check-licenses/result/_config.json
+++ b/tools/check-licenses/result/_config.json
@@ -49,7 +49,6 @@
           "prebuilt/drivers/backlight": true,
           "prebuilt/fsatrace": true,
           "prebuilt/infra/test_durations/fuchsia": true,
-          "prebuilt/infra/images/nuc11/gbl_x86_64.efi": true,
           "prebuilt/sdk-samples/fortune-teller": true,
           "prebuilt/starnix/android-image-amd64": true,
           "prebuilt/starnix/chromiumos-image-amd64": true,
@@ -191,8 +190,7 @@
           "third_party/tink/testing/java_src/third_party": true,
           "third_party/syzkaller": true,
           "third_party/pylibs": true,
-          "build/secondary/vendor/google/build": true,
-          "prebuilt/infra/images/nuc11/gbl_x86_64.efi": true
+          "build/secondary/vendor/google/build": true
         }
       },
       {

Change information

Files:
  • M manifests/jiri.lock
  • M manifests/prebuilts
  • M tools/check-licenses/result/_config.json
Change size: S
Delta: 3 files changed, 1 insertion(+), 13 deletions(-)
Open in Gerrit

Related details

Attention is currently required from:
  • Clayton Wilkinson
  • Jerry Belton
  • Oliver Newman
  • Owners Override
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement satisfiedCommit-Message-Has-Tags
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: Ied6bcffe867043466820138e49fe76ee51f56af8
Gerrit-Change-Number: 1330385
Gerrit-PatchSet: 1
Gerrit-Owner: Betram Lalusha <betram...@google.com>
Gerrit-Reviewer: Clayton Wilkinson <wilkin...@google.com>
Gerrit-Reviewer: Jerry Belton <jce...@google.com>
Gerrit-Reviewer: Oliver Newman <oliver...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-CC: Adam Barth <aba...@google.com>
Gerrit-Attention: Clayton Wilkinson <wilkin...@google.com>
Gerrit-Attention: Jerry Belton <jce...@google.com>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Oliver Newman <oliver...@google.com>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/2ffbb86c27a68df1246a17e249ab5c0fd24fba82-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
unsatisfied_requirement
open
diffy

'Betram Lalusha (Gerrit)' via owners-override

unread,
Jul 24, 2025, 4:09:06 PMJul 24
to RubberStamper 🤖?, Rubber Stamper (Chrome), Clayton Wilkinson, Jerry Belton, Owners Override, Oliver Newman, CQ Bot, Adam Barth, GI Try Builder, GI Roller
Attention needed from Clayton Wilkinson, Jerry Belton, Oliver Newman and Owners Override

Betram Lalusha voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Clayton Wilkinson
  • Jerry Belton
  • Oliver Newman
  • Owners Override
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedCommit-Message-Has-Tags
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: Ied6bcffe867043466820138e49fe76ee51f56af8
Gerrit-Change-Number: 1330385
Gerrit-PatchSet: 1
Gerrit-Owner: Betram Lalusha <betram...@google.com>
Gerrit-Reviewer: Betram Lalusha <betram...@google.com>
Gerrit-Reviewer: Clayton Wilkinson <wilkin...@google.com>
Gerrit-Reviewer: Jerry Belton <jce...@google.com>
Gerrit-Reviewer: Oliver Newman <oliver...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Reviewer: Rubber Stamper (Chrome) <rubber-...@appspot.gserviceaccount.com>
Gerrit-Reviewer: RubberStamper 🤖 <android-bu...@system.gserviceaccount.com>
Gerrit-CC: Adam Barth <aba...@google.com>
Gerrit-Attention: Clayton Wilkinson <wilkin...@google.com>
Gerrit-Attention: Jerry Belton <jce...@google.com>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Oliver Newman <oliver...@google.com>
Gerrit-Comment-Date: Thu, 24 Jul 2025 20:09:01 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/57c9214002f866a95e58dba8845eac0f2dc17f59-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy

'CQ Bot (Gerrit)' via owners-override

unread,
Jul 24, 2025, 5:38:37 PMJul 24
to Betram Lalusha, RubberStamper 🤖?, Rubber Stamper (Chrome), Clayton Wilkinson, Jerry Belton, Owners Override, Oliver Newman, Adam Barth, GI Try Builder, GI Roller

CQ Bot submitted the change

Change information

Commit message:
Revert "[cipd] Adds fastboot GBL to public checkout."

This reverts commit 90f8dfbf0e254358f6b145dbc1b187575cc0baf2.

Reason for revert: Violates Fuchsia licensing guidelines

Bug: 404956008
Original change's description:
> [cipd] Adds fastboot GBL to public checkout.
>
> This will be used by a recipe uploading images required by NUC11s in
> fastboot over TCP.
>
> Bug: 404956008
> Change-Id: Iea6314a92affb35cff131807f63b702f385d99dd
> Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1325665
> Commit-Queue: Betram Lalusha <betram...@google.com>
> Reviewed-by: Oliver Newman <oliver...@google.com>
> Reviewed-by: Clayton Wilkinson <wilkin...@google.com>
Bug: 404956008
Change-Id: Ied6bcffe867043466820138e49fe76ee51f56af8
Files:
  • M manifests/jiri.lock
  • M manifests/prebuilts
  • M tools/check-licenses/result/_config.json
Change size: S
Delta: 3 files changed, 1 insertion(+), 13 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +2 by RubberStamper 🤖
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: Ied6bcffe867043466820138e49fe76ee51f56af8
Gerrit-Change-Number: 1330385
Gerrit-PatchSet: 2
Gerrit-Owner: Betram Lalusha <betram...@google.com>
Gerrit-Reviewer: Betram Lalusha <betram...@google.com>
Gerrit-Reviewer: Clayton Wilkinson <wilkin...@google.com>
Gerrit-Reviewer: Jerry Belton <jce...@google.com>
Gerrit-Reviewer: Oliver Newman <oliver...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Reviewer: Rubber Stamper (Chrome) <rubber-...@appspot.gserviceaccount.com>
Gerrit-Reviewer: RubberStamper 🤖 <android-bu...@system.gserviceaccount.com>
Gerrit-CC: Adam Barth <aba...@google.com>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/5d560e85b8bfc61178afe6359e2f59d4ca5ae4af-HTML%40fuchsia-review.googlesource.com.
open
diffy
satisfied_requirement

'GI Roller (Gerrit)' via owners-override

unread,
Jul 24, 2025, 5:48:08 PMJul 24
to Betram Lalusha, CQ Bot, RubberStamper 🤖?, Rubber Stamper (Chrome), Clayton Wilkinson, Jerry Belton, Owners Override, Oliver Newman, Adam Barth, GI Try Builder

Message from GI Roller

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedCommit-Message-Has-Tags
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: Ied6bcffe867043466820138e49fe76ee51f56af8
Gerrit-Change-Number: 1330385
Gerrit-PatchSet: 2
Gerrit-Owner: Betram Lalusha <betram...@google.com>
Gerrit-Reviewer: Betram Lalusha <betram...@google.com>
Gerrit-Reviewer: Clayton Wilkinson <wilkin...@google.com>
Gerrit-Reviewer: Jerry Belton <jce...@google.com>
Gerrit-Reviewer: Oliver Newman <oliver...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Reviewer: Rubber Stamper (Chrome) <rubber-...@appspot.gserviceaccount.com>
Gerrit-Reviewer: RubberStamper 🤖 <android-bu...@system.gserviceaccount.com>
Gerrit-CC: Adam Barth <aba...@google.com>
Gerrit-Comment-Date: Thu, 24 Jul 2025 21:48:05 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/31176e46cf91e1152484d2dad1860234b8fbf35e-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages