[L] Change in fuchsia/fuchsia[main]: [fidl] Replace calls to VectorView::count() with size().
1 view
Skip to first unread message
'Victor Costan (Gerrit)' via owners-override
Jul 7, 2025, 5:49:11 PM7/7/25
to Owners Override
Attention needed from Owners Override
Victor Costan has uploaded the change for review![]( "Open in Gerrit")
Victor Costan would like Owners Override to review this change.
Commit message
[fidl] Replace calls to VectorView::count() with size().
This CL was generated by
1. Running gemini-cli with the prompt documented in the attached bug.
2. Reviewing the result and fixing a few errors.
3. Running fx format-code
Bug: 430060081
Change-Id: Idd9d91d9b56f12b79d9a34fe4123fa18c984d379
Change diff
Change information
Files:
- M sdk/lib/driver/compat/cpp/connect.cc
- M sdk/lib/driver/component/cpp/driver_component_cpp.api
- M sdk/lib/driver/component/cpp/internal/start_args.h
- M sdk/lib/driver/platform-device/cpp/pdev.cc
- M sdk/lib/driver/testing/cpp/test_node.cc
- M sdk/lib/fdio/bsdsocket.cc
- M sdk/lib/fidl/cpp/fidl_cpp_base_v2.api
- M sdk/lib/fidl/cpp/include/lib/fidl/cpp/wire_natural_conversions.h
- M sdk/lib/fidl/cpp/wire/fidl_cpp_wire.api
- M sdk/lib/fidl/cpp/wire/include/lib/fidl/cpp/wire/wire_coding_traits.h
- M sdk/lib/zxio/create.cc
- M sdk/lib/zxio/dgram_cache.cc
- M sdk/lib/zxio/remote.cc
- M sdk/lib/zxio/socket.cc
- M src/bringup/bin/console/console.cc
- M src/bringup/bin/critical-services/main.cc
- M src/bringup/bin/ptysvc/pty-client.cc
- M src/bringup/bin/ptysvc/pty-server.cc
- M src/cobalt/bin/system-metrics/cpu_stats_fetcher_impl.cc
- M src/connectivity/bluetooth/hci/transport/uart/bt_transport_uart.cc
- M src/connectivity/ethernet/drivers/third_party/igc/igc_driver.cc
- M src/connectivity/network/drivers/network-device/device/device_port.cc
- M src/connectivity/network/drivers/network-device/device/mac_addr_shim.cc
- M src/connectivity/network/drivers/network-device/device/network_device_shim.cc
- M src/connectivity/network/drivers/network-device/device/rx_queue.cc
- M src/connectivity/network/drivers/network-device/device/session.cc
- M src/connectivity/network/tun/network-tun/buffer.cc
- M src/connectivity/network/tun/network-tun/device_adapter.cc
- M src/connectivity/wlan/drivers/wlanphy/device.cc
- M src/connectivity/wlan/drivers/wlansoftmac/softmac_ifc_bridge.cc
- M src/developer/adb/bin/adb/adb.cc
- M src/developer/adb/third_party/adb-file-sync/file_sync_service.cc
- M src/devices/acpi/bin/acpidump/acpidump.cc
- M src/devices/acpi/drivers/acpi-battery/acpi_battery.cc
- M src/devices/acpi/drivers/intel-thermal/intel_thermal.cc
- M src/devices/bin/driver_loader/loader.cc
- M src/devices/bin/driver_manager/composite_node_spec/composite_node_spec_manager.cc
- M src/devices/bin/driver_manager/driver_host.cc
- M src/devices/bin/driver_manager/driver_host_runner.cc
- M src/devices/bin/driver_manager/node.cc
- M src/devices/bin/driver_manager/runner.cc
- M src/devices/block/drivers/core/block-device.cc
- M src/devices/block/drivers/sdmmc/sdio-function-device.cc
- M src/devices/block/drivers/sdmmc/sdmmc-device.cc
- M src/devices/block/drivers/ufs/ufs.cc
- M src/devices/block/drivers/zxcrypt/device-manager.cc
- M src/devices/board/lib/acpi/fidl.cc
- M src/devices/bus/drivers/platform/platform-bus.cc
- M src/devices/i2c/bin/i2cutil.cc
- M src/devices/i2c/drivers/i2c/i2c.cc
- M src/devices/i2c/drivers/intel-i2c/intel-i2c-controller.cc
- M src/devices/i2c/drivers/intel-i2c/intel-i2c-subordinate.cc
- M src/devices/i2c/lib/device-protocol-i2c-channel/include/lib/device-protocol/i2c-channel.h
- M src/devices/i2c/testing/mock-i2c/include/lib/mock-i2c/mock-i2c-gtest.h
- M src/devices/lib/acpi/object.h
- M src/devices/pci/lib/device-protocol-pci/pci.cc
- M src/devices/power/drivers/fusb302/fusb302-fifos.cc
- M src/devices/pwm/drivers/pwm/pwm.cc
- M src/devices/radar/lib/vmo-manager/vmo-manager.cc
- M src/devices/serial/bin/serialutil/serialutil.cc
- M src/devices/serial/drivers/ftdi/ftdi-i2c.cc
- M src/devices/serial/drivers/ftdi/ftdi.cc
- M src/devices/serial/drivers/usb-cdc-acm/usb-cdc-acm.cc
- M src/devices/serial/drivers/virtio-console/console.cc
- M src/devices/spi/drivers/spi/spi-child.cc
- M src/devices/spmi/lib/hwreg-spmi/include/hwreg/spmi.h
- M src/devices/tpm/drivers/tpm/registers.h
- M src/devices/tpm/drivers/tpm/tpm.cc
- M src/devices/usb/drivers/usb-peripheral/usb-peripheral.cc
- M src/graphics/display/drivers/amlogic-display/display-engine-test.cc
- M src/graphics/display/drivers/amlogic-display/display-engine.cc
- M src/graphics/display/drivers/coordinator/client.cc
- M src/graphics/display/drivers/coordinator/integration-test.cc
- M src/graphics/display/drivers/fake/fake-display-test.cc
- M src/graphics/display/drivers/fake/image-info.cc
- M src/graphics/display/drivers/framebuffer-intel-display/framebuffer-intel-display.cc
- M src/graphics/display/drivers/intel-display/intel-display-driver.cc
- M src/graphics/display/drivers/intel-display/intel-display.cc
- M src/graphics/display/drivers/intel-display/testing/fake-framebuffer-test.cc
- M src/graphics/display/drivers/virtio-gpu-display/gpu-control-server.cc
- M src/graphics/display/drivers/virtio-gpu-display/imported-images.cc
- M src/graphics/display/testing/client-utils/display.cc
- M src/graphics/drivers/msd-virtio-gpu/src/virtio_gpu_control.cc
- M src/graphics/lib/magma/src/libmagma/enumerator.cc
- M src/graphics/magma/lib/magma_service/sys_driver/primary_fidl_server.cc
- M src/graphics/tests/goldfish_test/goldfish_test.cc
- M src/media/audio/audio_core/effects_stage_v2.cc
- M src/media/audio/audio_core/pipeline_config.cc
- M src/media/audio/drivers/usb-audio/usb-midi-sink.cc
- M src/media/audio/lib/simple-codec/simple-codec-client.cc
- M src/media/audio/tools/audio-driver-ctl/audio.cc
- M src/security/lib/tee/tee-client-api/tee-client-api.cc
- M src/storage/fvm/fvm_check.cc
- M src/storage/lib/vfs/cpp/connection/remote_file_connection.cc
- M src/storage/lib/vfs/cpp/connection/stream_file_connection.cc
- M src/ui/input/bin/hid/main.cc
- M src/ui/input/drivers/buttons/buttons-device.cc
- M src/ui/input/drivers/ctaphid/ctaphid.cc
- M src/ui/input/drivers/hid-input-report/input-report.cc
- M src/ui/input/drivers/hid/hid-instance.cc
- M src/ui/input/drivers/hid/hid.cc
- M src/ui/input/drivers/i2c-hid/i2c-hid.cc
- M src/ui/input/drivers/usb-hid/usb-hid.cc
- M src/ui/input/drivers/virtio/input_kbd.cc
- M src/ui/input/drivers/virtio/input_mouse.cc
- M src/ui/input/drivers/virtio/input_touch.cc
- M src/ui/input/lib/hid-input-report/sensor.cc
- M src/ui/scenic/lib/display/display_manager.cc
- M src/ui/tools/print-input-report/devices.cc
- M tools/configc/goldens/config.cc.elf.golden
- M tools/lib/config_client/templates/vmo_parse_helpers.cc.hbs
- M zircon/system/ulib/hwreg-i2c/include/hwreg/i2c.h
- M zircon/system/ulib/spi/spi.cc
- M zircon/system/ulib/sysmem-version/sysmem-version.cc
- M zircon/system/ulib/trace-provider/provider_impl.cc
- M zircon/third_party/dev/ethernet/e1000/fuchsia.cc
Change size: L
Delta: 116 files changed, 315 insertions(+), 316 deletions(-)
Related details
Attention is currently required from:
- Owners Override
Submit Requirements:
API-Review
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/7e2eb82183ef6b1552d81aa2e724cadfa993f056-HTML%40fuchsia-review.googlesource.com.
'Victor Costan (Gerrit)' via owners-override
Jul 7, 2025, 5:49:15 PM7/7/25
to Owners Override, GI Try Builder, fuchsia-c...@fuchsia-infra.iam.gserviceaccount.com, CQ Bot
Attention needed from Owners Override
Victor Costan added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 8:
Victor Costan . resolved
This is a fairly straightforward rename. PTAL?
Related details
Attention is currently required from:
- Owners Override
Submit Requirements:
API-Review
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/7e2eb82183ef6b1552d81aa2e724cadfa993f056-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'Adam Barth (Gerrit)' via owners-override
Jul 7, 2025, 5:51:51 PM7/7/25
to Victor Costan, Owners Override, GI Try Builder, fuchsia-c...@fuchsia-infra.iam.gserviceaccount.com, CQ Bot
Attention needed from Owners Override and Victor Costan
Adam Barth voted Owners-Override+1![]( "Open in Gerrit")
Attention is currently required from:
- Owners Override
- Victor Costan
Submit Requirements:
API-Review
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/20d1235ac64beaa6c574ed34a74db6063686b632-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'Adam Barth (Gerrit)' via owners-override
Jul 7, 2025, 5:52:06 PM7/7/25
to Victor Costan, Owners Override, GI Try Builder, fuchsia-c...@fuchsia-infra.iam.gserviceaccount.com, CQ Bot
Attention needed from Owners Override and Victor Costan
Adam Barth voted API-Review+1![]( "Open in Gerrit")
| API-Review | +1 |
Related details
Attention is currently required from:
- Owners Override
- Victor Costan
Submit Requirements:
API-Review
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/00f11925aa6d3062e1a826f2c718d7675a65517b-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'Victor Costan (Gerrit)' via owners-override
Jul 7, 2025, 8:17:00 PM7/7/25
to Yilong Li, Adam Barth, Owners Override, GI Try Builder, fuchsia-c...@fuchsia-infra.iam.gserviceaccount.com, CQ Bot
Attention needed from Owners Override and Yilong Li
Victor Costan voted and added 1 comment![]( "Open in Gerrit")
Votes added by Victor Costan
| Commit-Queue | +1 |
| Fuchsia-Auto-Submit | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Owners Override
- Yilong Li
Submit Requirements:
API-Review
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/d490a6081ec003d57e6fa84b038c170def347421-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'Yilong Li (Gerrit)' via owners-override
Jul 7, 2025, 9:52:56 PM7/7/25
to Victor Costan, Yilong Li, Adam Barth, Owners Override, GI Try Builder, fuchsia-c...@fuchsia-infra.iam.gserviceaccount.com, CQ Bot
Attention needed from Owners Override and Victor Costan
Yilong Li voted Code-Review+2![]( "Open in Gerrit")
Attention is currently required from:
- Owners Override
- Victor Costan
Submit Requirements:
API-Review
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/9598d35d96047a86d74abf34f10f5866e41b4e84-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'CQ Bot (Gerrit)' via owners-override
Jul 7, 2025, 9:54:33 PM7/7/25
to Victor Costan, Ian McKellar, Yilong Li, Adam Barth, Owners Override, GI Try Builder, fuchsia-c...@fuchsia-infra.iam.gserviceaccount.com
CQ Bot submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[fidl] Replace calls to VectorView::count() with size().
This CL was generated by
1. Running gemini-cli with the prompt documented in the attached bug.
2. Reviewing the result and fixing a few errors.
3. Running fx format-code
Bug: 430060081
Change-Id: Idd9d91d9b56f12b79d9a34fe4123fa18c984d379
Owners-Override: Adam Barth <aba...@google.com>
Commit-Queue: Victor Costan <cos...@google.com>
Fuchsia-Auto-Submit: Victor Costan <cos...@google.com>
Reviewed-by: Yilong Li <li...@google.com>
API-Review: Adam Barth <aba...@google.com>
Branch: refs/heads/main
Submit Requirements:
API-Review: +1 by Adam Barth
Code-Review: +2 by Yilong Li
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/8cf6823dda14369b237843425d10a9581120d5b9-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'GI Roller (Gerrit)' via owners-override
Jul 7, 2025, 9:56:53 PM7/7/25
to Victor Costan, CQ Bot, Ian McKellar, Yilong Li, Adam Barth, Owners Override, GI Try Builder, fuchsia-c...@fuchsia-infra.iam.gserviceaccount.com
Message from GI Roller![]( "Open in Gerrit")
Change has been successfully rolled: https://turquoise-internal-review.googlesource.com/1013461
Related details
Attention set is empty
Submit Requirements:
API-Review
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/83ad74bc0b79ffea60ffcbe039eafe54d5cd4059-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'Victor Costan (Gerrit)' via owners-override
Jul 8, 2025, 1:42:31 PM7/8/25
to Owners Override, Ian McKellar
Attention needed from Owners Override
Victor Costan has uploaded the change for review![]( "Open in Gerrit")
Victor Costan would like Owners Override to review this change.
Commit message
[fidl] Replace calls to VectorView::count() with size().
This CL was generated by
1. Running gemini-cli with the prompt documented in the attached bug.
2. Reviewing the result and fixing a few errors.
3. Running fx format-code
This CL tackles all the instances missed by
Idd9d91d9b56f12b79d9a34fe4123fa18c984d379. This CL follows the same
process, but uses a build that includes the kitchen_sink build bundle.
Bug: 430060081
Change-Id: I87be0f40e844d8ab1ae22a2a3145b9214e8d27c1
Change diff
Change information
Files:
- M examples/drivers/transport/driver/v2/tests/parent-driver-test.cc
- M examples/drivers/transport/zircon/v2/child-driver.cc
- M examples/fidl/cpp/domain_objects/advanced.cc
- M examples/fidl/new/key_value_store/support_exports/cpp_wire/client/main.cc
- M sdk/lib/fidl/cpp/tests/conversion/conversion_test.cc
- M sdk/lib/fidl/cpp/tests/integration/wire_interop_tests.cc
- M sdk/lib/fidl_driver/tests/transport/wire_one_way_test.cc
- M sdk/lib/input_report_reader/reader_unittest.cc
- M sdk/lib/zxio/tests/file-test.cc
- M src/bringup/bin/console/console-test.cc
- M src/bringup/bin/critical-services/oom_watcher-test.cc
- M src/bringup/bin/ptysvc/pty-tests.cc
- M src/connectivity/bluetooth/hci/transport/uart/bt_transport_uart_unittest.cc
- M src/connectivity/ethernet/drivers/third_party/igc/test/igc_interface_tests.cc
- M src/connectivity/lib/network-device/cpp/network_device_client_test.cc
- M src/connectivity/network/drivers/network-device/device/network_device-test.cc
- M src/connectivity/network/drivers/network-device/device/test_util.cc
- M src/connectivity/network/drivers/network-device/device/test_util.h
- M src/connectivity/network/tun/network-tun/network_tun_unittest.cc
- M src/connectivity/wlan/drivers/lib/components/cpp/network_device.cc
- M src/connectivity/wlan/drivers/lib/components/cpp/test/network_device_test.cc
- M src/connectivity/wlan/drivers/third_party/broadcom/brcmfmac/cfg80211.cc
- M src/connectivity/wlan/drivers/third_party/broadcom/brcmfmac/device.cc
- M src/connectivity/wlan/drivers/third_party/broadcom/brcmfmac/sim/test/auth_test.cc
- M src/connectivity/wlan/drivers/third_party/broadcom/brcmfmac/sim/test/connect_test.cc
- M src/connectivity/wlan/drivers/third_party/broadcom/brcmfmac/sim/test/passive_scan_test.cc
- M src/connectivity/wlan/drivers/third_party/broadcom/brcmfmac/sim/test/phy_mac_roles_test.cc
- M src/connectivity/wlan/drivers/third_party/broadcom/brcmfmac/sim/test/set_keys_test.cc
- M src/connectivity/wlan/testing/wlantap-driver/utils.cc
- M src/connectivity/wlan/testing/wlantap-driver/wlantap-phy.cc
- M src/developer/adb/bin/adb-file-sync/adb-file-sync-test.cc
- M src/developer/adb/drivers/usb-adb-function/adb-function-test.cc
- M src/devices/bin/driver_manager/tests/bind_manager_test_base.cc
- M src/devices/bin/driver_manager/tests/driver_runner_test.cc
- M src/devices/block/bin/sdio/sdio-test.cc
- M src/devices/block/drivers/aml-sdmmc/aml-sdmmc.cc
- M src/devices/board/lib/acpi/fidl-test.cc
- M src/devices/bus/drivers/platform/test/test/spi.cc
- M src/devices/i2c/drivers/aml-i2c/aml-i2c-test.cc
- M src/devices/i2c/drivers/aml-i2c/aml-i2c.cc
- M src/devices/i2c/drivers/i2c/i2c-transaction-test.cc
- M src/devices/i2c/lib/device-protocol-i2c-channel/test.cc
- M src/devices/i2c/testing/fake-i2c/include/lib/fake-i2c/fake-i2c.h
- M src/devices/i2c/testing/mock-i2c/include/lib/mock-i2c/mock-i2c.h
- M src/devices/lib/acpi/test/client-test.cc
- M src/devices/lib/fidl-metadata/test/i2c-test.cc
- M src/devices/lib/fidl-metadata/test/spi-test.cc
- M src/devices/lib/fidl-metadata/test/tee-test.cc
- M src/devices/light-sensor/drivers/ams-light/tcs3400-test.cc
- M src/devices/light-sensor/drivers/ams-light/tcs3400.cc
- M src/devices/power/drivers/aml-meson-power/aml-power-test.cc
- M src/devices/power/drivers/aml-pwm-regulator/aml-pwm-regulator-test.cc
- M src/devices/pwm/drivers/aml-pwm-init/aml-pwm-init-test.cc
- M src/devices/radar/bin/radarutil/radarutil-test.cc
- M src/devices/radar/tests/radar-integration-test/radar-integration-test.cc
- M src/devices/serial/drivers/aml-uart/aml-uart.cc
- M src/devices/serial/drivers/aml-uart/tests/aml-uart-test.cc
- M src/devices/serial/drivers/ftdi/test/ftdi-i2c-test.cc
- M src/devices/serial/drivers/serial/tests/serial-test.cc
- M src/devices/spi/drivers/aml-spi/aml-spi.cc
- M src/devices/spi/drivers/aml-spi/aml-spi.h
- M src/devices/spi/drivers/aml-spi/tests/aml-spi-bti-test.cc
- M src/devices/spi/drivers/aml-spi/tests/aml-spi-test.cc
- M src/devices/spi/drivers/spi/spi-test.cc
- M src/devices/suspend/drivers/generic-suspend/tests/generic-suspend-test.cc
- M src/devices/tee/drivers/optee/optee-client.cc
- M src/devices/tee/drivers/optee/optee-message.cc
- M src/devices/tee/drivers/optee/test/optee-message-test.cc
- M src/devices/tests/driver-runtime/child-driver.cc
- M src/devices/tests/driver-runtime/parent-driver.cc
- M src/devices/tests/driver-runtime/test.cc
- M src/devices/tests/driver-transport/parent-driver.cc
- M src/devices/tests/driver-transport/test.cc
- M src/devices/tests/isolateddevmgr/test-driver.cc
- M src/devices/tests/isolateddevmgr/test.cc
- M src/devices/thermal/drivers/aml-thermal-s905d2g-legacy/aml-thermal-test.cc
- M src/devices/tpm/drivers/cr50-spi/cr50-spi-test.cc
- M src/devices/tpm/drivers/cr50-spi/cr50-spi.cc
- M src/devices/tpm/drivers/tpm-lpc/tpm-lpc.cc
- M src/devices/tpm/drivers/tpm-lpc/unit-tests.cc
- M src/devices/tpm/drivers/tpm/tpm-test.cc
- M src/devices/usb/drivers/usb-bus/tests/usb-device.cc
- M src/graphics/drivers/msd-arm-mali/tests/conformance/vendor_helper_arm.cc
- M src/graphics/drivers/msd-arm-mali/tests/integration/test_icd_list.cc
- M src/graphics/drivers/msd-intel-gen/tests/conformance/vendor_helper_intel.cc
- M src/graphics/drivers/msd-intel-gen/tests/integration/test_icd_list.cc
- M src/graphics/drivers/msd-vsi-vip/tests/integration/test_vsi_icd.cc
- M src/lib/fidl/llcpp/tests/conformance/manual_conformance_test.cc
- M src/lib/fidl/llcpp/tests/integration/handle_raii_test.cc
- M src/lib/fidl/llcpp/tests/integration/protocol_test.cc
- M src/lib/fidl/llcpp/tests/wire_types/llcpp_types_tests.cc
- M src/lib/fidl/llcpp/tests/wire_types/memory_test.cc
- M src/lib/fidl/llcpp/tests/wire_types/table_test.cc
- M src/lib/fidl/llcpp/tests/wire_types/vector_view_test.cc
- M src/media/audio/audio_core/effects_stage_v2_unittest.cc
- M src/media/audio/drivers/codecs/alc5663/tests/fake_i2c.h
- M src/media/audio/drivers/codecs/da7219/unit-tests.cc
- M src/media/audio/drivers/intel-hda/controller/intel-dsp-stream-test.cc
- M src/media/audio/drivers/intel-hda/test/intel_hda_test.cc
- M src/media/audio/drivers/usb-audio/tests/usb-audio-test.cc
- M src/media/audio/effects/test_effects/test_effects_v2.cc
- M src/media/audio/examples/tones/midi_keyboard.cc
- M src/media/audio/lib/effects_loader/effects_loader_v2_unittest.cc
- M src/media/audio/lib/simple-audio-stream/tests/sas-test.cc
- M src/media/audio/services/mixer/fidl/custom_node.cc
- M src/media/audio/services/mixer/fidl/graph_server.cc
- M src/media/audio/services/mixer/fidl/graph_server_unittest.cc
- M src/media/audio/services/mixer/mix/custom_stage.cc
- M src/performance/memory/sampler/instrumentation/tests/recorder_tests.cc
- M src/tests/fidl/dynsuite/server_suite/runners/cpp_wire/main.cc
- M src/ui/backlight/drivers/vim3-pwm-backlight/vim3-pwm-backlight-test.cc
- M src/ui/input/drivers/adc-buttons/adc-buttons-test.cc
- M src/ui/input/drivers/buttons/buttons-test.cc
- M src/ui/input/drivers/ctaphid/test.cc
- M src/ui/input/drivers/focaltech/ft_device_test.cc
- M src/ui/input/drivers/goldfish_sensor/tests/input_device_test.cc
- M src/ui/input/drivers/goodix/gt92xx-test.cc
- M src/ui/input/drivers/gt6853/gt6853-test.cc
- M src/ui/input/drivers/hid-input-report/test.cc
- M src/ui/input/drivers/hid/hid-test.cc
- M src/ui/input/drivers/hidctl/hidctl.cc
- M src/ui/input/drivers/i2c-hid/i2c-hid-test.cc
- M src/ui/input/drivers/pc-ps2/unit-tests.cc
- M src/ui/input/drivers/usb-hid/usb-hid-test.cc
- M src/ui/input/drivers/virtio/input_test.cc
- M src/ui/input/lib/hid-input-report/test/consumer-control-test.cc
- M src/ui/input/lib/hid-input-report/test/keyboard-test.cc
- M src/ui/input/lib/hid-input-report/test/mouse-test.cc
- M src/ui/input/lib/hid-input-report/test/sensor-test.cc
- M src/ui/input/lib/hid-input-report/test/touch-test.cc
- M src/ui/input/tests/hid/hid-driver.cc
- M src/ui/light/drivers/aml-light/aml-light-test.cc
- M tools/fidl/gidl/goldens/llcpp_golden.cc.golden
- M tools/fidl/gidl/lib/llcpp/allocator_builder.go
- M tools/fidl/gidl/lib/llcpp/equality_builder.go
- M zircon/system/ulib/fdio-caller/test/fdio.cc
- M zircon/system/ulib/mock-boot-arguments/server.cc
- M zircon/system/ulib/runtests-utils/log-exporter.cc
- M zircon/third_party/dev/ethernet/e1000/test/e1000_tests.cc
Change size: XL
Delta: 139 files changed, 735 insertions(+), 764 deletions(-)
Related details
Attention is currently required from:
- Owners Override
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/f28f7253971e2c03d71e123184857c0c666f77b2-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'Victor Costan (Gerrit)' via owners-override
Jul 8, 2025, 1:42:35 PM7/8/25
to Owners Override, Ian McKellar, GI Try Builder, CQ Bot
Attention needed from Owners Override
Victor Costan added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Victor Costan . resolved
Sorry for all the missed occurrences on the first round!
This is still a straightforward rename. PTAL?
Related details
Attention is currently required from:
- Owners Override
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/f28f7253971e2c03d71e123184857c0c666f77b2-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'Adam Barth (Gerrit)' via owners-override
Jul 8, 2025, 1:59:46 PM7/8/25
to Victor Costan, Owners Override, Ian McKellar, GI Try Builder, CQ Bot
Attention needed from Owners Override and Victor Costan
Adam Barth voted![]( "Open in Gerrit")
Attention is currently required from:
- Owners Override
- Victor Costan
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/b5d5ee0956926ca959f01ee17ff9323052376155-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'Victor Costan (Gerrit)' via owners-override
Jul 8, 2025, 2:17:18 PM7/8/25
to Adam Barth, Owners Override, Ian McKellar, GI Try Builder, CQ Bot
Attention needed from Owners Override
Victor Costan voted and added 1 comment![]( "Open in Gerrit")
Votes added by Victor Costan
| Commit-Queue | +2 |
| Fuchsia-Auto-Submit | +1 |
1 comment
Patchset-level comments
Victor Costan . resolved
abarth@: Thank you very much for the quick review!
Related details
Attention is currently required from:
- Owners Override
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/089c38988364194bf0f656d16412dcb83467bbee-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'CQ Bot (Gerrit)' via owners-override
Jul 8, 2025, 2:18:45 PM7/8/25
to Victor Costan, Adam Barth, Owners Override, Ian McKellar, GI Try Builder
CQ Bot submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[fidl] Replace calls to VectorView::count() with size().
This CL was generated by
1. Running gemini-cli with the prompt documented in the attached bug.
2. Reviewing the result and fixing a few errors.
3. Running fx format-code
This CL tackles all the instances missed by
Idd9d91d9b56f12b79d9a34fe4123fa18c984d379. This CL follows the same
process, but uses a build that includes the kitchen_sink build bundle.
Bug: 430060081
Change-Id: I87be0f40e844d8ab1ae22a2a3145b9214e8d27c1
Fuchsia-Auto-Submit: Victor Costan <cos...@google.com>
Reviewed-by: Adam Barth <aba...@google.com>
Commit-Queue: Victor Costan <cos...@google.com>
Owners-Override: Adam Barth <aba...@google.com>
Branch: refs/heads/main
Submit Requirements:
Code-Review: +2 by Adam Barth
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/7d47de9a8f9e6a4716d97391f28430063330d244-HTML%40fuchsia-review.googlesource.com.To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'GI Roller (Gerrit)' via owners-override
Jul 8, 2025, 2:21:31 PM7/8/25
to Victor Costan, CQ Bot, Adam Barth, Owners Override, Ian McKellar, GI Try Builder
Message from GI Roller![]( "Open in Gerrit")
Change has been successfully rolled: https://turquoise-internal-review.googlesource.com/1013624
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/dc2d27fbfd39232ba4ae50d6959318556c0d24b0-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'Victor Costan (Gerrit)' via owners-override
Jul 11, 2025, 12:10:53 PM7/11/25
to Owners Override
Attention needed from Owners Override
Victor Costan has uploaded the change for review![]( "Open in Gerrit")
Victor Costan would like Owners Override to review this change.
Commit message
[fidl] Replace calls to VectorView::count() with size().
This CL was generated by
1. Running gemini-cli with the prompt documented in the attached bug.
2. Reviewing the result and fixing a few errors.
3. Running fx format-code
This CL tackles all the instances missed by
I87be0f40e844d8ab1ae22a2a3145b9214e8d27c1. This CL follows the same
process, but uses more bundles, and also uses a bringup_with_tests.x64
build.
Bug: 430060081
Change-Id: I446ad8824574a7c32c5994a84ff96bbd371728b0
Change diff
Change information
Files:
- M src/connectivity/openthread/drivers/ot-radio/ot_radio.cc
- M src/connectivity/openthread/drivers/ot-radio/ot_radio_bootloader.cc
- M src/connectivity/openthread/tests/fake-drivers/fake-ot-radio/fake-ot-radio.cc
- M src/connectivity/openthread/third_party/openthread/spinel-framer/spinel_framer.cc
- M src/devices/board/drivers/x86/test/main.cc
- M src/devices/i2c/drivers/i2c/i2c-child-test.cc
- M src/media/audio/drivers/aml-g12-tdm/test/stream-test.cc
- M src/security/lib/fuchsia-tcti/src/fuchsia-tcti-agent.cc
- M src/security/lib/fuchsia-tcti/src/fuchsia-tcti-device.cc
- M src/sysmem/tests/sysmem/sysmem_tests.cc
- M src/tee/tee-client-api-experimental/tee-client-api-experimental.cc
- M src/tests/benchmarks/ipc/comparison/batch_case.cc
- M zircon/system/utest/svchost/main.cc
Change size: M
Delta: 13 files changed, 29 insertions(+), 29 deletions(-)
Related details
Attention is currently required from:
- Owners Override
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/814e175bf13c07422ac4060830597a5b00bc5fd7-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'Victor Costan (Gerrit)' via owners-override
Jul 11, 2025, 12:10:59 PM7/11/25
to Owners Override, GI Try Builder, CQ Bot
Attention needed from Owners Override
Victor Costan added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 5:
Victor Costan . resolved
PTAL? I really hope this is the last round of renames, the bots are now green on the dependent CL that deprecates the old methods.
Related details
Attention is currently required from:
- Owners Override
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/814e175bf13c07422ac4060830597a5b00bc5fd7-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'Victor Costan (Gerrit)' via owners-override
Jul 11, 2025, 12:11:22 PM7/11/25
to Owners Override, GI Try Builder, CQ Bot
Attention needed from Owners Override
Victor Costan voted![]( "Open in Gerrit")
| Commit-Queue | +1 |
| Fuchsia-Auto-Submit | +1 |
Related details
Attention is currently required from:
- Owners Override
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/31575c8aa21f14fd5220f47fd48779dbd06c1ed8-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'James Robinson (Gerrit)' via owners-override
Jul 11, 2025, 3:30:57 PM7/11/25
to Victor Costan, Owners Override, GI Try Builder, CQ Bot
Attention needed from Owners Override and Victor Costan
James Robinson voted![]( "Open in Gerrit")
Attention is currently required from:
- Owners Override
- Victor Costan
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/1cc83fefa0ba6654213bd9bd18250ca3777d1fd6-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'CQ Bot (Gerrit)' via owners-override
Jul 11, 2025, 3:34:08 PM7/11/25
to Victor Costan, James Robinson, Owners Override, GI Try Builder
CQ Bot submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[fidl] Replace calls to VectorView::count() with size().
This CL was generated by
1. Running gemini-cli with the prompt documented in the attached bug.
2. Reviewing the result and fixing a few errors.
3. Running fx format-code
This CL tackles all the instances missed by
I87be0f40e844d8ab1ae22a2a3145b9214e8d27c1. This CL follows the same
process, but uses more bundles, and also uses a bringup_with_tests.x64
build.
Bug: 430060081
Change-Id: I446ad8824574a7c32c5994a84ff96bbd371728b0
Commit-Queue: Victor Costan <cos...@google.com>
Fuchsia-Auto-Submit: Victor Costan <cos...@google.com>
Reviewed-by: James Robinson <jam...@google.com>
Owners-Override: James Robinson <jam...@google.com>
Files:
- M src/connectivity/openthread/drivers/ot-radio/ot_radio.cc
- M src/connectivity/openthread/drivers/ot-radio/ot_radio_bootloader.cc
- M src/connectivity/openthread/tests/fake-drivers/fake-ot-radio/fake-ot-radio.cc
- M src/connectivity/openthread/third_party/openthread/spinel-framer/spinel_framer.cc
- M src/devices/board/drivers/x86/test/main.cc
- M src/devices/i2c/drivers/i2c/i2c-child-test.cc
- M src/devices/i2c/lib/i2c-channel/i2c-channel-test.cc
- M src/devices/i2c/lib/i2c-channel/i2c-channel.cc
- M src/media/audio/drivers/aml-g12-tdm/test/stream-test.cc
- M src/security/lib/fuchsia-tcti/src/fuchsia-tcti-agent.cc
- M src/security/lib/fuchsia-tcti/src/fuchsia-tcti-device.cc
- M src/sysmem/tests/sysmem/sysmem_tests.cc
- M src/tee/tee-client-api-experimental/tee-client-api-experimental.cc
- M src/tests/benchmarks/ipc/comparison/batch_case.cc
- M zircon/system/utest/svchost/main.cc
Change size: M
Delta: 15 files changed, 37 insertions(+), 37 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +2 by James Robinson
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/c720309b155cc31d2ad372d15548bc6a3bc89fa2-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'GI Roller (Gerrit)' via owners-override
Jul 11, 2025, 3:42:04 PM7/11/25
to Victor Costan, CQ Bot, James Robinson, Owners Override, GI Try Builder
Message from GI Roller![]( "Open in Gerrit")
Change has been successfully rolled: https://turquoise-internal-review.googlesource.com/1015511
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/b6dd53735ccbf94476aea1a6d7229f6750ff2391-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'Victor Costan (Gerrit)' via owners-override
Jul 11, 2025, 4:34:29 PM7/11/25
to CQ Bot, GI Roller, James Robinson, Owners Override, GI Try Builder
Victor Costan added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 9 (Latest):
Victor Costan . resolved
jamesr@: Thank you very much for the quick review!
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/f31bab7cc566a27b62e47d3de696e87f6907758f-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
Reply all
Reply to author
Forward
0 new messages