David Turner would like Owners Override, Aaron Wood and Jay Zhuang to review this change.
[roll] Roll gn-prebuilt packages to git_revision:5d0a4153b0bcc86c5a23310d5b648a587be3c56d
The gn-prebuilt-roller due to another minor formatting change
(here it is removal of duplicate lines).
This CL rolls the new upstream GN manually, and applies formatting
with the following commands:
```
fx bazel2gn
git rebase --exec 'scripts/fx format-code -- "*.gn" "*.gni"'
```
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Commit-Queue | +1 |
Another GN upstream change broke our gn-roller, this time it is removing duplicate lines in label lists.
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Code-Review | +2 |
| Owners-Override | +1 |
Another GN upstream change broke our gn-roller, this time it is removing duplicate lines in label lists.
Very annoying - we need to change something so that these changes do not block integration. Couple of options:
1. We disable requiring formatting for GN, roll, then reformat piecewise after the roll. Re-enable our formatting check for GN when we're done.
2. Have GN guard new formatting errors with a flag. Roll in a new GN with the flag disabled, format, then enable the flag once we've caught everything.
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Commit-Queue | +2 |
James RobinsonAnother GN upstream change broke our gn-roller, this time it is removing duplicate lines in label lists.
Very annoying - we need to change something so that these changes do not block integration. Couple of options:
1. We disable requiring formatting for GN, roll, then reformat piecewise after the roll. Re-enable our formatting check for GN when we're done.
2. Have GN guard new formatting errors with a flag. Roll in a new GN with the flag disabled, format, then enable the flag once we've caught everything.
Option 1 seems the easiest to me, as it could be applied to any other formatting change (e.g. rust)
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
[roll] Roll gn-prebuilt packages to git_revision:5d0a4153b0bcc86c5a23310d5b648a587be3c56d
The gn-prebuilt-roller due to another minor formatting change
(here it is removal of duplicate lines).
This CL rolls the new upstream GN manually, and applies formatting
with the following commands:
```
fx bazel2gn
git rebase --exec 'scripts/fx format-code -- "*.gn" "*.gni"'
```
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Change has been successfully rolled: https://turquoise-internal-review.googlesource.com/1043453
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |