[XL] Change in fuchsia/fuchsia[main]: [mesa] Migrate to new layout [2/4]

['Erick Tryzelaar (Gerrit)' via owners-override]

Attention needed from Adam Barth and Paul Kirth

Erick Tryzelaar voted

Commit-Queue	+2
Fuchsia-Auto-Submit	+1

Open in Gerrit

Related details

Attention is currently required from:

• Adam Barth
• Paul Kirth

Submit Requirements:

• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: fuchsia

Gerrit-Branch: main

Gerrit-Change-Id: I222e7faf1a514e18d6306f940b49fedfa6257e45

Gerrit-Change-Number: 1333169

Gerrit-PatchSet: 36

Gerrit-Owner: Erick Tryzelaar <etryz...@google.com>

Gerrit-Reviewer: Aaron Wood <aaro...@google.com>

Gerrit-Reviewer: Adam Barth <aba...@google.com>

Gerrit-Reviewer: Craig Stout <cst...@google.com>

Gerrit-Reviewer: Erick Tryzelaar <etryz...@google.com>

Gerrit-Reviewer: Jerry Belton <jce...@google.com>

Gerrit-Reviewer: Oliver Newman <oliver...@google.com>

Gerrit-Reviewer: Paul Kirth <paul...@google.com>

Gerrit-CC: CQ Bot <fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: GI Try Builder <global-integrat...@fuchsia-infra.iam.gserviceaccount.com>

Gerrit-CC: Owners Override <owners-...@fuchsia.dev>

Gerrit-Attention: Paul Kirth <paul...@google.com>

Gerrit-Attention: Adam Barth <aba...@google.com>

Gerrit-Comment-Date: Tue, 05 Aug 2025 23:03:22 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/9b403e1aa635fe1213a0d9f96d8a9add087267e0-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

['CQ Bot (Gerrit)' via owners-override]

CQ Bot submitted the change with unreviewed changes

Unreviewed changes

20 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: third_party/mesa-migrating/build/src/gallium/drivers/llvmpipe/BUILD.gn
Insertions: 3, Deletions: 3.

The diff is too large to show. Please review the diff.
```
```
The name of the file: third_party/mesa-migrating/build/src/intel/vulkan/BUILD.gn
Insertions: 2, Deletions: 2.

The diff is too large to show. Please review the diff.
```
```
The name of the file: tools/check-licenses/assets/allowlists/Exception/SGI-B-2.0.json
Insertions: 50, Deletions: 49.

The diff is too large to show. Please review the diff.
```
```
The name of the file: build/secondary/third_party/mesa/build/mesa.gni
Insertions: 0, Deletions: 1.

The diff is too large to show. Please review the diff.
```
```
The name of the file: src/virtualization/bin/vmm/device/BUILD.gn
Insertions: 0, Deletions: 1.

The diff is too large to show. Please review the diff.
```
```
The name of the file: build/secondary/third_party/mesa/build/include/BUILD.gn
Insertions: 0, Deletions: 1.

The diff is too large to show. Please review the diff.
```
```
The name of the file: build/cpp/hlcpp_visibility.gni
Insertions: 1, Deletions: 0.

The diff is too large to show. Please review the diff.
```
```
The name of the file: build/secondary/third_party/mesa/BUILD.gn
Insertions: 0, Deletions: 1.

The diff is too large to show. Please review the diff.
```
```
The name of the file: build/secondary/third_party/mesa/build/tests/BUILD.gn
Insertions: 0, Deletions: 1.

The diff is too large to show. Please review the diff.
```
```
The name of the file: build/secondary/third_party/mesa/build/src/intel/vulkan/tests/BUILD.gn
Insertions: 0, Deletions: 1.

The diff is too large to show. Please review the diff.
```
```
The name of the file: build/secondary/third_party/mesa/build/src/gallium/frontends/lavapipe/BUILD.gn
Insertions: 0, Deletions: 1.

The diff is too large to show. Please review the diff.
```
```
The name of the file: tools/check-licenses/assets/allowlists/Exception/BSL-1.0.json
Insertions: 70, Deletions: 69.

The diff is too large to show. Please review the diff.
```
```
The name of the file: third_party/mesa-migrating/build/.gitlab-ci/container/build-skqp_base.gn
Insertions: 0, Deletions: 50.

The diff is too large to show. Please review the diff.
```
```
The name of the file: third_party/mesa-migrating/build/src/util/tests/BUILD.gn
Insertions: 3, Deletions: 1.

The diff is too large to show. Please review the diff.
```
```
The name of the file: src/graphics/lib/magma/src/libmagma/BUILD.gn
Insertions: 1, Deletions: 1.

The diff is too large to show. Please review the diff.
```
```
The name of the file: third_party/mesa-migrating/build/src/intel/compiler/BUILD.gn
Insertions: 1, Deletions: 1.

The diff is too large to show. Please review the diff.
```
```
The name of the file: third_party/mesa-migrating/build/src/util/tests/magma_wait/BUILD.gn
Insertions: 3, Deletions: 1.

The diff is too large to show. Please review the diff.
```
```
The name of the file: build/secondary/third_party/mesa/include
Insertions: 1, Deletions: 0.

The diff is too large to show. Please review the diff.
```
```
The name of the file: third_party/mesa-migrating/build/src/gallium/frontends/lavapipe/BUILD.gn
Insertions: 7, Deletions: 7.

The diff is too large to show. Please review the diff.
```
```
The name of the file: third_party/mesa-migrating/build/src/util/tests/magma_map/BUILD.gn
Insertions: 3, Deletions: 1.

The diff is too large to show. Please review the diff.
```
```
The name of the file: build/secondary/third_party/mesa/build/src/gallium/drivers/llvmpipe/BUILD.gn
Insertions: 0, Deletions: 1.

The diff is too large to show. Please review the diff.
```
```
The name of the file: third_party/mesa-migrating/build/src/gallium/auxiliary/BUILD.gn
Insertions: 19, Deletions: 19.

The diff is too large to show. Please review the diff.
```
```
The name of the file: third_party/mesa-migrating/build/src/util/tests/futex/BUILD.gn
Insertions: 3, Deletions: 1.

The diff is too large to show. Please review the diff.
```
```
The name of the file: src/graphics/lib/lavapipe-vulkan/BUILD.gn
Insertions: 2, Deletions: 2.

The diff is too large to show. Please review the diff.
```
```
The name of the file: third_party/mesa-migrating/build/src/util/tests/inflight_list/BUILD.gn
Insertions: 3, Deletions: 1.

The diff is too large to show. Please review the diff.
```
```
The name of the file: src/graphics/drivers/intel-gen/icd/BUILD.gn
Insertions: 9, Deletions: 14.

The diff is too large to show. Please review the diff.
```
```
The name of the file: third_party/mesa-migrating/include
Insertions: 1, Deletions: 0.

The diff is too large to show. Please review the diff.
```

Change information

Commit message:

[mesa] Migrate to new layout [2/4]

This starts the process to migrate `mesa` to the modern [3p layout].
Unfortunately jiri doesn't always handle moving a git repository into a
subdirectory, such as in this circumstance with us moving
`third_party/mesa` into `third_party/mesa/src`. If there are any files
in a submodule jiri will error out.

So we'll do this migration in 3 patches:

1. First, migrate this repository to `//third_party/mesa-migrating/src`.
   Then move the top-level `BUILD.gn` into
   `//third_party/mesa-migrating`. Finally, move all the remaining build
   files into `//third_party/mesa-migrating/build` (we use `build/`
   since the mesa repository has a `src/` directory, so we have a name
   collision.)

2. Remove the build artifacts from `//third_party/mesa-migrating/src`,
   and update the reference to point at this commit.

3. Migrate all the migrated repositories to their final path. In this
   case `//third_party/mesa`. Doing this in a single patch will allow us
   to send out a PSA with clear instructions, rather than handling
   issues on a patch-by-patch basis.

[3p layout]: https://fuchsia.dev/fuchsia-src/development/source_code/third-party-management#migrating_legacy_third-party_code_to_current_layout

Bug: 42137978

Change-Id: I222e7faf1a514e18d6306f940b49fedfa6257e45

Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1333169

Reviewed-by: Oliver Newman <oliver...@google.com>

Reviewed-by: Jerry Belton <jce...@google.com>

Commit-Queue: Erick Tryzelaar <etryz...@google.com>

Reviewed-by: Aaron Wood <aaro...@google.com>

Fuchsia-Auto-Submit: Erick Tryzelaar <etryz...@google.com>

Reviewed-by: Craig Stout <cst...@google.com>

Files:

• M .gitignore
• M build/config/BUILD.gn
• M build/cpp/hlcpp_visibility.gni
• A build/secondary/third_party/mesa/include
• M manifests/third_party/all
• M src/graphics/drivers/intel-gen/icd/BUILD.gn
• M src/graphics/lib/lavapipe-vulkan/BUILD.gn
• M src/graphics/lib/magma/src/libmagma/BUILD.gn
• M src/virtualization/bin/vmm/device/BUILD.gn
• A third_party/mesa-migrating/BUILD.gn
• M third_party/mesa-migrating/README.fuchsia
• A third_party/mesa-migrating/build/include/BUILD.gn
• A third_party/mesa-migrating/build/mesa.gni
• A third_party/mesa-migrating/build/scripts/gn_script_wrapper.sh
• A third_party/mesa-migrating/build/src/BUILD.gn
• A third_party/mesa-migrating/build/src/c11/BUILD.gn
• A third_party/mesa-migrating/build/src/compiler/BUILD.gn
• A third_party/mesa-migrating/build/src/compiler/glsl/BUILD.gn
• A third_party/mesa-migrating/build/src/compiler/nir/BUILD.gn
• A third_party/mesa-migrating/build/src/compiler/spirv/BUILD.gn
• A third_party/mesa-migrating/build/src/gallium/BUILD.gn
• A third_party/mesa-migrating/build/src/gallium/auxiliary/BUILD.gn
• A third_party/mesa-migrating/build/src/gallium/auxiliary/pipe-loader/BUILD.gn
• A third_party/mesa-migrating/build/src/gallium/drivers/llvmpipe/BUILD.gn
• A third_party/mesa-migrating/build/src/gallium/frontends/lavapipe/BUILD.gn
• A third_party/mesa-migrating/build/src/gallium/winsys/sw/dri/BUILD.gn
• A third_party/mesa-migrating/build/src/gallium/winsys/sw/null/BUILD.gn
• A third_party/mesa-migrating/build/src/gallium/winsys/sw/wrapper/BUILD.gn
• A third_party/mesa-migrating/build/src/intel/BUILD.gn
• A third_party/mesa-migrating/build/src/intel/blorp/BUILD.gn
• A third_party/mesa-migrating/build/src/intel/common/BUILD.gn
• A third_party/mesa-migrating/build/src/intel/compiler/BUILD.gn
• A third_party/mesa-migrating/build/src/intel/dev/BUILD.gn
• A third_party/mesa-migrating/build/src/intel/ds/BUILD.gn
• A third_party/mesa-migrating/build/src/intel/genxml/BUILD.gn
• A third_party/mesa-migrating/build/src/intel/perf/BUILD.gn
• A third_party/mesa-migrating/build/src/intel/vulkan/BUILD.gn
• A third_party/mesa-migrating/build/src/intel/vulkan/tests/BUILD.gn
• A third_party/mesa-migrating/build/src/os/BUILD.gn
• A third_party/mesa-migrating/build/src/util/BUILD.gn
• A third_party/mesa-migrating/build/src/util/format/BUILD.gn
• A third_party/mesa-migrating/build/src/util/magma/BUILD.gn
• A third_party/mesa-migrating/build/src/util/tests/BUILD.gn
• A third_party/mesa-migrating/build/src/util/tests/futex/BUILD.gn
• A third_party/mesa-migrating/build/src/util/tests/inflight_list/BUILD.gn
• A third_party/mesa-migrating/build/src/util/tests/magma_map/BUILD.gn
• A third_party/mesa-migrating/build/src/util/tests/magma_wait/BUILD.gn
• A third_party/mesa-migrating/build/src/vulkan/runtime/BUILD.gn
• A third_party/mesa-migrating/build/src/vulkan/util/BUILD.gn
• A third_party/mesa-migrating/build/src/vulkan/wsi/BUILD.gn
• A third_party/mesa-migrating/build/tests/BUILD.gn
• M third_party/mesa-migrating/include
• M tools/check-licenses/assets/allowlists/Exception/BSL-1.0.json
• M tools/check-licenses/assets/allowlists/Exception/SGI-B-2.0.json
• M tools/check-licenses/assets/readmes/third_party/mesa/README.fuchsia
• M tools/check-licenses/directory/_config.json

Change size: XL

Delta: 56 files changed, 4955 insertions(+), 23 deletions(-)

Branch: refs/heads/main

Submit Requirements:

• Code-Review: +2 by Aaron Wood, +2 by Oliver Newman, +2 by Craig Stout, +2 by Jerry Belton

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: fuchsia

Gerrit-Branch: main

Gerrit-Change-Id: I222e7faf1a514e18d6306f940b49fedfa6257e45

Gerrit-Change-Number: 1333169

Gerrit-PatchSet: 37

Gerrit-Owner: Erick Tryzelaar <etryz...@google.com>

Gerrit-Reviewer: Aaron Wood <aaro...@google.com>

Gerrit-Reviewer: Adam Barth <aba...@google.com>

Gerrit-Reviewer: CQ Bot <fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Craig Stout <cst...@google.com>

Gerrit-Reviewer: Erick Tryzelaar <etryz...@google.com>

Gerrit-Reviewer: Jerry Belton <jce...@google.com>

Gerrit-Reviewer: Oliver Newman <oliver...@google.com>

Gerrit-Reviewer: Paul Kirth <paul...@google.com>

Gerrit-CC: GI Try Builder <global-integrat...@fuchsia-infra.iam.gserviceaccount.com>

Gerrit-CC: Owners Override <owners-...@fuchsia.dev>

--

You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/f420cfeabf9fb5cb1ca0e067306795fa8abc7d93-HTML%40fuchsia-review.googlesource.com.

['GI Roller (Gerrit)' via owners-override]

Message from GI Roller

Change has been successfully rolled: https://turquoise-internal-review.googlesource.com/1026257

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: fuchsia

Gerrit-Branch: main

Gerrit-Change-Id: I222e7faf1a514e18d6306f940b49fedfa6257e45

Gerrit-Change-Number: 1333169

Gerrit-PatchSet: 37

Gerrit-Owner: Erick Tryzelaar <etryz...@google.com>

Gerrit-Reviewer: Aaron Wood <aaro...@google.com>

Gerrit-Reviewer: Adam Barth <aba...@google.com>

Gerrit-Reviewer: CQ Bot <fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Craig Stout <cst...@google.com>

Gerrit-Reviewer: Erick Tryzelaar <etryz...@google.com>

Gerrit-Reviewer: Jerry Belton <jce...@google.com>

Gerrit-Reviewer: Oliver Newman <oliver...@google.com>

Gerrit-Reviewer: Paul Kirth <paul...@google.com>

Gerrit-CC: GI Roller <global-integra...@fuchsia-infra.iam.gserviceaccount.com>

Gerrit-CC: GI Try Builder <global-integrat...@fuchsia-infra.iam.gserviceaccount.com>

Gerrit-CC: Owners Override <owners-...@fuchsia.dev>

Gerrit-Comment-Date: Wed, 06 Aug 2025 00:39:36 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: No

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/c2ae8a23df09cada2631800a8a83af236ab827cf-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.