[L] Change in fuchsia/fuchsia[main]: [go] Run `go fix`
0 views
Skip to first unread message
'Oliver Newman (Gerrit)' via owners-override
Feb 17, 2026, 2:27:03 PM (3 days ago) Feb 17
to Owners Override
Attention needed from Owners Override
Oliver Newman has uploaded the change for review![]( "Open in Gerrit")
Oliver Newman would like Owners Override to review this change.
Commit message
[go] Run `go fix`
... on `//tools` and also `//zircon/tools/zither`, to update code to use
more modern idioms such as `min()` and `max()` built-ins and `any`
instead of `interface{}`.
I couldn't run it on the whole tree because it got caught up on any
files that depended on ninja-provided imports, so stuck to just these
directories for now.
I also made a couple minor manual cleanups of local variables that had
become unnecessary/confusing as a result of the fixes.
Change-Id: I25668b820cc53df4285994d04cb80d746db19f1b
Change diff
Change information
Files:
- M tools/artifactory/cmd/up.go
- M tools/bazel-docgen/doc_generator.go
- M tools/bazel-docgen/markdown_renderer.go
- M tools/botanist/cmd/run.go
- M tools/botanist/pkg.go
- M tools/botanist/targets/device.go
- M tools/botanist/targets/gce.go
- M tools/build/client.go
- M tools/build/modules.go
- M tools/build/ninjago/buildstats/main.go
- M tools/build/ninjago/chrometrace/chrometrace.go
- M tools/build/ninjago/rbetrace/rbetrace_test.go
- M tools/bundle_fetcher/cmd/product_list.go
- M tools/check-licenses/directory/directory_test.go
- M tools/check-licenses/file/file.go
- M tools/check-licenses/file/filedata.go
- M tools/check-licenses/project/config.go
- M tools/check-licenses/project/readme/readme.go
- M tools/check-licenses/project/spdx.go
- M tools/check-licenses/result/checks.go
- M tools/check-licenses/result/result.go
- M tools/debroot/cmd/main.go
- M tools/debug/bloaty/chart.go
- M tools/debug/bloaty/chart_test.go
- M tools/debug/buildidtool/cmd/main.go
- M tools/debug/covargs/api/llvm/llvm.go
- M tools/debug/covargs/report.go
- M tools/debug/debugsyms/cmd/upload.go
- M tools/debug/debugsyms/cmd/worker_test.go
- M tools/debug/symbolize/filter.go
- M tools/debug/symbolize/filter_test.go
- M tools/debug/symbolize/presenter.go
- M tools/fidl/fidlgen_go/codegen/ir.go
- M tools/fidl/fidlmerge/fidlmerge.go
- M tools/fidl/gidl-format/format.go
- M tools/fidl/gidl/backend/cpp/conformance.go
- M tools/fidl/gidl/backend/cpp/equality_builder.go
- M tools/fidl/gidl/backend/golang/common.go
- M tools/fidl/gidl/backend/golang/conformance.go
- M tools/fidl/gidl/backend/golang/equality_builder.go
- M tools/fidl/gidl/backend/hlcpp/conformance.go
- M tools/fidl/gidl/backend/hlcpp/equality_builder.go
- M tools/fidl/gidl/backend/llcpp/conformance.go
- M tools/fidl/gidl/backend/python/conformance.go
- M tools/fidl/gidl/backend/python/equality_builder.go
- M tools/fidl/gidl/backend/rust/conformance.go
- M tools/fidl/gidl/backend/rust/equality_builder.go
- M tools/fidl/gidl/backend/rust_codec/conformance.go
- M tools/fidl/gidl/backend/rust_next/conformance.go
- M tools/fidl/gidl/backend/rust_next/equality_builder.go
- M tools/fidl/gidl/lib/cpp/builder.go
- M tools/fidl/gidl/lib/ir/value.go
- M tools/fidl/gidl/lib/llcpp/allocator_builder.go
- M tools/fidl/gidl/lib/llcpp/equality_builder.go
- M tools/fidl/gidl/lib/llcpp/unowned_builder.go
- M tools/fidl/gidl/lib/mixer/mixer.go
- M tools/fidl/gidl/lib/parser/parser.go
- M tools/fidl/gidl/lib/parser/parser_test.go
- M tools/fidl/lib/fidlgen/generator.go
- M tools/fidl/lib/fidlgen/templates.go
- M tools/fidl/lib/fidlgen/types.go
- M tools/fidl/lib/fidlgen_cpp/codegen_options.go
- M tools/fidl/lib/fidlgen_cpp/enum.go
- M tools/fidl/lib/fidlgen_cpp/namespaced_enum.go
- M tools/fidl/lib/fidlgen_cpp/template_funcs.go
- M tools/fidl/lib/fidlgen_cpp/testutils_test.go
- M tools/fidl/measure-tape/src/hlcpp/hlcpp.go
- M tools/fidl/measure-tape/src/measurer/measurer.go
- M tools/fidl/measure-tape/src/rust/rust.go
- M tools/fuzz/connector_mock_test.go
- M tools/fuzz/e2e_test.go
- M tools/fuzz/fuzzer.go
- M tools/fuzz/fuzzer_test.go
- M tools/fuzz/ssh_fake_test.go
- M tools/integration/fint/build.go
- M tools/integration/fint/build_test.go
- M tools/integration/fint/cmd/fint/cmd_affected.go
- M tools/integration/fint/cmd/fint/cmd_build.go
- M tools/integration/fint/cmd/fint/cmd_set.go
- M tools/integration/fint/set.go
- M tools/integration/testsharder/cmd/main_test.go
- M tools/integration/testsharder/postprocess.go
- M tools/integration/testsharder/preprocess_test.go
- M tools/lib/cache/cache.go
- M tools/lib/color/color.go
- M tools/lib/jsonutil/jsonutil.go
- M tools/lib/logger/logger.go
- M tools/lib/serial/serial_test.go
- M tools/mdlint/core/reporter.go
- M tools/mdlint/rules/testutils_test.go
- M tools/net/device-finder/cmd/list.go
- M tools/net/device-finder/cmd/resolve.go
- M tools/net/netboot/netboot_test.go
- M tools/orchestrate/config.go
- M tools/sdk-tools/fssh/fssh/fssh.go
- M tools/sdk-tools/fssh/fssh/synckeys.go
- M tools/sdk-tools/fssh/fssh/tunnel.go
- M tools/sdk-tools/fstar_integration/fstar_integration_test.go
- M tools/sdk-tools/sdkcommon/sdkcommon.go
- M tools/sdk-tools/sdkcommon/sdkcommon_test.go
- M tools/staticanalysis/clippy-reporter/main.go
- M tools/testing/tap/parser.go
- M tools/testing/tap/producer.go
- M tools/testing/tap/tokenizer/stream.go
- M tools/testing/tefmocheck/nearby_string_check.go
- M tools/testing/tefmocheck/string_in_log_check.go
- M tools/testing/tefmocheck/string_in_log_check_test.go
- M tools/testing/testrunner/tester_test.go
- M tools/whereiscl/netutil/netutil.go
- M zircon/tools/zither/backends/c/c.go
- M zircon/tools/zither/zither_ir.go
Change size: L
Delta: 111 files changed, 363 insertions(+), 454 deletions(-)
Related details
Attention is currently required from:
- Owners Override
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/988addd0268d1e6f537906d0bc7b823790941bfc-HTML%40fuchsia-review.googlesource.com.
'Oliver Newman (Gerrit)' via owners-override
Feb 17, 2026, 2:27:04 PM (3 days ago) Feb 17
to Owners Override, Jerry Belton, GI Try Builder, CQ Bot
Attention needed from Owners Override
Oliver Newman voted Fuchsia-Auto-Submit+1![]( "Open in Gerrit")
| Fuchsia-Auto-Submit | +1 |
Related details
Attention is currently required from:
- Owners Override
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/988addd0268d1e6f537906d0bc7b823790941bfc-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'Adam Barth (Gerrit)' via owners-override
Feb 17, 2026, 2:48:21 PM (3 days ago) Feb 17
to Oliver Newman, Owners Override, Jerry Belton, GI Try Builder, CQ Bot
Attention needed from Oliver Newman and Owners Override
Adam Barth voted Owners-Override+1![]( "Open in Gerrit")
Attention is currently required from:
- Oliver Newman
- Owners Override
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/9d63294268ce1033e67b6e8a15c8d1eae828d8bb-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'CQ Bot (Gerrit)' via owners-override
Feb 17, 2026, 3:48:56 PM (2 days ago) Feb 17
to Oliver Newman, Adam Barth, Owners Override, Jerry Belton, GI Try Builder
CQ Bot submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[go] Run `go fix`
... on `//tools` and also `//zircon/tools/zither`, to update code to use
more modern idioms such as `min()` and `max()` built-ins and `any`
instead of `interface{}`.
I couldn't run it on the whole tree because it got caught up on any
files that depended on ninja-provided imports, so stuck to just these
directories for now.
I also made a couple minor manual cleanups of local variables that had
become unnecessary/confusing as a result of the fixes.
Change-Id: I25668b820cc53df4285994d04cb80d746db19f1b
Fuchsia-Auto-Submit: Oliver Newman <oliver...@google.com>
Commit-Queue: Oliver Newman <oliver...@google.com>
Reviewed-by: Jerry Belton <jce...@google.com>
Owners-Override: Adam Barth <aba...@google.com>
Branch: refs/heads/main
Submit Requirements:
Code-Review: +2 by Jerry Belton
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/5c82b6d2559d590ea84916eece8199b65fe0618f-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'GI Roller (Gerrit)' via owners-override
Feb 17, 2026, 3:51:29 PM (2 days ago) Feb 17
to Oliver Newman, CQ Bot, Adam Barth, Owners Override, Jerry Belton, GI Try Builder
Message from GI Roller![]( "Open in Gerrit")
Change has been successfully rolled: https://turquoise-internal-review.googlesource.com/1171246
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/8d7892f85fb127ffbda308333f0c1dbcef4793bc-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
Reply all
Reply to author
Forward
0 new messages