[S] Change in fuchsia/fuchsia[main]: [power] Add hwasan suppressions where there's existing asan suppressions

2 views
Skip to first unread message

'Petr Hosek (Gerrit)' via owners-override

unread,
Sep 3, 2025, 5:46:03 PM (4 days ago) Sep 3
to Owners Override
Attention needed from Owners Override, Prashanth Swaminathan and Vaas Krishnamurthy

Leonard Chan has uploaded the change for review

Petr Hosek would like Owners Override to review this change authored by Leonard Chan.

Commit message

[power] Add hwasan suppressions where there's existing asan suppressions

These have suppressions primarily for lsan, so they should also have the hwasan suppressions which come with lsan by default.
Change-Id: I5fc3696f433d28c6eb5d2760546f1cef2fc379af

Change diff

diff --git a/src/connectivity/wlan/lib/common/rust/src/test_utils/fake_stas.rs b/src/connectivity/wlan/lib/common/rust/src/test_utils/fake_stas.rs
index 822a8d4..311b908 100644
--- a/src/connectivity/wlan/lib/common/rust/src/test_utils/fake_stas.rs
+++ b/src/connectivity/wlan/lib/common/rust/src/test_utils/fake_stas.rs
@@ -695,6 +695,7 @@
#[should_panic(expected = "Personal is not supported")]
// TODO(https://fxbug.dev/42169733): LeakSanitizer flags leaks caused by panic.
#[cfg_attr(feature = "variant_asan", ignore)]
+ #[cfg_attr(feature = "variant_hwasan", ignore)]
fn unsupported_bss_type() {
fake_fidl_bss_description!(Open, bss_type: fidl_common::BssType::Personal);
}
diff --git a/src/lib/fuchsia-async/src/runtime/mod.rs b/src/lib/fuchsia-async/src/runtime/mod.rs
index 30c7975..6dac358 100644
--- a/src/lib/fuchsia-async/src/runtime/mod.rs
+++ b/src/lib/fuchsia-async/src/runtime/mod.rs
@@ -263,6 +263,7 @@
#[should_panic]
// TODO(https://fxbug.dev/42169733): delete the below
#[cfg_attr(feature = "variant_asan", ignore)]
+ #[cfg_attr(feature = "variant_hwasan", ignore)]
fn unblock_fn_panics() {
run(async move {
unblock(|| panic!("bad")).await;
diff --git a/src/lib/fuchsia/src/lib.rs b/src/lib/fuchsia/src/lib.rs
index eea770a..fecf1cb 100644
--- a/src/lib/fuchsia/src/lib.rs
+++ b/src/lib/fuchsia/src/lib.rs
@@ -341,11 +341,11 @@
// are targeting is lsan (LeakSanitizer), which is enabled as part of the asan variant.

#[doc(hidden)]
-#[cfg(not(feature = "variant_asan"))]
+#[cfg(not(any(feature = "variant_asan", feature = "variant_hwasan")))]
pub fn disable_lsan_for_should_panic() {}

#[doc(hidden)]
-#[cfg(feature = "variant_asan")]
+#[cfg(any(feature = "variant_asan", feature = "variant_hwasan"))]
pub fn disable_lsan_for_should_panic() {
extern "C" {
fn __lsan_disable();
@@ -355,10 +355,10 @@
}
}

-#[cfg(not(feature = "variant_asan"))]
+#[cfg(not(any(feature = "variant_asan", feature = "variant_hwasan")))]
fn install_lsan_hook() {}

-#[cfg(feature = "variant_asan")]
+#[cfg(any(feature = "variant_asan", feature = "variant_hwasan"))]
fn install_lsan_hook() {
extern "C" {
fn __lsan_do_leak_check();
diff --git a/src/power/cpu-manager/src/test/mock_node.rs b/src/power/cpu-manager/src/test/mock_node.rs
index 305bdfe..3f84859 100644
--- a/src/power/cpu-manager/src/test/mock_node.rs
+++ b/src/power/cpu-manager/src/test/mock_node.rs
@@ -266,6 +266,7 @@
#[should_panic(expected = "Mock node(s) were leaked: MockNode")]
// TODO(fxbug.dev/42169733): delete the below
#[cfg_attr(feature = "variant_asan", ignore)]
+ #[cfg_attr(feature = "variant_hwasan", ignore)]
fn test_leaked_node_panic() {
let _node = {
let mut mock_maker = MockNodeMaker::new();
diff --git a/src/power/power-manager/src/test/mock_node.rs b/src/power/power-manager/src/test/mock_node.rs
index ba025ff..d1fa8c1 100644
--- a/src/power/power-manager/src/test/mock_node.rs
+++ b/src/power/power-manager/src/test/mock_node.rs
@@ -270,6 +270,7 @@
#[should_panic(expected = "Mock node(s) were leaked: MockNode")]
// TODO(https://fxbug.dev/42169733): delete the below
#[cfg_attr(feature = "variant_asan", ignore)]
+ #[cfg_attr(feature = "variant_hwasan", ignore)]
fn test_leaked_node_panic() {
let _node = {
let mut mock_maker = MockNodeMaker::new();

Change information

Files:
Change size: S
Delta: 5 files changed, 8 insertions(+), 4 deletions(-)
Open in Gerrit

Related details

Attention is currently required from:
  • Owners Override
  • Prashanth Swaminathan
  • Vaas Krishnamurthy
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I5fc3696f433d28c6eb5d2760546f1cef2fc379af
Gerrit-Change-Number: 1360147
Gerrit-PatchSet: 3
Gerrit-Owner: Leonard Chan <leona...@google.com>
Gerrit-Reviewer: Adam Perry <adam...@google.com>
Gerrit-Reviewer: Leonard Chan <leona...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Reviewer: Prashanth Swaminathan <prash...@google.com>
Gerrit-Reviewer: Vaas Krishnamurthy <va...@google.com>
Gerrit-CC: Petr Hosek <pho...@google.com>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Prashanth Swaminathan <prash...@google.com>
Gerrit-Attention: Vaas Krishnamurthy <va...@google.com>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/efc7af4848e92ae872022545f409a0e2ab5ce312-HTML%40fuchsia-review.googlesource.com.
unsatisfied_requirement
satisfied_requirement
open
diffy

'James Robinson (Gerrit)' via owners-override

unread,
Sep 3, 2025, 5:58:47 PM (4 days ago) Sep 3
to Leonard Chan, Owners Override, Petr Hosek, Adam Perry, GI Try Builder, Vaas Krishnamurthy, Prashanth Swaminathan, CQ Bot
Attention needed from Leonard Chan, Owners Override, Prashanth Swaminathan and Vaas Krishnamurthy

James Robinson added 1 comment

Commit Message
Line 9, Patchset 3 (Latest):These have suppressions primarily for lsan, so they should also have the hwasan suppressions which come with lsan by default.
James Robinson . unresolved

The changed code seems to be checking for asan, not lsan. Does our asan configuration also include lsan by default?

Open in Gerrit

Related details

Attention is currently required from:
  • Leonard Chan
  • Owners Override
  • Prashanth Swaminathan
  • Vaas Krishnamurthy
    Submit Requirements:
      • requirement is not satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: fuchsia
      Gerrit-Branch: main
      Gerrit-Change-Id: I5fc3696f433d28c6eb5d2760546f1cef2fc379af
      Gerrit-Change-Number: 1360147
      Gerrit-PatchSet: 3
      Gerrit-Owner: Leonard Chan <leona...@google.com>
      Gerrit-Reviewer: Adam Perry <adam...@google.com>
      Gerrit-Reviewer: Leonard Chan <leona...@google.com>
      Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
      Gerrit-Reviewer: Prashanth Swaminathan <prash...@google.com>
      Gerrit-Reviewer: Vaas Krishnamurthy <va...@google.com>
      Gerrit-CC: James Robinson <jam...@google.com>
      Gerrit-CC: Petr Hosek <pho...@google.com>
      Gerrit-Attention: Leonard Chan <leona...@google.com>
      Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
      Gerrit-Attention: Prashanth Swaminathan <prash...@google.com>
      Gerrit-Attention: Vaas Krishnamurthy <va...@google.com>
      Gerrit-Comment-Date: Wed, 03 Sep 2025 21:58:38 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No

      --
      You received this message because you are subscribed to the Google Groups "owners-override" group.
      To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
      To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/5d88944428307aeb41ef36222b03432ccb07a2f2-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
      unsatisfied_requirement
      satisfied_requirement
      open
      diffy

      'Prashanth Swaminathan (Gerrit)' via owners-override

      unread,
      Sep 3, 2025, 5:58:55 PM (4 days ago) Sep 3
      to Leonard Chan, James Robinson, Owners Override, Petr Hosek, Adam Perry, GI Try Builder, Vaas Krishnamurthy, CQ Bot
      Attention needed from Leonard Chan, Owners Override and Vaas Krishnamurthy

      Prashanth Swaminathan voted Code-Review+2

      Code-Review+2
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Leonard Chan
      • Owners Override
      • Vaas Krishnamurthy
      Gerrit-Attention: Vaas Krishnamurthy <va...@google.com>
      Gerrit-Comment-Date: Wed, 03 Sep 2025 21:58:48 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes

      --
      You received this message because you are subscribed to the Google Groups "owners-override" group.
      To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
      To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/f05ce1ab1fdf031b5d07165e04d313a85acde4cd-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
      unsatisfied_requirement
      satisfied_requirement
      open
      diffy

      'Leonard Chan (Gerrit)' via owners-override

      unread,
      Sep 3, 2025, 6:11:19 PM (4 days ago) Sep 3
      to Prashanth Swaminathan, James Robinson, Owners Override, Petr Hosek, Adam Perry, GI Try Builder, Vaas Krishnamurthy, CQ Bot
      Attention needed from James Robinson, Owners Override and Vaas Krishnamurthy

      Leonard Chan added 1 comment

      Commit Message
      Line 9, Patchset 3 (Latest):These have suppressions primarily for lsan, so they should also have the hwasan suppressions which come with lsan by default.
      James Robinson . unresolved

      The changed code seems to be checking for asan, not lsan. Does our asan configuration also include lsan by default?

      Leonard Chan

      LSan is brought in by default with asan, but there's no compile-time check for lsan because lsan doesn't require any sanitizer instrumentation. In practice we use lsan whenever compiling with either asan or hwasan hence all the asan/hwasan-specific suppressions.

      Open in Gerrit

      Related details

      Attention is currently required from:
      • James Robinson
      • Owners Override
      • Vaas Krishnamurthy
      Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
      Gerrit-Attention: James Robinson <jam...@google.com>
      Gerrit-Attention: Vaas Krishnamurthy <va...@google.com>
      Gerrit-Comment-Date: Wed, 03 Sep 2025 22:11:05 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: James Robinson <jam...@google.com>

      --
      You received this message because you are subscribed to the Google Groups "owners-override" group.
      To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
      To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/edfa5b5d4bcab8ceead25931bcf2c6f21a703f04-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
      unsatisfied_requirement
      satisfied_requirement
      open
      diffy

      'James Robinson (Gerrit)' via owners-override

      unread,
      Sep 3, 2025, 6:14:26 PM (4 days ago) Sep 3
      to Leonard Chan, Prashanth Swaminathan, Owners Override, Petr Hosek, Adam Perry, GI Try Builder, Vaas Krishnamurthy, CQ Bot
      Attention needed from Leonard Chan, Owners Override and Vaas Krishnamurthy

      James Robinson voted

      Code-Review+2
      Owners-Override+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Leonard Chan
      • Owners Override
      • Vaas Krishnamurthy
      Submit Requirements:
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: fuchsia
      Gerrit-Branch: main
      Gerrit-Change-Id: I5fc3696f433d28c6eb5d2760546f1cef2fc379af
      Gerrit-Change-Number: 1360147
      Gerrit-PatchSet: 3
      Gerrit-Owner: Leonard Chan <leona...@google.com>
      Gerrit-Reviewer: Adam Perry <adam...@google.com>
      Gerrit-Reviewer: James Robinson <jam...@google.com>
      Gerrit-Reviewer: Leonard Chan <leona...@google.com>
      Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
      Gerrit-Reviewer: Prashanth Swaminathan <prash...@google.com>
      Gerrit-Reviewer: Vaas Krishnamurthy <va...@google.com>
      Gerrit-CC: Petr Hosek <pho...@google.com>
      Gerrit-Attention: Leonard Chan <leona...@google.com>
      Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
      Gerrit-Attention: Vaas Krishnamurthy <va...@google.com>
      Gerrit-Comment-Date: Wed, 03 Sep 2025 22:14:16 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes

      --
      You received this message because you are subscribed to the Google Groups "owners-override" group.
      To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
      To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/dcb0f8456b01248d00efa6fb97b5e7506f4580b7-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      'James Robinson (Gerrit)' via owners-override

      unread,
      Sep 3, 2025, 6:14:31 PM (4 days ago) Sep 3
      to Leonard Chan, Prashanth Swaminathan, Owners Override, Petr Hosek, Adam Perry, GI Try Builder, Vaas Krishnamurthy, CQ Bot
      Attention needed from Leonard Chan, Owners Override and Vaas Krishnamurthy

      James Robinson added 1 comment

      Commit Message
      Line 9, Patchset 3 (Latest):These have suppressions primarily for lsan, so they should also have the hwasan suppressions which come with lsan by default.
      James Robinson . resolved

      The changed code seems to be checking for asan, not lsan. Does our asan configuration also include lsan by default?

      Leonard Chan

      LSan is brought in by default with asan, but there's no compile-time check for lsan because lsan doesn't require any sanitizer instrumentation. In practice we use lsan whenever compiling with either asan or hwasan hence all the asan/hwasan-specific suppressions.

      James Robinson

      Acknowledged

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Leonard Chan
      • Owners Override
      • Vaas Krishnamurthy
      Submit Requirements:
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: fuchsia
        Gerrit-Branch: main
        Gerrit-Change-Id: I5fc3696f433d28c6eb5d2760546f1cef2fc379af
        Gerrit-Change-Number: 1360147
        Gerrit-PatchSet: 3
        Gerrit-Owner: Leonard Chan <leona...@google.com>
        Gerrit-Reviewer: Adam Perry <adam...@google.com>
        Gerrit-Reviewer: James Robinson <jam...@google.com>
        Gerrit-Reviewer: Leonard Chan <leona...@google.com>
        Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
        Gerrit-Reviewer: Prashanth Swaminathan <prash...@google.com>
        Gerrit-Reviewer: Vaas Krishnamurthy <va...@google.com>
        Gerrit-CC: Petr Hosek <pho...@google.com>
        Gerrit-Attention: Leonard Chan <leona...@google.com>
        Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
        Gerrit-Attention: Vaas Krishnamurthy <va...@google.com>
        Gerrit-Comment-Date: Wed, 03 Sep 2025 22:14:23 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: No
        Comment-In-Reply-To: Leonard Chan <leona...@google.com>
        Comment-In-Reply-To: James Robinson <jam...@google.com>

        --
        You received this message because you are subscribed to the Google Groups "owners-override" group.
        To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
        To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/53dce5ddc9e26c5df6e8b5935167ed094962beb2-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
        satisfied_requirement
        open
        diffy

        'Leonard Chan (Gerrit)' via owners-override

        unread,
        Sep 3, 2025, 6:24:18 PM (4 days ago) Sep 3
        to James Robinson, Prashanth Swaminathan, Owners Override, Petr Hosek, Adam Perry, GI Try Builder, Vaas Krishnamurthy, CQ Bot
        Attention needed from Owners Override and Vaas Krishnamurthy

        Leonard Chan voted Commit-Queue+2

        Commit-Queue+2
        Open in Gerrit

        Related details

        Attention is currently required from:
        • Owners Override
        • Vaas Krishnamurthy
        Submit Requirements:
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: fuchsia
        Gerrit-Branch: main
        Gerrit-Change-Id: I5fc3696f433d28c6eb5d2760546f1cef2fc379af
        Gerrit-Change-Number: 1360147
        Gerrit-PatchSet: 3
        Gerrit-Owner: Leonard Chan <leona...@google.com>
        Gerrit-Reviewer: Adam Perry <adam...@google.com>
        Gerrit-Reviewer: James Robinson <jam...@google.com>
        Gerrit-Reviewer: Leonard Chan <leona...@google.com>
        Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
        Gerrit-Reviewer: Prashanth Swaminathan <prash...@google.com>
        Gerrit-Reviewer: Vaas Krishnamurthy <va...@google.com>
        Gerrit-CC: Petr Hosek <pho...@google.com>
        Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
        Gerrit-Attention: Vaas Krishnamurthy <va...@google.com>
        Gerrit-Comment-Date: Wed, 03 Sep 2025 22:24:09 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes

        --
        You received this message because you are subscribed to the Google Groups "owners-override" group.
        To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
        To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/0d44a32432b9b4e8df7ef9afc008ef2bc61167c2-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
        satisfied_requirement
        open
        diffy

        'CQ Bot (Gerrit)' via owners-override

        unread,
        Sep 3, 2025, 6:24:43 PM (4 days ago) Sep 3
        to Leonard Chan, James Robinson, Prashanth Swaminathan, Owners Override, Petr Hosek, Adam Perry, GI Try Builder, Vaas Krishnamurthy

        CQ Bot submitted the change

        Change information

        Commit message:
        [power] Add hwasan suppressions where there's existing asan suppressions

        These have suppressions primarily for lsan, so they should also have the hwasan suppressions which come with lsan by default.
        Change-Id: I5fc3696f433d28c6eb5d2760546f1cef2fc379af
        Reviewed-by: Prashanth Swaminathan <prash...@google.com>
        Commit-Queue: Leonard Chan <leona...@google.com>
        Owners-Override: James Robinson <jam...@google.com>
        Reviewed-by: James Robinson <jam...@google.com>
        Reviewed-by: Adam Perry <adam...@google.com>
        Files:
        Change size: S
        Delta: 5 files changed, 8 insertions(+), 4 deletions(-)
        Branch: refs/heads/main
        Submit Requirements:
        • requirement satisfiedCode-Review: +2 by Prashanth Swaminathan, +2 by Adam Perry, +2 by James Robinson
        Open in Gerrit
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: merged
        Gerrit-Project: fuchsia
        Gerrit-Branch: main
        Gerrit-Change-Id: I5fc3696f433d28c6eb5d2760546f1cef2fc379af
        Gerrit-Change-Number: 1360147
        Gerrit-PatchSet: 4
        Gerrit-Owner: Leonard Chan <leona...@google.com>
        Gerrit-Reviewer: Adam Perry <adam...@google.com>
        Gerrit-Reviewer: James Robinson <jam...@google.com>
        Gerrit-Reviewer: Leonard Chan <leona...@google.com>
        Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
        Gerrit-Reviewer: Prashanth Swaminathan <prash...@google.com>
        Gerrit-Reviewer: Vaas Krishnamurthy <va...@google.com>
        Gerrit-CC: Petr Hosek <pho...@google.com>

        --
        You received this message because you are subscribed to the Google Groups "owners-override" group.
        To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
        To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/01a629a59a5a041cce0e3e73e65e3e30f61d4766-HTML%40fuchsia-review.googlesource.com.
        open
        diffy
        satisfied_requirement

        'GI Roller (Gerrit)' via owners-override

        unread,
        Sep 3, 2025, 6:30:20 PM (4 days ago) Sep 3
        to Leonard Chan, CQ Bot, James Robinson, Prashanth Swaminathan, Owners Override, Petr Hosek, Adam Perry, GI Try Builder, Vaas Krishnamurthy

        Message from GI Roller

        Open in Gerrit

        Related details

        Attention set is empty
        Submit Requirements:
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: fuchsia
        Gerrit-Branch: main
        Gerrit-Change-Id: I5fc3696f433d28c6eb5d2760546f1cef2fc379af
        Gerrit-Change-Number: 1360147
        Gerrit-PatchSet: 4
        Gerrit-Owner: Leonard Chan <leona...@google.com>
        Gerrit-Reviewer: Adam Perry <adam...@google.com>
        Gerrit-Reviewer: James Robinson <jam...@google.com>
        Gerrit-Reviewer: Leonard Chan <leona...@google.com>
        Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
        Gerrit-Reviewer: Prashanth Swaminathan <prash...@google.com>
        Gerrit-Reviewer: Vaas Krishnamurthy <va...@google.com>
        Gerrit-CC: Petr Hosek <pho...@google.com>
        Gerrit-Comment-Date: Wed, 03 Sep 2025 22:30:17 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: No

        --
        You received this message because you are subscribed to the Google Groups "owners-override" group.
        To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
        To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/f936c0608ca999db12b34dcdf1af0c8999689f70-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
        satisfied_requirement
        open
        diffy
        Reply all
        Reply to author
        Forward
        0 new messages