'Vinicius Felizardo (Gerrit)' via owners-override

unread,

May 7, 2024, 8:08:53 PM5/7/24

to Owners Override

Attention needed from Owners Override

Vinicius Felizardo has uploaded the change for review

Vinicius Felizardo would like Owners Override to review this change.

Commit message

[infra] Updates nuc_env to nuc7_env and nuc11_env.

Bug: b/326499130

Change-Id: I81a797d4345c87f357ca19a4692539ade884c505

Change diff

Change information

Files:

M build/testing/environments.gni
M build/testing/perf/test.gni
M build/testing/test_spec.gni
M sdk/ctf/build/generate_ctf_tests.gni
M src/chromium/generate_chromium_targets.gni
M src/cobalt/bin/BUILD.gn
M src/developer/ffx/frontends/ffx/BUILD.gn
M src/developer/ffx/lib/fuchsia-controller/end_to_end_tests/mobly/BUILD.gn
M src/developer/ffx/tests/e2e/python/BUILD.gn
M src/devices/tests/fhcp/sample/BUILD.gn
M src/devices/usb/bin/lsusb/BUILD.gn
M src/devices/usb/tests/usb-hci-test/BUILD.gn
M src/graphics/lib/compute/gn/build_rules_for_fuchsia.gni
M src/graphics/lib/magma/gnbuild/magma.gni
M src/lib/diagnostics/inspect/contrib/self_profiles_report/tests/BUILD.gn
M src/lib/ui/carnelian/BUILD.gn
M src/media/audio/drivers/intel-hda/test/BUILD.gn
M src/media/audio/hardware.gni
M src/media/codec/examples/BUILD.gn
M src/media/stream_processors/test/BUILD.gn
M src/recovery/integration/system/BUILD.gn
M src/recovery/system/BUILD.gn
M src/starnix/tests/BUILD.gn
M src/storage/lib/paver/e2e_tests/BUILD.gn
M src/sys/pkg/tests/system-tests/BUILD.gn
M src/sys/time/timekeeper/BUILD.gn
M src/sys/time/timekeeper_integration/BUILD.gn
M src/testing/end_to_end/examples/test_soft_reboot/BUILD.gn
M src/testing/end_to_end/honeydew/tests/functional_tests/fuchsia_device_tests/test_fuchsia_device/BUILD.gn
M src/tests/end_to_end/perf/BUILD.gn
M src/tests/end_to_end/sl4f/BUILD.gn
M src/tests/end_to_end/snapshot/BUILD.gn
M src/tests/end_to_end/time_sync/BUILD.gn
M src/ui/bin/virtual_keyboard_manager/tests/BUILD.gn
M src/ui/scenic/BUILD.gn
M src/virtualization/tests/BUILD.gn
M src/zircon/tests/restricted-mode-shared/stress/BUILD.gn
M zircon/kernel/lib/userabi/userboot/tests/BUILD.gn
M zircon/kernel/params.gni
M zircon/system/utest/core/BUILD.gn
M zircon/system/utest/device-enumeration/BUILD.gn
D zircon/system/utest/device-enumeration/boards/nuc.cc
A zircon/system/utest/device-enumeration/boards/nuc11.cc
A zircon/system/utest/device-enumeration/boards/nuc7.cc

Change size: L

Delta: 44 files changed, 311 insertions(+), 179 deletions(-)

Open in Gerrit

Related details

Attention is currently required from:

Owners Override

Submit Requirements:

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/4873662998cf7699e524e7ebc4136c1b9172892d-HTML%40fuchsia-review.googlesource.com.

satisfied_requirement

open

diffy

'Vinicius Felizardo (Gerrit)' via owners-override

unread,

May 7, 2024, 8:43:35 PM5/7/24

to Tricium, Owners Override, Suraj Malhotra, Krithika Balan, Kevin Cho, Oliver Newman, CQ Bot, Fuchsia Try Builder

Attention needed from Owners Override

Vinicius Felizardo voted and added 1 comment

Votes added by Vinicius Felizardo

Commit-Queue

+1

1 comment

File build/testing/test_spec.gni

Line 292, Patchset 2: foreach(env, environments) {

Oliver Newman . resolved

Would it be possible to add some validation here that if a test has NUC7 included in its envs, it also has NUC11?

Something like:

```
  has_nuc7 = false
  has_nuc11 = false
  foreach(env, environments) {
    if (env.dimensions.device_type = "Intel NUC Kit NUC7i5DNHE") {
      has_nuc7 = true
    }
    if (env.dimensions.device_type = "Intel NUC Kit NUC11TNHv5") {
      has_nuc11 = true
    }
    ...
  }
  
  // (not sure if this is the correct value to check, but we need some
  // sort of exemption for this test)
  if (name != "core-tests-hpet") {
    assert(!has_nuc7 || has_nuc11, "every test that runs on nuc7 must also run on nuc11")
  }
```

Vinicius Felizardo

Done

Vinicius Felizardo

FYI I cant add this check in this CL because of the skew issue of other CLs that will only include nuc7 for now. However, they are actually including nuc11 too given the existing logic to replace nuc_env with nuc7 + nuc11.

Therefore, when I get to delete this hack of adding nuc7 + nuc11, I can also add the check here: https://paste.googleplex.com/5374925699547136

Open in Gerrit

Related details

Attention is currently required from:

Owners Override

Submit Requirements:

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/000001fa840429fd1f2bcdc090473e6904f8b1e6-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

satisfied_requirement

open

diffy

'Vinicius Felizardo (Gerrit)' via owners-override

unread,

May 7, 2024, 8:44:53 PM5/7/24

to Tricium, Owners Override, Suraj Malhotra, Krithika Balan, Kevin Cho, Oliver Newman, CQ Bot, Fuchsia Try Builder

Attention needed from Owners Override

Vinicius Felizardo added 1 comment

File build/testing/test_spec.gni

Line 292, Patchset 2: foreach(env, environments) {

Oliver Newman . resolved

Would it be possible to add some validation here that if a test has NUC7 included in its envs, it also has NUC11?

Something like:

```
  has_nuc7 = false
  has_nuc11 = false
  foreach(env, environments) {
    if (env.dimensions.device_type = "Intel NUC Kit NUC7i5DNHE") {
      has_nuc7 = true
    }
    if (env.dimensions.device_type = "Intel NUC Kit NUC11TNHv5") {
      has_nuc11 = true
    }
    ...
  }
  
  // (not sure if this is the correct value to check, but we need some
  // sort of exemption for this test)
  if (name != "core-tests-hpet") {
    assert(!has_nuc7 || has_nuc11, "every test that runs on nuc7 must also run on nuc11")
  }
```

Vinicius Felizardo

Done

Vinicius Felizardo

FYI I cant add this check in this CL because of the skew issue of other CLs that will only include nuc7 for now. However, they are actually including nuc11 too given the existing logic to replace nuc_env with nuc7 + nuc11.
Therefore, when I get to delete this hack of adding nuc7 + nuc11, I can also add the check here: https://paste.googleplex.com/5374925699547136

Vinicius Felizardo

skew issue of other repositories*

Open in Gerrit

Related details

Attention is currently required from:

Owners Override

Submit Requirements:

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/f0cf3b187b3884946c15d69ea712a168d1db9b34-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

satisfied_requirement

open

diffy

'Adam Barth (Gerrit)' via owners-override

unread,

May 8, 2024, 3:26:14 AM5/8/24

to Vinicius Felizardo, Tricium, Owners Override, Suraj Malhotra, Krithika Balan, Kevin Cho, Oliver Newman, CQ Bot, Fuchsia Try Builder

Attention needed from Owners Override and Vinicius Felizardo

Adam Barth voted Owners-Override+1

Owners-Override

+1

Open in Gerrit

Related details

Attention is currently required from:

Owners Override
Vinicius Felizardo

Submit Requirements:

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/f103cf628cebc44ce84f4852b4285c50a417d2b9-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

satisfied_requirement

open

diffy

'Vinicius Felizardo (Gerrit)' via owners-override

unread,

May 8, 2024, 2:09:04 PM5/8/24

to Adam Barth, Tricium, Owners Override, Suraj Malhotra, Krithika Balan, Kevin Cho, Oliver Newman, CQ Bot, Fuchsia Try Builder

Attention needed from Adam Barth and Owners Override

Vinicius Felizardo added 1 comment

File zircon/system/utest/device-enumeration/boards/nuc7.cc

File-level comment, Patchset 21 (Latest):

Vinicius Felizardo . resolved

File not formatted properly.
Run the following to format:
fx format-code --changed-lines --files=zircon/system/utest/device-enumeration/boards/nuc7.cc

I run this but no changes take effect: https://paste.googleplex.com/5051469229457408

Open in Gerrit

Related details

Attention is currently required from:

Adam Barth
Owners Override

Submit Requirements:

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--

You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/072da2f0a69896380eeb216c3d9cffac17634fc3-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

satisfied_requirement

open

diffy

'Adam Barth (Gerrit)' via owners-override

unread,

May 8, 2024, 2:10:30 PM5/8/24

to Vinicius Felizardo, Tricium, Owners Override, Suraj Malhotra, Krithika Balan, Kevin Cho, Oliver Newman, CQ Bot, Fuchsia Try Builder

Attention needed from Owners Override and Vinicius Felizardo

Adam Barth voted Owners-Override+1

Owners-Override

+1

Open in Gerrit

Related details

Attention is currently required from:

Owners Override
Vinicius Felizardo

Submit Requirements:

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--

You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/4348622314a143de22d493deccaa62a50df51341-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

satisfied_requirement

open

diffy

'Vinicius Felizardo (Gerrit)' via owners-override

unread,

May 8, 2024, 2:12:31 PM5/8/24

to Adam Barth, Tricium, Owners Override, Suraj Malhotra, Krithika Balan, Kevin Cho, Oliver Newman, CQ Bot, Fuchsia Try Builder

Attention needed from Owners Override

Vinicius Felizardo voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention is currently required from:

Owners Override

Submit Requirements:

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/9fd2a07eac8301b8e46ff59d660693b6ced9f008-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

satisfied_requirement

open

diffy

'Vinicius Felizardo (Gerrit)' via owners-override

unread,

May 8, 2024, 4:00:50 PM5/8/24

to Owners Override, Adam Barth, Tricium, Suraj Malhotra, Krithika Balan, Kevin Cho, Oliver Newman, CQ Bot, Fuchsia Try Builder

Attention needed from Vinicius Felizardo

Vinicius Felizardo removed Owners Override from this change

Deleted Reviewers:

Owners Override

Open in Gerrit

Related details

Attention is currently required from:

Vinicius Felizardo

Submit Requirements:

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/a9a38594b2a6cf93edecf1838cdf521e02b94f82-HTML%40fuchsia-review.googlesource.com.

satisfied_requirement

open

diffy

Reply all

Reply to author

Forward

[L] Change in fuchsia/fuchsia[main]: [infra] Updates nuc_env to nuc7_env and nuc11_env.

'Vinicius Felizardo (Gerrit)' via owners-override

Vinicius Felizardo has uploaded the change for review

Commit message

Change diff

Change information

Related details

'Vinicius Felizardo (Gerrit)' via owners-override

Vinicius Felizardo voted and added 1 comment

Votes added by Vinicius Felizardo

1 comment

Related details

'Vinicius Felizardo (Gerrit)' via owners-override

Vinicius Felizardo added 1 comment

Related details

'Adam Barth (Gerrit)' via owners-override

Adam Barth voted Owners-Override+1

Related details

'Vinicius Felizardo (Gerrit)' via owners-override

Vinicius Felizardo added 1 comment

Related details

'Adam Barth (Gerrit)' via owners-override

Adam Barth voted Owners-Override+1

Related details

'Vinicius Felizardo (Gerrit)' via owners-override

Vinicius Felizardo voted Commit-Queue+2

Related details

'Vinicius Felizardo (Gerrit)' via owners-override

Vinicius Felizardo removed Owners Override from this change

Related details