Groups keyboard shortcuts have been updated
Dismiss
See shortcuts
[S] Change in fuchsia/fuchsia[main]: [fx][bazel-tool] Move bazel_tool.py to //build/bazel/scripts/
1 view
Skip to first unread message
'David Turner (Gerrit)' via owners-override
Mar 10, 2025, 1:53:24 PMMar 10
to Clayton Wilkinson, David Fang, Owners Override, Aaron Wood, Jay Zhuang
Attention needed from Aaron Wood, Clayton Wilkinson, David Fang, Jay Zhuang and Owners Override
David Turner has uploaded the change for review![]( "Open in Gerrit")
David Turner would like Clayton Wilkinson, David Fang, Owners Override, Aaron Wood and Jay Zhuang to review this change.
Commit message
[fx][bazel-tool] Move bazel_tool.py to //build/bazel/scripts/
As discussed previously in [1], this is a better logical location
for this script.
+ Fix a few minor issues detect by shellcheck in bazel-tool.
[1] https://fuchsia-review.googlesource.com/c/fuchsia/+/1220865
Change-Id: Icac4649231548ec6fb5eb586ad66b07e7d8892fb
Change diff
diff --git a/scripts/bazel_tool.py b/build/bazel/scripts/bazel_tool.py
similarity index 99%
rename from scripts/bazel_tool.py
rename to build/bazel/scripts/bazel_tool.py
index 50939bb..bde3f9e 100755
--- a/scripts/bazel_tool.py
+++ b/build/bazel/scripts/bazel_tool.py
@@ -120,7 +120,7 @@
"""Implement the set_gn_targets command."""
# Lazy import of workspace_utils.py and gn_targets_utils.py
- sys.path.insert(0, f"{args.fuchsia_dir}/build/bazel/scripts")
+ sys.path.insert(0, str(Path(__file__).parent))
import gn_targets_utils
import workspace_utils
diff --git a/scripts/OWNERS b/scripts/OWNERS
index 2a8b214..f8c0926 100644
--- a/scripts/OWNERS
+++ b/scripts/OWNERS
@@ -5,8 +5,6 @@
# shell- and fx-related utilities.
per-file fuchsia-vendored-python*,fx,fx-*,hermetic-env = crj...@google.com
-per-file bazel_tool.py = file://build/OWNERS
-
# FIDL-related scripts.
per-file generate-fidl-* = file://tools/fidl/OWNERS
diff --git a/tools/devshell/bazel-tool b/tools/devshell/bazel-tool
index 59d3451..8bbdb74 100755
--- a/tools/devshell/bazel-tool
+++ b/tools/devshell/bazel-tool
@@ -13,17 +13,19 @@
## queries easily. Use --help for details.
##
+# shellcheck source=/dev/null
source "$(cd "$(dirname "${BASH_SOURCE[0]}")" >/dev/null 2>&1 && pwd)"/lib/vars.sh || exit $?
fx-config-read
if [[ ! -d "${FUCHSIA_BUILD_DIR}" ]]; then
- fx-error "No Fuchsia build directory, please run `fx set` or `fx gen`."
+ fx-error "No Fuchsia build directory, please run 'fx set' or 'fx gen'."
fi
+# shellcheck source=/dev/null
source "$(cd "$(dirname "${BASH_SOURCE[0]}")" >/dev/null 2>&1 && pwd)"/lib/bazel_utils.sh || exit $?
fx-update-bazel-workspace
-"${PREBUILT_PYTHON3}" "${FUCHSIA_DIR}"/scripts/bazel_tool.py \
+"${PREBUILT_PYTHON3}" "${FUCHSIA_DIR}"/build/bazel/scripts/bazel_tool.py \
--workspace="$(fx-get-bazel-workspace)" \
--fuchsia-dir="${FUCHSIA_DIR}" \
--build-dir="${FUCHSIA_BUILD_DIR}" \
Change information
Files:
- R build/bazel/scripts/bazel_tool.py
- M scripts/OWNERS
- M tools/devshell/bazel-tool
Change size: S
Delta: 3 files changed, 5 insertions(+), 5 deletions(-)
Related details
Attention is currently required from:
- Aaron Wood
- Clayton Wilkinson
- David Fang
- Jay Zhuang
- Owners Override
Submit Requirements:
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/98038c4fbbbb55021f2e64bf46d808b4b8e14e99-HTML%40fuchsia-review.googlesource.com.
'Aaron Wood (Gerrit)' via owners-override
Mar 10, 2025, 1:54:16 PMMar 10
to David Turner, GI Try Builder, Clayton Wilkinson, Jay Zhuang, David Fang, Owners Override, CQ Bot
Attention needed from Clayton Wilkinson, David Fang, David Turner, Jay Zhuang and Owners Override
Aaron Wood voted Code-Review+2![]( "Open in Gerrit")
Attention is currently required from:
- Clayton Wilkinson
- David Fang
- David Turner
- Jay Zhuang
- Owners Override
Submit Requirements:
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/679a2561f2cffa9fc0ac2d765d28c8193ff16e17-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'David Fang (Gerrit)' via owners-override
Mar 10, 2025, 1:54:23 PMMar 10
to David Turner, Aaron Wood, GI Try Builder, Clayton Wilkinson, Jay Zhuang, Owners Override, CQ Bot
Attention needed from Clayton Wilkinson, David Turner, Jay Zhuang and Owners Override
David Fang voted Code-Review+2![]( "Open in Gerrit")
| Code-Review | +2 |
Related details
Attention is currently required from:
- Clayton Wilkinson
- David Turner
- Jay Zhuang
- Owners Override
Submit Requirements:
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/235e9bf9addfd1c84e0399cb465e3df7bdfac2e4-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'Clayton Wilkinson (Gerrit)' via owners-override
Mar 10, 2025, 2:03:27 PMMar 10
to David Turner, David Fang, Aaron Wood, GI Try Builder, Jay Zhuang, Owners Override, CQ Bot
Attention needed from David Turner, Jay Zhuang and Owners Override
Clayton Wilkinson voted Code-Review+2![]( "Open in Gerrit")
| Code-Review | +2 |
Related details
Attention is currently required from:
- David Turner
- Jay Zhuang
- Owners Override
Submit Requirements:
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/fddd3b8ee6445bf27caa9467fcc1048c2e12d04c-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'Jay Zhuang (Gerrit)' via owners-override
Mar 12, 2025, 7:28:04 PMMar 12
to David Turner, Android Build Huckle Nudge, Clayton Wilkinson, David Fang, Aaron Wood, GI Try Builder, Owners Override, CQ Bot
Attention needed from David Turner and Owners Override
Jay Zhuang voted Code-Review+2![]( "Open in Gerrit")
| Code-Review | +2 |
Related details
Attention is currently required from:
- David Turner
- Owners Override
Submit Requirements:
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/c1b35e424173cf51b35203075635794f6b7161a3-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'David Turner (Gerrit)' via owners-override
Mar 17, 2025, 4:22:42 AMMar 17
to James Robinson, Jay Zhuang, Android Build Huckle Nudge, Clayton Wilkinson, David Fang, Aaron Wood, GI Try Builder, Owners Override, CQ Bot
Attention needed from James Robinson and Owners Override
David Turner voted and added 1 comment![]( "Open in Gerrit")
Votes added by David Turner
| Fuchsia-Auto-Submit | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 1 (Latest):
David Turner . resolved
Adding jamesr@ explicitly to get an owners-override@ approval.
Related details
Attention is currently required from:
- James Robinson
- Owners Override
Submit Requirements:
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/1ca81e2aa8f441c51ef1eec3caa9f069c8143f33-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'James Robinson (Gerrit)' via owners-override
Mar 17, 2025, 3:31:11 PMMar 17
to David Turner, Jay Zhuang, Android Build Huckle Nudge, Clayton Wilkinson, David Fang, Aaron Wood, GI Try Builder, Owners Override, CQ Bot
Attention needed from David Turner and Owners Override
James Robinson voted Code-Review+2![]( "Open in Gerrit")
Attention is currently required from:
- David Turner
- Owners Override
Submit Requirements:
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/02a354086d6e76b73ac98522ecb9d70f6d62d8b3-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'James Robinson (Gerrit)' via owners-override
Mar 17, 2025, 3:31:14 PMMar 17
to David Turner, Jay Zhuang, Android Build Huckle Nudge, Clayton Wilkinson, David Fang, Aaron Wood, GI Try Builder, Owners Override, CQ Bot
Attention needed from David Turner and Owners Override
James Robinson voted Owners-Override+1![]( "Open in Gerrit")
| Owners-Override | +1 |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/9354d644fbae33afd1fb5da93b983887c3cfb963-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'CQ Bot (Gerrit)' via owners-override
Mar 17, 2025, 4:17:53 PMMar 17
to David Turner, Auto-Submit, James Robinson, Jay Zhuang, Android Build Huckle Nudge, Clayton Wilkinson, David Fang, Aaron Wood, GI Try Builder, Owners Override
CQ Bot submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[fx][bazel-tool] Move bazel_tool.py to //build/bazel/scripts/
As discussed previously in [1], this is a better logical location
for this script.
+ Fix a few minor issues detect by shellcheck in bazel-tool.
[1] https://fuchsia-review.googlesource.com/c/fuchsia/+/1220865
Change-Id: Icac4649231548ec6fb5eb586ad66b07e7d8892fb
Commit-Queue: Auto-Submit <auto-...@fuchsia-infra.iam.gserviceaccount.com>
Reviewed-by: David Fang <fan...@google.com>
Fuchsia-Auto-Submit: David Turner <di...@google.com>
Reviewed-by: Jay Zhuang <jayz...@google.com>
Reviewed-by: James Robinson <jam...@google.com>
Owners-Override: James Robinson <jam...@google.com>
Reviewed-by: Aaron Wood <aaro...@google.com>
Reviewed-by: Clayton Wilkinson <wilkin...@google.com>
Files:
- R build/bazel/scripts/bazel_tool.py
- M scripts/OWNERS
- M tools/devshell/bazel-tool
Change size: S
Delta: 3 files changed, 5 insertions(+), 5 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +2 by David Fang, +2 by James Robinson, +2 by Aaron Wood, +2 by Jay Zhuang, +2 by Clayton Wilkinson
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/f7c0e2619afe2f0261a1a082a084cc0d34a0ebbe-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'GI Roller (Gerrit)' via owners-override
Mar 17, 2025, 4:20:33 PMMar 17
to David Turner, CQ Bot, Auto-Submit, James Robinson, Jay Zhuang, Android Build Huckle Nudge, Clayton Wilkinson, David Fang, Aaron Wood, GI Try Builder, Owners Override
Message from GI Roller![]( "Open in Gerrit")
Change has been successfully rolled: http://go/roll-cl/19186a6070e06a384dc5ac56524f3e92d83ad78e
Related details
Attention set is empty
Submit Requirements:
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/5eaa068bc86ee1218d671226a2a4efb6b2430cd0-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
Reply all
Reply to author
Forward
0 new messages