[L] Change in fuchsia/fuchsia[main]: [lacewing] Run async on the same event loop everywhere
0 views
Skip to first unread message
'Charles Celerier (Gerrit)' via owners-override
2:55 PM (2 hours ago) 2:55 PM
to Owners Override
Attention needed from Owners Override
Charles Celerier has uploaded the change for review![]( "Open in Gerrit")
Charles Celerier would like Owners Override to review this change.
Commit message
[lacewing] Run async on the same event loop everywhere
Instead of creating a new loop every time a test needs to run a
coroutine, this change runs all the coroutines on the same global event
loop. This is a preparatory change for spreading the use of async to all
the tests.
Depends-on: turquoise-internal:I526098579b1e6444874fb880e0c098efa6ba2288
Change-Id: If23a4f15ce3c2931ce226f4a25ea9a152cc9c5f9
Change diff
Change information
Files:
- M docs/development/tools/fuchsia-controller/async-python.md
- M scripts/lib/async_utils/BUILD.gn
- M scripts/lib/async_utils/tests/async_utils_test.py
- M scripts/lib/ffx_cmd/BUILD.gn
- M scripts/lib/ffx_cmd/e2e_tests/test_ffx_inspect.py
- M scripts/lib/ffx_cmd/lib.py
- M scripts/lib/ffx_cmd/tests/__init__.py
- M scripts/lib/ffx_cmd/tests/test_ffx_cmd.py
- M scripts/lib/fx_cmd/lib.py
- M scripts/lib/fx_cmd/tests/test_fx_cmd.py
- M src/connectivity/network/tests/benchmarks/iperf/BUILD.gn
- M src/connectivity/network/tests/benchmarks/iperf/netstack_iperf_test.py
- M src/connectivity/wlan/tests/wlancfg/BUILD.gn
- M src/connectivity/wlan/tests/wlancfg/RegulatoryRecoveryTest.py
- M src/connectivity/wlan/tests/wlanix/ApfTest.py
- M src/connectivity/wlan/tests/wlanix/BUILD.gn
- M src/connectivity/wlan/tests/wlanix/IfaceCorrectnessAndConsistencyTest.py
- M src/connectivity/wlan/tests/wlanix/IfaceLifecycleTest.py
- M src/connectivity/wlan/tests/wlanix/WifiChipCorrectnessAndConsistencyTest.py
- M src/connectivity/wlan/tests/wlanix/WifiChipExistenceTest.py
- M src/connectivity/wlan/tests/wlanix/wlanix_testing/BUILD.gn
- M src/connectivity/wlan/tests/wlanix/wlanix_testing/base_test.py
- M src/developer/ffx/lib/fuchsia-controller/BUILD.gn
- M src/developer/ffx/lib/fuchsia-controller/python/fidl/_client.py
- M src/developer/ffx/lib/fuchsia-controller/python/fidl/_ipc.py
- D src/developer/ffx/lib/fuchsia-controller/python/fidl/tests/BUILD.gn
- D src/developer/ffx/lib/fuchsia-controller/python/fidl/tests/queue_wrapper_test.py
- M src/developer/ffx/lib/fuchsia-controller/python/fuchsia_controller_py/wrappers.py
- M src/storage/blackout/host/tests/BUILD.gn
- M src/storage/blackout/host/tests/blackout.py
- M src/testing/end_to_end/honeydew/honeydew/affordances/connectivity/bluetooth/bluetooth_common/bluetooth_common_using_fc.py
- M src/testing/end_to_end/honeydew/honeydew/affordances/connectivity/bluetooth/bluetooth_common/tests/unit_tests/bluetooth_common_using_fc_test.py
- M src/testing/end_to_end/honeydew/honeydew/affordances/rtc/rtc_using_fc.py
- M src/testing/end_to_end/honeydew/honeydew/affordances/rtc/tests/unit_tests/rtc_using_fc_test.py
- M src/testing/end_to_end/honeydew/honeydew/affordances/ui/user_input/user_input_using_fc.py
- M src/testing/end_to_end/honeydew/honeydew/affordances/virtual_audio/audio_using_fuchsia_controller.py
- M src/testing/end_to_end/honeydew/honeydew/affordances/virtual_audio/tests/functional_tests/BUILD.gn
- M src/testing/end_to_end/honeydew/honeydew/affordances/virtual_audio/tests/functional_tests/test_audio_inject_record.py
- M src/testing/end_to_end/honeydew/honeydew/fuchsia_device/fuchsia_device_impl.py
- M tools/devshell/python/system-status/main.py
- M tools/devshell/python/system-status/tests/test_system_status.py
- M tools/fidl/fidlgen_python/tests/test_client.py
Change size: L
Delta: 42 files changed, 359 insertions(+), 539 deletions(-)
Related details
Attention is currently required from:
- Owners Override
Submit Requirements:
Code-Owners
Code-Review
Dependencies-Satisfied
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/a45c012c0b43411333abd91016c77dac5b8ff2a2-HTML%40fuchsia-review.googlesource.com.
'Charles Celerier (Gerrit)' via owners-override
2:57 PM (2 hours ago) 2:57 PM
to Owners Override, Andrew Davies, GI Try Builder, CQ Bot
Attention needed from Owners Override
Charles Celerier added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 14 (Latest):
Charles Celerier . unresolved
Context for Owners Override: This change will be accompanied by an announcement to encourage e2e test writers to reach for `fuchsia_async_extension.get_loop().run_until_complete` instead of `asyncio.run`. Later changes to spread usage of async in e2e tests will eliminate needing to interface with `fuchsia_async_extension.get_loop().run_until_complete` at all. This change is necessary to ensure a smooth migration to that point because otherwise moving some affordances to a new event loop can cause unexpected problems.
Related details
Attention is currently required from:
- Owners Override
Submit Requirements:
Code-Owners
Code-Review
Dependencies-Satisfied
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/6f2f17fee5705ac8fed15ccb99e43a278e2910db-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'Charles Celerier (Gerrit)' via owners-override
3:12 PM (1 hour ago) 3:12 PM
to Owners Override, Andrew Davies, GI Try Builder, CQ Bot
Attention needed from Owners Override
Charles Celerier voted Fuchsia-Auto-Submit+1![]( "Open in Gerrit")
| Fuchsia-Auto-Submit | +1 |
Related details
Attention is currently required from:
- Owners Override
Submit Requirements:
Code-Owners
Code-Review
Dependencies-Satisfied
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/33099c6945126b6218392b2cc2272735260b50ea-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
Reply all
Reply to author
Forward
0 new messages