[L] Change in fuchsia/fuchsia[main]: [fx-env] Remove fd alias
0 views
Skip to first unread message
'Marc Khouri (Gerrit)' via owners-override
Jun 2, 2026, 3:26:11 PM (2 days ago) Jun 2
to Owners Override
Attention needed from Owners Override
Marc Khouri has uploaded the change for review![]( "Open in Gerrit")
Marc Khouri would like Owners Override to review this change.
Commit message
[fx-env] Remove fd alias
The `fd` alias conflicts with the fd utility
(https://github.com/sharkdp/fd), which is very commonly used as a faster
replacement for `find`.
Change-Id: Id23237b7322de7605cc1d56daab258b44e0ba891
Change diff
Change information
Files:
- D scripts/fd.py
- M scripts/fx-env.sh
Change size: L
Delta: 2 files changed, 0 insertions(+), 328 deletions(-)
Related details
Attention is currently required from:
- Owners Override
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/b3590126af70529fa5d4e3205e9743aa103289f7-HTML%40fuchsia-review.googlesource.com.
'Marc Khouri (Gerrit)' via owners-override
Jun 2, 2026, 3:26:18 PM (2 days ago) Jun 2
to Owners Override
Attention needed from Owners Override
Marc Khouri voted and added 1 comment![]( "Open in Gerrit")
Votes added by Marc Khouri
| Commit-Queue | +1 |
| Fuchsia-Auto-Submit | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 1:
Marc Khouri . unresolved
Marc KhouriI've started a poll in the Fuchsia chat room, so far it seems like no one uses this and it's OK to remove: https://chat.google.com/room/AAAAqFnv39c/faTUCCOSqRo
I'm not sure how to be certain that no one uses this, because we don't have metrics for these random scripts, but if someone complains, it would be easy to revert!
Related details
Attention is currently required from:
- Owners Override
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/b3590126af70529fa5d4e3205e9743aa103289f7-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'Adam Barth (Gerrit)' via owners-override
Jun 2, 2026, 3:29:28 PM (2 days ago) Jun 2
to Marc Khouri, Christopher Johnson, fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com, Owners Override
Attention needed from Christopher Johnson, Marc Khouri and Owners Override
Adam Barth added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Adam Barth . resolved
Looks like crjohsn is an appropriate reviewer: https://cs.opensource.google/fuchsia/fuchsia/+/main:scripts/OWNERS;l=6
Related details
Attention is currently required from:
- Christopher Johnson
- Marc Khouri
- Owners Override
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/7d0035f4d08e4370178cd7e08792e7868be102d0-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'Marc Khouri (Gerrit)' via owners-override
Jun 2, 2026, 3:36:42 PM (2 days ago) Jun 2
to Christopher Johnson, Adam Barth, fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com, Owners Override
Attention needed from Adam Barth, Christopher Johnson and Owners Override
Marc Khouri added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Adam Barth . resolved
Looks like crjohsn is an appropriate reviewer: https://cs.opensource.google/fuchsia/fuchsia/+/main:scripts/OWNERS;l=6
Marc Khouri
The scripts/fd.py doesn't have an owner (intentionally, according to that file) -- but happy to get crjohns's review on fx-env first
Related details
Attention is currently required from:
- Adam Barth
- Christopher Johnson
- Owners Override
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/da72afa378e27bbf02b8fd7f00a3238449c11bee-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'Aaron Wood (Gerrit)' via owners-override
Jun 2, 2026, 3:58:36 PM (2 days ago) Jun 2
to Marc Khouri, Christopher Johnson, Adam Barth, fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com, Owners Override
Attention needed from Adam Barth, Christopher Johnson, Marc Khouri and Owners Override
Aaron Wood voted and added 1 comment![]( "Open in Gerrit")
Votes added by Aaron Wood
| Code-Review | -1 |
1 comment
Patchset-level comments
Aaron Wood . unresolved
I may be in the minority, but I use this heavily.
Related details
Attention is currently required from:
- Adam Barth
- Christopher Johnson
- Marc Khouri
- Owners Override
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/62892a67671e8bc8ad69b718738b78cc62ffdb64-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'Marc Khouri (Gerrit)' via owners-override
Jun 2, 2026, 4:28:21 PM (2 days ago) Jun 2
to Owners Override, Adam Barth
Attention needed from Aaron Wood and Christopher Johnson
Marc Khouri has uploaded the change for review![]( "Open in Gerrit")
Marc Khouri removed Owners Override and Adam Barth from reviewers of this change.
Commit message
[fx-env] Remove fd alias
The `fd` alias conflicts with the fd utility
(https://github.com/sharkdp/fd), which is very commonly used as a faster
replacement for `find`.
Change-Id: Id23237b7322de7605cc1d56daab258b44e0ba891
Change diff
Change information
Files:
- D scripts/fd.py
- M scripts/fx-env.sh
Change size: L
Delta: 2 files changed, 0 insertions(+), 328 deletions(-)
Related details
Attention is currently required from:
- Aaron Wood
- Christopher Johnson
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/14a971e19002827d945e2cd99db96a99859a8d50-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
Reply all
Reply to author
Forward
0 new messages