[L] Change in fuchsia/fuchsia[main]: [toolbox] Expose tool protocols to toolbox

0 views
Skip to first unread message

'Bruno Dal Bo (Gerrit)' via owners-override

unread,
Dec 3, 2025, 3:31:35 PM (8 days ago) Dec 3
to Owners Override
Attention needed from Owners Override

Bruno Dal Bo has uploaded the change for review

Bruno Dal Bo would like Owners Override to review this change.

Commit message

[toolbox] Expose tool protocols to toolbox

Gather all the protocols currently routed from into the SSH namespace
and make them available to the toolbox instead, so we can have a single
namespace that concentrates the tools available for shells.

As we're doing this, adopt the toolbox pattern of moving all the offers
to the toolbox dictionary closer to where the components are inserted
in the realm.
Bug: 416063207
Bug: 447668986
Change-Id: I3a86bba2b15165569aa8ae93c3b5fcdd6a6a6964

Change diff


Change information

Files:
  • M src/camera/meta/camera.core_shard.cml
  • M src/connectivity/bluetooth/core/bt-init/meta/bt-init.core_shard.cml
  • M src/connectivity/bluetooth/profiles/bt-a2dp/meta/bt-a2dp-common.core_shard.cml
  • M src/connectivity/bluetooth/profiles/bt-avrcp/meta/bt-avrcp.core_shard.cml
  • M src/connectivity/bluetooth/profiles/bt-device-id/meta/bt-device-id.core_shard.cml
  • M src/connectivity/bluetooth/profiles/bt-hfp-audio-gateway/meta/bt-hfp-audio-gateway.core_shard.cml
  • M src/connectivity/bluetooth/profiles/bt-hfp-hands-free/meta/bt-hfp-hands-free.core_shard.cml
  • M src/connectivity/bluetooth/profiles/bt-map-mce/meta/bt-map-mce.core_shard.cml
  • M src/connectivity/bluetooth/testing/bt-affordances/meta/bt-affordances-server.core_shard.cml
  • M src/connectivity/bluetooth/testing/pandora/bt-pandora-server/meta/bt-pandora-server.core_shard.cml
  • M src/connectivity/bluetooth/tools/bt-rootcanal/meta/bt-rootcanal.core_shard.cml
  • M src/connectivity/bluetooth/tools/bt-snoop/meta/bt-snoop-eager.core_shard.cml
  • M src/connectivity/bluetooth/tools/bt-snoop/meta/bt-snoop.core_shard.cml
  • M src/connectivity/location/emergency/meta/emergency.core_shard.cml
  • M src/connectivity/lowpan/drivers/lowpan-ot-driver/meta/lowpan-ot-driver.core_shard.cml
  • M src/connectivity/lowpan/service/meta/lowpanservice.core_shard.cml
  • M src/connectivity/network/tun/network-tun/meta/network-tun.core_shard.cml
  • M src/connectivity/weave/meta/weavestack.core_shard.cml.template
  • M src/connectivity/wlan/wlancfg/meta/wlancfg.core_shard.cml
  • M src/connectivity/wlan/wlandevicemonitor/meta/wlandevicemonitor.core_shard.cml
  • M src/connectivity/wlan/wlanix/meta/wlanix.core_shard.cml
  • M src/developer/build_info/meta/build_info.core_shard.cml
  • M src/developer/forensics/forensics.core_shard.cml
  • M src/developer/memory/monitor/meta/memory_monitor.core_shard.cml
  • M src/developer/memory/pressure_signaler/meta/memory_pressure_signaler.core_shard.cml
  • M src/developer/process_explorer/meta/process_explorer.core_shard.cml
  • M src/developer/remote-control/meta/remote-control.core_shard.cml
  • M src/developer/toolbox/meta/toolbox.cml
  • M src/developer/toolbox/meta/toolbox.core_shard.cml
  • M src/developer/toolbox/meta/toolbox.root_shard.cml
  • M src/devices/bin/driver_framework/meta/driver_framework.bootstrap_shard.cml
  • M src/devices/radar/bin/radar-proxy/meta/radar-proxy-with-injector.core_shard.cml
  • M src/devices/radar/bin/radar-proxy/meta/radar-proxy-without-injector.core_shard.cml
  • M src/factory/factory_store_providers/meta/factory_store_providers.core_shard.cml
  • M src/media/audio/audio_core/meta/audio_core.core_shard.cml
  • M src/media/audio/services/device_registry/meta/audio_device_registry.core_shard.cml
  • M src/media/audio/services/ffxdaemon/meta/audio_ffx_daemon.core_shard.cml
  • M src/media/codec/factory/meta/codec_factory.core_shard.cml
  • M src/media/sessions/meta/mediasession.core_shard.cml
  • M src/media/sounds/soundplayer/meta/soundplayer.core_shard.cml
  • M src/performance/memory/sampler/meta/memory_sampler.core_shard.cml
  • M src/performance/trace_manager/meta/trace_manager.core_shard.cml
  • M src/power/battery-manager/meta/battery_manager.core_shard.cml
  • M src/power/meta/power-framework.shard.cml
  • M src/power/system-activity-governor-controller/meta/system-activity-governor-controller.core_shard.cml
  • M src/recovery/factory_reset/meta/factory_reset.core_shard.cml
  • M src/security/policy/component_manager_policy.json5
  • M src/security/policy/component_manager_policy_eng.json5
  • M src/security/policy/component_manager_policy_userdebug.json5
  • M src/session/bin/session_manager/meta/session_manager.core_shard.cml
  • M src/settings/service/meta/setui_service_base.core_shard.cml
  • M src/storage/fs_realm/meta/fs_realm.core_shard.cml
  • M src/storage/fshost/meta/fshost.bootstrap_shard.cml
  • M src/sys/core/meta/core.cml
  • M src/sys/core/meta/core.root_shard.cml
  • M src/sys/fuzzing/meta/fuzzing.core-shard.cml
  • M src/sys/pkg/bin/pkg-cache/meta/pkg-cache.bootstrap_shard.cml
  • M src/sys/pkg/bin/system-updater/meta/system_updater.core_shard.cml
  • M src/sys/process-resolver/meta/process_resolver.base-resolver.core_shard.cml
  • M src/sys/process-resolver/meta/process_resolver.pkg-resolver.core_shard.cml
  • M src/sys/root/root.cml
  • M src/sys/test_manager/meta/test_manager.bootstrap_shard.cml
  • M src/sys/test_manager/meta/test_manager.core_shard.cml
  • M src/sysmem/server/meta/sysmem.bootstrap_shard.cml
  • M src/testing/sl4f/meta/sl4f_base.core_shard.cml
  • M src/ui/bin/brightness_manager/meta/brightness_manager.core_shard.cml
  • M src/ui/meta/ui.core_shard.cml
  • M src/virtualization/bin/guest_manager/meta/debian_guest_manager.core_shard.cml
  • M src/virtualization/bin/guest_manager/meta/termina_guest_manager.core_shard.cml
  • M src/virtualization/bin/guest_manager/meta/zircon_guest_manager.core_shard.cml
  • M src/zircon/bin/role_manager/meta/role_manager.bootstrap_shard.cml
Change size: L
Delta: 71 files changed, 897 insertions(+), 80 deletions(-)
Open in Gerrit

Related details

Attention is currently required from:
  • Owners Override
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I3a86bba2b15165569aa8ae93c3b5fcdd6a6a6964
Gerrit-Change-Number: 1427114
Gerrit-PatchSet: 9
Gerrit-Owner: Bruno Dal Bo <bruno...@google.com>
Gerrit-Reviewer: Bruno Dal Bo <bruno...@google.com>
Gerrit-Reviewer: Claire Gonyeo <cgo...@google.com>
Gerrit-Reviewer: Eric Stone <ecs...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Reviewer: Steven Grady <slg...@google.com>
Gerrit-Reviewer: Suraj Malhotra <surajm...@google.com>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/d861a89a281318257e0d62606bcc39d53fe78968-HTML%40fuchsia-review.googlesource.com.
unsatisfied_requirement
satisfied_requirement
open
diffy

'Bruno Dal Bo (Gerrit)' via owners-override

unread,
Dec 3, 2025, 3:31:40 PM (8 days ago) Dec 3
to Owners Override, Eric Stone, Claire Gonyeo, Suraj Malhotra, Steven Grady, GI Try Builder, CQ Bot
Attention needed from Owners Override

Bruno Dal Bo voted and added 1 comment

Votes added by Bruno Dal Bo

Fuchsia-Auto-Submit+1

1 comment

Patchset-level comments
File-level comment, Patchset 9 (Latest):
Bruno Dal Bo . resolved

Adding owners override for the rest of the mechanical changes

Open in Gerrit

Related details

Attention is currently required from:
  • Owners Override
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I3a86bba2b15165569aa8ae93c3b5fcdd6a6a6964
Gerrit-Change-Number: 1427114
Gerrit-PatchSet: 9
Gerrit-Owner: Bruno Dal Bo <bruno...@google.com>
Gerrit-Reviewer: Bruno Dal Bo <bruno...@google.com>
Gerrit-Reviewer: Claire Gonyeo <cgo...@google.com>
Gerrit-Reviewer: Eric Stone <ecs...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Reviewer: Steven Grady <slg...@google.com>
Gerrit-Reviewer: Suraj Malhotra <surajm...@google.com>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Comment-Date: Wed, 03 Dec 2025 20:31:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/d861a89a281318257e0d62606bcc39d53fe78968-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
unsatisfied_requirement
satisfied_requirement
open
diffy

'Adam Barth (Gerrit)' via owners-override

unread,
Dec 3, 2025, 3:43:23 PM (8 days ago) Dec 3
to Bruno Dal Bo, Owners Override, Eric Stone, Claire Gonyeo, Suraj Malhotra, Steven Grady, GI Try Builder, CQ Bot
Attention needed from Bruno Dal Bo and Owners Override

Adam Barth voted Owners-Override+1

Owners-Override+1
Open in Gerrit

Related details

Attention is currently required from:
  • Bruno Dal Bo
  • Owners Override
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I3a86bba2b15165569aa8ae93c3b5fcdd6a6a6964
Gerrit-Change-Number: 1427114
Gerrit-PatchSet: 9
Gerrit-Owner: Bruno Dal Bo <bruno...@google.com>
Gerrit-Reviewer: Adam Barth <aba...@google.com>
Gerrit-Reviewer: Bruno Dal Bo <bruno...@google.com>
Gerrit-Reviewer: Claire Gonyeo <cgo...@google.com>
Gerrit-Reviewer: Eric Stone <ecs...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Reviewer: Steven Grady <slg...@google.com>
Gerrit-Reviewer: Suraj Malhotra <surajm...@google.com>
Gerrit-Attention: Bruno Dal Bo <bruno...@google.com>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Comment-Date: Wed, 03 Dec 2025 20:43:15 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/a5ffbb85aef2dca1ecfe7b221332c75e2e785653-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy

'CQ Bot (Gerrit)' via owners-override

unread,
Dec 3, 2025, 4:55:14 PM (8 days ago) Dec 3
to Bruno Dal Bo, Adam Barth, Owners Override, Eric Stone, Claire Gonyeo, Suraj Malhotra, Steven Grady, GI Try Builder

CQ Bot submitted the change

Change information

Commit message:
[toolbox] Expose tool protocols to toolbox

Gather all the protocols currently routed from into the SSH namespace
and make them available to the toolbox instead, so we can have a single
namespace that concentrates the tools available for shells.

As we're doing this, adopt the toolbox pattern of moving all the offers
to the toolbox dictionary closer to where the components are inserted
in the realm.
Bug: 416063207
Bug: 447668986
Change-Id: I3a86bba2b15165569aa8ae93c3b5fcdd6a6a6964
Reviewed-by: Eric Stone <ecs...@google.com>
Reviewed-by: Suraj Malhotra <surajm...@google.com>
Reviewed-by: Steven Grady <slg...@google.com>
Fuchsia-Auto-Submit: Bruno Dal Bo <bruno...@google.com>
Owners-Override: Adam Barth <aba...@google.com>
Reviewed-by: Claire Gonyeo <cgo...@google.com>
Commit-Queue: Bruno Dal Bo <bruno...@google.com>
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +2 by Suraj Malhotra, +2 by Steven Grady, +2 by Eric Stone, +2 by Claire Gonyeo
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I3a86bba2b15165569aa8ae93c3b5fcdd6a6a6964
Gerrit-Change-Number: 1427114
Gerrit-PatchSet: 10
Gerrit-Owner: Bruno Dal Bo <bruno...@google.com>
Gerrit-Reviewer: Adam Barth <aba...@google.com>
Gerrit-Reviewer: Bruno Dal Bo <bruno...@google.com>
Gerrit-Reviewer: Claire Gonyeo <cgo...@google.com>
Gerrit-Reviewer: Eric Stone <ecs...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Reviewer: Steven Grady <slg...@google.com>
Gerrit-Reviewer: Suraj Malhotra <surajm...@google.com>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/2a134cfb26ecf2f5c297099f91c820aaf6754616-HTML%40fuchsia-review.googlesource.com.
open
diffy
satisfied_requirement

'GI Roller (Gerrit)' via owners-override

unread,
Dec 3, 2025, 4:59:15 PM (8 days ago) Dec 3
to Bruno Dal Bo, CQ Bot, Adam Barth, Owners Override, Eric Stone, Claire Gonyeo, Suraj Malhotra, Steven Grady, GI Try Builder

Message from GI Roller

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I3a86bba2b15165569aa8ae93c3b5fcdd6a6a6964
Gerrit-Change-Number: 1427114
Gerrit-PatchSet: 10
Gerrit-Owner: Bruno Dal Bo <bruno...@google.com>
Gerrit-Reviewer: Adam Barth <aba...@google.com>
Gerrit-Reviewer: Bruno Dal Bo <bruno...@google.com>
Gerrit-Reviewer: Claire Gonyeo <cgo...@google.com>
Gerrit-Reviewer: Eric Stone <ecs...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Reviewer: Steven Grady <slg...@google.com>
Gerrit-Reviewer: Suraj Malhotra <surajm...@google.com>
Gerrit-Comment-Date: Wed, 03 Dec 2025 21:59:12 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/0dd1cacc6c6844aa48a6cb31b1cce1a3565ab16d-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages