[L] Change in fuchsia/fuchsia[main]: [rust] enable or_fun_call Clippy lint on all code
0 views
Skip to first unread message
'Colin Nelson (Gerrit)' via owners-override
Nov 21, 2025, 5:06:32 PMNov 21
to Owners Override
Attention needed from Owners Override
Colin Nelson has uploaded the change for review![]( "Open in Gerrit")
Colin Nelson would like Owners Override to review this change.
Commit message
[rust] enable or_fun_call Clippy lint on all code
Test: ran fx build and fx test
Fixed: b/462736347
NO_IFTTT=mechanical change that does not need to be reflected in the C++ code
Depends-on: turquoise-internal:I42ace3241271e321d4a23a49b69e4f876a6a636c
Change-Id: Ib8e7578749b6db9ea5d53aade4a1c93c6a6a6964
Change diff
Change information
Files:
- M build/components/generate_test_component_script_and_config.rs
- M build/config/rust/lints/BUILD.bazel
- M build/config/rust/lints/BUILD.gn
- M examples/diagnostics/inspect/codelab/rust/part_5/tests/integration_test.rs
- M examples/drivers/power/cpp/realm_test.rs
- M examples/drivers/power/rust/realm_test.rs
- M sdk/lib/driver_test_realm/realm_builder/rust/src/builder.rs
- M src/connectivity/bluetooth/lib/bt-obex/src/server/handler.rs
- M src/connectivity/bluetooth/profiles/bt-a2dp/src/media/player_sink.rs
- M src/connectivity/bluetooth/profiles/bt-fastpair-provider/src/pairing.rs
- M src/connectivity/bluetooth/profiles/bt-fastpair-provider/src/provider.rs
- M src/connectivity/bluetooth/profiles/bt-fastpair-provider/src/types/keys.rs
- M src/connectivity/bluetooth/profiles/bt-fastpair-provider/src/types/mod.rs
- M src/connectivity/bluetooth/testing/bt-test-harness/src/core_realm.rs
- M src/connectivity/bluetooth/tests/bt-host-integration/src/lib.rs
- M src/connectivity/network/dns/src/main.rs
- M src/connectivity/network/net-cli/src/lib.rs
- M src/connectivity/network/netlink/src/protocol_family.rs
- M src/connectivity/network/netstack3/core/udp/src/base.rs
- M src/connectivity/network/stack-migration/src/main.rs
- M src/connectivity/network/testing/netemul/configurable-netstack/src/main.rs
- M src/connectivity/network/testing/netemul/rust/src/lib.rs
- M src/connectivity/network/tests/integration/forwarding/src/lib.rs
- M src/connectivity/policy/netcfg/src/lib.rs
- M src/connectivity/wlan/lib/mlme/fullmac/src/device.rs
- M src/connectivity/wlan/testing/hw-sim/test/verify_wlan_inspect/src/lib.rs
- M src/connectivity/wlan/tests/helpers/realm-factory/src/main.rs
- M src/developer/ffx/config/src/mapping/home.rs
- M src/developer/ffx/playground/src/parser.rs
- M src/developer/hw_info/shell.rs
- M src/developer/sys_info/shell.rs
- M src/devices/interconnect/drivers/interconnect/integration_test.rs
- M src/devices/testing/realm-factory/src/main.rs
- M src/devices/tests/v2/compat-node-group/test.rs
- M src/devices/tests/v2/dynamic_offers/test.rs
- M src/devices/tests/v2/inspect/test.rs
- M src/devices/tests/v2/interop/test.rs
- M src/devices/tests/v2/reload-driver/reloadtest_tools.rs
- M src/devices/tests/v2/runtime-dispatcher/test.rs
- M src/devices/tests/v2/runtime-protocol/test.rs
- M src/diagnostics/archivist/tests/integration/realm_factory/src/realm_factory.rs
- M src/diagnostics/detect/integration/realm_factory/src/realm_factory.rs
- M src/diagnostics/triage/src/test/integration.rs
- M src/diagnostics/validator/inspect/src/data.rs
- M src/diagnostics/validator/inspect/src/data/fetch.rs
- M src/diagnostics/validator/inspect/src/data/scanner.rs
- M src/diagnostics/validator/inspect/src/metrics.rs
- M src/diagnostics/validator/inspect/src/puppet.rs
- M src/graphics/display/lib/rust/display-utils/src/controller.rs
- M src/lib/fuchsia-component-test/tests/scoped_instance/realm.rs
- M src/media/audio/drivers/configurator/src/codec.rs
- M src/media/audio/drivers/configurator/src/dai.rs
- M src/media/audio/drivers/configurator/src/default.rs
- M src/media/audio/drivers/configurator/src/signal.rs
- M src/media/audio/drivers/configurator/src/testing.rs
- M src/media/stream_processors/test/src/output_validator.rs
- M src/media/stream_processors/test/src/stream.rs
- M src/power/bench/src/lib.rs
- M src/power/system-activity-governor/integration/tests/src/main.rs
- M src/security/bin/kms/src/crypto_provider/optee_provider/mod.rs
- M src/session/bin/element_manager/src/main.rs
- M src/session/tests/session_manager/src/main.rs
- M src/starnix/lib/ebpf_loader/src/loader.rs
- M src/starnix/tests/syscalls/rust/src/ebpf.rs
- M src/storage/fshost/src/matcher.rs
- M src/storage/lib/super_parser/src/metadata.rs
- M src/storage/stress-tests/genericfs/environment.rs
- M src/sys/component_manager/src/model/testing/mocks.rs
- M src/sys/component_manager/src/model/testing/routing_test_helpers.rs
- M src/sys/component_manager/testing/echo_server/src/main.rs
- M src/sys/component_manager/tests/events/components/scoped/echo_reporter.rs
- M src/sys/fuzzing/fuzzctl/src/fuzzctl.rs
- M src/sys/fuzzing/fuzzctl/testing/src/manager.rs
- M src/sys/fuzzing/fuzzctl/testing/src/test.rs
- M src/sys/lib/library_loader/src/lib.rs
- M src/sys/lib/routing/testing/src/availability.rs
- M src/sys/test_manager/src/running_suite.rs
- M src/sys/test_manager/src/test_lib.rs
- M src/sys/test_runners/gotests/src/main.rs
- M src/sys/test_runners/gtest/src/main.rs
- M src/sys/test_runners/inspect/src/main.rs
- M src/sys/test_runners/rust/src/main.rs
- M src/sys/test_runners/starnix/src/helpers.rs
- M src/sys/test_runners/starnix/src/syscalls.rs
- M src/sys/test_runners/starnix/src/test_suite.rs
- M src/sys/test_runners/stress_test/src/main.rs
- M src/sys/test_runners/stress_test/src/test.rs
- M src/sys/test_runners/stress_test/tests/test_data/echo/actor/main.rs
- M src/ui/bin/brightness_manager/src/led.rs
- M src/ui/bin/text/tests/test_helpers.rs
- M src/virtualization/bin/guest_manager_rs/src/guest_config.rs
- M src/virtualization/bin/guest_manager_rs/src/guest_manager.rs
- M src/virtualization/bin/vmm/device/virtio_block/src/backend_test.rs
- M tools/gn_desc/tests/src/main.rs
- M tools/validate_test_type/src/hermeticity.rs
Change size: L
Delta: 95 files changed, 435 insertions(+), 338 deletions(-)
Related details
Attention is currently required from:
- Owners Override
Submit Requirements:
Code-Owners
Code-Review
Dependencies-Satisfied
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/6b46249e603bd67fa706e9b9fb21c43f0e7a481b-HTML%40fuchsia-review.googlesource.com.
'James Robinson (Gerrit)' via owners-override
Nov 21, 2025, 5:08:50 PMNov 21
to Colin Nelson, Owners Override, Adam Perry, Megan Batty, Erick Tryzelaar, CL Deps Checker, GI Try Builder, CQ Bot
Attention needed from Colin Nelson and Owners Override
James Robinson voted Owners-Override+1![]( "Open in Gerrit")
Attention is currently required from:
- Colin Nelson
- Owners Override
Submit Requirements:
Code-Owners
Code-Review
Dependencies-Satisfied
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/4e9cc0ccfa0812c4bf32791cdc5e7d4b36e0a601-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'CQ Bot (Gerrit)' via owners-override
Nov 21, 2025, 5:09:59 PMNov 21
to Colin Nelson, James Robinson, Owners Override, Adam Perry, Megan Batty, Erick Tryzelaar, CL Deps Checker, GI Try Builder
CQ Bot submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[rust] enable or_fun_call Clippy lint on all code
Test: ran fx build and fx test
Fixed: b/462736347
NO_IFTTT=mechanical change that does not need to be reflected in the C++ code
Depends-on: turquoise-internal:I42ace3241271e321d4a23a49b69e4f876a6a636c
Change-Id: Ib8e7578749b6db9ea5d53aade4a1c93c6a6a6964
Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1429021
Dependencies-Satisfied: CL Deps Checker <cl-deps...@fuchsia-internal-service-accts.iam.gserviceaccount.com>
Reviewed-by: Adam Perry <adam...@google.com>
Reviewed-by: Megan Batty <mg...@google.com>
Fuchsia-Auto-Submit: Colin Nelson <colnn...@google.com>
Reviewed-by: Erick Tryzelaar <etryz...@google.com>
Owners-Override: James Robinson <jam...@google.com>
Commit-Queue: Colin Nelson <colnn...@google.com>
Delta: 95 files changed, 434 insertions(+), 337 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +2 by Erick Tryzelaar, +2 by Adam Perry, +2 by Megan Batty
Dependencies-Satisfied: +1 by CL Deps Checker
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/ecdfa3d69a2f753c768fd8e28a31ecf6bae18908-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'GI Roller (Gerrit)' via owners-override
Nov 21, 2025, 5:16:44 PMNov 21
to Colin Nelson, CQ Bot, James Robinson, Owners Override, Adam Perry, Megan Batty, Erick Tryzelaar, CL Deps Checker, GI Try Builder
Message from GI Roller![]( "Open in Gerrit")
Change has been successfully rolled: https://turquoise-internal-review.googlesource.com/1094460
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Dependencies-Satisfied
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/a3c5bcc4a0ecc5c8095433b1e145a038d35484df-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
Reply all
Reply to author
Forward
0 new messages